[Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187 Katrin Fischer changed: What|Removed |Added Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #10 from Katrin Fischer --- Bug 32752 resolved this I think. :) *** This bug has been marked as a duplicate of bug 32752 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #9 from Jonathan Druart --- Hi Pasi, That's great! I would recommend 2 things: 1. Add a comment at the top of the include file to add a bit of doc 2. Replace HideStatuses with an array: HideStatuses=[1,8] Then use grep in the include file What do you think? Keep in mind that we use snake_case instead of CamelCase for var names. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187 David Nind changed: What|Removed |Added Attachment #101743|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 102048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102048=edit Bug 12187: (follow-up) Reindent new include file This patch re-indents the new include file so that it is consistent with coding guidelines. Taking this opportunity to add a full test plan: Instead of duplicating the code for serial statuses in multiple files, move all of them into single include file, and use that. To test, apply the patch and go to Serials. - Search for a subscription which has multiple issues. - On the subscription detail page, open the "Issues" tab. - Statuses in the "Status" column should display correctly. - Click the "Serial collection" link in the sidebar. - In the table of issues, the "Status" colunn should display the correct information. - Select some isues and click the "Edit serials" button. - In the "Status" column, the options should display correctly. - Test setting various statuses and saving. The statuses should save correctly. - Click "Claims" in the sidebar menu and select a vendor. - In the list of missing issues the "Status" column should show the correct information. - In the catalog, locate the bibliographic record for a subscription with issues. - Under the "Subscriptions" tab check the "Status" column. Status information should be displayed correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187 David Nind changed: What|Removed |Added Attachment #98966|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 102047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102047=edit Bug 12187: Duplicate TT code for serial statuses Instead of duplicating the code for serial statuses in multiple files, move all of them into single include file, and use that. Needs a test plan, but I haven't used serials. Rebased Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187 --- Comment #6 from Owen Leonard --- Created attachment 101743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101743=edit Bug 12187: (follow-up) Reindent new include file This patch re-indents the new include file so that it is consistent with coding guidelines. Taking this opportunity to add a full test plan: Instead of duplicating the code for serial statuses in multiple files, move all of them into single include file, and use that. To test, apply the patch and go to Serials. - Search for a subscription which has multiple issues. - On the subscription detail page, open the "Issues" tab. - Statuses in the "Status" column should display correctly. - Click the "Serial collection" link in the sidebar. - In the table of issues, the "Status" colunn should display the correct information. - Select some isues and click the "Edit serials" button. - In the "Status" column, the options should display correctly. - Test setting various statuses and saving. The statuses should save correctly. - Click "Claims" in the sidebar menu and select a vendor. - In the list of missing issues the "Status" column should show the correct information. - In the catalog, locate the bibliographic record for a subscription with issues. - Under the "Subscriptions" tab check the "Status" column. Status information should be displayed correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187 --- Comment #5 from David Nind --- Thanks Bernardo! I don't know anything about serials, so will wait for a test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #78175|0 |1 is obsolete|| --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 98966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98966=edit Bug 12187: Duplicate TT code for serial statuses Instead of duplicating the code for serial statuses in multiple files, move all of them into single include file, and use that. Needs a test plan, but I haven't used serials. Rebased -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||da...@davidnind.com --- Comment #3 from David Nind --- Patch no longer applies 8-( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr --- Comment #2 from Séverine Queune --- Hi Pasi, I'm used to serials features and can esily test the different pages, but I don't have any idea about the differences in using .pl or .tt pages... Can you enlighten me about the different points or behaviours I need to pay attention ? Or do I just work as usual on the pages you mentioned and check there are no issues ? Thanks ! Séverine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12187] Duplicate TT code for serial statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187 paxed changed: What|Removed |Added Assignee|oleon...@myacpl.org |pasi.kalli...@joensuu.fi Status|NEW |Needs Signoff --- Comment #1 from paxed --- Created attachment 78175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78175=edit Bug 12187: Duplicate TT code for serial statuses Instead of duplicating the code for serial statuses in multiple files, move all of them into single include file, and use that. Needs a test plan, but I haven't used serials. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
