[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 Tom Misilo misi...@fit.edu changed: What|Removed |Added CC||misi...@fit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #14 from Tomás Cohen Arazi tomasco...@gmail.com --- Patches pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #28570|0 |1 is obsolete|| CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 --- Comment #13 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 29586 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29586action=edit Bug 12330: [QA Follow-up] Consistency between opac-search and staff client In opac-search two regexes are added for the results of splitting the pref AdvancedSearchTypes, allowing spaces before and after the names. The same regexes should be added to catalogue/search.pl to have the same behavior there. Test plan: Set AdvancedSearchTypes to itemtypes | ccode | loc (no quotes). Check OPAC and staff with and without this patch. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330
--- Comment #12 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 29585
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29585action=edit
Bug 12330: OpacHiddenItems not affecting Advanced Search
This patch affects only the area displayed on Advanced Search
by setting the AdvancedSearchTypes OPAC system preference
accordingly. Prior to this patch, no filtering based on
OpacHiddenItems was done. This patch determines if itemtypes,
collections, or shelving locations are hidden and prevents
them from being shown.
TEST PLAN
-
1) Back up your DB (always handy)
2) Set the Searching system preference AdvancedSearchTypes to:
'itemtypes|ccode|loc' (without the single quotes).
3) Set the OPAC system preference OpacHiddenItems to include the
lines:
itype: [{list of itemtype codes separated by commas}]
location: [{list of comma delimited shelving location codes}]
ccode: [{list of comma delimited collection codes}]
Make sure to exclude one value for each, so there will be at
least one known thing on each tab.
4) Open the OPAC.
5) Click on 'Advanced Search'
-- three tabs appear: Itemtypes, Collection, Shelving location
-- Everything is visible
6) Set the Searching system preference AdvancedSearchTypes to:
'itemtypes | ccode | loc' (without the single quotes).
7) Refresh the OPAC.
-- There will be three tabs, but ugliness ensues.
8) Apply the patch
9) Refresh the OPAC.
-- You will see: Itemtypes, Collection, Shelving location
-- Only excluded values from OpacHiddenItems will be seen.
10) Run koha qa test tools
Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com
All tests pass
Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
Small rewording in comment only.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 --- Comment #11 from Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca --- (In reply to M. Tompsett from comment #10) (In reply to Marjorie Barry-Vila from comment #9) [should] location and items types be hidden on facets too if [they] are exclu[d]ed in [the OpacHiddenItems] syspref? This bug handles just the Advanced Search page's criteria. Facets are on the OPAC results page, and thus beyond the scope of this bug. Will i create a new bug on bz? I'm not sure, because Bug 10891 was all about customizing which facets are viewable. That would certainly cover the scope of what you are asking about. Thank you for your reply and corrected faults. You are right for bug 10891. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca --- Comment #9 from Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca --- Hi, I tested it on a sandbox and i have a question: location and items types should be hidden on facets too if there are exclued in syspref? Will i create a new bug on bz? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 --- Comment #10 from M. Tompsett mtomp...@hotmail.com --- (In reply to Marjorie Barry-Vila from comment #9) [should] location and items types be hidden on facets too if [they] are exclu[d]ed in [the OpacHiddenItems] syspref? This bug handles just the Advanced Search page's criteria. Facets are on the OPAC results page, and thus beyond the scope of this bug. Will i create a new bug on bz? I'm not sure, because Bug 10891 was all about customizing which facets are viewable. That would certainly cover the scope of what you are asking about. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 sandbo...@biblibre.com sandbo...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sandbo...@biblibre.com --- Comment #3 from sandbo...@biblibre.com sandbo...@biblibre.com --- Patch tested with a sandbox, by Nicole Engard neng...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 sandbo...@biblibre.com sandbo...@biblibre.com changed: What|Removed |Added Attachment #28566|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 --- Comment #4 from Nicole C. Engard neng...@gmail.com --- That was my first time using the sandbox ... Did I do it right? I don't see the signed off patch attached here. Nicole -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 --- Comment #5 from M. Tompsett mtomp...@hotmail.com --- Hmmm... I don't see the signed off patched either. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #28566|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330
--- Comment #6 from Nicole C. Engard neng...@gmail.com ---
Created attachment 28570
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28570action=edit
[SIGNED-OFF] Bug 12330: OpacHiddenItems not affecting Advanced Search
This patch affects only the area displayed on Advanced Search
by setting the AdvancedSearchTypes OPAC system preference
accordingly. Prior to this patch, no filtering based on
OpacHiddenItems was done. This patch determines if itemtypes,
collections, or shelving locations are hidden and prevents
them from being shown.
TEST PLAN
-
1) Back up your DB (always handy)
2) Set the Searching system preference AdvancedSearchTypes to:
'itemtypes|ccode|loc' (without the single quotes).
3) Set the OPAC system preference OpacHiddenItems to include the
lines:
itype: [{list of itemtype codes separated by commas}]
location: [{list of comma delimited shelving location codes}]
ccode: [{list of comma delimited collection codes}]
Make sure to exclude one value for each, so there will be at
least one known thing on each tab.
4) Open the OPAC.
5) Click on 'Advanced Search'
-- three tabs appear: Itemtypes, Collection, Shelving location
-- Everything is visible
6) Set the Searching system preference AdvancedSearchTypes to:
'itemtypes | ccode | loc' (without the single quotes).
7) Refresh the OPAC.
-- There will be three tabs, but ugliness ensues.
8) Apply the patch
9) Refresh the OPAC.
-- You will see: Itemtypes, Collection, Shelving location
-- Only excluded values from OpacHiddenItems will be seen.
10) Run koha qa test tools
Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com
All tests pass
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #28566|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 --- Comment #7 from Nicole C. Engard neng...@gmail.com --- Did the sign off the traditional way as well to get the attachment - there might be a problem with the sandboxes attaching patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Nicole C. Engard from comment #7) Did the sign off the traditional way as well to get the attachment - there might be a problem with the sandboxes attaching patches. I think I did not update git-bz on sandboxes. It is on my todo list... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10937 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330
--- Comment #1 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 28565
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28565action=edit
Bug 12330: OpacHiddenItems not affecting Advanced Search
This patch affects only the area displayed on Advanced Search
by setting the AdvancedSearchTypes OPAC system preference
accordingly. Prior to this patch, no filtering based on
OpacHiddenItems was done. This patch determines if itemtypes,
collections, or shelving locations are hidden and prevents
them from being shown.
TEST PLAN
-
1) Back up your DB (always handy)
2) Set the OPAC system preference AdvancedSearchTypes to:
'itemtypes|ccode|loc' (without the single quotes).
3) Set the OPAC system preference OpacHiddenItems to include the
lines:
itype: [{list of itemtype codes separated by commas}]
location: [{list of comma delimited shelving location codes}]
ccode: [{list of comma delimited collection codes}]
Make sure to exclude one value for each, so there will be at
least one known thing on each tab.
4) Open the OPAC.
5) Click on 'Advanced Search'
-- three tabs appear: Itemtypes, Collection, Shelving location
-- Everything is visible
6) Set the OPAC system preference AdvancedSearchTypes to:
'itemtypes | ccode | loc' (without the single quotes).
7) Refresh the OPAC.
-- There will be three tabs, but ugliness ensues.
8) Apply the patch
9) Refresh the OPAC.
-- You will see: Itemtypes, Collection, Shelving location
-- Only excluded values from OpacHiddenItems will be seen.
10) Run koha qa test tools
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added CC||mtomp...@hotmail.com Assignee|oleon...@myacpl.org |mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #28565|0 |1
is obsolete||
--- Comment #2 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 28566
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28566action=edit
Bug 12330: OpacHiddenItems not affecting Advanced Search
This patch affects only the area displayed on Advanced Search
by setting the AdvancedSearchTypes OPAC system preference
accordingly. Prior to this patch, no filtering based on
OpacHiddenItems was done. This patch determines if itemtypes,
collections, or shelving locations are hidden and prevents
them from being shown.
TEST PLAN
-
1) Back up your DB (always handy)
2) Set the Searching system preference AdvancedSearchTypes to:
'itemtypes|ccode|loc' (without the single quotes).
3) Set the OPAC system preference OpacHiddenItems to include the
lines:
itype: [{list of itemtype codes separated by commas}]
location: [{list of comma delimited shelving location codes}]
ccode: [{list of comma delimited collection codes}]
Make sure to exclude one value for each, so there will be at
least one known thing on each tab.
4) Open the OPAC.
5) Click on 'Advanced Search'
-- three tabs appear: Itemtypes, Collection, Shelving location
-- Everything is visible
6) Set the Searching system preference AdvancedSearchTypes to:
'itemtypes | ccode | loc' (without the single quotes).
7) Refresh the OPAC.
-- There will be three tabs, but ugliness ensues.
8) Apply the patch
9) Refresh the OPAC.
-- You will see: Itemtypes, Collection, Shelving location
-- Only excluded values from OpacHiddenItems will be seen.
10) Run koha qa test tools
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
