[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||gmcha...@gmail.com --- Comment #13 from Galen Charlton gmcha...@gmail.com --- Pushed to 3.16.x for inclusion in 3.16.4. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Keywords||rel_3_16_4_candidate CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 Barton Chittenden bar...@bywatersolutions.com changed: What|Removed |Added CC||bar...@bywatersolutions.com --- Comment #12 from Barton Chittenden bar...@bywatersolutions.com --- Couple of small issues still need to be addressed: * The code 'FFOR' is still not expanded. * There is a space between the fine decription and the following comma, so Fine , To kill a mockingbird / 10/23/2013 23:59 View item To kill a mockingbird / should read Fine, To kill a mockingbird / 10/23/2013 23:59 View item To kill a mockingbird / -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 --- Comment #11 from Nicole C. Engard neng...@gmail.com --- Are there any plans for this to be in 3.16.x? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #10 from Tomás Cohen Arazi tomasco...@gmail.com --- Patches pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #29389|0 |1 is obsolete|| Attachment #29390|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 29531 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29531action=edit [PASSED QA] Bug 12429 [staff client] patron seeing fines codes Bug 2546 introduced translatable handling of Koha account type codes but missed several codes. This patch adds handling of these codes to the staff client. This patch also corrects a couple of instances of incorrect capitalization. To test, apply the patch and view fines page (Patron details - Fines) and the pay fines page (Patron details - Fines - Pay fines). You should not see any account type codes like CR, LR, or FU. Signed-off-by: Aleisha aleishaamo...@hotmail.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 --- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 29532 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29532action=edit [PASSED QA] Bug 12429 [OPAC] patron seeing fines codes Bug 2546 introduced translatable handling of Koha account type codes but missed several codes. This patch adds handling of these codes to the bootstrap OPAC. This patch also corrects a couple of instances of incorrect capitalization. To test, apply the patch and log in to the OPAC as a user who has existing fines and charges. View the Your fines page. You should not see any account type codes like CR, LR, or FU. Signed-off-by: Aleisha aleishaamo...@hotmail.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12415 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 --- Comment #3 from Owen Leonard oleon...@myacpl.org --- Created attachment 29369 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29369action=edit Bug 12429 [staff client] patron seeing fines codes Bug 2546 introduced translatable handling of Koha account type codes but missed several codes. This patch adds handling of these codes to the staff client. This patch also corrects a couple of instances of incorrect capitalization. To test, apply the patch and view fines page (Patron details - Fines) and the pay fines page (Patron details - Fines - Pay fines). You should not see any account type codes like CR, LR, or FU. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 --- Comment #4 from Owen Leonard oleon...@myacpl.org --- Created attachment 29370 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29370action=edit Bug 12429 [OPAC] patron seeing fines codes Bug 2546 introduced translatable handling of Koha account type codes but missed several codes. This patch adds handling of these codes to the bootstrap OPAC. This patch also corrects a couple of instances of incorrect capitalization. To test, apply the patch and log in to the OPAC as a user who has existing fines and charges. View the Your fines page. You should not see any account type codes like CR, LR, or FU. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 paxed pasi.kalli...@pttk.fi changed: What|Removed |Added CC||pasi.kalli...@pttk.fi See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12186 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 sandbo...@biblibre.com sandbo...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sandbo...@biblibre.com --- Comment #5 from sandbo...@biblibre.com sandbo...@biblibre.com --- Patch tested with a sandbox, by Aleisha aleishaamo...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 sandbo...@biblibre.com sandbo...@biblibre.com changed: What|Removed |Added Attachment #29369|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 --- Comment #7 from sandbo...@biblibre.com sandbo...@biblibre.com --- Created attachment 29390 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29390action=edit Bug 12429 [OPAC] patron seeing fines codes Bug 2546 introduced translatable handling of Koha account type codes but missed several codes. This patch adds handling of these codes to the bootstrap OPAC. This patch also corrects a couple of instances of incorrect capitalization. To test, apply the patch and log in to the OPAC as a user who has existing fines and charges. View the Your fines page. You should not see any account type codes like CR, LR, or FU. Signed-off-by: Aleisha aleishaamo...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 --- Comment #6 from sandbo...@biblibre.com sandbo...@biblibre.com --- Created attachment 29389 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29389action=edit Bug 12429 [staff client] patron seeing fines codes Bug 2546 introduced translatable handling of Koha account type codes but missed several codes. This patch adds handling of these codes to the staff client. This patch also corrects a couple of instances of incorrect capitalization. To test, apply the patch and view fines page (Patron details - Fines) and the pay fines page (Patron details - Fines - Pay fines). You should not see any account type codes like CR, LR, or FU. Signed-off-by: Aleisha aleishaamo...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 sandbo...@biblibre.com sandbo...@biblibre.com changed: What|Removed |Added Attachment #29370|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Caused by Bug 2546 which attempts to anticipate every obscure undocumented account type code which Koha uses but fails to cover all of them: [% SWITCH line.accounttype %] [% CASE 'Pay' %]Payment,thanks [% CASE 'Pay00' %]Payment,thanks (cash via SIP2) [% CASE 'Pay01' %]Payment,thanks (VISA via SIP2) [% CASE 'Pay02' %]Payment,thanks (credit card via SIP2) [% CASE 'N' %]New Card [% CASE 'F' %]Fine [% CASE 'A' %]Account management fee [% CASE 'M' %]Sundry [% CASE 'L' %]Lost Item [% CASE 'W' %]Writeoff [% CASE %][% line.accounttype %] [%- END -%] Kyle's list of codes includes these which are not in the above list: FU = Fine that is currently accruing Rent = Rental fee FOR = Forgiven LR = Lost item fee refund PAY = Payment WO = Writeoff C = Credit CR = Credit I also see checks in the code for accounttypes 'O' and 'FN' but I haven't found any code which inserts those codes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 --- Comment #2 from Owen Leonard oleon...@myacpl.org --- Created attachment 29334 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29334action=edit Bug 12429 [staff client] patron seeing fines codes Bug 2546 introduced translatable handling of Koha account type codes but missed several codes. This patch adds handling of these codes to the staff client. This patch also corrects a couple of instances of incorrect capitalization. To test, apply the patch and view fines page (Patron details - Fines) and the pay fines page (Patron details - Fines - Pay fines). You should not see any account type codes like CR, LR, or FU. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #29334|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
