[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 --- Comment #1 from Matthias Meusburger --- Created attachment 29976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29976&action=edit Inventory: fix "wrong place" and "item not scanned" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Matthias Meusburger changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Assignee|gmcha...@gmail.com |matthias.meusburger@biblibr ||e.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Fridolin SOMERS changed: What|Removed |Added CC||fridolyn.som...@biblibre.co ||m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #2 from Martin Renvoize --- Afraid we don't have anyone using this feature, so I'm not really in the best position to sign-off on it. Maybe a mail to the dev list might stir some interest? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Fridolin SOMERS changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12909 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Fridolin SOMERS changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12913 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 sandbo...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sandbo...@biblibre.com --- Comment #3 from sandbo...@biblibre.com --- Patch tested with a sandbox, by sonia.bo...@univ-lyon3.fr <2> -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 sandbo...@biblibre.com changed: What|Removed |Added Attachment #29976|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 --- Comment #4 from sandbo...@biblibre.com --- Created attachment 34236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34236&action=edit Bug 12567: Make catalog statistics wizard publication year work for MARC21 Publication year was useless for MARC21, as it was using the biblioitems.publicationyear (UNIMARC) instead of biblio.copyrightdate (MARC21). This patch tries to fix the search options to work for both MARC flavours. To test: In Reports > Statistics wizards > Catalog: - Test the publication year search options on a UNIMARC and a MARC21 installation. - Make sure search results make sense for both. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy The changes are fine with me, but this script is certainly not bug free. Also note that all its SQL should be moved out according to our coding guidelines. When doing so, a rewrite would be appropriate. Signed-off-by: Tomas Cohen Arazi Signed-off-by: sonia.bo...@univ-lyon3.fr <2> -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Jonathan Druart changed: What|Removed |Added Attachment #34236|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Jonathan Druart changed: What|Removed |Added Attachment #29976|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #5 from Jonathan Druart --- Sonia, did you want to signoff this patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Koha Team Lyon 3 changed: What|Removed |Added CC||k...@univ-lyon3.fr --- Comment #6 from Koha Team Lyon 3 --- no, I didn't sign off, it was the "sandbox bug" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Brendan Gallagher changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631
--- Comment #7 from Brendan Gallagher ---
Created attachment 35859
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35859&action=edit
BZ12631: Inventory: fix "wrong place" and "item not scanned"
"item not scanned": when calling GetItemsForInventory, datelastseen should
be used when "compare barcodes list to result" is checked.
Otherwise, when loading multiple barcodes files for the same inventory, many
items will be marked as "item not scanned" when loading the last barcode file
("compare barcodes list to result" checked) even though they were scanned.
"wrong place": when searching for wrongly placed items, we should only check
for the location (callnumbers, location and branch). To fix this, A new call
to GetItemsForInventory has been made with location filters only.
Otherwise, any item with a different itemtype for instance will be marked as
wrong place even if the location is correct.
Test plan:
"item not scanned" status:
1) Split a barcode file in two.
2) Load the first barcode file without checking "compare barcodes list to
result".
3) Load the second barcode file with "compare barcodes list to result" checked.
4) Check in the csv report that you have a lot of scanned items with the "item
not scanned" status.
Then apply the patch, do the same, and check that the false "item not scanned"
statuses are gone.
"wrong place" status:
1) Load a barcode file with barcode matching an item that has a correct
location, but a different itemtype than what you're looking for.
2) Check in the results that this item will be marked as "change item status"
and "wrong place".
Then apply the patch, do the same, and check that the only status for this item
is "change item status", which is correct.
Signed-off-by: Brendan Gallagher
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631
Brendan Gallagher changed:
What|Removed |Added
CC||bren...@bywatersolutions.co
||m
--- Comment #8 from Brendan Gallagher ---
(In reply to Brendan Gallagher from comment #7)
> Created attachment 35859 [details] [review]
> BZ12631: Inventory: fix "wrong place" and "item not scanned"
>
> "item not scanned": when calling GetItemsForInventory, datelastseen should
> be used when "compare barcodes list to result" is checked.
>
> Otherwise, when loading multiple barcodes files for the same inventory, many
> items will be marked as "item not scanned" when loading the last barcode
> file
> ("compare barcodes list to result" checked) even though they were scanned.
>
> "wrong place": when searching for wrongly placed items, we should only check
> for the location (callnumbers, location and branch). To fix this, A new call
> to GetItemsForInventory has been made with location filters only.
>
> Otherwise, any item with a different itemtype for instance will be marked as
> wrong place even if the location is correct.
>
> Test plan:
>
> "item not scanned" status:
>
> 1) Split a barcode file in two.
> 2) Load the first barcode file without checking "compare barcodes list to
> result".
> 3) Load the second barcode file with "compare barcodes list to result"
> checked.
> 4) Check in the csv report that you have a lot of scanned items with the
> "item
> not scanned" status.
>
> Then apply the patch, do the same, and check that the false "item not
> scanned"
> statuses are gone.
>
> "wrong place" status:
>
> 1) Load a barcode file with barcode matching an item that has a correct
> location, but a different itemtype than what you're looking for.
> 2) Check in the results that this item will be marked as "change item status"
> and "wrong place".
>
> Then apply the patch, do the same, and check that the only status for this
> item is "change item status", which is correct.
>
> Signed-off-by: Brendan Gallagher
I recently had a support ticket that dealt with inventory, so I easily had a
few copies of barcodes. I split into two and followed the test plan.
Excellent timing.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Jonathan Druart changed: What|Removed |Added Attachment #29976|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631
Kyle M Hall changed:
What|Removed |Added
Attachment #35859|0 |1
is obsolete||
--- Comment #9 from Kyle M Hall ---
Created attachment 36082
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36082&action=edit
[PASSED QA] Bug 12631: Inventory: fix "wrong place" and "item not scanned"
"item not scanned": when calling GetItemsForInventory, datelastseen should
be used when "compare barcodes list to result" is checked.
Otherwise, when loading multiple barcodes files for the same inventory, many
items will be marked as "item not scanned" when loading the last barcode file
("compare barcodes list to result" checked) even though they were scanned.
"wrong place": when searching for wrongly placed items, we should only check
for the location (callnumbers, location and branch). To fix this, A new call
to GetItemsForInventory has been made with location filters only.
Otherwise, any item with a different itemtype for instance will be marked as
wrong place even if the location is correct.
Test plan:
"item not scanned" status:
1) Split a barcode file in two.
2) Load the first barcode file without checking "compare barcodes list to
result".
3) Load the second barcode file with "compare barcodes list to result" checked.
4) Check in the csv report that you have a lot of scanned items with the "item
not scanned" status.
Then apply the patch, do the same, and check that the false "item not scanned"
statuses are gone.
"wrong place" status:
1) Load a barcode file with barcode matching an item that has a correct
location, but a different itemtype than what you're looking for.
2) Check in the results that this item will be marked as "change item status"
and "wrong place".
Then apply the patch, do the same, and check that the only status for this item
is "change item status", which is correct.
Signed-off-by: Brendan Gallagher
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #10 from Tomás Cohen Arazi --- Patch pushed to master. Thanks for the pastis Matthias! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Status|Pushed to Master|Pushed to Stable --- Comment #11 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.5 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #12 from Mason James --- Pushed to 3.16.x, will be in 3.16.9 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 --- Comment #13 from Fridolin SOMERS --- Pushed to 3.14, will be in 3.14.15. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 David Cook changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14398 CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=14399 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
