[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #38 from Jonathan Druart  
---
Created attachment 57270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57270=edit
Bug 12633: Remove export line

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15332


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332
[Bug 15332] ModMember not interpreting dates (Batch patron modification)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Liz Rea l...@catalyst.net.nz changed:

   What|Removed |Added

 Blocks||8753
 CC||l...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633
Bug 12633 depends on bug 14038, which changed state.

Bug 14038 Summary: SQLHelper replacement - C4::Members::Search - nl-search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #37 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Thanks Jonathan, almost there!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|BLOCKED |Signed Off

--- Comment #32 from Jonathan Druart jonathan.dru...@biblibre.com ---
Bug 14038 is signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Passed QA   |Signed Off

--- Comment #35 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Habits.. this was only a sign off, fixing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #38284|0   |1
is obsolete||
  Attachment #38285|0   |1
is obsolete||

--- Comment #33 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 38697
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38697action=edit
[PASSED QA] Bug 12633: Remove SQLHelper in C4::Members

This is the only places where SQLHelper is still called.
The C4::Members::Search is not used anymore, but ModMember and
AddMember.

This patch replaced the calls to SQLHelper to use DBIX::Class.
TODO: Move them to Koha::Borrower.

Test plan:
1/ Make sure the patron search still works (no changes expected since the
code was not in used).
2/ Add a patron with all fields filled
3/ Add another patron with some fields filled
4/ Update them with other values
5/ Delete them

You should not get any errors.

Signed-off-by: Mirko Tietgen mi...@abunchofthings.net
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #34 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 38698
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38698action=edit
[PASSED QA] Bug 12633: Fix specific default values

The dates should be set to undef if defined but empty, otherwise with an
empty string, '-00-00' will be inserted into the DB.

Signed-off-by: Mirko Tietgen mi...@abunchofthings.net

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #36 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
It's getting too late... this is PASSED QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #30 from Marc Véron ve...@veron.ch ---
git grep ' Search('

result:
members/nl-search.pl:my $local_results = Search( $identifier );

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||14038

--- Comment #31 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Katrin Fischer from comment #29)
 Hi Jonathan,
 
 I think I located another use of the Search routine, can you please check?
 
 members/nl-search.pl:my $local_results = Search( $identifier );

Good catch, bug 14038 opened.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #25 from Jonathan Druart jonathan.dru...@biblibre.com ---
Ok sorry, too quick, I get it when modifying a patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #26 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 38272
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38272action=edit
Bug 12633: Fix specific default values

The dates should be set to undef if defined but empty, otherwise with an
empty string, '-00-00' will be inserted into the DB.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net
 Status|Needs Signoff   |Failed QA

--- Comment #23 from Mirko Tietgen mi...@abunchofthings.net ---
With this patch applied, leaving the »Date of birth« field empty results in a
default value of 02/00/0, which, on a subsequent change of another field, leads
to the error message »The following fields are wrong. Please fix them. Date of
birth is invalid.«

If Date of birth is empty, there should not be anything added on saving the
record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #24 from Jonathan Druart jonathan.dru...@biblibre.com ---
I don't get it,
I created a new patron, didn't fill the date of birth, save
I got null in DB and nothing in the input on editing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

  Attachment #37751|0   |1
is obsolete||

--- Comment #27 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 38284
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38284action=edit
Bug 12633: Remove SQLHelper in C4::Members

This is the only places where SQLHelper is still called.
The C4::Members::Search is not used anymore, but ModMember and
AddMember.

This patch replaced the calls to SQLHelper to use DBIX::Class.
TODO: Move them to Koha::Borrower.

Test plan:
1/ Make sure the patron search still works (no changes expected since the
code was not in used).
2/ Add a patron with all fields filled
3/ Add another patron with some fields filled
4/ Update them with other values
5/ Delete them

You should not get any errors.

Signed-off-by: Mirko Tietgen mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Mirko Tietgen mi...@abunchofthings.net changed:

   What|Removed |Added

  Attachment #38272|0   |1
is obsolete||

--- Comment #28 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 38285
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38285action=edit
Bug 12633: Fix specific default values

The dates should be set to undef if defined but empty, otherwise with an
empty string, '-00-00' will be inserted into the DB.

Signed-off-by: Mirko Tietgen mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #29 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Jonathan,

I think I located another use of the Search routine, can you please check?

members/nl-search.pl:my $local_results = Search( $identifier );

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #22 from Jonathan Druart jonathan.dru...@biblibre.com ---
The patch has been reverted from master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Josef Moravec from comment #20)
 I wanted to test it, but there is merge conflict. Could you please rebase?

A patch has been pushed to master and I think it is a mistake. I pingued Tomas
on bug 13189.

You can test it reverting a7822b0a32faa5ffe6e5a3b43c1cd2c58a8a802a before.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Josef Moravec josef.mora...@gmail.com changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #20 from Josef Moravec josef.mora...@gmail.com ---
I wanted to test it, but there is merge conflict. Could you please rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #30937|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #30937|0   |1
is obsolete||

--- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 37751
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37751action=edit
Bug 12633: Remove SQLHelper in C4::Members

This is the only places where SQLHelper is still called.
The C4::Members::Search is not used anymore, but ModMember and
AddMember.

This patch replaced the calls to SQLHelper to use DBIX::Class.
TODO: Move them to Koha::Borrower.

Test plan:
1/ Make sure the patron search still works (no changes expected since the
code was not in used).
2/ Add a patron with all fields filled
3/ Add another patron with some fields filled
4/ Update them with other values
5/ Delete them

You should not get any errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||13926

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Jonathan Druart from comment #16)
 Ok so...
 The good news is that only 1 occurrence still exists in C4::Members::Search
 The bad one is that it is called from 3 different places  (but I may have
 missed some others...):
   admin/aqbudget_user_search.pl
   serials/member-search.pl
   patroncards/members-search.pl
 
 I have a patch and will be able to submitted it on monday.

Done on bug 13891.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||13892

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com ---
circ/ysearch.pl should not use C4::Members::Search, done on bug 13892.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||13894

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||13891

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com ---
No track of SQLHelper in C4::Members anymore :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Woohoo!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com ---
Sorry, but there is one left in C4::Members::Search :-/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com ---
Ok so...
The good news is that only 1 occurrence still exists in C4::Members::Search
The bad one is that it is called from 3 different places  (but I may have
missed some others...):
  admin/aqbudget_user_search.pl
  serials/member-search.pl
  patroncards/members-search.pl

I have a patch and will be able to submitted it on monday.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Katrin Fischer from comment #11)
 Do we need a new patch here? It looks like this is the last missing piece to
 get rid of SQLHelper.

see comment 9.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #30547|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Do we need a new patch here? It looks like this is the last missing piece to
get rid of SQLHelper.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||13021

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Jonathan Druart from comment #9)
 1 is removed by 12648, I have a patch for 2.

The call in guarantor_search is removed by 13021.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED
 CC||jonathan.dru...@biblibre.co
   ||m
   Assignee|yohann.duf...@biblibre.com  |jonathan.dru...@biblibre.co
   ||m

--- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com ---
If I am not wrong, there are 3 occurrences of C4::Members::Search:
1/ acqui/aqbasketuser_search.pl
2/ members/guarantor_search.pl
3/ patroncards/members-search.pl

1 is removed by 12648, I have a patch for 2.
3 is todo.

When done, I will completely remove the C4::Members::Search subroutine.
Some code should be move from C4::Utils::DT::Members to C4::Members (or
Koha::Members).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||12648

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #30937|0   |1
is obsolete||
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #6 from Kyle M Hall k...@bywatersolutions.com ---
Enabling ExtendedPatronAttributes completely breaks patron searching with this
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #7 from Kyle M Hall k...@bywatersolutions.com ---
Actually, it only breaks it for patroncards/members-search.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #8 from Kyle M Hall k...@bywatersolutions.com ---
This ties in a bit with bug 12833. This bug is why this patch isn't breaking
the main patron search. They aren't directly related though.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Yohann Dufour yohann.duf...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #5 from Yohann Dufour yohann.duf...@biblibre.com ---
Created attachment 30937
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30937action=edit
Bug 12633: SQLHelper replacement - C4::Members

With this patch, the subroutines AddMember and Search uses DBIx::Class instead
of C4::SQLHelper.
In order to replace SQLHelper in the Search subroutine, 2 subroutines has been
added, it seems a lot : replace 1 line with 2 subroutines, but in fact these 2
subroutines replace all the hidden work done by the SQLHelper.

Test plan:
1) Apply the patch 12457 in order to get the last unit tests for Members

2) Apply the patch

3) Execute the unit tests by launching :
prove t/db_dependent/Members.t

4) The result has to be a success without error or warning :
t/db_dependent/Members.t .. ok
All tests successful.
Files=1, Tests=55,  2 wallclock secs ( 0.04 usr  0.01 sys +  2.27 cusr  0.09
csys =  2.41 CPU)
Result: PASS

5) Sign in the intranet.

6) Verify you can add a member in the intranet.

7) Test of members/guarantor_search.pl :
Edit a member which belongs to the cateogry type 'C' (Child), click on 'Set to
patron' and verify the search of an adult member is correct.

8) Test of patroncards/members-search.pl :
Go to Tools  Patron card creator  New batch  Add item(s) and verify the
search of a member is correct.

9) Test of serials/member-search.pl :
Go on the page serials/member-search.pl and verify the search of a member is
correct.

10) Test of reserve/request.pl :
Go on a biblio details then Holds and verify the search of a member is
correct.

11) Test of circ/circulation.pl :
Go on Circulation  Checkouts and verify the search of a member is correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
When adding patrons to a routing list, this explodes:
DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'subscriptionid' in
'where clause' at /home/katrin/kohaclone/C4/Members.pm line 358

To test:
- Go to serials
- Create a subscription
- Go to 'serial collection'
- Create a routing list
- Add recipients to routing list
- Window for patron search opens and shows error from above

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #3 from Marc Véron ve...@veron.ch ---
Created attachment 30547
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30547action=edit
[Signed-off] Bug 12633: SQLHelper replacement - C4::Members

With this patch, the subroutines AddMember and Search uses DBIx::Class instead
of C4::SQLHelper.
In order to replace SQLHelper in the Search subroutine, 2 subroutines has been
added, it seems a lot : replace 1 line with 2 subroutines, but in fact these 2
subroutines replace all the hidden work done by the SQLHelper.

Test plan:
1) Apply the patch 12457 in order to get the last unit tests for Members

2) Apply the patch

3) Execute the unit tests by launching :
prove t/db_dependent/Members.t

4) The result has to be a success without error or warning :
t/db_dependent/Members.t .. ok
All tests successful.
Files=1, Tests=55,  2 wallclock secs ( 0.04 usr  0.01 sys +  2.27 cusr  0.09
csys =  2.41 CPU)
Result: PASS

5) Sign in the intranet.

6) Verify you can add a member in the intranet.

7) Test of members/guarantor_search.pl :
Edit a member which belongs to the cateogry type 'C' (Child), click on 'Set to
patron' and verify the search of an adult member is correct.

8) Test of patroncards/members-search.pl :
Go to Tools  Patron card creator  New batch  Add item(s) and verify the
search of a member is correct.

9) Test of serials/member-search.pl :
Go on the page serials/member-search.pl and verify the search of a member is
correct.

10) Test of reserve/request.pl :
Go on a biblio details then Holds and verify the search of a member is
correct.

11) Test of circ/circulation.pl :
Go on Circulation  Checkouts and verify the search of a member is correct.

Followed test plan. Patch behaves as expected.
Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

  Attachment #30119|0   |1
is obsolete||
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Yohann Dufour yohann.duf...@biblibre.com changed:

   What|Removed |Added

 Depends on||12457

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

--- Comment #1 from Yohann Dufour yohann.duf...@biblibre.com ---
Created attachment 30115
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30115action=edit
Bug 12633: SQLHelper replacement - C4::Members

With this patch, the subroutines AddMember and Search uses DBIx::Class instead
of C4::SQLHelper.
In order to replace SQLHelper in the Search subroutine, 2 subroutines has been
added, it seems a lot : replace 1 line with 2 subroutines, but in fact these 2
subroutines replace all the hidden work done by the SQLHelper.

Test plan:
1) Apply the patch 12457 in order to get the last unit tests for Members

2) Apply the patch

3) Execute the unit tests by launching :
prove t/db_dependent/Members.t

4) The result has to be a success without error or warning :
t/db_dependent/Members.t .. ok
All tests successful.
Files=1, Tests=55,  2 wallclock secs ( 0.04 usr  0.01 sys +  2.27 cusr  0.09
csys =  2.41 CPU)
Result: PASS

5) Sign in the intranet.

6) Verify you can add a member in the intranet.

7) Test of members/guarantor_search.pl :
Edit a member which belongs to the cateogry type 'C' (Child), click on 'Set to
patron' and verify the search of an adult member is correct.

8) Test of patroncards/members-search.pl :
Go to Tools  Patron card creator  New batch  Add item(s) and verify the
search of a member is correct.

9) Test of serials/member-search.pl :
Go on the page serials/member-search.pl and verify the search of a member is
correct.

10) Test of reserve/request.pl :
Go on a biblio details then Holds and verify the search of a member is
correct.

11) Test of circ/circulation.pl :
Go on Circulation  Checkouts and verify the search of a member is correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Yohann Dufour yohann.duf...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Yohann Dufour yohann.duf...@biblibre.com changed:

   What|Removed |Added

  Attachment #30115|0   |1
is obsolete||

--- Comment #2 from Yohann Dufour yohann.duf...@biblibre.com ---
Created attachment 30119
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30119action=edit
Bug 12633: SQLHelper replacement - C4::Members

With this patch, the subroutines AddMember and Search uses DBIx::Class instead
of C4::SQLHelper.
In order to replace SQLHelper in the Search subroutine, 2 subroutines has been
added, it seems a lot : replace 1 line with 2 subroutines, but in fact these 2
subroutines replace all the hidden work done by the SQLHelper.

Test plan:
1) Apply the patch 12457 in order to get the last unit tests for Members

2) Apply the patch

3) Execute the unit tests by launching :
prove t/db_dependent/Members.t

4) The result has to be a success without error or warning :
t/db_dependent/Members.t .. ok
All tests successful.
Files=1, Tests=55,  2 wallclock secs ( 0.04 usr  0.01 sys +  2.27 cusr  0.09
csys =  2.41 CPU)
Result: PASS

5) Sign in the intranet.

6) Verify you can add a member in the intranet.

7) Test of members/guarantor_search.pl :
Edit a member which belongs to the cateogry type 'C' (Child), click on 'Set to
patron' and verify the search of an adult member is correct.

8) Test of patroncards/members-search.pl :
Go to Tools  Patron card creator  New batch  Add item(s) and verify the
search of a member is correct.

9) Test of serials/member-search.pl :
Go on the page serials/member-search.pl and verify the search of a member is
correct.

10) Test of reserve/request.pl :
Go on a biblio details then Holds and verify the search of a member is
correct.

11) Test of circ/circulation.pl :
Go on Circulation  Checkouts and verify the search of a member is correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Yohann Dufour yohann.duf...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |yohann.duf...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Yohann Dufour yohann.duf...@biblibre.com changed:

   What|Removed |Added

 Blocks||11385

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/