[Koha-bugs] [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 Nick Clemens changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||n...@bywatersolutions.com --- Comment #7 from Nick Clemens --- Awesome work all, pushed to stable for 17.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 Katrin Fischer changed: What|Removed |Added Attachment #71087|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 71175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71175&action=edit Bug 12932: When all modules installed, Perl version check ignored The description in comment #0 is quite true, because the scope of the $checkmodule variable is local to just the module checking. If we change the scope, we can include the perl check as part of the new scope, and thus properly set its value. As Debian Jessie, Stretch and Ubuntu Xenial all have good versions of Perl by default, the easiest way to test this is to: - make sure to have some optional modules not installed. - change the system preference 'Version' to one just under the current version in your SQL client. - modify the version check line to 5.03 - restart_all and try going to the staff client. -- This should not inform you that your perl version is bad. - git reset hard back to origin/master - apply the patch - modify the version check line to 5.03 - change the system preference 'Version' to one just under the current version in your SQL client. - restart_all and try going to the staff client. -- This should trigger the patch, and you should be informed your perl version is bad. - git reset hard back to origin/master - apply the patch - run koha qa test tools Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 Owen Leonard changed: What|Removed |Added Attachment #71073|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 71087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71087&action=edit Bug 12932: When all modules installed, Perl version check ignored The description in comment #0 is quite true, because the scope of the $checkmodule variable is local to just the module checking. If we change the scope, we can include the perl check as part of the new scope, and thus properly set its value. As Debian Jessie, Stretch and Ubuntu Xenial all have good versions of Perl by default, the easiest way to test this is to: - make sure to have some optional modules not installed. - change the system preference 'Version' to one just under the current version in your SQL client. - modify the version check line to 5.03 - restart_all and try going to the staff client. -- This should not inform you that your perl version is bad. - git reset hard back to origin/master - apply the patch - modify the version check line to 5.03 - change the system preference 'Version' to one just under the current version in your SQL client. - restart_all and try going to the staff client. -- This should trigger the patch, and you should be informed your perl version is bad. - git reset hard back to origin/master - apply the patch - run koha qa test tools Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 M. Tompsett changed: What|Removed |Added Blocks||20104 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20104 [Bug 20104] Update minimum version of Perl to 5.20 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 M. Tompsett changed: What|Removed |Added Attachment #71072|0 |1 is obsolete|| --- Comment #3 from M. Tompsett --- Created attachment 71073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71073&action=edit Bug 12932: When all modules installed, Perl version check ignored The description in comment #0 is quite true, because the scope of the $checkmodule variable is local to just the module checking. If we change the scope, we can include the perl check as part of the new scope, and thus properly set its value. As Debian Jessie, Stretch and Ubuntu Xenial all have good versions of Perl by default, the easiest way to test this is to: - make sure to have some optional modules not installed. - change the system preference 'Version' to one just under the current version in your SQL client. - modify the version check line to 5.03 - restart_all and try going to the staff client. -- This should not inform you that your perl version is bad. - git reset hard back to origin/master - apply the patch - modify the version check line to 5.03 - change the system preference 'Version' to one just under the current version in your SQL client. - restart_all and try going to the staff client. -- This should trigger the patch, and you should be informed your perl version is bad. - git reset hard back to origin/master - apply the patch - run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 M. Tompsett changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 --- Comment #2 from M. Tompsett --- sudo apt-get remove libwebservices-ils-perl -- it's currently the only one that is really not packaged with koha-common. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 --- Comment #1 from M. Tompsett --- Created attachment 71072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71072&action=edit Bug 12932: When all modules installed, Perl version check ignored The description in comment #0 is quite true, because the scope of the $checkmodule variable is local to just the module checking. If we change the scope, we can include the perl check as part of the new scope, and thus properly set its value. As Debian Jessie, Stretch and Ubuntu Xenial all have good versions of Perl by default, the easiest way to test this is to: - make sure to have some optional modules not installed. - change the system preference 'Version' to one just under the current version in your SQL client. - modify the version check line to 5.03 - restart_all and try going to the staff client. -- This should inform you that your perl version is bad. - git reset hard back to origin/master - apply the patch - modify the version check line to 5.03 - change the system preference 'Version' to one just under the current version in your SQL client. - restart_all and try going to the staff client. -- This should trigger the patch, and you should be informed your perl version is bad. - git reset hard back to origin/master - apply the patch - run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 M. Tompsett changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |mtomp...@hotmail.com |ity.org | Status|NEW |ASSIGNED CC||mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
