[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #14 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #31981|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 35594 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35594action=edit [PASSED QA] Bug 12975: Use the centralize VAT and prices calculation - basketgroup.pl Bug 12969 introduces a subroutine to centralize VAT and prices calculation. It should be use in the acqui/basketgroup.pl script. Test plan: 0/ Don't apply the patch 1/ Create 4 suppliers with the different configurations 2/ Create a basket and create several orders 3/ Close the basket and create the corresponding basket groups. 4/ Print the basket group 5/ Verify you don't see any difference before and after applying the patch on the pdf file. Signed-off-by: Paola Rossi paola.ro...@cineca.it Signed-off-by: Katrin Fischer katrin.fischer...@web.de Works as described, passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975
--- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Katrin Fischer from comment #8)
Comment on attachment 31981 [details] [review]
Bug 12975: Use the centralize VAT and prices calculation - basketgroup.pl
Review of attachment 31981 [details] [review]:
-
::: acqui/basketgroup.pl
@@ -212,5 @@
}
}
-my $ba_order = {
-isbn = ($ord-{isbn} ? $ord-{isbn} : undef),
Hi Jonathan, bit irritated by this line - was removing it intentional? I see
that that PDF should be printing the ISBN, but have a bit of trouble making
it work in my installation currently.
Hi Katrin,
Yes it is intentional.
Actually before the patch, the $ba_order was pushed to @ba_orders.
Now, the order $ord is pushed.
We could add:
$ord-{isbn} = $ord-{isbn} ? $order-{isbn} : undef;
But it does not make sense, except if we need to manage the empty string or 0,
but it would not be a valid ISBN.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 --- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, I think you lost me there, but I believe you :) It looks like the printed PDF should include the ISBN, which also seems crucial for an order to a vendor. Does it print for you? It didn't for me, so maybe that's a separate bug to file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #11) Hi Jonathan, I think you lost me there, but I believe you :) It looks like the printed PDF should include the ISBN, which also seems crucial for an order to a vendor. Does it print for you? It didn't for me, so maybe that's a separate bug to file. Yes, I see it with English 3-pages with and without the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975
--- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Comment on attachment 31981
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31981
Bug 12975: Use the centralize VAT and prices calculation - basketgroup.pl
Review of attachment 31981:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=12975attachment=31981)
-
::: acqui/basketgroup.pl
@@ -212,5 @@
}
}
-my $ba_order = {
-isbn = ($ord-{isbn} ? $ord-{isbn} : undef),
Hi Jonathan, bit irritated by this line - was removing it intentional? I see
that that PDF should be printing the ISBN, but have a bit of trouble making it
work in my installation currently.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Changing to 'failed qa' for now, waiting for Jonathan to take a look at the last comment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |BLOCKED CC||katrin.fisc...@bsz-bw.de --- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Blocked by bug 12896 currently not applying. :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||paola.ro...@cineca.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Attachment #31830|0 |1 is obsolete|| --- Comment #4 from Paola Rossi paola.ro...@cineca.it --- Created attachment 31981 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31981action=edit Bug 12975: Use the centralize VAT and prices calculation - basketgroup.pl I've applied the patch against master 3.17.00.025 Firstly I've applied: 5342 (2), 12852 (3), 12844 (4), 12830 (2), 12896 (1), 12969 (2). Everything is OK. NB. in Conf III 1-0 RRP tax inc. : 162.02 instead of 164.0 (file-doc in 12964) 82.01 instead of 82.0 (file-doc in 12964) I pass the patch to Signed Off status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Paola Rossi from comment #4) Created attachment 31981 [details] [review] Paola, you forgot to attach your signoff patch :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Jonathan Druart from comment #5) (In reply to Paola Rossi from comment #4) Created attachment 31981 [details] [review] [review] Paola, you forgot to attach your signoff patch :) Sorry, end of the day... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #31830|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 31879 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31879action=edit Bug 12975: Use the centralize VAT and prices calculation - basketgroup.pl Bug 12969 introduces a subroutine to centralize VAT and prices calculation. It should be use in the acqui/basketgroup.pl script. Test plan: 0/ Don't apply the patch 1/ Create 4 suppliers with the different configurations 2/ Create a basket and create several orders 3/ Close the basket and create the corresponding basket groups. 4/ Print the basket group 5/ Verify you don't see any difference before and after applying the patch on the pdf file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #31830|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #31879|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #31811|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 31830 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31830action=edit Bug 12975: Use the centralize VAT and prices calculation - basketgroup.pl Bug 12969 introduces a subroutine to centralize VAT and prices calculation. It should be use in the acqui/basketgroup.pl script. Test plan: 0/ Don't apply the patch 1/ Create 4 suppliers with the different configurations 2/ Create a basket and create several orders 3/ Close the basket and create the corresponding basket groups. 4/ Print the basket group 5/ Verify you don't see any difference before and after applying the patch on the pdf file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED Depends on||12969 Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 31811 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31811action=edit Bug 12975: Use the centralize VAT and prices calculation - basketgroup.pl Bug 12969 introduces a subroutine to centralize VAT and prices calculation. It should be use in the acqui/basketgroup.pl script. Test plan: 0/ Don't apply the patch 1/ Create 4 suppliers with the different configurations 2/ Create a basket and create several orders 3/ Close the basket and create the corresponding basket groups. 4/ Print the basket group 5/ Verify you don't see any difference before and after applying the patch on the pdf file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12975] Refactor VAT and price calculation - basketgroup page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12975 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
