[Koha-bugs] [Bug 13018] Static fine should apply only once for a given borrower
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13018 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Sophie! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13018] Static fine should apply only once for a given borrower
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13018 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13018] Static fine should apply only once for a given borrower
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13018 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #32295|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 32425 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32425action=edit [PASSED QA] Bug 13018 : Static fine should be charged only once Test plan (see Bug 6858 for using staticfine.pl) : For a user (of a given category and library) with several overdues, launch the script : staticfines.pl --category CAT,AMOUNT --library LIB --delay DELAY Then, check that the user has been charged of AMOUNT if the due date of the most late item plus the delay is *before* today. One day later, re-execute the script with the same parameters and check that the fine has not been charged twice. Without patch, the fine is charged twice, with patch the user already charged is skipped (see output in debug mode) Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de Without the patch, the fine will be applied every time the script is run. With the patch the fine will only be applied once. Passes tests and QA script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13018] Static fine should apply only once for a given borrower
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13018 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #31967|0 |1 is obsolete|| --- Comment #2 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 32295 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32295action=edit Bug 13018 : Static fine should be charged only once Test plan (see Bug 6858 for using staticfine.pl) : For a user (of a given category and library) with several overdues, launch the script : staticfines.pl --category CAT,AMOUNT --library LIB --delay DELAY Then, check that the user has been charged of AMOUNT if the due date of the most late item plus the delay is *before* today. One day later, re-execute the script with the same parameters and check that the fine has not been charged twice. Without patch, the fine is charged twice, with patch the user already charged is skipped (see output in debug mode) Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13018] Static fine should apply only once for a given borrower
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13018 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13018] Static fine should apply only once for a given borrower
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13018 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=6858 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13018] Static fine should apply only once for a given borrower
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13018 --- Comment #1 from Sophie MEYNIEUX sophie.meyni...@biblibre.com --- Created attachment 31967 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31967action=edit Bug 13018 : Static fine should be charged only once Test plan (see Bug 6858 for using staticfine.pl) : For a user (of a given category and library) with several overdues, launch the script : staticfines.pl --category CAT,AMOUNT --library LIB --delay DELAY Then, check that the user has been charged of AMOUNT if the due date of the most late item plus the delay is *before* today. One day later, re-execute the script with the same parameters and check that the fine has not been charged twice. Without patch, the fine is charged twice, with patch the user already charged is skipped (see output in debug mode) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13018] Static fine should apply only once for a given borrower
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13018 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/