[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Jonathan Druart changed: What|Removed |Added Blocks||37818 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37818 [Bug 37818] XXX trick in installer code is not longer needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Jonathan Druart changed: What|Removed |Added Whiteboard|/perl | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Jonathan Druart changed: What|Removed |Added Whiteboard||/perl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Blou changed: What|Removed |Added CC|philippe.blo...@inlibro.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #111 from Jonathan Druart --- Tomas, it would be good to have a test somewhere to be sure a release (stable or master) does not have anything in the atomicupdate directory. Do you launch some tests before pushing into master? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #110 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #107) > Improvement pushed to master. > > Thanks Paul and Marcel. > Please help me update the wiki to reflect the new workflow. See http://wiki.koha-community.org/wiki/Database_updates#updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #109 from Blou --- Sorry about that, wrong bug. I wish I could just completely remove my previous comment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Blou changed: What|Removed |Added CC||philippe.blo...@inlibro.com Attachment #37491|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #108 from Blou --- Created attachment 37491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37491&action=edit Bug 8753 - Add forgot password link to OPAC This redo includes the following - usage of the template letters for the email instead of a .tt (that feature didn't exist when the functionnality was initially coded for our client) - removal of the prog version - removal of the code that was initially put into Members.pm - Added a letter into updatedatabase.pl and sample_notices.sql - Of course, rebase to latest master. The rest remain unchanged since the previous comments/approvals. As such, what worked before should still work. TEST PLAN: 1) apply the patch 2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON. That will cause the link 'Forgot yo 2b) make sure that OpacPasswordChange is also ON. 3) refresh front page, click on 'Forgot your password' and enter a VALID address (one that is associated to an en 3b) Also try an INVALID address (valid yet not in your koha db). An error message will show up. 4) An email should be received at that address with a link. 5) Follow the link in the mail to fill the new password. Until a satisfactory new password is entered, the old password is not reset. 6) Go to main page try the new password. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #107 from Tomás Cohen Arazi --- Improvement pushed to master. Thanks Paul and Marcel. Please help me update the wiki to reflect the new workflow. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #106 from Tomás Cohen Arazi --- (In reply to M. Tompsett from comment #105) > Please rebase. No problem, Mark. It is already applied on my working branch. It will be pushed tomorrow morning (argentinian tz). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #105 from M. Tompsett --- Please rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Kyle M Hall changed: What|Removed |Added Blocks||13893 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #104 from Kyle M Hall --- Agreed, we will need the ability run perl files in the same manner, but that can be a further enhancement independent of this. (In reply to M. de Rooy from comment #103) > There is one thing that I will still want to mention again, with reference > to comments 12 and 17: > > I would like to run perl files too. > If we start doing more with DBIC, we should probably stop with db revisions > in sql format, but use the perl format. > > The current implementation switches back to .sql only. > Aside from that, this seems to work fine (with some additional work for the > RM). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #103 from M. de Rooy --- There is one thing that I will still want to mention again, with reference to comments 12 and 17: I would like to run perl files too. If we start doing more with DBIC, we should probably stop with db revisions in sql format, but use the perl format. The current implementation switches back to .sql only. Aside from that, this seems to work fine (with some additional work for the RM). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What|Removed |Added Attachment #37075|0 |1 is obsolete|| --- Comment #102 from M. de Rooy --- Created attachment 37076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37076&action=edit Bug 13068: [QA Follow-up] Remove the Talking-Tech-itiva file from atomicupdate The file can be removed. The code is included in the db revisions 3.09.00.014 and 3.15.00.040. Also I adjusted the text of TalkingTech.README and removed the reference to the atomicupdate file. NOTE: I open a new report for adding TalkingTechItivaPhoneNotification to sysprefs.sql. Probably, the text inserted in the db revisions should have been inserted into the sample notices sql text too. These corrections are outside the scope of this report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What|Removed |Added See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13514| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13883 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #101 from M. de Rooy --- Created attachment 37075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37075&action=edit Bug 13068: [QA Follow-up] Remove the Talking-Tech-itiva file from atomicupdate The file can be removed. The code is included in the db revisions 3.09.00.014 and 3.15.00.040. Also I adjusted the text of TalkingTech.README and removed the reference to the atomicupdate file. NOTE: I open a new report for adding TalkingTechItivaPhoneNotification to sysprefs.sql. Probably, the text inserted in the db revisions should have been inserted into the sample notices sql text too. These corrections are outside the scope of this report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #100 from Kyle M Hall --- I wasn't able to get this feature to work without my QA followup. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #99 from Kyle M Hall --- Created attachment 37066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37066&action=edit Bug 13068 [QA Followup] - Remove use File::Slurp -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #97 from Kyle M Hall --- Created attachment 37064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37064&action=edit [PASSED QA] Bug 13068: (follow-up) Remove old files, use C4::Installer The do method does not accept more than 1 sql query. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #95 from Kyle M Hall --- Created attachment 37062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37062&action=edit [PASSED QA] Bug 13068: Follow-up for cleaning up atomicupdate folder The folder atomicupdate can be cleaned up. It mainly contains old files that are not used any more. I found two files that are still referenced: [1] Bug-4246-Talking-Tech-itiva-phone-notifications.pl A readme file refers to it. The code in this file slightly differs from the TalkingTech db revision. It can probably be deleted too, but I will first check. [2] oai_sets.sql This file should remain. It is used in dbrev 3.07.00.029. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Kyle M Hall changed: What|Removed |Added Attachment #36779|0 |1 is obsolete|| Attachment #36780|0 |1 is obsolete|| Attachment #36781|0 |1 is obsolete|| Attachment #36792|0 |1 is obsolete|| --- Comment #94 from Kyle M Hall --- Created attachment 37061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37061&action=edit [PASSED QA] Bug 13068: updatedatabase improvement for developer process with this patch, the updatedatabase now checks info the atomicupdate directory. If there is some SQL here, it's executed. Note that there is no version update, so if you run the updatedatabase script twice, you'll get an sql error probably. This patch will be very useful for sandbox testing process. When the RM pushes a patch with something in i'atomicupdate', he will have to copy it into updatedatabase.pl, give it a number, and remove the file in db_update Test plan: * apply the patch * create a files with a .sql extension in the atomicupdate directory * run updatedatabase.pl * look at your database, what was in the .sql file must have been run Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #96 from Kyle M Hall --- Created attachment 37063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37063&action=edit [PASSED QA] Bug 13068: (QA followup) Remove old files, use C4::Installer * moving oai-sets.sql from atomicupdate to updatedatabase itself * using Installer file loader to load & execute SQL file Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #98 from Kyle M Hall --- Created attachment 37065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37065&action=edit Bug 13068 [QA Followup] - Fix reading of sql files list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #93 from Jonathan Druart --- Created attachment 36792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36792&action=edit Bug 13068: (follow-up) Remove old files, use C4::Installer The do method does not accept more than 1 sql query. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #90 from Jonathan Druart --- (In reply to Jonathan Druart from comment #89) > This does not work. > It's not possible to execute more than 1 query using the do method. I will try to submit a follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #92 from Jonathan Druart --- (In reply to Paul Poulain from comment #91) > Sure ? When we tested this patch, with Tomas, I think we started from a 3.0 > DB, and I didn't saw any error. I must be wrong... Yep, sure: http://search.cpan.org/dist/DBI/DBI.pm#do "Prepare and execute a single statement.[...]" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #91 from Paul Poulain --- (In reply to Jonathan Druart from comment #89) > Comment on attachment 36781 [details] [review] > [SIGNED OFF] Bug 13068: (QA followup) Remove old files, use C4::Installer > > Review of attachment 36781 [details] [review]: > - > > ::: installer/data/mysql/updatedatabase.pl > @@ +4945,5 @@ > > +$dbh->do(qq{ > > +DROP TABLE IF EXISTS `oai_sets_descriptions`; > > +DROP TABLE IF EXISTS `oai_sets_mappings`; > > +DROP TABLE IF EXISTS `oai_sets_biblios`; > > +DROP TABLE IF EXISTS `oai_sets`; > > This does not work. > It's not possible to execute more than 1 query using the do method. Sure ? When we tested this patch, with Tomas, I think we started from a 3.0 DB, and I didn't saw any error. I must be wrong... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #89 from Jonathan Druart --- Comment on attachment 36781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36781 [SIGNED OFF] Bug 13068: (QA followup) Remove old files, use C4::Installer Review of attachment 36781: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13068&attachment=36781) - ::: installer/data/mysql/updatedatabase.pl @@ +4945,5 @@ > +$dbh->do(qq{ > +DROP TABLE IF EXISTS `oai_sets_descriptions`; > +DROP TABLE IF EXISTS `oai_sets_mappings`; > +DROP TABLE IF EXISTS `oai_sets_biblios`; > +DROP TABLE IF EXISTS `oai_sets`; This does not work. It's not possible to execute more than 1 query using the do method. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 k...@akafred.com changed: What|Removed |Added CC||k...@akafred.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Signed Off --- Comment #88 from Tomás Cohen Arazi --- I'm pretty confident, just asking for another QA just in case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Tomás Cohen Arazi changed: What|Removed |Added Attachment #36718|0 |1 is obsolete|| --- Comment #87 from Tomás Cohen Arazi --- Created attachment 36781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36781&action=edit [SIGNED OFF] Bug 13068: (QA followup) Remove old files, use C4::Installer * moving oai-sets.sql from atomicupdate to updatedatabase itself * using Installer file loader to load & execute SQL file Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Tomás Cohen Arazi changed: What|Removed |Added Attachment #36717|0 |1 is obsolete|| --- Comment #86 from Tomás Cohen Arazi --- Created attachment 36780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36780&action=edit [SIGNED OFF] Bug 13068: Follow-up for cleaning up atomicupdate folder The folder atomicupdate can be cleaned up. It mainly contains old files that are not used any more. I found two files that are still referenced: [1] Bug-4246-Talking-Tech-itiva-phone-notifications.pl A readme file refers to it. The code in this file slightly differs from the TalkingTech db revision. It can probably be deleted too, but I will first check. [2] oai_sets.sql This file should remain. It is used in dbrev 3.07.00.029. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Tomás Cohen Arazi changed: What|Removed |Added Attachment #36716|0 |1 is obsolete|| --- Comment #85 from Tomás Cohen Arazi --- Created attachment 36779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36779&action=edit [SIGNED OFF] Bug 13068: updatedatabase improvement for developer process with this patch, the updatedatabase now checks info the atomicupdate directory. If there is some SQL here, it's executed. Note that there is no version update, so if you run the updatedatabase script twice, you'll get an sql error probably. This patch will be very useful for sandbox testing process. When the RM pushes a patch with something in i'atomicupdate', he will have to copy it into updatedatabase.pl, give it a number, and remove the file in db_update Test plan: * apply the patch * create a files with a .sql extension in the atomicupdate directory * run updatedatabase.pl * look at your database, what was in the .sql file must have been run Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What|Removed |Added Assignee|m.de.r...@rijksmuseum.nl|paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #81 from Paul Poulain --- Created attachment 36716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36716&action=edit updatedatabase improvement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #83 from Paul Poulain --- Created attachment 36718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36718&action=edit bz 13068 follow-up : using slurp & removing oai-sets.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #82 from Paul Poulain --- Created attachment 36717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36717&action=edit bz 13068 atomicupdate directory cleaning -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #84 from Paul Poulain --- Created attachment 36719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36719&action=edit SAMPLE sql file, not for pushing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What|Removed |Added Attachment #32185|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What|Removed |Added Attachment #32841|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What|Removed |Added Attachment #32173|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What|Removed |Added Attachment #32174|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What|Removed |Added Attachment #32175|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What|Removed |Added Attachment #32185|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What|Removed |Added Attachment #32841|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What|Removed |Added Attachment #32175|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What|Removed |Added Attachment #32173|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What|Removed |Added Attachment #32174|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #80 from Paul Poulain --- Katrin, Tomas, Jonathan, Brendan and I had a discussion about this patch during the 2015 hackfest in Marseille. We think Marcel proposal does too much things, and add some complexity where initial my patch just fixed the main problem : applying patches on sandboxes fails. After a discussion, I'm about to resurrect my initial patches, keep the cleaning atomicupdate one, as they're interesting, and we will go forward. (I'll take care of Marcel comment 12 #1 into accout) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What|Removed |Added Attachment #35001|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What|Removed |Added Attachment #35370|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What|Removed |Added Attachment #35368|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What|Removed |Added Attachment #35000|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What|Removed |Added Attachment #35367|0 |1 is obsolete|| --- Comment #79 from M. de Rooy --- Created attachment 35370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35370&action=edit Bug 13068: Raise an error if a pl script has a sql error Signed-off-by: Marcel de Rooy Tested with some perl and sql dev updates. Checked the list of dev updates for the TRACK mode. Slightly amended the patch for printing the error message. Also the message now may tell you that a dev update failed. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What|Removed |Added Attachment #35366|0 |1 is obsolete|| --- Comment #78 from M. de Rooy --- Created attachment 35368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35368&action=edit Bug 13068: Counterpatch follow-up for controlling workflow The workflow for dev updates can be altered with devupdatecontrol: [1] devupdatecontrol= PROD for production machines: Do not execute RunRemainingDevUpdates, so only official db revs. This is the default. [2] devupdatecontrol= RESET: Reinstall dev updates after an official db rev. [3] devupdatecontrol= ALWAYS: Run the dev updates at each upgrade. [4] devupdatecontrol=TRACK: Only install new dev updates. It does not reset the local pref listing all recently applied dev updates. ONLY use this if you know what you are doing! Note: devupdatecontrol is a configuration variable from koha-conf.xml. If it does not exist or is empty, we fall back to PROD (safest). If it differs from PROD, ALWAYS or TRACK, it falls back to RESET. Note2: Initially, devupdatecontrol was a preference. It has been moved to koha-conf.xml as requested by several developers (Nov 24). Test plan: [1] Add a few lines calling ExecDBRev to updatedatabase with corresponding files in atomicupdate like (insert the correct version!!): ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); Do not forget to update kohaversion.pl accordingly. Add some other files in atomicupdate as dev updates. [2] Repeat for the various modes of devupdatecontrol (see above): Reset the database version. You could edit Version in local preferences. Optionally clear/delete the _LocalAtomicUpdates pref. Run updatestructure and check which db revs and dev updates are run or skipped. Run it again and check which dev updates are run or skipped. Signed-off-by: Marcel de Rooy Signed-off-by: Paul Poulain Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #77 from M. de Rooy --- Trivial rebase on debian/templates/koha-conf-site.xml.in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What|Removed |Added Attachment #35002|0 |1 is obsolete|| --- Comment #75 from M. de Rooy --- Created attachment 35366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35366&action=edit Bug 13068: Counterpatch follow-up for controlling workflow The workflow for dev updates can be altered with devupdatecontrol: [1] devupdatecontrol= PROD for production machines: Do not execute RunRemainingDevUpdates, so only official db revs. This is the default. [2] devupdatecontrol= RESET: Reinstall dev updates after an official db rev. [3] devupdatecontrol= ALWAYS: Run the dev updates at each upgrade. [4] devupdatecontrol=TRACK: Only install new dev updates. It does not reset the local pref listing all recently applied dev updates. ONLY use this if you know what you are doing! Note: devupdatecontrol is a configuration variable from koha-conf.xml. If it does not exist or is empty, we fall back to PROD (safest). If it differs from PROD, ALWAYS or TRACK, it falls back to RESET. Note2: Initially, devupdatecontrol was a preference. It has been moved to koha-conf.xml as requested by several developers (Nov 24). Test plan: [1] Add a few lines calling ExecDBRev to updatedatabase with corresponding files in atomicupdate like (insert the correct version!!): ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); Do not forget to update kohaversion.pl accordingly. Add some other files in atomicupdate as dev updates. [2] Repeat for the various modes of devupdatecontrol (see above): Reset the database version. You could edit Version in local preferences. Optionally clear/delete the _LocalAtomicUpdates pref. Run updatestructure and check which db revs and dev updates are run or skipped. Run it again and check which dev updates are run or skipped. Signed-off-by: Marcel de Rooy Signed-off-by: Paul Poulain Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What|Removed |Added Attachment #35003|0 |1 is obsolete|| --- Comment #76 from M. de Rooy --- Created attachment 35367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35367&action=edit Bug 13068: Raise an error if a pl script has a sql error Signed-off-by: Marcel de Rooy Tested with some perl and sql dev updates. Checked the list of dev updates for the TRACK mode. Slightly amended the patch for printing the error message. Also the message now may tell you that a dev update failed. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #74 from Jonathan Druart --- QA comments: All works as expected, we really need this to avoid recurrent conflicts on the updatedatabase.pl file. At some places, the code is not really obvious, but it's a good start. It could be great to have an entry on the wiki (http://wiki.koha-community.org/wiki/Database_updates ?) to list the different available options and explain the new workflow (don't append to updatedatabase.pl but create a new file). Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #73 from Jonathan Druart --- Created attachment 35003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35003&action=edit Bug 13068: Raise an error if a pl script has a sql error Signed-off-by: Marcel de Rooy Tested with some perl and sql dev updates. Checked the list of dev updates for the TRACK mode. Slightly amended the patch for printing the error message. Also the message now may tell you that a dev update failed. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #71 from Jonathan Druart --- Created attachment 35001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35001&action=edit Bug 13068: Counterpatch using atomicupdate directory This patch makes a distinction between atomicupdates belonging to an official db revision and development updates. It also keeps track of the dev updates since the last official db rev. (This is done via a local pref; so easily accessible if needed.) The db revs can be txt files, perl scripts or sql files. Sql files are run via the installer. A new db revision is now only a matter of dropping a file in atomicupdates for the developer. The RM only adds one line to updatedatabase like: ExecDBRev( $aupd, '13068', 'Refined dbrev', '13068.pl', '3.17.00.028'); This line should follow the last dbrev and preceed the call to RunRemainingAtomicUpdates. Test plan: [1] Add a few lines calling ExecDBRev to updatedatabase with corresponding files in atomicupdate like (insert the correct version!!): ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); Do not forget to update kohaversion.pl accordingly. Add some other files in atomicupdate as dev updates. [2] Run updatestructure and check if all db revs and dev updates are run. Run updatestructure again. Nothing should be run now. Clear/delete the _LocalAtomicUpdates pref. Run updatestructure again. Only dev updates should be run. Reset the database version. You could edit Version in local preferences. Run updatestructure and check if all db revs and dev updates are run. Edit _LocalAtomicUpdates and remove one filename. Run updatestructure again. Only one dev update should be run. Signed-off-by: Marcel de Rooy Signed-off-by: Paul Poulain Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #72 from Jonathan Druart --- Created attachment 35002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35002&action=edit Bug 13068: Counterpatch follow-up for controlling workflow The workflow for dev updates can be altered with devupdatecontrol: [1] devupdatecontrol= PROD for production machines: Do not execute RunRemainingDevUpdates, so only official db revs. This is the default. [2] devupdatecontrol= RESET: Reinstall dev updates after an official db rev. [3] devupdatecontrol= ALWAYS: Run the dev updates at each upgrade. [4] devupdatecontrol=TRACK: Only install new dev updates. It does not reset the local pref listing all recently applied dev updates. ONLY use this if you know what you are doing! Note: devupdatecontrol is a configuration variable from koha-conf.xml. If it does not exist or is empty, we fall back to PROD (safest). If it differs from PROD, ALWAYS or TRACK, it falls back to RESET. Note2: Initially, devupdatecontrol was a preference. It has been moved to koha-conf.xml as requested by several developers (Nov 24). Test plan: [1] Add a few lines calling ExecDBRev to updatedatabase with corresponding files in atomicupdate like (insert the correct version!!): ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); Do not forget to update kohaversion.pl accordingly. Add some other files in atomicupdate as dev updates. [2] Repeat for the various modes of devupdatecontrol (see above): Reset the database version. You could edit Version in local preferences. Optionally clear/delete the _LocalAtomicUpdates pref. Run updatestructure and check which db revs and dev updates are run or skipped. Run it again and check which dev updates are run or skipped. Signed-off-by: Marcel de Rooy Signed-off-by: Paul Poulain Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Jonathan Druart changed: What|Removed |Added Attachment #34949|0 |1 is obsolete|| Attachment #34950|0 |1 is obsolete|| Attachment #34951|0 |1 is obsolete|| Attachment #34998|0 |1 is obsolete|| --- Comment #70 from Jonathan Druart --- Created attachment 35000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35000&action=edit Bug 13068: Follow-up for cleaning up atomicupdate folder The folder atomicupdate can be cleaned up. It mainly contains old files that are not used any more. I found two files that are still referenced: [1] Bug-4246-Talking-Tech-itiva-phone-notifications.pl A readme file refers to it. The code in this file slightly differs from the TalkingTech db revision. It can probably be deleted too, but I will first check. [2] oai_sets.sql This file should remain. It is used in dbrev 3.07.00.029. Signed-off-by: Marcel de Rooy Signed-off-by: Paul Poulain Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #69 from M. de Rooy --- (In reply to Jonathan Druart from comment #67) > (In reply to M. de Rooy from comment #65) > > I agree that we ideally should not. But how should we catch this in a simple > > and elegant way? > > What about the last patch? Great! Signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What|Removed |Added Attachment #34960|0 |1 is obsolete|| --- Comment #68 from M. de Rooy --- Created attachment 34998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34998&action=edit Bug 13068: Raise an error if a pl script has a sql error Signed-off-by: Marcel de Rooy Tested with some perl and sql dev updates. Checked the list of dev updates for the TRACK mode. Slightly amended the patch for printing the error message. Also the message now may tell you that a dev update failed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #67 from Jonathan Druart --- (In reply to M. de Rooy from comment #65) > I agree that we ideally should not. But how should we catch this in a simple > and elegant way? What about the last patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #66 from Jonathan Druart --- Created attachment 34960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34960&action=edit Bug 13068: Raise an error if a pl script has a sql error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #65 from M. de Rooy --- > 7/ In TRACK mode, given the following file: > 1 use Modern::Perl; > 2 use C4::Context; > 3 my $dbh = C4::Context->dbh; > 4 $dbh->do("delete from foo"); > I executed perl installer/data/mysql/updatedatabase.pl > and I got > DBD::mysql::db do failed: Table 'koha.foo' doesn't exist > at /home/koha/src/installer/data/mysql/atomicupdate/test3.pl line 4. > Dev upgrade test3.pl done > The filename is appended to _localatomicupdates, it seems it should not, > could you confirm? Yes, I can reproduce this (does not depend on the mode). Problem here is if the db rev does not care about the errors raised, the calling program (updatedatabase) does not see them any more. Your last statement $dbh->do returns undef to the caller. But when you are back in updatedatabase, the $! and $@ are not set any more. (Note that if you had a trailing 1; in your file, I even would have received a 1.) In this case I assume everything is fine and I append your file to the pref. I agree that we ideally should not. But how should we catch this in a simple and elegant way? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What|Removed |Added QA Contact|m.de.r...@rijksmuseum.nl| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13514 --- Comment #64 from M. de Rooy --- > 4/ Don't you think we should move the 2 files to skip into another directory > (and use this one exclusively for this use)? I will open up a new report to move or delete them. After that we can clean up the hash variable. (See bug 13514.) This way they will not provide further noise in this report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #63 from M. de Rooy --- > 1/ Could you please detail when the RESET mode should be used? The difference between TRACK and RESET concentrates on what you do when you run an official db rev on your dev machine. If you are very cautious, you got rid of all things that were done in dev updates BEFORE you run a real db rev. In that case RESET is your friend: it will reinstall all dev updates again. It may theoretically be better. If you know that the dev updates you installed do not interfere with the db rev at hand, TRACK will not try to run them again. More pragmatic. All depends on how you use them and how you interpret the *risks* on such a dev box. Instead of choosing one road to go, I offer them both. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #62 from M. de Rooy --- > 2/ ExecDBRev takes 5 parameters, but you use only 3, the idea is to call this > routine for each db rev in updatedatabase.pl? Yes. I gave this example in one of the commit messages: ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What|Removed |Added Attachment #34072|0 |1 is obsolete|| --- Comment #61 from M. de Rooy --- Created attachment 34951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34951&action=edit Bug 13068: Counterpatch follow-up for controlling workflow The workflow for dev updates can be altered with devupdatecontrol: [1] devupdatecontrol= PROD for production machines: Do not execute RunRemainingDevUpdates, so only official db revs. This is the default. [2] devupdatecontrol= RESET: Reinstall dev updates after an official db rev. [3] devupdatecontrol= ALWAYS: Run the dev updates at each upgrade. [4] devupdatecontrol=TRACK: Only install new dev updates. It does not reset the local pref listing all recently applied dev updates. ONLY use this if you know what you are doing! Note: devupdatecontrol is a configuration variable from koha-conf.xml. If it does not exist or is empty, we fall back to PROD (safest). If it differs from PROD, ALWAYS or TRACK, it falls back to RESET. Note2: Initially, devupdatecontrol was a preference. It has been moved to koha-conf.xml as requested by several developers (Nov 24). Test plan: [1] Add a few lines calling ExecDBRev to updatedatabase with corresponding files in atomicupdate like (insert the correct version!!): ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); Do not forget to update kohaversion.pl accordingly. Add some other files in atomicupdate as dev updates. [2] Repeat for the various modes of devupdatecontrol (see above): Reset the database version. You could edit Version in local preferences. Optionally clear/delete the _LocalAtomicUpdates pref. Run updatestructure and check which db revs and dev updates are run or skipped. Run it again and check which dev updates are run or skipped. Signed-off-by: Marcel de Rooy Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What|Removed |Added Attachment #34071|0 |1 is obsolete|| --- Comment #60 from M. de Rooy --- Created attachment 34950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34950&action=edit Bug 13068: Counterpatch using atomicupdate directory This patch makes a distinction between atomicupdates belonging to an official db revision and development updates. It also keeps track of the dev updates since the last official db rev. (This is done via a local pref; so easily accessible if needed.) The db revs can be txt files, perl scripts or sql files. Sql files are run via the installer. A new db revision is now only a matter of dropping a file in atomicupdates for the developer. The RM only adds one line to updatedatabase like: ExecDBRev( $aupd, '13068', 'Refined dbrev', '13068.pl', '3.17.00.028'); This line should follow the last dbrev and preceed the call to RunRemainingAtomicUpdates. Test plan: [1] Add a few lines calling ExecDBRev to updatedatabase with corresponding files in atomicupdate like (insert the correct version!!): ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); Do not forget to update kohaversion.pl accordingly. Add some other files in atomicupdate as dev updates. [2] Run updatestructure and check if all db revs and dev updates are run. Run updatestructure again. Nothing should be run now. Clear/delete the _LocalAtomicUpdates pref. Run updatestructure again. Only dev updates should be run. Reset the database version. You could edit Version in local preferences. Run updatestructure and check if all db revs and dev updates are run. Edit _LocalAtomicUpdates and remove one filename. Run updatestructure again. Only one dev update should be run. Signed-off-by: Marcel de Rooy Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What|Removed |Added Attachment #34070|0 |1 is obsolete|| --- Comment #59 from M. de Rooy --- Created attachment 34949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34949&action=edit Bug 13068: Follow-up for cleaning up atomicupdate folder The folder atomicupdate can be cleaned up. It mainly contains old files that are not used any more. I found two files that are still referenced: [1] Bug-4246-Talking-Tech-itiva-phone-notifications.pl A readme file refers to it. The code in this file slightly differs from the TalkingTech db revision. It can probably be deleted too, but I will first check. [2] oai_sets.sql This file should remain. It is used in dbrev 3.07.00.029. Signed-off-by: Marcel de Rooy Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #58 from M. de Rooy --- > 3/ What means the $rv flag? rv= return value (from do or something similar); I use it later in the routine to check if I should call the atomicmemory routine: _atomic_memory( $atomicupd, $file ) if $rv; > 5/ > $rv = 1 if !$! && !$@; #apparently, the file does not end with 1; > I tested with a file without 1; and I don't get any error. That's just what this line did for you. If your file did not return 1 and I discovered no error, then I set rv to 1 for you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #57 from M. de Rooy --- I will the -> I will add the -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #56 from M. de Rooy --- (In reply to Jonathan Druart from comment #55) > Marcel, all looks good to me but I have few questions: Thanks for testing, Jonathan. I hope to address your questions now. > 6/ From http://perldoc.perl.org/functions/do.html, it seems that > print "ERROR: $!\n" if $!; > should be > print "ERROR: $!\n" if $! and not $@; OK. That is fine with me. I first check $@; in the second print I will the condition. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #55 from Jonathan Druart --- Marcel, all looks good to me but I have few questions: 1/ Could you please detail when the RESET mode should be used? 2/ ExecDBRev takes 5 parameters, but you use only 3, the idea is to call this routine for each db rev in updatedatabase.pl? 3/ What means the $rv flag? 4/ Don't you think we should move the 2 files to skip into another directory (and use this one exclusively for this use)? 5/ 9691 $rv = 1 if !$! && !$@; #apparently, the file does not end with 1; I tested with a file without 1; and I don't get any error. 6/ From http://perldoc.perl.org/functions/do.html, it seems that 9690 print "ERROR: $!\n" if $!; should be 9690 print "ERROR: $!\n" if $! and not $@; 7/ In TRACK mode, given the following file: 1 use Modern::Perl; 2 use C4::Context; 3 my $dbh = C4::Context->dbh; 4 $dbh->do("delete from foo"); I executed perl installer/data/mysql/updatedatabase.pl and I got DBD::mysql::db do failed: Table 'koha.foo' doesn't exist at /home/koha/src/installer/data/mysql/atomicupdate/test3.pl line 4. Dev upgrade test3.pl done The filename is appended to _localatomicupdates, it seems it should not, could you confirm? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #54 from M. de Rooy --- (In reply to Paul Poulain from comment #53) > made many tests using TRACK mode, as well as PROD mode, and could not find > any problem. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #53 from Paul Poulain --- made many tests using TRACK mode, as well as PROD mode, and could not find any problem. signed-off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What|Removed |Added Attachment #32842|0 |1 is obsolete|| --- Comment #51 from Paul Poulain --- Created attachment 34071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34071&action=edit Bug 13068: Counterpatch using atomicupdate directory This patch makes a distinction between atomicupdates belonging to an official db revision and development updates. It also keeps track of the dev updates since the last official db rev. (This is done via a local pref; so easily accessible if needed.) The db revs can be txt files, perl scripts or sql files. Sql files are run via the installer. A new db revision is now only a matter of dropping a file in atomicupdates for the developer. The RM only adds one line to updatedatabase like: ExecDBRev( $aupd, '13068', 'Refined dbrev', '13068.pl', '3.17.00.028'); This line should follow the last dbrev and preceed the call to RunRemainingAtomicUpdates. Test plan: [1] Add a few lines calling ExecDBRev to updatedatabase with corresponding files in atomicupdate like (insert the correct version!!): ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); Do not forget to update kohaversion.pl accordingly. Add some other files in atomicupdate as dev updates. [2] Run updatestructure and check if all db revs and dev updates are run. Run updatestructure again. Nothing should be run now. Clear/delete the _LocalAtomicUpdates pref. Run updatestructure again. Only dev updates should be run. Reset the database version. You could edit Version in local preferences. Run updatestructure and check if all db revs and dev updates are run. Edit _LocalAtomicUpdates and remove one filename. Run updatestructure again. Only one dev update should be run. Signed-off-by: Marcel de Rooy Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What|Removed |Added Attachment #33859|0 |1 is obsolete|| --- Comment #52 from Paul Poulain --- Created attachment 34072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34072&action=edit Bug 13068: Counterpatch follow-up for controlling workflow The workflow for dev updates can be altered with devupdatecontrol: [1] devupdatecontrol= PROD for production machines: Do not execute RunRemainingDevUpdates, so only official db revs. This is the default. [2] devupdatecontrol= RESET: Reinstall dev updates after an official db rev. [3] devupdatecontrol= ALWAYS: Run the dev updates at each upgrade. [4] devupdatecontrol=TRACK: Only install new dev updates. It does not reset the local pref listing all recently applied dev updates. ONLY use this if you know what you are doing! Note: devupdatecontrol is a configuration variable from koha-conf.xml. If it does not exist or is empty, we fall back to PROD (safest). If it differs from PROD, ALWAYS or TRACK, it falls back to RESET. Note2: Initially, devupdatecontrol was a preference. It has been moved to koha-conf.xml as requested by several developers (Nov 24). Test plan: [1] Add a few lines calling ExecDBRev to updatedatabase with corresponding files in atomicupdate like (insert the correct version!!): ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); Do not forget to update kohaversion.pl accordingly. Add some other files in atomicupdate as dev updates. [2] Repeat for the various modes of devupdatecontrol (see above): Reset the database version. You could edit Version in local preferences. Optionally clear/delete the _LocalAtomicUpdates pref. Run updatestructure and check which db revs and dev updates are run or skipped. Run it again and check which dev updates are run or skipped. Signed-off-by: Marcel de Rooy Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Paul Poulain changed: What|Removed |Added Attachment #32841|0 |1 is obsolete|| --- Comment #50 from Paul Poulain --- Created attachment 34070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34070&action=edit Bug 13068: Follow-up for cleaning up atomicupdate folder The folder atomicupdate can be cleaned up. It mainly contains old files that are not used any more. I found two files that are still referenced: [1] Bug-4246-Talking-Tech-itiva-phone-notifications.pl A readme file refers to it. The code in this file slightly differs from the TalkingTech db revision. It can probably be deleted too, but I will first check. [2] oai_sets.sql This file should remain. It is used in dbrev 3.07.00.029. Signed-off-by: Marcel de Rooy Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #49 from David Cook --- Thanks for the explanations and further work, Marcel :). My plate is pretty full today, but I'm definitely interested in testing this. Will take a look as soon as I can :). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What|Removed |Added Assignee|paul.poul...@biblibre.com |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #48 from M. de Rooy --- OK Two against one: I moved it to koha-conf.xml Please test and sign-off.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What|Removed |Added Attachment #32843|0 |1 is obsolete|| Attachment #32921|0 |1 is obsolete|| --- Comment #47 from M. de Rooy --- Created attachment 33859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33859&action=edit Bug 13068: Counterpatch follow-up for controlling workflow The workflow for dev updates can be altered with devupdatecontrol: [1] devupdatecontrol= PROD for production machines: Do not execute RunRemainingDevUpdates, so only official db revs. This is the default. [2] devupdatecontrol= RESET: Reinstall dev updates after an official db rev. [3] devupdatecontrol= ALWAYS: Run the dev updates at each upgrade. [4] devupdatecontrol=TRACK: Only install new dev updates. It does not reset the local pref listing all recently applied dev updates. ONLY use this if you know what you are doing! Note: devupdatecontrol is a configuration variable from koha-conf.xml. If it does not exist or is empty, we fall back to PROD (safest). If it differs from PROD, ALWAYS or TRACK, it falls back to RESET. Note2: Initially, devupdatecontrol was a preference. It has been moved to koha-conf.xml as requested by several developers (Nov 24). Test plan: [1] Add a few lines calling ExecDBRev to updatedatabase with corresponding files in atomicupdate like (insert the correct version!!): ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); Do not forget to update kohaversion.pl accordingly. Add some other files in atomicupdate as dev updates. [2] Repeat for the various modes of devupdatecontrol (see above): Reset the database version. You could edit Version in local preferences. Optionally clear/delete the _LocalAtomicUpdates pref. Run updatestructure and check which db revs and dev updates are run or skipped. Run it again and check which dev updates are run or skipped. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #46 from Paul Poulain --- (In reply to M. de Rooy from comment #45) > (In reply to Katrin Fischer from comment #44) > > Hm. so how does the system figure out which is the new dev one it needs to > > run? By comparing all entries in updatedatabase to the directory's contents? > > Paul raised the same question earlier. It is answered in comment16. The code > builds a hash with all db revs. The time needed for that is limited, since > it does not really inspect the file itself. It just sees the reference to > the file. And what worried me also was the time dedicated to this test on each page. As the $version system does not change, this test, with a hash is run only when needed, which is A-OK (about the idea to put it in a configuration, I like the idea. About having some "forbidden to change, or with a specific warning syspref", i'm also A-OK, even if: * no-one I know ever made something as silly as changing the MARCflavour avec going live ;-) * the list of such syspref would probably result in forever lasting debates... ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #45 from M. de Rooy --- (In reply to Katrin Fischer from comment #44) > Hm. so how does the system figure out which is the new dev one it needs to > run? By comparing all entries in updatedatabase to the directory's contents? Paul raised the same question earlier. It is answered in comment16. The code builds a hash with all db revs. The time needed for that is limited, since it does not really inspect the file itself. It just sees the reference to the file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #44 from Katrin Fischer --- Hm. so how does the system figure out which is the new dev one it needs to run? By comparing all entries in updatedatabase to the directory's contents? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/