[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-23 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #18 from Brendan Gallagher  ---
Pushed to Master - Should be in the May 2016 release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

--- Comment #17 from Katrin Fischer  ---
Created attachment 49354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49354=edit
[PASSED QA] Bug 13238: Specific string if no results

Signed-off-by: Jonathan Druart 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #49351|0   |1
is obsolete||
  Attachment #49352|0   |1
is obsolete||

--- Comment #16 from Katrin Fischer  ---
Created attachment 49353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49353=edit
[PASSED QA] Bug 13238: Improve heading on vendor search when searching for all
vendors

To test:
1) Go to Acquisitions and do an empty vendor search
2) Should now read "Vendor search: X results found"
3) Enter a search term and search for vendor
4) Should now read "Vendor search: Y results found for 'search term'"

Sponsored-by: Catalyst IT

NOTE: two nested if/else/end's could make it result/results,
  as suggested in comment #3. However, this meets my understanding
  of the problem as defined in comment #0.

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

--- Comment #15 from Katrin Fischer  ---
Forgot to sign the first patch... trying again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

--- Comment #14 from Katrin Fischer  ---
Created attachment 49352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49352=edit
[PASSED QA] Bug 13238: Specific string if no results

Signed-off-by: Jonathan Druart 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #48917|0   |1
is obsolete||
  Attachment #49122|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 49351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49351=edit
Bug 13238: Improve heading on vendor search when searching for all vendors

To test:
1) Go to Acquisitions and do an empty vendor search
2) Should now read "Vendor search: X results found"
3) Enter a search term and search for vendor
4) Should now read "Vendor search: Y results found for 'search term'"

Sponsored-by: Catalyst IT

NOTE: two nested if/else/end's could make it result/results,
  as suggested in comment #3. However, this meets my understanding
  of the problem as defined in comment #0.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

--- Comment #12 from Katrin Fischer  ---
This is looking great now!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-14 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #11 from Jonathan Druart  
---
Katrin, could you confirm it is what you had in mind?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-14 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

--- Comment #10 from Jonathan Druart  
---
Created attachment 49122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49122=edit
Bug 13238: Specific string if no results

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-11 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

--- Comment #9 from M. Tompsett  ---
Valid point. I stand by the sign off for this string revision.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-11 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-09 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #48915|0   |1
is obsolete||

--- Comment #8 from Aleisha Amohia  ---
Created attachment 48917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48917=edit
Bug 13238: Improve heading on vendor search when searching for all vendors

To test:
1) Go to Acquisitions and do an empty vendor search
2) Should now read "Vendor search: X results found"
3) Enter a search term and search for vendor
4) Should now read "Vendor search: Y results found for 'search term'"

Sponsored-by: Catalyst IT

NOTE: two nested if/else/end's could make it result/results,
  as suggested in comment #3. However, this meets my understanding
  of the problem as defined in comment #0.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-09 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-09 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

--- Comment #7 from Aleisha Amohia  ---
Actually before I make that change, the search heading will never show if there
is only one result. It will just show the one vendor.
Therefore, it doesn't need the s in brackets because that heading will only
show if there is more than one result.
So I'll take the brackets out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-09 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

--- Comment #6 from Aleisha Amohia  ---
(In reply to M. Tompsett from comment #5)

> NOTE: two nested if/else/end's could make it result/results,
>   as suggested in comment #3. However, this meets my understanding
>   of the problem as defined in comment #0.

OH! I didn't understand this. Will make that change now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-09 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-09 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

M. Tompsett  changed:

   What|Removed |Added

  Attachment #48912|0   |1
is obsolete||

--- Comment #5 from M. Tompsett  ---
Created attachment 48915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48915=edit
Bug 13238: Improve heading on vendor search when searching for all vendors

To test:
1) Go to Acquisitions and do an empty vendor search
2) Should now read "Vendor search: X result(s) found"
3) Enter a search term and search for vendor
4) Should now read "Vendor search: Y result(s) found for 'search term'"

Sponsored-by: Catalyst IT

NOTE: two nested if/else/end's could make it result/results,
  as suggested in comment #3. However, this meets my understanding
  of the problem as defined in comment #0.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-09 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #48531|0   |1
is obsolete||

--- Comment #4 from Aleisha Amohia  ---
Created attachment 48912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48912=edit
Bug 13238: Improve heading on vendor search when searching for all vendors

To test:
1) Go to Acquisitions and do an empty vendor search
2) Should now read "Vendor search: X result(s) found"
3) Enter a search term and search for vendor
4) Should now read "Vendor search: Y result(s) found for 'search term'"

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-09 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #3 from M. Tompsett  ---
(In reply to M. Tompsett from comment #2)
> Comment on attachment 48531 [details] [review]
> > +[% count %] result(s) found for 'vendor: [% supplier %]'
...
> http://template-toolkit.org/docs/manual/VMethods.html#section_length

And you could even get the result/results nicer too, with a nested if/else/end.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-09 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

--- Comment #2 from M. Tompsett  ---
Comment on attachment 48531
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48531
Bug 13238: Improve heading on vendor search when searching for all vendors

Review of attachment 48531:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=13238=48531)
-

This works, but:
2 result(s) found for 'vendor: '
still looks ugly for empty search term case, as mentioned in comment #0.

::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt
@@ +52,4 @@
>  
>  [% INCLUDE 'acquisitions-toolbar.inc' %]
>  [% UNLESS ( count == 1 ) %]
> +[% count %] result(s) found for 'vendor: [% supplier %]'

Perhaps an [% IF (supplier.length>0) %] ... [% ELSE % ][% count %]
result(s) found[% END %] -- Except with nicer vertical spacing?
http://template-toolkit.org/docs/manual/VMethods.html#section_length

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-01 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com
   Assignee|koha-b...@lists.koha-commun |aleishaamo...@hotmail.com
   |ity.org |
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-01 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13238] Improve heading on vendor search when searching for all vendors

2016-03-01 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13238

--- Comment #1 from Aleisha Amohia  ---
Created attachment 48531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48531=edit
Bug 13238: Improve heading on vendor search when searching for all vendors

Changed wording to be similar to a catalog search (ie 2 result(s) found for
'kw,wrdl: f')

To test:
1) Go to Acquisitions and do an empty vendor search
2) Should now read "2 result(s) found for 'vendor: '"

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/