[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Mason James m...@kohaaloha.com changed: What|Removed |Added Keywords|rel_3_16_candidate | --- Comment #16 from Mason James m...@kohaaloha.com --- Pushed to 3.16.x, will be in 3.16.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Mason James m...@kohaaloha.com changed: What|Removed |Added CC||m...@kohaaloha.com Keywords||rel_3_16_candidate --- Comment #15 from Mason James m...@kohaaloha.com --- Possible selection for 3.16.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Status|Pushed to Master|Pushed to Stable --- Comment #14 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #13 from Tomás Cohen Arazi tomasco...@gmail.com --- Patches pushed to master. Thanks Frido and Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 --- Comment #12 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 34758 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34758action=edit [PASSED QA] Bug 13268: the size should not be emptied in pl script It duplicates what the first patch does. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #34740|0 |1 is obsolete|| Attachment #34741|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 34757 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34757action=edit [PASSED QA] Bug 13268 - biblioitems.size value not correctly displayed (more) Bug partially corrected by Bug 11357. The size column in biblioitems is a bit problematic when used in TT, because instead of the size value from the biblio column it will give you the size of the variable or current loop. It's currently used in the templates like opac-topissues.tt : [% IF results_loo.size %][% results_loo.size %][% END %] This patch corrects by using item() TT method. See http://stackoverflow.com/questions/2311303/how-can-i-handle-hash-keys-containing-illegal-identifier-characters-in-template. Test plan : - Be sure there is a mapping between a MARC field and biblioitems.size - Create a record A with biblioitems.size defined : like 10x12 - Create a record B with no value in biblioitems.size - Check each modified page : = Without this patch : you see a number (loop size) for both records = With this patch : you only see the correct value for A and nothing for B Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #34286|0 |1 is obsolete|| --- Comment #9 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 34740 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34740action=edit Bug 13268 - biblioitems.size value not correctly displayed (more) Bug partially corrected by Bug 11357. The size column in biblioitems is a bit problematic when used in TT, because instead of the size value from the biblio column it will give you the size of the variable or current loop. It's currently used in the templates like opac-topissues.tt : [% IF results_loo.size %][% results_loo.size %][% END %] This patch corrects by using item() TT method. See http://stackoverflow.com/questions/2311303/how-can-i-handle-hash-keys-containing-illegal-identifier-characters-in-template. Test plan : - Be sure there is a mapping between a MARC field and biblioitems.size - Create a record A with biblioitems.size defined : like 10x12 - Create a record B with no value in biblioitems.size - Check each modified page : = Without this patch : you see a number (loop size) for both records = With this patch : you only see the correct value for A and nothing for B Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #34287|0 |1 is obsolete|| --- Comment #10 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 34741 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34741action=edit Bug 13268: the size should not be emptied in pl script It duplicates what the first patch does. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- This is quite annoying because a value is displayed, but not the good one! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33615|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34286 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34286action=edit Bug 13268 - biblioitems.size value not correctly displayed (more) Bug partially corrected by Bug 11357. The size column in biblioitems is a bit problematic when used in TT, because instead of the size value from the biblio column it will give you the size of the variable or current loop. It's currently used in the templates like opac-topissues.tt : [% IF results_loo.size %][% results_loo.size %][% END %] This patch corrects by using item() TT method. See http://stackoverflow.com/questions/2311303/how-can-i-handle-hash-keys-containing-illegal-identifier-characters-in-template. Test plan : - Be sure there is a mapping between a MARC field and biblioitems.size - Create a record A with biblioitems.size defined : like 10x12 - Create a record B with no value in biblioitems.size - Check each modified page : = Without this patch : you see a number (loop size) for both records = With this patch : you only see the correct value for A and nothing for B Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34287 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34287action=edit Bug 13268: the size should not be emptied in pl script It duplicates what the first patch does. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Against master: cataloguing/addbooks.pl?q=tintin I got: Les Aventures de Tintin. 15 : Objectif Lune [texte et dessins] par Hergé - 2203001151 - 1981 - Casterman - 61 p. ; 30 cm biblioitems.size is mapped with 215$d and is equal to '30 cm'. So what does this patch fix? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 --- Comment #4 from Fridolin SOMERS fridolyn.som...@biblibre.com --- (In reply to Jonathan Druart from comment #3) You reproduce the bug in opac-shelves.pl and opac-topissues.pl ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268
--- Comment #5 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
(In reply to Jonathan Druart from comment #3)
Against master:
cataloguing/addbooks.pl?q=tintin
I got:
Les Aventures de Tintin. 15 : Objectif Lune
[texte et dessins] par Hergé - 2203001151 - 1981 - Casterman - 61 p. ; 30 cm
biblioitems.size is mapped with 215$d and is equal to '30 cm'.
So what does this patch fix?
In this page, it works because of ugly hack in cataloguing/addbooks.pl :
foreach my $line (@newresults) {
if ( not exists $line-{'size'} ) { $line-{'size'} = }
}
Looks like resultsloo.size is the size of loop only when biblioitems.size is
undefined.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Assignee|oleon...@myacpl.org |fridolyn.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11357 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 --- Comment #1 from Fridolin SOMERS fridolyn.som...@biblibre.com --- Looks like it linked to Bug 11692 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11692 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268 --- Comment #2 from Fridolin SOMERS fridolyn.som...@biblibre.com --- Created attachment 33615 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33615action=edit Bug 13268 - biblioitems.size value not correctly displayed (more) Bug partially corrected by Bug 11357. The size column in biblioitems is a bit problematic when used in TT, because instead of the size value from the biblio column it will give you the size of the variable or current loop. It's currently used in the templates like opac-topissues.tt : [% IF results_loo.size %][% results_loo.size %][% END %] This patch corrects by using item() TT method. See http://stackoverflow.com/questions/2311303/how-can-i-handle-hash-keys-containing-illegal-identifier-characters-in-template. Test plan : - Be sure there is a mapping between a MARC field and biblioitems.size - Create a record A with biblioitems.size defined : like 10x12 - Create a record B with no value in biblioitems.size - Check each modified page : = Without this patch : you see a number (loop size) for both records = With this patch : you only see the correct value for A and nothing for B -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
