[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Owen Leonard  changed:

   What|Removed |Added

 Blocks||22351


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22351
[Bug 22351] SCSS conversion broke style on last checked out information
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

--- Comment #28 from Viktor Sarge  ---
(In reply to Katrin Fischer from comment #27)
> (In reply to Viktor Sarge from comment #26)
> > I love this patch a lot, but am I the only one who seems to get nothing in
> > the  [% issue.item.biblio.title %]? I only get the barcode and due date
> > (both production server and my dev-install). Since I seem to remember this
> > one working fine I'd just like to hear from others before I do any really
> > extensive testing on my setup.
> 
> I Viktor - I just checked, the title, barcode and due date display nicely in
> my tests.

Thanks for the feedback Katrin! It was gone for a while, but it was patched
with some later release and I had already forgotten about commenting on this
thread by then. Sorry for the extra work!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #27 from Katrin Fischer  ---
(In reply to Viktor Sarge from comment #26)
> I love this patch a lot, but am I the only one who seems to get nothing in
> the  [% issue.item.biblio.title %]? I only get the barcode and due date
> (both production server and my dev-install). Since I seem to remember this
> one working fine I'd just like to hear from others before I do any really
> extensive testing on my setup.

I Viktor - I just checked, the title, barcode and due date display nicely in my
tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Viktor Sarge  changed:

   What|Removed |Added

 CC||viktor.sarge@regionhalland.
   ||se

--- Comment #26 from Viktor Sarge  ---
I love this patch a lot, but am I the only one who seems to get nothing in the 
[% issue.item.biblio.title %]? I only get the barcode and due date (both
production server and my dev-install). Since I seem to remember this one
working fine I'd just like to hear from others before I do any really extensive
testing on my setup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Colin Campbell  changed:

   What|Removed |Added

 CC||colin.campbell@ptfs-europe.
   ||com

--- Comment #25 from Colin Campbell  ---
Change in return causes sipserver instances to crash on renewals : see bug 
14673 for description and workaround

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Blocks||14465

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #24 from Chris Cormack ch...@bigballofwax.co.nz ---
Applied on 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #23 from Chris Cormack ch...@bigballofwax.co.nz ---
String changes held for 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

--- Comment #21 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 37776
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37776action=edit
Bug 13315: (QA followup) fix t/db_dependent/Circulation_issue.t

C4::Circulation::AddIssue now returns a Koha::Schema::Result::Issue object
so tests need to be fixed.

The old behaviour was to always return the due date. It now returns
undef if no issue performed. So one of the tests become irrelevant.

Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #22 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Thanks Kyle and Owen, nice job!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #34384|0   |1
is obsolete||
  Attachment #34385|0   |1
is obsolete||

--- Comment #18 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 36290
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36290action=edit
Bug 13315 [Follow-up] Add feedback for last item checked out to circulation.pl

This patch changes the position and styling of the information about the
last checkout so that it is grouped with the checkout form itself,
placing the message in a more visible position, especially for patrons
with a lot of information in the right-hand messages column which might
push the checkouts table down offscreen.

To test, apply the patch and clear your browser cache in order to
refresh the main CSS file.

Check out an item and confirm that a message is prominently displayed.

Signed-off-by: Jason Burds  jbu...@dubuque.lib.ia.us
Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

--- Comment #20 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 36292
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36292action=edit
Bug 13315 [Follow-up] Add feedback for last item checked out to circulation.pl

This patch changes the position and styling of the information about the
last checkout so that it is grouped with the checkout form itself,
placing the message in a more visible position, especially for patrons
with a lot of information in the right-hand messages column which might
push the checkouts table down offscreen.

To test, apply the patch and clear your browser cache in order to
refresh the main CSS file.

Check out an item and confirm that a message is prominently displayed.

Signed-off-by: Jason Burds  jbu...@dubuque.lib.ia.us
Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #36290|0   |1
is obsolete||

--- Comment #19 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 36291
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36291action=edit
Bug 13315 - Add feedback for last item checked out to circulation.pl

It seems that many librarians find it disconcerting to have no feedback
with the new checkouts table. It seems that many of them wait for it to
fully load, check to verify the item was checked out, and only then
check out the next item.

To help alleviate this issue, we can have the checkouts page give
feedback about the item that was just checked out.

Test Plan:
1) Apply this patch
2) Check an item out
3) Note the message $title ($barcode) due on $date_due

Signed-off-by: Owen Leonard oleon...@myacpl.org

This works well and fixes a very problematic issue with the new AJAX
circ. I will be submitting a follow-up which I think is an improvement
to the display.

Signed-off-by: Jason Burds  jbu...@dubuque.lib.ia.us

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply
 CC||tomasco...@gmail.com

--- Comment #17 from Tomás Cohen Arazi tomasco...@gmail.com ---
Everything looks good, but it doesn't apply anymore, please rebase!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Heather Braum hbr...@nekls.org changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #34253|0   |1
is obsolete||
  Attachment #34254|0   |1
is obsolete||

--- Comment #15 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 34384
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34384action=edit
[PASSED QA] Bug 13315 - Add feedback for last item checked out to
circulation.pl

It seems that many librarians find it disconcerting to have no feedback
with the new checkouts table. It seems that many of them wait for it to
fully load, check to verify the item was checked out, and only then
check out the next item.

To help alleviate this issue, we can have the checkouts page give
feedback about the item that was just checked out.

Test Plan:
1) Apply this patch
2) Check an item out
3) Note the message $title ($barcode) due on $date_due

Signed-off-by: Owen Leonard oleon...@myacpl.org

This works well and fixes a very problematic issue with the new AJAX
circ. I will be submitting a follow-up which I think is an improvement
to the display.

Signed-off-by: Jason Burds  jbu...@dubuque.lib.ia.us

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

--- Comment #16 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 34385
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34385action=edit
[PASSED QA] Bug 13315 [Follow-up] Add feedback for last item checked out to
circulation.pl

This patch changes the position and styling of the information about the
last checkout so that it is grouped with the checkout form itself,
placing the message in a more visible position, especially for patrons
with a lot of information in the right-hand messages column which might
push the checkouts table down offscreen.

To test, apply the patch and clear your browser cache in order to
refresh the main CSS file.

Check out an item and confirm that a message is prominently displayed.

Signed-off-by: Jason Burds  jbu...@dubuque.lib.ia.us
Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

jdem...@roseville.ca.us jdem...@roseville.ca.us changed:

   What|Removed |Added

 CC||jdem...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

--- Comment #4 from Owen Leonard oleon...@myacpl.org ---
Here's the way it works with Kyle's patch:

http://www.screencast.com/t/qNw2U3hwz

I'm inclined to do something less obtrusive:

http://www.screencast.com/t/1gsa2prF

...on the assumption that the visual aspect of checking out was working fine
before AJAX circ, and fixes to AJAX circ should look to returning things to a
proven-functional state.

However, always assuming that it was better before would prevent us from making
improvements, so I want hear opinions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Christopher Brannon cbran...@cdalibrary.org changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #5 from Christopher Brannon cbran...@cdalibrary.org ---
(In reply to Owen Leonard from comment #4)
 Here's the way it works with Kyle's patch:
 
 http://www.screencast.com/t/qNw2U3hwz
 
 I'm inclined to do something less obtrusive:
 
 http://www.screencast.com/t/1gsa2prF
 
 ...on the assumption that the visual aspect of checking out was working fine
 before AJAX circ, and fixes to AJAX circ should look to returning things to
 a proven-functional state.
 
 However, always assuming that it was better before would prevent us from
 making improvements, so I want hear opinions.

Owen,
I would be more inclined to see the feedback in the same area that I'm scanning
in (in the same box).  Maybe at the bottom?  It is less scanning around the
screen.  You are already looking there when scanning, why not have it in the
same area?

The concept is similar to switching between the keyboard and mouse.  If I am
given the option, I will choose a technique that requires the least amount of
reorientation.

Just my two cents.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Jason Burds jbu...@dubuque.lib.ia.us changed:

   What|Removed |Added

 CC||jbu...@dubuque.lib.ia.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

--- Comment #6 from Owen Leonard oleon...@myacpl.org ---
(In reply to Christopher Brannon from comment #5)
 I would be more inclined to see the feedback in the same area that I'm
 scanning in (in the same box).  Maybe at the bottom?

I like this idea too! Here's my take:

http://www.screencast.com/t/ZcsPfJabP

The advantage to this method is that the feedback is visible even for patrons
with lost of information in the messages column:

http://www.screencast.com/t/3uEHAaWnUyc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

--- Comment #7 from Jason Burds jbu...@dubuque.lib.ia.us ---
If I have a vote it's for this one.

http://www.screencast.com/t/ZcsPfJabP

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

--- Comment #8 from Christopher Brannon cbran...@cdalibrary.org ---
(In reply to Owen Leonard from comment #6)
 (In reply to Christopher Brannon from comment #5)
  I would be more inclined to see the feedback in the same area that I'm
  scanning in (in the same box).  Maybe at the bottom?
 
 I like this idea too! Here's my take:
 
 http://www.screencast.com/t/ZcsPfJabP
 
 The advantage to this method is that the feedback is visible even for
 patrons with lost of information in the messages column:
 
 http://www.screencast.com/t/3uEHAaWnUyc

Excellent.  My OCD side of me says indent everything past Checked out: so it
is more visually attractive.  Something like this:

http://screencast.com/t/EC4qcKNixO

But this is just a simulated example.  Don't know how the formatting would
actually look or work.

I'd also suggest a contrasting background color to help bring attention to it. 
Unlike some of the warning messages that are yellow, I'd maybe use a faint
green background?

Here's another example, with the header above and slightly larger, with a
colored background:

http://screencast.com/t/hDNBknJ8e

Anyway, I think placement is excellent.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

Version|unspecified |master
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

--- Comment #10 from Owen Leonard oleon...@myacpl.org ---
Created attachment 34251
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34251action=edit
Bug 13315 [Follow-up] Add feedback for last item checked out to circulation.pl

This patch changes the position and styling of the information about the
last checkout so that it is grouped with the checkout form itself,
placing the message in a more visible position, especially for patrons
with a lot of information in the right-hand messages column which might
push the checkouts table down offscreen.

To test, apply the patch and clear your browser cache in order to
refresh the main CSS file.

Check out an item and confirm that a message is prominently displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #33765|0   |1
is obsolete||

--- Comment #9 from Owen Leonard oleon...@myacpl.org ---
Created attachment 34250
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34250action=edit
[SIGNED-OFF] Bug 13315 - Add feedback for last item checked out to
circulation.pl

It seems that many librarians find it disconcerting to have no feedback
with the new checkouts table. It seems that many of them wait for it to
fully load, check to verify the item was checked out, and only then
check out the next item.

To help alleviate this issue, we can have the checkouts page give
feedback about the item that was just checked out.

Test Plan:
1) Apply this patch
2) Check an item out
3) Note the message $title ($barcode) due on $date_due

Signed-off-by: Owen Leonard oleon...@myacpl.org

This works well and fixes a very problematic issue with the new AJAX
circ. I will be submitting a follow-up which I think is an improvement
to the display.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Jason Burds jbu...@dubuque.lib.ia.us changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #11 from Jason Burds jbu...@dubuque.lib.ia.us ---
Looks good.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #34250|0   |1
is obsolete||
  Attachment #34251|0   |1
is obsolete||

--- Comment #12 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 34253
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34253action=edit
[SIGNED-OFF] Bug 13315 - Add feedback for last item checked out to
circulation.pl

It seems that many librarians find it disconcerting to have no feedback
with the new checkouts table. It seems that many of them wait for it to
fully load, check to verify the item was checked out, and only then
check out the next item.

To help alleviate this issue, we can have the checkouts page give
feedback about the item that was just checked out.

Test Plan:
1) Apply this patch
2) Check an item out
3) Note the message $title ($barcode) due on $date_due

Signed-off-by: Owen Leonard oleon...@myacpl.org

This works well and fixes a very problematic issue with the new AJAX
circ. I will be submitting a follow-up which I think is an improvement
to the display.

Signed-off-by: Jason Burds  jbu...@dubuque.lib.ia.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

--- Comment #13 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 34254
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34254action=edit
[SIGNED-OFF] Bug 13315 [Follow-up] Add feedback for last item checked out to
circulation.pl

This patch changes the position and styling of the information about the
last checkout so that it is grouped with the checkout form itself,
placing the message in a more visible position, especially for patrons
with a lot of information in the right-hand messages column which might
push the checkouts table down offscreen.

To test, apply the patch and clear your browser cache in order to
refresh the main CSS file.

Check out an item and confirm that a message is prominently displayed.

Signed-off-by: Jason Burds  jbu...@dubuque.lib.ia.us
Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

--- Comment #14 from Kyle M Hall k...@bywatersolutions.com ---
I just wanted to add that Owen's followup looks fantastic! Great work!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 33764
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33764action=edit
Bug 13315 - Add feedback for last item checked out to circulation.pl

It seems that many librarians find it disconcerting to have no feedback
with the new checkouts table. It seems that many of them wait for it to
fully load, check to verify the item was checked out, and only then
check out the next item.

To help alleviate this issue, we can have the checkouts page give
feedback about the item that was just checked out.

Test Plan:
1) Apply this patch
2) Check an item out
3) Note the message $title ($barcode) due on $date_due

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #33764|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 33765
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33765action=edit
Bug 13315 - Add feedback for last item checked out to circulation.pl

It seems that many librarians find it disconcerting to have no feedback
with the new checkouts table. It seems that many of them wait for it to
fully load, check to verify the item was checked out, and only then
check out the next item.

To help alleviate this issue, we can have the checkouts page give
feedback about the item that was just checked out.

Test Plan:
1) Apply this patch
2) Check an item out
3) Note the message $title ($barcode) due on $date_due

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

--- Comment #3 from Owen Leonard oleon...@myacpl.org ---
I think this is an important step towards making the AJAX circ feature more
usable, but I think it would be good to get some opinions from librarians about
this implementation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/