[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Bug 13323 depends on bug 13321, which changed state. Bug 13321 Summary: Fix tax and prices calculation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #36 from Kyle M Hall --- Pushed to master for 16.11, thanks Jonathan, Julian! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Nick Clemens changed: What|Removed |Added Attachment #56436|0 |1 is obsolete|| --- Comment #35 from Nick Clemens --- Created attachment 56897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56897&action=edit Bug 13323: Recalculate tax_value for partially received orders Test plan: 1. Create an order with at least 2 items 2. Receive only 1 item 3. Check that the tax value of the received order line is correct on the parcel and invoice pages 4. Check that the tax value of the original order line is correct (on the basket page for example) 5. Cancel the receipt 6. Check that the tax value of the original order line is correct Signed-off-by: Sonia Bouis Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Nick Clemens changed: What|Removed |Added Attachment #56435|0 |1 is obsolete|| --- Comment #34 from Nick Clemens --- Created attachment 56896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56896&action=edit Bug 13323: QA fix (trailing whitespace) Signed-off-by: Sonia Bouis Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Nick Clemens changed: What|Removed |Added Attachment #56434|0 |1 is obsolete|| --- Comment #33 from Nick Clemens --- Created attachment 56895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56895&action=edit Bug 13323: Tax rate can change on receiving This commit permits to update the tax rate on receiving. Signed-off-by: Laurence Rault Signed-off-by: Francois Charbonnier Signed-off-by: Sonia Bouis Signed-off-by: Sonia Bouis Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Nick Clemens changed: What|Removed |Added Attachment #56433|0 |1 is obsolete|| --- Comment #32 from Nick Clemens --- Created attachment 56894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56894&action=edit Bug 13323: Tax rate can change on receiving - DB changes This patch adds 4 new DB fields to the aqorders table: * tax_rate_on_ordering * tax_rate_on_receiving * tax_value_on_ordering * tax_value_on_receiving Signed-off-by: Laurence Rault Signed-off-by: Francois Charbonnier Signed-off-by: Sonia Bouis Signed-off-by: Sonia Bouis Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Koha Team Lyon 3 changed: What|Removed |Added Status|BLOCKED |Signed Off --- Comment #31 from Koha Team Lyon 3 --- tested with all the configuration of vendor possible (GST include/exclude). I have tried to change the price / GST on receiving. I have tried partial receipt. All works as described. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Koha Team Lyon 3 changed: What|Removed |Added Attachment #56096|0 |1 is obsolete|| --- Comment #27 from Koha Team Lyon 3 --- Created attachment 56433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56433&action=edit Bug 13323: Tax rate can change on receiving - DB changes This patch adds 4 new DB fields to the aqorders table: * tax_rate_on_ordering * tax_rate_on_receiving * tax_value_on_ordering * tax_value_on_receiving Signed-off-by: Laurence Rault Signed-off-by: Francois Charbonnier Signed-off-by: Sonia Bouis Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Koha Team Lyon 3 changed: What|Removed |Added Attachment #56387|0 |1 is obsolete|| --- Comment #30 from Koha Team Lyon 3 --- Created attachment 56436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56436&action=edit Bug 13323: Recalculate tax_value for partially received orders Test plan: 1. Create an order with at least 2 items 2. Receive only 1 item 3. Check that the tax value of the received order line is correct on the parcel and invoice pages 4. Check that the tax value of the original order line is correct (on the basket page for example) 5. Cancel the receipt 6. Check that the tax value of the original order line is correct Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Koha Team Lyon 3 changed: What|Removed |Added Attachment #56097|0 |1 is obsolete|| --- Comment #28 from Koha Team Lyon 3 --- Created attachment 56434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56434&action=edit Bug 13323: Tax rate can change on receiving This commit permits to update the tax rate on receiving. Signed-off-by: Laurence Rault Signed-off-by: Francois Charbonnier Signed-off-by: Sonia Bouis Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Koha Team Lyon 3 changed: What|Removed |Added Attachment #56098|0 |1 is obsolete|| --- Comment #29 from Koha Team Lyon 3 --- Created attachment 56435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56435&action=edit Bug 13323: QA fix (trailing whitespace) Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 --- Comment #26 from Julian Maurice --- Created attachment 56387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56387&action=edit Bug 13323: Recalculate tax_value for partially received orders Test plan: 1. Create an order with at least 2 items 2. Receive only 1 item 3. Check that the tax value of the received order line is correct on the parcel and invoice pages 4. Check that the tax value of the original order line is correct (on the basket page for example) 5. Cancel the receipt 6. Check that the tax value of the original order line is correct -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Julian Maurice changed: What|Removed |Added Attachment #51983|0 |1 is obsolete|| --- Comment #24 from Julian Maurice --- Created attachment 56097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56097&action=edit Bug 13323: Tax rate can change on receiving This commit permits to update the tax rate on receiving. Signed-off-by: Laurence Rault Signed-off-by: Francois Charbonnier Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Julian Maurice changed: What|Removed |Added Attachment #51982|0 |1 is obsolete|| --- Comment #23 from Julian Maurice --- Created attachment 56096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56096&action=edit Bug 13323: Tax rate can change on receiving - DB changes This patch adds 4 new DB fields to the aqorders table: * tax_rate_on_ordering * tax_rate_on_receiving * tax_value_on_ordering * tax_value_on_receiving Signed-off-by: Laurence Rault Signed-off-by: Francois Charbonnier Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Julian Maurice changed: What|Removed |Added Attachment #51984|0 |1 is obsolete|| --- Comment #25 from Julian Maurice --- Created attachment 56098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56098&action=edit Bug 13323: QA fix (trailing whitespace) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Alex Arnaud changed: What|Removed |Added Attachment #48876|0 |1 is obsolete|| --- Comment #22 from Alex Arnaud --- Created attachment 51984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51984&action=edit Bug 13323: QA fix (trailing whitespace) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Alex Arnaud changed: What|Removed |Added Attachment #48875|0 |1 is obsolete|| --- Comment #21 from Alex Arnaud --- Created attachment 51983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51983&action=edit Bug 13323: Tax rate can change on receiving This commit permits to update the tax rate on receiving. Signed-off-by: Laurence Rault Signed-off-by: Francois Charbonnier Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Alex Arnaud changed: What|Removed |Added Attachment #48874|0 |1 is obsolete|| --- Comment #20 from Alex Arnaud --- Created attachment 51982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51982&action=edit Bug 13323: Tax rate can change on receiving - DB changes This patch adds 4 new DB fields to the aqorders table: * tax_rate_on_ordering * tax_rate_on_receiving * tax_value_on_ordering * tax_value_on_receiving Signed-off-by: Laurence Rault Signed-off-by: Francois Charbonnier Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Katrin Fischer changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #19 from Katrin Fischer --- Dependent bug 13321 is Failed QA. Please reset status once 13321 is ok. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Julian Maurice changed: What|Removed |Added Attachment #47495|0 |1 is obsolete|| --- Comment #16 from Julian Maurice --- Created attachment 48874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48874&action=edit Bug 13323: Tax rate can change on receiving - DB changes Rebased on master and added Signed-off-by lines that were lost in the process -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Julian Maurice changed: What|Removed |Added Attachment #47499|0 |1 is obsolete|| --- Comment #18 from Julian Maurice --- Created attachment 48876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48876&action=edit Bug 13323: QA fix (trailing whitespace) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Julian Maurice changed: What|Removed |Added Attachment #47496|0 |1 is obsolete|| --- Comment #17 from Julian Maurice --- Created attachment 48875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48875&action=edit Bug 13323: Tax rate can change on receiving Rebased on master and added Signed-off-by lines that were lost in the process -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Jonathan Druart changed: What|Removed |Added Blocks||16017 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16017 [Bug 16017] Currency constraints and poorly named prices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 --- Comment #15 from Julian Maurice --- Created attachment 47499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47499&action=edit Bug 13323: QA fix (trailing whitespace) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 --- Comment #14 from Julian Maurice --- All patches rebased on master. Also, sandbox 17 has been updated with those patches: http://pro.test17.biblibre.com/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Julian Maurice changed: What|Removed |Added Attachment #33870|0 |1 is obsolete|| --- Comment #13 from Julian Maurice --- Created attachment 47496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47496&action=edit Bug 13323: Tax rate can change on receiving Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Julian Maurice changed: What|Removed |Added Attachment #33871|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Julian Maurice changed: What|Removed |Added Attachment #33869|0 |1 is obsolete|| --- Comment #12 from Julian Maurice --- Created attachment 47495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47495&action=edit Bug 13323: Tax rate can change on receiving - DB changes Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #11 from Kyle M Hall --- (In reply to Jonathan Druart from comment #10) > (In reply to Francois Charbonnier from comment #8) > > Jonathan, could you sign them off on my behalf? > > Added on the remote branch :) Jonathan, could you rebase your patches and attach them to this bug? I'd like to try to QA them! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Marc Véron changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14541 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Jonathan Druart changed: What|Removed |Added Blocks||11514 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Jonathan Druart changed: What|Removed |Added Blocks||10253 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Jonathan Druart changed: What|Removed |Added Blocks||13726 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 --- Comment #10 from Jonathan Druart --- (In reply to Francois Charbonnier from comment #8) > Jonathan, could you sign them off on my behalf? Added on the remote branch :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 --- Comment #9 from Jonathan Druart --- (In reply to Francois Charbonnier from comment #8) > I tested the patches on Biblibre's sandbox17. > > Jonathan, could you sign them off on my behalf? > > Thanks! Thanks François! I will add you signoff to the commit on the remote branch. Thanks for testing! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Francois Charbonnier changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #8 from Francois Charbonnier --- In the end, about the set up 3, Laurence, Sonia, I agree with both of you. About the set up 4, I'll keep what we have now because it shares the same logic thabn the set up 3. I tested the patches on Biblibre's sandbox17. Jonathan, could you sign them off on my behalf? Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Jonathan Druart changed: What|Removed |Added Blocks||11062 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Koha Team Lyon 3 changed: What|Removed |Added CC||k...@univ-lyon3.fr --- Comment #7 from Koha Team Lyon 3 --- For the setup 3 (List prices INCLUDE TAX + Invoice prices EXCLUDE TAX), I would have the same analysis as Laurence : the change of tax between order and receipt should not change prices tax excl. that are the basis. So this patch introduce the right calculation. For the setup4 (List prices EXCLUDE TAX + Invoice prices INCLUDE TAX), It would be better that the price tax incl. was recalculated in the order receive page. But for me, it's not the most important. What really matters is that the calculation is right after the receipt was recorded. There's often a change of price between the order and the receipt and the calculation have to take into account the entered price. Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Laurence Lefaucheur changed: What|Removed |Added CC||laurence.lefaucheur@biblibr ||e.com --- Comment #6 from Laurence Lefaucheur --- Set up 3 (List prices INCLUDE TAX + Invoice prices EXCLUDE TAX): I think that Vendor price (tax excl) when receiving should be the same as calculated in Ordering. In my mind this price is kind of 'base' price for the item. So the following seems to be logical for me : Ordering : Vendor price (tax incl) = 10 euros < what I entered Vendor price (tax excl) = 9.52 euros Tax amount (5%) = 0.48 euros Total (tax excl) = 9.52 euros Total (tax incl) = 10 euros Receiving (what we have now): Vendor price (tax incl) = 10.47 euros Vendor price (tax excl) = 9.52 euros (= value in actual cost) Tax amount (10%) = 0.95 euros Total (tax excl) = 9.52 euros Total (tax incl) = 10.47 euros Set up 4 (List prices EXCLUDE TAX + Invoice prices INCLUDE TAX): is less evident : I wonder if Vendor price (tax excl) should be changed between order and reception. If it's not the case, François's proposition should be considered But we have no library examples of case where the way of using tax include/exclude changes between ordering and receiving, so I am not really for changing the calculation just now without more real experience of how it should be. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Francois Charbonnier changed: What|Removed |Added CC||francois.charbonnier@inlibr ||o.com --- Comment #5 from Francois Charbonnier --- I tested this patch on BibLibre's sandbox17. Here is what I did. I created 4 new vendors to test 4 different set ups : Set up 1 = List prices INCLUDE TAX + Invoice prices INCLUDE TAX Set up 2 = List prices EXCLUDE TAX + Invoice prices EXCLUDE TAX Set up 3 = List prices INCLUDE TAX + Invoice prices EXCLUDE TAX Set up 4 = List prices EXCLUDE TAX + Invoice prices INCLUDE TAX For each vendor, default tax rate is 5%. Then, for each vendor : * I add 1 basket with 1 item. Vendor price is 10 euros. Default tax rate is 5%. * I check the prices and tax caculation on the basket page. Everything is well calculated (prices tax included or excluded) * I close the basket and go to the receive page * I receive the item and change the tax rate to 10%. * I check the prices and tax calculation on the receive page. For the set ups 1 and 2, I have what I expected. Not for the set ups 3 and 4. Set up 1 (List prices INCLUDE TAX + Invoice prices INCLUDE TAX): Ordering : Vendor price (tax incl) = 10 euros < what I entered Vendor price (tax excl) = 9.52 euros Tax amount (5%) = 0.48 euros Total (tax excl) = 9.52 euros Total (tax incl) = 10 euros Receiving : Vendor price (tax incl) = 10 euros (= value in actual cost) Vendor price (tax excl) = 9.09 euros Tax amount (10%) = 0.91 euros Total (tax excl) = 9.09 euros Total (tax incl) = 10 euros Set up 2 (List prices EXCLUDE TAX + Invoice prices EXCLUDE TAX): Ordering : Vendor price (tax incl) = 10.5 euros Vendor price (tax excl) = 10 euros < what I entered Tax amount (5%) = 0.5 euros Total (tax excl) = 10 euros Total (tax incl) = 10.5 euros Receiving : Vendor price (tax incl) = 11 euros Vendor price (tax excl) = 10 euros (= value in actual cost) Tax amount (10%) = 1 euros Total (tax excl) = 10 euros Total (tax incl) = 11 euros Set up 3 (List prices INCLUDE TAX + Invoice prices EXCLUDE TAX): Ordering : Vendor price (tax incl) = 10 euros < what I entered Vendor price (tax excl) = 9.52 euros Tax amount (5%) = 0.48 euros Total (tax excl) = 9.52 euros Total (tax incl) = 10 euros Receiving (what we have now): Vendor price (tax incl) = 10.47 euros Vendor price (tax excl) = 9.52 euros (= value in actual cost) Tax amount (10%) = 0.95 euros Total (tax excl) = 9.52 euros Total (tax incl) = 10.47 euros Receiving (what I expected): Vendor price (tax incl) = 10 euros Vendor price (tax excl) = 9.09 euros (= value in actual cost) Tax amount (10%) = 0.91 euros Total (tax excl) = 9.09 euros Total (tax incl) = 10 euros Since I entered the price tax included and then changed the tax rate, I expected the actual cost, which is here the price tax excluded, to be recalculated. But here, the value in actual cost is the price tax excluded calculated on the price tax included with a 5% tax (but I changed it to 10%...) Set up 4 (List prices EXCLUDE TAX + Invoice prices INCLUDE TAX): Ordering : Vendor price (tax incl) = 10.5 euros Vendor price (tax excl) = 10 euros < what I entered Tax amount (5%) = 0.5 euros Total (tax excl) = 10 euros Total (tax incl) = 10.5 euros Receiving (what we have) : Vendor price (tax incl) = 10.50 euros (= value in actual cost) Vendor price (tax excl) = 9.55 euros Tax amount (10%) = 0.95 euros Total (tax excl) = 9.55 euros Total (tax incl) = 10.50 euros Receiving (what I expected) : Vendor price (tax incl) = 11 euros (= value in actual cost) Vendor price (tax excl) = 10 euros Tax amount (10%) = 1 euros Total (tax excl) = 10 euros Total (tax incl) = 11 euros Same logic than before. I expected the value in actual cost to be recalculated. In a few words, I expect the reference value on which calculation should be based to be the one I entered when I placed the order. So, if I change the tax rate during the receiving process, I expect the actual cost to be recalculated. Here, the actual cost calculation is always based on the tax rate we have when placing the order. To me, it's not logical. Jonathan, could you ask librarians in charge of acquisition what they think of this. I'll trust their judgment. If the logic in place is good. You can signed off these patches. If not, tell me when it's ready and I'll test it again. ;^) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #4 from Jonathan Druart --- To test these patches, have a look at http://lists.koha-community.org/pipermail/koha-devel/2014-December/041024.html -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 --- Comment #2 from Jonathan Druart --- Created attachment 33870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33870&action=edit Bug 13323: Tax rate can change on receiving This commit permits to update the tax rate on receiving. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 --- Comment #1 from Jonathan Druart --- Created attachment 33869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33869&action=edit Bug 13323: Tax rate can change on receiving - DB changes This patch adds 4 new DB fields to the aqorders table: * tax_rate_on_ordering * tax_rate_on_receiving * tax_value_on_ordering * tax_value_on_receiving -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 --- Comment #3 from Jonathan Druart --- Created attachment 33871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33871&action=edit Bug 13323: [DO NOT PUSH] Tax rate can change on receiving - DBIC changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Jonathan Druart changed: What|Removed |Added Depends on||13321 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
