[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Katrin Fischer changed: What|Removed |Added Blocks||29462 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29462 [Bug 29462] OPACPopupAuthorsSearch doesn't work when authors include $d, $4, and possible other subfields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Katrin Fischer changed: What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #33 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 David Nind changed: What|Removed |Added Text to go in the||This enhancement improves release notes||the OPACPopupAuthorsSearch ||feature so that it works in ||both the normal and XSLT ||views ||(OPACXSLTDetailsDisplay). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #32 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Martin Renvoize changed: What|Removed |Added Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #31 from Martin Renvoize --- Thanks guys, really pleased to see this one having made it through :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #29 from Jonathan Druart --- Created attachment 99771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99771=edit Bug 13327: (follow-up) Correct CSS and XSL errors This patch adds back the CSS changes which seem to have been lost in a rebase somewhere. The patch also corrects a bad copy/paste in the XSL file which led to a 404 error. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #30 from Jonathan Druart --- (In reply to Jonathan Druart from comment #27) > Owen, sorry but I found a regression. > > With OPACPopupAuthorsSearch and NOT OPACXSLTDetailsDisplay > Hit /cgi-bin/koha/opac-detail.pl?biblionumber=15 > Without the patch, the link on "Additional authors: Bradbury, Nicola." opens > a popup. It does not with your patch. Saw with Owen on IRC. There was only 1 checkbox on the popup, so assuming it's a bug fix and not a regression. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Jonathan Druart changed: What|Removed |Added Attachment #99296|0 |1 is obsolete|| Attachment #99297|0 |1 is obsolete|| --- Comment #28 from Jonathan Druart --- Created attachment 99770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99770=edit Bug 13327: OPACPopupAuthorsSearch doesn't work with XSLT views This patch reimplements the OPACPopupAuthorsSearch feature so that it will work in the XSLT view. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - View the detail page for a bibliographic record in the OPAC. Test under the following conditions: - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay empty - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay empty In each of these cases, test the detail page's listing of additional authors/contributors and subjects. Test records which have both multiple contributors or subjects and which have only one author or subject. When OPACPopupAuthorsSearch is turned on, verify that the author/subject selection modal appears and that your selections are correctly combined to build a search string. Note that OPACPopupAuthorsSearch feature has a problem with terms containing parentheses. The issue predates this patch. Also note that the QA tools will give a false positive about Bootstrap button styles. This rule only applies to the staff client. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #27 from Jonathan Druart --- Owen, sorry but I found a regression. With OPACPopupAuthorsSearch and NOT OPACXSLTDetailsDisplay Hit /cgi-bin/koha/opac-detail.pl?biblionumber=15 Without the patch, the link on "Additional authors: Bradbury, Nicola." opens a popup. It does not with your patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #26 from Jonathan Druart --- (In reply to Katrin Fischer from comment #25) > Sorry, working on the older bugs by bug number - missed your QA contact > (also sometimes it's not reliable :) ) No worries I was not, I assigned to me after you PQAed it! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #25 from Katrin Fischer --- Sorry, working on the older bugs by bug number - missed your QA contact (also sometimes it's not reliable :) ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #24 from Katrin Fischer --- (In reply to Katrin Fischer from comment #23) > (In reply to Jonathan Druart from comment #22) > > > Note that OPACPopupAuthorsSearch feature has a problem with terms > > > containing parentheses. The issue predates this patch. > > > > To avoid that, should not we search using the id instead of the string? > > We could, but we still need to fix it, as not all entries will be linked to > authorities - some libraries don't use them at all and there can also be a > mix. For example 653 (uncontrolled term) will show as subject but is, if i > am not mistaken, usually unlinked (uncontrolled). Oh, see bug 24690 - I filed it for follow-ups. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #23 from Katrin Fischer --- (In reply to Jonathan Druart from comment #22) > > Note that OPACPopupAuthorsSearch feature has a problem with terms > > containing parentheses. The issue predates this patch. > > To avoid that, should not we search using the id instead of the string? We could, but we still need to fix it, as not all entries will be linked to authorities - some libraries don't use them at all and there can also be a mix. For example 653 (uncontrolled term) will show as subject but is, if i am not mistaken, usually unlinked (uncontrolled). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #22 from Jonathan Druart --- > Note that OPACPopupAuthorsSearch feature has a problem with terms > containing parentheses. The issue predates this patch. To avoid that, should not we search using the id instead of the string? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Signed Off --- Comment #21 from Jonathan Druart --- I wanted to get back to this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Jonathan Druart changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Katrin Fischer changed: What|Removed |Added Attachment #99250|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer --- Created attachment 99297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99297=edit Bug 13327: (follow-up) Correct CSS and XSL errors This patch adds back the CSS changes which seem to have been lost in a rebase somewhere. The patch also corrects a bad copy/paste in the XSL file which led to a 404 error. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Katrin Fischer changed: What|Removed |Added Attachment #99002|0 |1 is obsolete|| --- Comment #19 from Katrin Fischer --- Created attachment 99296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99296=edit Bug 13327: OPACPopupAuthorsSearch doesn't work with XSLT views This patch reimplements the OPACPopupAuthorsSearch feature so that it will work in the XSLT view. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - View the detail page for a bibliographic record in the OPAC. Test under the following conditions: - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay empty - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay empty In each of these cases, test the detail page's listing of additional authors/contributors and subjects. Test records which have both multiple contributors or subjects and which have only one author or subject. When OPACPopupAuthorsSearch is turned on, verify that the author/subject selection modal appears and that your selections are correctly combined to build a search string. Note that OPACPopupAuthorsSearch feature has a problem with terms containing parentheses. The issue predates this patch. Also note that the QA tools will give a false positive about Bootstrap button styles. This rule only applies to the staff client. Signed-off-by: Liz Rea Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Katrin Fischer changed: What|Removed |Added Blocks||24690 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 [Bug 24690] Make OPACPopupAuthorsSearch work with search terms containing parenthesis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #18 from Katrin Fischer --- hi Owen, sorry, just realized it was even in the test plan: Also note that the QA tools will give a false positive about Bootstrap button styles. This rule only applies to the staff client. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #17 from Katrin Fischer --- Thx! I'll try to come back to this one in my next QA session (not mad if someone beats me to it :) ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #16 from Owen Leonard --- (In reply to Katrin Fischer from comment #15) > forbidden pattern: Contains old bootstrap style for buttons > (see bug It's a false positive. That check doesn't apply to OPAC templates. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer --- Hi Owen, can you please check? FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt OK filters FAIL forbidden patterns forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 1347) OK git manipulation OK js_in_body OK spelling OK tt_valid OK valid_template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #14 from Owen Leonard --- (In reply to Jonathan Druart from comment #10) > Request URL:http://catalogue.kohadev.org/opac-tmpl/bootstrap/images/z.png > Also, the style looks weird (I did yarn build --view opac): My follow-up should correct these mistakes. > And the popup does not display for the non XSLT view (new search is launched > instead). I don't see this problem. I believe the popup displays in all cases where it did previously, which excepts the "magnifying glass" link which links directly to an authority search. Can you re-test? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #13 from Owen Leonard --- Created attachment 99250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99250=edit Bug 13327: (follow-up) Correct CSS and XSL errors This patch adds back the CSS changes which seem to have been lost in a rebase somewhere. The patch also corrects a bad copy/paste in the XSL file which led to a 404 error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #12 from Jonathan Druart --- Also, the style looks weird (I did yarn build --view opac): https://snipboard.io/ob6UZq.jpg And the popup does not display for the non XSLT view (new search is launched instead). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #11 from Jonathan Druart --- (In reply to Jonathan Druart from comment #10) > I get a 404 > Request URL:http://catalogue.kohadev.org/opac-tmpl/bootstrap/images/z.png https://snipboard.io/8BbRWf.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #10 from Jonathan Druart --- I get a 404 Request URL:http://catalogue.kohadev.org/opac-tmpl/bootstrap/images/z.png -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Liz Rea changed: What|Removed |Added Attachment #98939|0 |1 is obsolete|| --- Comment #9 from Liz Rea --- Created attachment 99002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99002=edit Bug 13327: OPACPopupAuthorsSearch doesn't work with XSLT views This patch reimplements the OPACPopupAuthorsSearch feature so that it will work in the XSLT view. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - View the detail page for a bibliographic record in the OPAC. Test under the following conditions: - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay empty - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay empty In each of these cases, test the detail page's listing of additional authors/contributors and subjects. Test records which have both multiple contributors or subjects and which have only one author or subject. When OPACPopupAuthorsSearch is turned on, verify that the author/subject selection modal appears and that your selections are correctly combined to build a search string. Note that OPACPopupAuthorsSearch feature has a problem with terms containing parentheses. The issue predates this patch. Also note that the QA tools will give a false positive about Bootstrap button styles. This rule only applies to the staff client. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #8 from Owen Leonard --- (In reply to David Nind from comment #6) > A new issue is the pop-up select boxes - they aren't formatted correctly. I forgot to update the test plan with my revised patch: The OPAC CSS needs to be rebuilt! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard changed: What|Removed |Added Attachment #98885|0 |1 is obsolete|| --- Comment #7 from Owen Leonard --- Created attachment 98939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98939=edit Bug 13327: OPACPopupAuthorsSearch doesn't work with XSLT views This patch reimplements the OPACPopupAuthorsSearch feature so that it will work in the XSLT view. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - View the detail page for a bibliographic record in the OPAC. Test under the following conditions: - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay empty - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay empty In each of these cases, test the detail page's listing of additional authors/contributors and subjects. Test records which have both multiple contributors or subjects and which have only one author or subject. When OPACPopupAuthorsSearch is turned on, verify that the author/subject selection modal appears and that your selections are correctly combined to build a search string. Note that OPACPopupAuthorsSearch feature has a problem with terms containing parentheses. The issue predates this patch. Also note that the QA tools will give a false positive about Bootstrap button styles. This rule only applies to the staff client. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #6 from David Nind --- Created attachment 98904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98904=edit Bug 13327: Screenshots - select items to search issue I think the issues from the previous testing are now resolved. A new issue is the pop-up select boxes - they aren't formatted correctly. See the attachment Bug 13327 - Select items to search issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard changed: What|Removed |Added Attachment #96919|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 98885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98885=edit Bug 13327: OPACPopupAuthorsSearch doesn't work with XSLT views This patch reimplements the OPACPopupAuthorsSearch feature so that it will work in the XSLT view. To test, apply the patch and view the detail page for a bibliographic record in the OPAC. Test under the following conditions: - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay empty - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay empty In each of these cases, test the detail page's listing of additional authors/contributors and subjects. Test records which have both multiple contributors or subjects and which have only one author or subject. When OPACPopupAuthorsSearch is turned on, verify that the author/subject selection modal appears and that your selections are correctly combined to build a search string. Note that OPACPopupAuthorsSearch feature has a problem with terms containing parentheses. The issue predates this patch. Also note that the QA tools will give a false positive about Bootstrap button styles. This rule only applies to the staff client. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard --- Thanks for testing, David! I'll take a look. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- Created attachment 97932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97932=edit Bug 13327: Screenshots with different options Results from my testing: - For OPACPopupAuthorsSearch enabled and OPACXSLTDetailsDisplay default: • works for the author search (the new style for the modal is much nicer) • the modal for subject terms doesn't appear/work - For OPACPopupAuthorsSearch enabled and OPACXSLTDetailsDisplay empty: • search icon different for additional authors • old search icon displays for ‘Subject(s):’ • the modal for subject terms works, but uses 'old style' - For OPACPopupAuthorsSearch disabled and OPACXSLTDetailsDisplay empty - the record displays the same as for OPACPopupAuthorsSearch enabled and OPACXSLTDetailsDisplay empty I've attached a document with screenshots. Tested use Firefox Developer Edition and Google Chrome on Ubuntu 18.04 - cleared browser history, cache, etc for different combination of options. Also used a fresh container for each combination using koha-testing-docker. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #2 from Owen Leonard --- Created attachment 96919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96919=edit Bug 13327: OPACPopupAuthorsSearch doesn't work with XSLT views This patch reimplements the OPACPopupAuthorsSearch feature so that it will work in the XSLT view. To test, apply the patch and view the detail page for a bibliographic record in the OPAC. Test under the following conditions: - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay empty - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay empty In each of these cases, test the detail page's listing of additional authors/contributors. Test records which have both multiple contributors and which have only one additional author. When OPACPopupAuthorsSearch is turned on, verify that the author selection modal appears and that your selections are correctly combined to build a search string. Note that OPACPopupAuthorsSearch feature has a problem with terms containing parentheses. The issue predates this patch. Also note that the QA tools will give a false positive about Bootstrap button styles. This rule only applies to the staff client. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #1 from Owen Leonard --- It occurs to me that as long as we don't remove opac-detail's access to the MARCAUTHORS and MARCSUBJCTS information we could still have the corresponding modals be built in opac-detail.tt. That way we would only need to make sure the XSLT markup had the right classes to act as a hook for triggering the modals. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Keywords||RM_priority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Blocks||12561 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/