[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #44 from David Cook  ---
Just sharing that I have a patch in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 that turns off
the alert bit when using checked_in_ok, if that's of interest to people.

We're having issues with SIP2 sorters because the alert is causing incorrect
sorting for books that haven't been checked out, even when using checked_in_ok
(which removes the screen message and marks it as OK).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #42 from Liz Rea  ---
Pushed to 3.18.13, and released.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #41 from Frédéric Demians  ---
This patch has been pushed to 3.20.x, will be in 3.20.6.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #43590|0   |1
is obsolete||

--- Comment #38 from Brendan Gallagher  ---
Created attachment 45027
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45027=edit
[SIGNED-OFF] Bug 13411 - Koha's SIP server returns not ok for checking in items
that are not checked out

If an item is not checked out when a checkin via SIP2 is attempted,
Koha's SIP server sends back an "ok" of 0, and the AF message "Item
not checked out". I am not entirely sure this is good and correct
behavior by the SIP2 protocol.

In particular, this will cause SIP2 book sorting devices to fail on
all items that are not checked out, causing them all to be put into
the "special handling" been that should be reserved for things like
items checked in at the wrong library and items on hold.

Test Plan:
1) Apply the patch for bug 13159 so you can use the new enhanced
   SIP2 command line emulator
2) Use a command similar to the following to check in an item:
   sip_cli_emulator.pl -a localhost -su  -sp  -l
 --item  -m checkin
3) Note the 3rd character is 0, and there is an AF field saying the item is not
checked out
4) Apply this patch
5) Restart the SIP server
6) Repeat steps 2-3, note that nothing has changed
7) In the SIP config file, Add the parameter checked_in_ok="1" to the SIP
account you are using.
8) Restart the SIP server
9) Repeat steps 2-3, note that this time the 3rd character is 1, and you do not
recieve the item not checked out message.

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Brendan Gallagher  changed:

   What|Removed |Added

  Attachment #43591|0   |1
is obsolete||

--- Comment #39 from Brendan Gallagher  ---
Created attachment 45028
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45028=edit
[SIGNED-OFF] Bug 13411 [QA Followup] - Add logging

Signed-off-by: Brendan A Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #40 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||15221


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221
[Bug 15221] SIP server always sets the alert flag
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

--- Comment #36 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #34)
> 9) Repeat steps 2-3, note that this time the 3rd character is 1, and you do
> not recieve the item not checked out message.

Why don't we want to display the message?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

--- Comment #37 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #36)
> (In reply to Kyle M Hall from comment #34)
> > 9) Repeat steps 2-3, note that this time the 3rd character is 1, and you do
> > not recieve the item not checked out message.
> 
> Why don't we want to display the message?

Because some SIP2 sorters will behave badly if we send the message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

--- Comment #33 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #32)
> > In the test plan step 9 it talks of 4th character but should be 3rd as in
> > step 3
> 
> Sorry about that! I will revise the test plan.

Setting the status accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Kyle M Hall  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

--- Comment #35 from Kyle M Hall  ---
Created attachment 43591
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43591=edit
Bug 13411 [QA Followup] - Add logging

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #42081|0   |1
is obsolete||
  Attachment #42082|0   |1
is obsolete||

--- Comment #34 from Kyle M Hall  ---
Created attachment 43590
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43590=edit
Bug 13411 - Koha's SIP server returns not ok for checking in items that are not
checked out

If an item is not checked out when a checkin via SIP2 is attempted,
Koha's SIP server sends back an "ok" of 0, and the AF message "Item
not checked out". I am not entirely sure this is good and correct
behavior by the SIP2 protocol.

In particular, this will cause SIP2 book sorting devices to fail on
all items that are not checked out, causing them all to be put into
the "special handling" been that should be reserved for things like
items checked in at the wrong library and items on hold.

Test Plan:
1) Apply the patch for bug 13159 so you can use the new enhanced
   SIP2 command line emulator
2) Use a command similar to the following to check in an item:
   sip_cli_emulator.pl -a localhost -su  -sp  -l
 --item  -m checkin
3) Note the 3rd character is 0, and there is an AF field saying the item is not
checked out
4) Apply this patch
5) Restart the SIP server
6) Repeat steps 2-3, note that nothing has changed
7) In the SIP config file, Add the parameter checked_in_ok="1" to the SIP
account you are using.
8) Restart the SIP server
9) Repeat steps 2-3, note that this time the 3rd character is 1, and you do not
recieve the item not checked out message.

Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

--- Comment #32 from Kyle M Hall  ---
(In reply to Colin Campbell from comment #31)
> Restested and working (??) 
> 
> Message suppressed and ok set to 1

Excellent!

> In the test plan step 9 it talks of 4th character but should be 3rd as in
> step 3

Sorry about that! I will revise the test plan.

> Although discharge is now ok and no message sent the alert flag is being
> returned as  'Y' which would indicate a condition requiring special action.
> should this not be set to N in this case?

This appears to be out of the scope of this bug.

Here is a checkin with the item checked out to a patron
SEND: 09N2015101507240220151015   
072402APCPL|AOCPL|AB0140620125|ACstaff|BIN|
READ: 101YNY20151015072402AOCPL|AB0140620125|AQMY|AJWuthering heights
/|AA2352935676|CSPZ3.B7902 W36|CV04|

Here is a checkin of the same item without it being checked out:
SEND: 09N201510150720151015   
07APCPL|AOCPL|AB0140620125|ACstaff|BIN|
READ: 101YNY2015101507AOCPL|AB0140620125|AQMY|AJWuthering heights
/|CSPZ3.B7902 W36|CV04|

Here is the same checkin with a checkout on master:
SEND: 09N2015101507271820151015   
072718APCPL|AOCPL|AB0140620125|ACstaff|BIN|
READ: 101YNY20151015072719AOCPL|AB0140620125|AQMY|AJWuthering heights
/|AA2352935676|CSPZ3.B7902 W36|CV04|

And on master without a checkout:
SEND: 09N2015101507280320151015   
072803APCPL|AOCPL|AB0140620125|ACstaff|BIN|
READ: 100YNY20151015072803AOCPL|AB0140620125|AQMY|AJWuthering heights
/|CSPZ3.B7902 W36|CV04|AFItem not checked out|

So it appears that Koha always sets the alert flag no matter what. I think we
should file a new bug report for this!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

--- Comment #31 from Colin Campbell  ---
Restested and working (??) 

Message suppressed and ok set to 1

In the test plan step 9 it talks of 4th character but should be 3rd as in step
3

Although discharge is now ok and no message sent the alert flag is being
returned as  'Y' which would indicate a condition requiring special action.
should this not be set to N in this case?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #30 from Kyle M Hall  ---
(In reply to Colin Campbell from comment #29)
> having applied the patch against current master server terminates when
> processing an issue transaction

I have been unable to reproduce this on master. It seems unlikely to be related
to this patch since this patch only modifies the checkins, and not checkouts.
Can you please retest?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Colin Campbell  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #29 from Colin Campbell  ---
having applied the patch against current master server terminates when
processing an issue transaction

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Janet McGowan  changed:

   What|Removed |Added

 CC||janet.mcgowan@ptfs-europe.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Colin Campbell colin.campb...@ptfs-europe.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #25 from Colin Campbell colin.campb...@ptfs-europe.com ---
Patch not working as advertised - in the rebasings it looks like we've lost the
check of the config value to pass to checkin so the checked_in_ok variable is
never passed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com

--- Comment #28 from Kyle M Hall kyle.m.h...@gmail.com ---
(In reply to Colin Campbell from comment #25)
 Patch not working as advertised - in the rebasings it looks like we've lost
 the check of the config value to pass to checkin so the checked_in_ok
 variable is never passed

Thanks for catching that! I've re-rebased the patch to correct that omission!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

--- Comment #27 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 42082
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42082action=edit
Bug 13411 [QA Followup] - Add logging

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #42035|0   |1
is obsolete||
  Attachment #42036|0   |1
is obsolete||

--- Comment #26 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 42081
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42081action=edit
Bug 13411 - Koha's SIP server returns not ok for checking in items that are not
checked out

If an item is not checked out when a checkin via SIP2 is attempted,
Koha's SIP server sends back an ok of 0, and the AF message Item
not checked out. I am not entirely sure this is good and correct
behavior by the SIP2 protocol.

In particular, this will cause SIP2 book sorting devices to fail on
all items that are not checked out, causing them all to be put into
the special handling been that should be reserved for things like
items checked in at the wrong library and items on hold.

Test Plan:
1) Apply the patch for bug 13159 so you can use the new enhanced
   SIP2 command line emulator
2) Use a command similar to the following to check in an item:
   sip_cli_emulator.pl -a localhost -su sip user -sp sip password -l
instituation id --item barcode -m checkin
3) Note the 3rd character is 0, and there is an AF field saying the item is not
checked out
4) Apply this patch
5) Restart the SIP server
6) Repeat steps 2-3, note that nothing has changed
7) In the SIP config file, Add the parameter checked_in_ok=1 to the SIP
account you are using.
8) Restart the SIP server
9) Repeat steps 2-3, note that this time the 4rd character is 1, and you do not
recieve the item not checked out message.

Signed-off-by: Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #40952|0   |1
is obsolete||
  Attachment #40953|0   |1
is obsolete||

--- Comment #23 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 42035
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42035action=edit
Bug 13411 - Koha's SIP server returns not ok for checking in items that are not
checked out

If an item is not checked out when a checkin via SIP2 is attempted,
Koha's SIP server sends back an ok of 0, and the AF message Item
not checked out. I am not entirely sure this is good and correct
behavior by the SIP2 protocol.

In particular, this will cause SIP2 book sorting devices to fail on
all items that are not checked out, causing them all to be put into
the special handling been that should be reserved for things like
items checked in at the wrong library and items on hold.

Test Plan:
1) Apply the patch for bug 13159 so you can use the new enhanced
   SIP2 command line emulator
2) Use a command similar to the following to check in an item:
   sip_cli_emulator.pl -a localhost -su sip user -sp sip password -l
instituation id --item barcode -m checkin
3) Note the 3rd character is 0, and there is an AF field saying the item is not
checked out
4) Apply this patch
5) Restart the SIP server
6) Repeat steps 2-3, note that nothing has changed
7) In the SIP config file, Add the parameter checked_in_ok=1 to the SIP
account you are using.
8) Restart the SIP server
9) Repeat steps 2-3, note that this time the 4rd character is 1, and you do not
recieve the item not checked out message.

Signed-off-by: Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

--- Comment #24 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 42036
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42036action=edit
Bug 13411 [QA Followup] - Add logging

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no changed:

   What|Removed |Added

  Attachment #36310|1   |0
is obsolete||

--- Comment #20 from Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no ---
Comment on attachment 36310
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36310
Bug 13411 [QA Followup] - Add logging

moved namespace fix to other patch of this bug. It has nothing to do with
logging

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no changed:

   What|Removed |Added

  Attachment #36428|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no changed:

   What|Removed |Added

  Attachment #36310|0   |1
is obsolete||

--- Comment #22 from Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no ---
Created attachment 40953
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40953action=edit
Bug 13411 [QA Followup] - Add logging

Revert ordering of patches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no changed:

   What|Removed |Added

  Attachment #36271|0   |1
is obsolete||

--- Comment #21 from Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no ---
Created attachment 40952
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40952action=edit
Bug 13411 - Koha's SIP server returns not ok for checking in items that are not
checked out

corrected line

$circ-patron( $patron = new ILS::Patron $item-{patron} );

to

$circ-patron($patron = C4::SIP::ILS::Patron-new( $item-{patron}));

in patch, as it breaks checkin and conforms to namespace used in file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

--- Comment #19 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Colin, could you take a look at the last 2 comments and update the status here?
Thx!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

--- Comment #18 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to Benjamin Rokseth from comment #17)
 Actually,as Kyle mentioned above I'm also not entirely sure the current
 implementation is correct as to the SIP2 standard. Checkin is not limited to
 checked out items, it is, the way I see it,the only way for an ACS to
 validate the circulation status of an item. (hold,wrong branch,in transfer,
 etc.) Compare this to a package delivery service where every point involves
 a checkin.
 
 Any critical error in the process should fail the checkin response and give
 a suitable feedback.
 
 The checked_in_ok param from SIPConfig.xml is used as param in the checkin
 routine and fallbacks to old behaviour (item not checked out) if unset.
 Kyle,please correct me if wrong.
 
 This bug is actually a showstopper for us (50+ self-check machines and book
 sorting device) so I hope it can be resolved shortly

You're spot on!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

--- Comment #17 from Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no ---
Actually,as Kyle mentioned above I'm also not entirely sure the current
implementation is correct as to the SIP2 standard. Checkin is not limited to
checked out items, it is, the way I see it,the only way for an ACS to validate
the circulation status of an item. (hold,wrong branch,in transfer, etc.)
Compare this to a package delivery service where every point involves a
checkin.

Any critical error in the process should fail the checkin response and give a
suitable feedback.

The checked_in_ok param from SIPConfig.xml is used as param in the checkin
routine and fallbacks to old behaviour (item not checked out) if unset.
Kyle,please correct me if wrong.

This bug is actually a showstopper for us (50+ self-check machines and book
sorting device) so I hope it can be resolved shortly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Colin Campbell colin.campb...@ptfs-europe.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #16 from Colin Campbell colin.campb...@ptfs-europe.com ---
There are a few problems with these patches. First the existing behaviour is
consistent with the standard ( 0 because a checkin has not succeeded) however I
can see that there is probably no practical distinction between checkin of an
unissued book and an issued one especially if some machines are routing returns
incorrectly as a result. But we should document it as a change in behaviour so
it gets reported as that in release notes (in case there are unforeseen
consequences)

The commit message also gives a test which does not succeed it says the message
is not returned after the patch is applied, but it is (incidently I think it
should still be returned as information, so the code is ok the test fails)

Finally the patch adds a new parameter into the config files but there is a) no
mention of it and b) it doesnt seem to be of any use in the implementation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

--- Comment #15 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Colin, could you take a look at this again please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no changed:

   What|Removed |Added

  Attachment #36310|0   |1
is obsolete||

--- Comment #14 from Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no ---
Created attachment 36428
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36428action=edit
Bug 13411 [QA Followup] - Add logging

Added a fix for bug in C4/SIP/ILS.pm line 202 as described above.

Tested OK. Setting to Signed Off as it works as previously noted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #13 from Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no ---
there is a small bug in the rebase on line 202:
Can't locate object method Patron via package ILS at C4/SIP/ILS.pm line
202.

$circ-patron( $patron = new ILS::Patron $item-{patron} );

should be:

$circ-patron($patron = C4::SIP::ILS::Patron-new( $item-{patron} ));

otherwise it breaks connection on checkin of checked out item

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

--- Comment #12 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 36310
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36310action=edit
Bug 13411 [QA Followup] - Add logging

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #35669|0   |1
is obsolete||

--- Comment #11 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 36271
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36271action=edit
Bug 13411 - Koha's SIP server returns not ok for checking in items that are not
checked out

If an item is not checked out when a checkin via SIP2 is attempted,
Koha's SIP server sends back an ok of 0, and the AF message Item
not checked out. I am not entirely sure this is good and correct
behavior by the SIP2 protocol.

In particular, this will cause SIP2 book sorting devices to fail on
all items that are not checked out, causing them all to be put into
the special handling been that should be reserved for things like
items checked in at the wrong library and items on hold.

Test Plan:
1) Apply the patch for bug 13159 so you can use the new enhanced
   SIP2 command line emulator
2) Use a command similar to the following to check in an item:
   sip_cli_emulator.pl -a localhost -su sip user -sp sip password -l
instituation id --item barcode -m checkin
3) Note the 3rd character is 0, and there is an AF field saying the item is not
checked out
4) Apply this patch
5) Restart the SIP server
6) Repeat steps 2-3, note that nothing has changed
7) In the SIP config file, Add the parameter checked_in_ok=1 to the SIP
account you are using.
8) Restart the SIP server
9) Repeat steps 2-3, note that this time the 4rd character is 1, and you do not
recieve the item not checked out message.

Signed-off-by: Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Signed Off  |Patch doesn't apply

--- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
There is a conflict in ILS.pm - please rebase!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com ---
The code looks good but I am not confident enough with this part of code to
mark it as passed QA.
Another pair of eyes needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no changed:

   What|Removed |Added

   Severity|normal  |major

--- Comment #8 from Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no ---
As a sidenote, I can confirm that if the returned character 3in the SIP
Checkout Response is 0 for an item that is not checked out, it breaks
automation and circulation logic altogether, as any item returned should
trigger a transfer if applicable.

Therefore I'd like to up the severity of this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no changed:

   What|Removed |Added

  Attachment #35667|0   |1
is obsolete||

--- Comment #7 from Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no ---
Created attachment 35669
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35669action=edit
Bug 13411 - Koha's SIP server returns not ok for checking in items that are not
checked out

If an item is not checked out when a checkin via SIP2 is attempted,
Koha's SIP server sends back an ok of 0, and the AF message Item
not checked out. I am not entirely sure this is good and correct
behavior by the SIP2 protocol.

In particular, this will cause SIP2 book sorting devices to fail on
all items that are not checked out, causing them all to be put into
the special handling been that should be reserved for things like
items checked in at the wrong library and items on hold.

Test Plan:
1) Apply the patch for bug 13159 so you can use the new enhanced
   SIP2 command line emulator
2) Use a command similar to the following to check in an item:
   sip_cli_emulator.pl -a localhost -su sip user -sp sip password -l
instituation id --item barcode -m checkin
3) Note the 3rd character is 0, and there is an AF field saying the item is not
checked out
4) Apply this patch
5) Restart the SIP server
6) Repeat steps 2-3, note that nothing has changed
7) In the SIP config file, Add the parameter checked_in_ok=1 to the SIP
account you are using.
8) Restart the SIP server
9) Repeat steps 2-3, note that this time the 4rd character is 1, and you do not
recieve the item not checked out message.

Signed-off-by: Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no changed:

   What|Removed |Added

 CC||benjamin.roks...@kul.oslo.k
   ||ommune.no

--- Comment #5 from Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no ---
Not able to confirm expected behaviour.

checkin of item checked out works ok:

Trying 'checkin'
SEND: 09Y201515115144201515115144APCPL|AOCPL|AB123456|ACautopass|BIN|
READ: 101YNN20150205115144AOCPL|AB123456|AQCPL|AJEn tittel|AA2|

but checkin of not checked out item returns error:

Trying 'checkin'
SEND: 09Y201515115147201515115147APCPL|AOCPL|AB123456|ACautopass|BIN|
Use of uninitialized value $data in concatenation (.) or string at
./sip_cli_emulator.pl line 270, GEN0 chunk 1.
READ: 

command used:
perl -I. ./sip_cli_emulator.pl -l CPL -su autouser -sp autopass --port=6001
--address=localhost --item 123456 -m checkin --patron 2

output from SIPServer log:

Use of uninitialized value $id in string ne at C4/SIP/ILS.pm line 84.
Use of uninitialized value $_[1] in sprintf at /usr/lib/perl/5.14/Sys/Syslog.pm
line 368.
Use of uninitialized value in negation (-) at /usr/lib/perl5/DateTime.pm line
1764.
DBD::mysql::st execute failed: called with 1 bind variables when 0 are needed
at C4/Members.pm line 596.
Can't use an undefined value as an ARRAY reference at /usr/lib/perl5/DBI.pm
line 2054.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #35665|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 35667
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35667action=edit
Bug 13411 - Koha's SIP server returns not ok for checking in items that are not
checked out

If an item is not checked out when a checkin via SIP2 is attempted,
Koha's SIP server sends back an ok of 0, and the AF message Item
not checked out. I am not entirely sure this is good and correct
behavior by the SIP2 protocol.

In particular, this will cause SIP2 book sorting devices to fail on
all items that are not checked out, causing them all to be put into
the special handling been that should be reserved for things like
items checked in at the wrong library and items on hold.

Test Plan:
1) Apply the patch for bug 13159 so you can use the new enhanced
   SIP2 command line emulator
2) Use a command similar to the following to check in an item:
   sip_cli_emulator.pl -a localhost -su sip user -sp sip password -l
instituation id --item barcode -m checkin
3) Note the 3rd character is 0, and there is an AF field saying the item is not
checked out
4) Apply this patch
5) Restart the SIP server
6) Repeat steps 2-3, note that nothing has changed
7) In the SIP config file, Add the parameter checked_in_ok=1 to the SIP
account you are using.
8) Restart the SIP server
9) Repeat steps 2-3, note that this time the 4rd character is 1, and you do not
recieve the item not checked out message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #34187|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 35665
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35665action=edit
Bug 13411 - Koha's SIP server returns not ok for checking in items that are not
checked out

If an item is not checked out when a checkin via SIP2 is attempted,
Koha's SIP server sends back an ok of 0, and the AF message Item
not checked out. I am not entirely sure this is good and correct
behavior by the SIP2 protocol.

In particular, this will cause SIP2 book sorting devices to fail on
all items that are not checked out, causing them all to be put into
the special handling been that should be reserved for things like
items checked in at the wrong library and items on hold.

Test Plan:
1) Apply the patch for bug 13159 so you can use the new enhanced
   SIP2 command line emulator
2) Use a command similar to the following to check in an item:
   sip_cli_emulator.pl -a localhost -su sip user -sp sip password -l
instituation id --item barcode -m checkin
3) Note the 3rd character is 0, and there is an AF field saying the item is not
checked out
4) Apply this patch
5) Restart the SIP server
6) Repeat steps 2-3, note that nothing has changed
7) In the SIP config file, Add the parameter checked_in_ok=1 to the SIP
account you are using.
8) Restart the SIP server
9) Repeat steps 2-3, note that this time the 4rd character is 1, and you do not
recieve the item not checked out message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

--- Comment #3 from Colin Campbell colin.campb...@ptfs-europe.com ---
I think this works ok for the self check but it would be good if it logged
something in this case as we might need to track odd behaviour (e.g. bug 11039
)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13159

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 34187
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34187action=edit
Bug 13411 - Koha's SIP server returns not ok for checking in items that are not
checked out

If an item is not checked out when a checkin via SIP2 is attempted,
Koha's SIP server sends back an ok of 0, and the AF message Item
not checked out. I am not entirely sure this is good and correct
behavior by the SIP2 protocol.

In particular, this will cause SIP2 book sorting devices to fail on
all items that are not checked out, causing them all to be put into
the special handling been that should be reserved for things like
items checked in at the wrong library and items on hold.

Test Plan:
1) Apply the patch for bug 13159 so you can use the new enhanced
   SIP2 command line emulator
2) Use a command similar to the following to check in an item:
   sip_cli_emulator.pl -a localhost -su sip user -sp sip password -l
instituation id --item barcode -m checkin
3) Note the 3rd character is 0, and there is an AF field saying the item is not
checked out
4) Apply this patch
5) Restart the SIP server
6) Repeat steps 2-3, note that nothing has changed
7) In the SIP config file, Add the parameter checked_in_ok=1 to the SIP
account you are using.
8) Restart the SIP server
9) Repeat steps 2-3, note that this time the 4rd character is 1, and you do not
recieve the item not checked out message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Note, I believe this is really most likely a bug, but am reticent to change
this SIP server's default behavior. Thus, I have made this a configurable
option instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/