[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Jonathan Druart changed: What|Removed |Added Summary|Untranslatable strings in |Unused code in |serials-edit.tt and |serials-edit.tt and |serials-recieve.tt |serials-recieve.tt CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Jonathan Druart changed: What|Removed |Added Attachment #37435|0 |1 is obsolete|| Attachment #38508|0 |1 is obsolete|| --- Comment #13 from Jonathan Druart --- Created attachment 38647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38647&action=edit Bug 13423: Remove unused JS function in serials-edit.tt This patch removes unused code: * barcode_check() function, with untranslatable strings * commented call to this function To test: 1. Apply the patch 2. Check serials receive, no changes shall be detected NOTE: I did not run this test plan. Verification steps -- 1. Find out where barcode_check is used. $ git grep barcode_check -- This is only in serials-edit.tt and serials-receive.tt 2. This patch only affects serials-edit.tt, so check who put the $ git blame -L130 koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt -- note the commit related number. 3. Check out the commit. $ git show 77b64098 -- should show bug 5917, but the patches on bugzilla don't have the change nicely, so... 4. Hunt through the pages to find the change. -- Note: it is part of a "new file" diff! 5. Since this code hasn't been running since it was added... 6. apply the patch 7. run koha-qa test tools Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 --- Comment #16 from Jonathan Druart --- I took the liberty to edit the commit message of the first patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423
--- Comment #14 from Jonathan Druart ---
Created attachment 38648
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38648&action=edit
Bug 13423: Remove unused serials-recieve
This patch removes two files, serials-recieve.pl and serial-recieve.tt
serials-recieve.pl is not called anyware
(it's recieve!)
Also removes the sub removeMissingIssue called only from serials-recieve.pl
git grep serials-recieve.pl .
C4/Serials.pm:called when a missing issue is found from the serials-recieve.pl
file
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt:
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt:
serials/serials-recieve.pl:serials-recieve.pl
Just a POD entry and self reference.
After removing of files
git grep removeMissingIssue .
C4/Serials.pm: &check_routing &updateClaim &removeMissingIssue
C4/Serials.pm:=head2 removeMissingIssue
C4/Serials.pm:removeMissingIssue($subscriptionid)
C4/Serials.pm:sub removeMissingIssue {
t/db_dependent/Serials.t:is(C4::Serials::removeMissingIssue(), undef, 'test
removing a missing issue');
Not used anymore
To test:
1) Apply the patch
2) Check serials workflow, no changes must be noted
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 --- Comment #15 from Jonathan Druart --- Created attachment 38649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38649&action=edit Bug 13423: Fix number of tests in Serials.t Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 --- Comment #19 from Katrin Fischer --- Created attachment 38705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38705&action=edit [PASSED QA] Bug 13423: Fix number of tests in Serials.t Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 --- Comment #17 from Katrin Fischer --- Created attachment 38703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38703&action=edit [PASSED QA] Bug 13423: Remove unused JS function in serials-edit.tt This patch removes unused code: * barcode_check() function, with untranslatable strings * commented call to this function To test: 1. Apply the patch 2. Check serials receive, no changes shall be detected NOTE: I did not run this test plan. Verification steps -- 1. Find out where barcode_check is used. $ git grep barcode_check -- This is only in serials-edit.tt and serials-receive.tt 2. This patch only affects serials-edit.tt, so check who put the $ git blame -L130 koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt -- note the commit related number. 3. Check out the commit. $ git show 77b64098 -- should show bug 5917, but the patches on bugzilla don't have the change nicely, so... 4. Hunt through the pages to find the change. -- Note: it is part of a "new file" diff! 5. Since this code hasn't been running since it was added... 6. apply the patch 7. run koha-qa test tools Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Katrin Fischer changed: What|Removed |Added Attachment #38647|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423
--- Comment #18 from Katrin Fischer ---
Created attachment 38704
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38704&action=edit
[PASSED QA] Bug 13423: Remove unused serials-recieve
This patch removes two files, serials-recieve.pl and serial-recieve.tt
serials-recieve.pl is not called anyware
(it's recieve!)
Also removes the sub removeMissingIssue called only from serials-recieve.pl
git grep serials-recieve.pl .
C4/Serials.pm:called when a missing issue is found from the serials-recieve.pl
file
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt:
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt:
serials/serials-recieve.pl:serials-recieve.pl
Just a POD entry and self reference.
After removing of files
git grep removeMissingIssue .
C4/Serials.pm: &check_routing &updateClaim &removeMissingIssue
C4/Serials.pm:=head2 removeMissingIssue
C4/Serials.pm:removeMissingIssue($subscriptionid)
C4/Serials.pm:sub removeMissingIssue {
t/db_dependent/Serials.t:is(C4::Serials::removeMissingIssue(), undef, 'test
removing a missing issue');
Not used anymore
To test:
1) Apply the patch
2) Check serials workflow, no changes must be noted
Signed-off-by: Jonathan Druart
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Katrin Fischer changed: What|Removed |Added Attachment #38648|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Katrin Fischer changed: What|Removed |Added Attachment #38649|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #20 from Tomás Cohen Arazi --- Parches aplicados en master. Gracias Bernardo! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #21 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com Keywords||rel_3_16_candidate --- Comment #22 from Mason James --- Possible selection for 3.16.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Jonathan Druart changed: What|Removed |Added Blocks||18274 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18274 [Bug 18274] C4::Items - Remove GetItemStatus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
