[Koha-bugs] [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com

--- Comment #10 from Joy Nelson  ---
does not apply to 19.11.x branch.  please rebase if needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||20.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518

--- Comment #9 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518

--- Comment #8 from Katrin Fischer  ---
Thx Jonathan! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103176|0   |1
is obsolete||

--- Comment #7 from Katrin Fischer  ---
Created attachment 103187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103187=edit
Bug 13518: Delete patron's modifications along with the patron

The table borrower_modifications has no FK constraint on the borrowernumber
and will remain untouched when the patron is deleted.
If the borrowernumber doesn't exist in the database, the modification entry is
no longer visible in Koha.

The problem is that this table is used for the borrower modifications and the
self-registration features.

So far borrowernumber is the PK (int(11) NOT NULL DEFAULT '0'), for the
self-registration feature we can have borrowernumber that is not defined (0 is
used)

Ideally we would like to have borrowernumber a DEFAULT NULL, and use NULL for
self-reg, but then we will loose the PK (PK cannot be NULL).

As we cannot keep the correct constraints at DB level anyway, we will need to
handle consistency at code-level.

Test plan:
Create a new patron
Do some modification at the OPAC
Delete the patron
Confirm that the modifications as been removed (directly in DB)

Signed-off-by: Bernardo Gonzalez Kriegel 
Modifications removed, test pass

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Attachment #103130|0   |1
is obsolete||

--- Comment #6 from Bernardo Gonzalez Kriegel  ---
Created attachment 103176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103176=edit
Bug 13518: Delete patron's modifications along with the patron

The table borrower_modifications has no FK constraint on the borrowernumber
and will remain untouched when the patron is deleted.
If the borrowernumber doesn't exist in the database, the modification entry is
no longer visible in Koha.

The problem is that this table is used for the borrower modifications and the
self-registration features.

So far borrowernumber is the PK (int(11) NOT NULL DEFAULT '0'), for the
self-registration feature we can have borrowernumber that is not defined (0 is
used)

Ideally we would like to have borrowernumber a DEFAULT NULL, and use NULL for
self-reg, but then we will loose the PK (PK cannot be NULL).

As we cannot keep the correct constraints at DB level anyway, we will need to
handle consistency at code-level.

Test plan:
Create a new patron
Do some modification at the OPAC
Delete the patron
Confirm that the modifications as been removed (directly in DB)

Signed-off-by: Bernardo Gonzalez Kriegel 
Modifications removed, test pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518

--- Comment #5 from Jonathan Druart  
---
Created attachment 103130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103130=edit
Bug 13518: Delete patron's modifications along with the patron

The table borrower_modifications has no FK constraint on the borrowernumber
and will remain untouched when the patron is deleted.
If the borrowernumber doesn't exist in the database, the modification entry is
no longer visible in Koha.

The problem is that this table is used for the borrower modifications and the
self-registration features.

So far borrowernumber is the PK (int(11) NOT NULL DEFAULT '0'), for the
self-registration feature we can have borrowernumber that is not defined (0 is
used)

Ideally we would like to have borrowernumber a DEFAULT NULL, and use NULL for
self-reg, but then we will loose the PK (PK cannot be NULL).

As we cannot keep the correct constraints at DB level anyway, we will need to
handle consistency at code-level.

Test plan:
Create a new patron
Do some modification at the OPAC
Delete the patron
Confirm that the modifications as been removed (directly in DB)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518

--- Comment #4 from Jonathan Druart  
---
It should be in Koha::Patron->delete, yes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518

--- Comment #3 from Katrin Fischer  ---
I see what you by it being used for 2 features.

So we have:

`verification_token` varchar(255) NOT NULL DEFAULT '',
`borrowernumber` int(11) NOT NULL DEFAULT '0',
PRIMARY KEY (`verification_token` (191),`borrowernumber`),

Because we either have it's either or:

modification: 
borrowernumber != 0 or, no verfication token

self registration 
borrower = 0, verififcation token exists

The design, if I understand it correctly, also means that one patron can only
have one modification request at a time.

And a PK column can not be NULL... as the resulting keys wouldn't be unique any
more.

The main idea about the FK was to make sure we don't keep storing address and
other personal data in there when the patron was long deleted.

Would it be simpler to solve that in the method deleting the patron? (where we
move the data to deleted_borrowers?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518

--- Comment #2 from Jonathan Druart  
---
The problem is that this table is used for the borrower modifications and the
self-registration features.

So far borrowernumber is the PK (int(11) NOT NULL DEFAULT '0'), for the
self-registration feature we can have borrowernumber that is not defined (0 is
used)

Ideally we would like to have borrowernumber a DEFAULT NULL, and use NULL for
self-reg, but then we will loose the PK (PK cannot be NULL).

I do not think we will be able to keep the correct constraints at DB level
anyway, we will need to handle consistency at code-level.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518

Katrin Fischer  changed:

   What|Removed |Added

   Severity|normal  |major

--- Comment #1 from Katrin Fischer  ---
Upping severity a bit - storing patron information that is/can never be deleted
outside of SQL is not nice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518

Nicole C. Engard  changed:

   What|Removed |Added

 CC||a...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Blocks||5334


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334
[Bug 5334] add explicit foreign key constraints
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518

Nicole Engard (ByWater) nic...@bywatersolutions.com changed:

   What|Removed |Added

 CC||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/