[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|String patch|Small patch
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

--- Comment #10 from Marcel de Rooy  ---
Created attachment 67960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67960=edit
Bug 13572: (Follow-up) Add perl extension to script

There is no reason to keep this perl script without the regular extension.
Please see other scripts in the same folder too.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

--- Comment #11 from Marcel de Rooy  ---
Created attachment 67961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67961=edit
Bug 13572: (Follow-up) Print since on a separate line

Very trivial change.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #58206|0   |1
is obsolete||

--- Comment #9 from Marcel de Rooy  ---
Created attachment 67959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67959=edit
Bug 13572 - Add --actives parameter to force_borrower_messaging_defaults script

1) Apply the patch
2) Create a new patron with random values, except for it expiration date, make
it expired (Patrons > New Patron > Student)
3) Enable the system preference called “EnhancedMessagingPreferences”
4) In “Administration" > "Patron categories" > Student, modify the "days in
advance", then click "Save"
5) run the script "./misc/maintenance/borrowers-force-messaging-defaults --doit
--actives"
6) Validate that the student created in step 2 hasn't changed (Patrons >
search)
7) Validate that any other student that isn't expired has changed.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Charles Farmer  changed:

   What|Removed |Added

  Attachment #46179|0   |1
is obsolete||
  Attachment #46180|0   |1
is obsolete||

--- Comment #8 from Charles Farmer  ---
Created attachment 58206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58206=edit
Bug 13572 - Add --actives parameter to force_borrower_messaging_defaults script

1) Apply the patch
2) Create a new patron with random values, except for it expiration date, make
it expired (Patrons > New Patron > Student)
3) Enable the system preference called “EnhancedMessagingPreferences”
4) In “Administration" > "Patron categories" > Student, modify the "days in
advance", then click "Save"
5) run the script "./misc/maintenance/borrowers-force-messaging-defaults --doit
--actives"
6) Validate that the student created in step 2 hasn't changed (Patrons >
search)
7) Validate that any other student that isn't expired has changed.

---

This patch is a squashed version of the two previous ones, rebased on the
current master, plus the changes asked in comment #7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Charles Farmer  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #7 from Jonathan Druart  
---
It would make more sense to have a --active[s] instead of --onlyactives, it
will allow to add another flag later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Chris Cormack  changed:

   What|Removed |Added

  Attachment #41235|0   |1
is obsolete||

--- Comment #6 from Chris Cormack  ---
Created attachment 46180
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46180=edit
Bug13572 - Changed "borrowers-force-messaging-defaults" --help parameter's
result to better explain the new functionality

New test plan (well, a clearer version):

1) Apply both patches
2) Create a new patron with random values, except for it expiration date, make
it expired (Patrons > New Patron > Student)
3) Enable the system preference called “EnhancedMessagingPreferences”
4) In “Administration" > "Patron categories" > Student, modify the "days in
advance", then click "Save"
5) run the script "./misc/maintenance/borrowers-force-messaging-defaults --doit
--onlyactives"
6) Validate that the student created in step 2 hasn't changed (Patrons >
search)
7) Validate that any other student that isn't expired has changed.

Signed-off-by: Chris 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Chris Cormack  changed:

   What|Removed |Added

  Attachment #35164|0   |1
is obsolete||

--- Comment #5 from Chris Cormack  ---
Created attachment 46179
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46179=edit
Bug 13572 - Add onlyactives parameter to force_borrower_messaging_defaults
script

1) Apply both patches
2) Create a new patron with random values, except for it expiration date, make
it expired (Patrons > New Patron > Student)
3) Enable the system preference called “EnhancedMessagingPreferences”
4) In “Administration" > "Patron categories" > Student, modify the "days in
advance", then click "Save"
5) run the script "./misc/maintenance/borrowers-force-messaging-defaults --doit
--onlyactives"
6) Validate that the student created in step 2 hasn't changed (Patrons >
search)
7) Validate that any other student that isn't expired has changed.

Signed-off-by: Chris 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |remi.mayrand-provencher@inL
   |ity.org |ibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

--- Comment #4 from Rémi Mayrand-Provencher 
remi.mayrand-provenc...@inlibro.com ---
Created attachment 41235
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41235action=edit
Bug13572 - Changed borrowers-force-messaging-defaults --help parameter's
result to better explain the new functionality

New test plan (well, a clearer version):

1) Apply both patches
2) Create a new patron with random values, except for it expiration date, make
it expired (Patrons  New Patron  Student)
3) Enable the system preference called “EnhancedMessagingPreferences”
4) In “Administration  Patron categories  Student, modify the days in
advance, then click Save
5) run the script ./misc/maintenance/borrowers-force-messaging-defaults --doit
--onlyactives
6) Validate that the student created in step 2 hasn't changed (Patrons 
search)
7) Validate that any other student that isn't expired has changed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Rémi Mayrand-Provencher remi.mayrand-provenc...@inlibro.com changed:

   What|Removed |Added

 CC||remi.mayrand-provencher@inL
   ||ibro.com
 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Abby abbyrobertson.stud...@wegc.school.nz changed:

   What|Removed |Added

 CC||abbyrobertson.student@wegc.
   ||school.nz
 Status|Needs Signoff   |In Discussion

--- Comment #3 from Abby abbyrobertson.stud...@wegc.school.nz ---
I followed the test plan but I can't verify the patch fixes it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

--- Comment #2 from simith.dolive...@inlibro.com ---
Created attachment 35164
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35164action=edit
Bug 13572 - Add onlyactives parameter to force_borrower_messaging_defaults
script

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

simith.dolive...@inlibro.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||eric.be...@inlibro.com,
   ||marjorie.barry-v...@ccsr.qc
   ||.ca,
   ||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

simith.dolive...@inlibro.com changed:

   What|Removed |Added

   Patch complexity|--- |String patch
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

--- Comment #1 from simith.dolive...@inlibro.com ---
To test:

1) Apply the patch
2) Active the preference system “EnhancedMessagingPreferences”
3) In “Administration › Patron categories” modify the default messaging
preferences for a
 category. Ex. Student 
4) Run the script
5) Validate: expired Students don't have their patron messaging preferences
 changed
6) Validate: active Students do have their patron messaging preferences
 changed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/