[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Fridolin SOMERS changed: What|Removed |Added Blocks||14374 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14374 [Bug 14374] dont use mysql_auto_reconnect with DBIx::Connector -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com Keywords||rel_3_16_candidate --- Comment #32 from Mason James --- (In reply to Chris Cormack from comment #31) > Pushed to 3.18.x will be in 3.18.5 hmm, possible selection for 3.16.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #31 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.5 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #30 from Tomás Cohen Arazi --- Followup pushed to master. Thanks Robin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #29 from Robin Sheat --- I've uploaded a master build, and included my patch in it. It seemed to be happy. Have a go with that if you want an easy test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Robin Sheat changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Robin Sheat changed: What|Removed |Added Status|Pushed to Master|ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Robin Sheat changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #28 from Robin Sheat --- The patch I've attached will need to go in alongside this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Robin Sheat changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #27 from Robin Sheat --- Created attachment 36131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36131&action=edit Bug 13645: dependencies for libdbix-connector-perl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #26 from Robin Sheat --- (In reply to Robin Sheat from comment #25) > Needs a squeeze package for DBIx::Connector. I'll have a go at building the > wheezy one for it. So the packages built surprisingly easily on squeeze. And then a series of cockups on my part made it take forever to actually get into the repo :) It's there now though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Robin Sheat changed: What|Removed |Added CC||ro...@catalyst.net.nz --- Comment #25 from Robin Sheat --- Needs a squeeze package for DBIx::Connector. I'll have a go at building the wheezy one for it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #24 from Chris Cormack --- Holding for 3.18.5, I need to test this more. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #23 from Tomás Cohen Arazi --- Patches pushed to master. Thanks Jonathan and Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #21 from Kyle M Hall --- Created attachment 36093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36093&action=edit [PASSED QA] Bug 13645: Use DBIx::Connector Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #22 from Kyle M Hall --- Created attachment 36094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36094&action=edit [PASSED QA] Bug 13645 [QA Followup] - Add DBIx::Connector to the list of dependancies Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Kyle M Hall changed: What|Removed |Added Attachment #35959|0 |1 is obsolete|| Attachment #35960|0 |1 is obsolete|| --- Comment #20 from Kyle M Hall --- Created attachment 36092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36092&action=edit [PASSED QA] Bug 13645: Cache the DBIx connection We don't want to recreate a new connection to the DB every time we want a new schema. This patch creates a $database package level variable on the same way it's done in C4::Context for $dbh. Signed-off-by: Jacek Ablewicz Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Jonathan Druart changed: What|Removed |Added Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Tomás Cohen Arazi changed: What|Removed |Added Attachment #35774|0 |1 is obsolete|| --- Comment #19 from Tomás Cohen Arazi --- Created attachment 35960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35960&action=edit [SIGNED OFF] Bug 13645: Use DBIx::Connector Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Tomás Cohen Arazi changed: What|Removed |Added Attachment #35668|0 |1 is obsolete|| --- Comment #18 from Tomás Cohen Arazi --- Created attachment 35959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35959&action=edit [PASSED QA] Bug 13645: Cache the DBIx connection We don't want to recreate a new connection to the DB every time we want a new schema. This patch creates a $database package level variable on the same way it's done in C4::Context for $dbh. Signed-off-by: Jacek Ablewicz Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #17 from Tomás Cohen Arazi --- I think both patches should be used together: in a persistent environment (in the sense of plack-like one-time-load execution) we need a module to take care of reconnections and keep connections open as needed. Caching the database connection object to reuse it, seems ok. But how long? what if the connection drops for some reason? That's when DBIx::Connector proves handy. My only concern was about this approach being kosher or not, and that's why I tried to contact ribasushi on the IRC channel, because it smells like a trivial use case everyone faces when using DBIx::Class :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #16 from Jonathan Druart --- (In reply to Jacek Ablewicz from comment #15) > Not sure what to think about patch #2 (Bug 13645: Use DBIx::Connector) - is > it needed for patch #1 or patch #3 (from Bug 13690) to work properly? No, there are all independent. > I'm not seeing any measurable performance gains with patch #2 (on the > contrary, in most test performed so far it seems to be a little bit slower > to me - but in any case, the differences are insignificant, +3/-2 msec or > so); same results when tested alone, or in combination with #1 and #3. In my tests, it was better, see the png file on bug 13690. > BTW, DBIx::Connector is not on the dependencies list (don't know if it needs > to be added, on my test setup I had this module package already installed > because I was toying with it previously). Yes, should be added if the patch is validated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Tomás Cohen Arazi changed: What|Removed |Added CC||gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #15 from Jacek Ablewicz --- Not sure what to think about patch #2 (Bug 13645: Use DBIx::Connector) - is it needed for patch #1 or patch #3 (from Bug 13690) to work properly? I'm not seeing any measurable performance gains with patch #2 (on the contrary, in most test performed so far it seems to be a little bit slower to me - but in any case, the differences are insignificant, +3/-2 msec or so); same results when tested alone, or in combination with #1 and #3. Generally, DBIx::Connector looks like a move in the right direction (I guess it should improve stability/DBI connection handling safety in persistent environments, at least in theory ?), but in comparison with #1 & #3, it would be a lot harder to evaluate it for possible regressions, issues etc. While testing #2 I found one issue (Bug 13699), but this bug is also reproducible in unpatched master :). BTW, DBIx::Connector is not on the dependencies list (don't know if it needs to be added, on my test setup I had this module package already installed because I was toying with it previously). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #14 from Jonathan Druart --- Switch the status back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13690 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #13 from Jonathan Druart --- It's performance-related only, I will sent an email to koha-devel today (hopefully). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #12 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #11) > I got bad results with other tests. What kinds of bad results? Do you mean something performance-related only, or did you perhaps encountered some unforseen problems, regressions etc elsewhere? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Jonathan Druart changed: What|Removed |Added Status|Passed QA |In Discussion --- Comment #11 from Jonathan Druart --- This needs discussion, I really would like to see more people involved here. I submitted a second patch, here the benchmark result for Koha::Acquisition::Bookseller->search; Patch 1 is "Cache the DBIx connection" Patch 2 is "Use DBIx::Connector" With 14 suppliers in DB On master Perl benchmark_bookseller.pl 1.34s user 0.05s system 96% cpu 1.444 total Perl benchmark_bookseller.pl 1.38s user 0.03s system 97% cpu 1.448 total Perl benchmark_bookseller.pl 1.37s user 0.04s system 97% cpu 1.445 total Perl benchmark_bookseller.pl 1.38s user 0.02s system 97% cpu 1.437 total Perl benchmark_bookseller.pl 1.35s user 0.03s system 97% cpu 1.418 total On master + patch 1 Perl benchmark_bookseller.pl 0.92s user 0.04s system 96% cpu 0.999 total Perl benchmark_bookseller.pl 0.94s user 0.05s system 96% cpu 1.031 total Perl benchmark_bookseller.pl 0.90s user 0.06s system 96% cpu 0.988 total Perl benchmark_bookseller.pl 0.94s user 0.04s system 96% cpu 1.021 total Perl benchmark_bookseller.pl 0.93s user 0.04s system 96% cpu 1.003 total On master + patch 1 & patch 2 Perl benchmark_bookseller.pl 0.93s user 0.03s system 95% cpu 1.002 total Perl benchmark_bookseller.pl 0.96s user 0.03s system 95% cpu 1.031 total Perl benchmark_bookseller.pl 0.97s user 0.03s system 95% cpu 1.046 total Perl benchmark_bookseller.pl 0.99s user 0.02s system 96% cpu 1.048 total Perl benchmark_bookseller.pl 0.93s user 0.04s system 95% cpu 1.013 total On master + patch 2 Perl benchmark_bookseller.pl 1.40s user 0.02s system 97% cpu 1.464 total Perl benchmark_bookseller.pl 1.36s user 0.04s system 96% cpu 1.436 total Perl benchmark_bookseller.pl 1.36s user 0.04s system 97% cpu 1.428 total Perl benchmark_bookseller.pl 1.39s user 0.01s system 97% cpu 1.439 total Perl benchmark_bookseller.pl 1.37s user 0.05s system 97% cpu 1.454 total With 1014 suppliers in DB On master perl benchmark_bookseller.pl 35.66s user 0.14s system 99% cpu 35.977 total perl benchmark_bookseller.pl 35.36s user 0.14s system 99% cpu 35.591 total On master + patch 1 perl benchmark_bookseller.pl 2.50s user 0.07s system 95% cpu 2.675 total perl benchmark_bookseller.pl 2.56s user 0.07s system 95% cpu 2.739 total perl benchmark_bookseller.pl 2.66s user 0.05s system 95% cpu 2.849 total perl benchmark_bookseller.pl 2.49s user 0.06s system 96% cpu 2.655 total perl benchmark_bookseller.pl 2.42s user 0.08s system 96% cpu 2.581 total On master + patch 1 & patch 2 perl benchmark_bookseller.pl 2.45s user 0.05s system 96% cpu 2.596 total perl benchmark_bookseller.pl 2.49s user 0.04s system 96% cpu 2.629 total perl benchmark_bookseller.pl 2.49s user 0.04s system 96% cpu 2.629 total perl benchmark_bookseller.pl 2.48s user 0.09s system 96% cpu 2.678 total perl benchmark_bookseller.pl 2.40s user 0.08s system 96% cpu 2.562 total On master + patch 2 perl benchmark_bookseller.pl 34.75s user 0.11s system 99% cpu 34.927 total perl benchmark_bookseller.pl 34.22s user 0.12s system 99% cpu 34.397 total perl benchmark_bookseller.pl 35.12s user 0.15s system 99% cpu 35.343 total At first glance, patch 2 does not seem to be efficient, but I am not confident with patch 1, I got bad results with other tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #10 from Jonathan Druart --- Created attachment 35774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35774&action=edit Bug 13645: Use DBIx::Connector -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Magnus Enger changed: What|Removed |Added CC||mag...@enger.priv.no -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Kyle M Hall changed: What|Removed |Added Attachment #35657|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall --- Created attachment 35668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35668&action=edit [PASSED QA] Bug 13645: Cache the DBIx connection We don't want to recreate a new connection to the DB every time we want a new schema. This patch creates a $database package level variable on the same way it's done in C4::Context for $dbh. Signed-off-by: Jacek Ablewicz Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645
--- Comment #8 from Jacek Ablewicz ---
(In reply to Jonathan Druart from comment #7)
> I quickly implemented Koha::Acquisition::Bookseller using Koha::Object (see
> bug 13019) and tested with
>
> use Modern::Perl;
> use Koha::Acquisition::Booksellers;
> my $booksellers = Koha::Acquisition::Booksellers->search;
> while ( my $b = $booksellers->next ) {
> say $b->name;
> }
>
> perl benchmark_bookseller.pl 1.00s user 0.03s system 96% cpu 1.072 total
Speed-wise, I'm getting pretty much the same results with the following
quick&dirty mod:
--- a/Koha/Acquisition/Bookseller.pm
+++ b/Koha/Acquisition/Bookseller.pm
@@ -46,13 +46,12 @@ sub search {
}
my $rs = $schema->resultset('Aqbookseller')->search(
$search_params,
-{ order_by => 'name' }
+{ order_by => 'name' }, { result_class =>
'DBIx::Class::ResultClass::HashRefInflator' }
);
my @booksellers;
while ( my $b = $rs->next ) {
-my $t = Koha::Acquisition::Bookseller->fetch({ id => $b->id });
-push @booksellers, $t;
+push @booksellers, $b;
}
return @booksellers;
}
With it, booksellers.pl loading times are 0.96 sec / 1.82 sec / 10.3 sec for
170 / 1700 / 17000 booksellers in the database.
Whenever DBIx object is cached or not cached doesn't seem to matter much with
such mod - I guess because there would be just one DBIx schema/connection
object created in this case anyway?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645
--- Comment #7 from Jonathan Druart ---
I did a quick test (master):
inserted 1000 booksellers, launched
use Modern::Perl;
use Koha::Acquisition::Bookseller;
Koha::Acquisition::Bookseller->search;
perl benchmark_bookseller.pl 33.83s user 0.12s system 99% cpu 34.280 total
I quickly implemented Koha::Acquisition::Bookseller using Koha::Object (see bug
13019) and tested with
use Modern::Perl;
use Koha::Acquisition::Booksellers;
my $booksellers = Koha::Acquisition::Booksellers->search;
while ( my $b = $booksellers->next ) {
say $b->name;
}
perl benchmark_bookseller.pl 1.00s user 0.03s system 96% cpu 1.072 total
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #6 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #5) > Did you benchmark the scripts booksellers.pl and invoices.pl with this patch? Patched master: 166 booksellers: - acqui/booksellers.pl: 1.3 sec - acqui/invoices.pl: 1.2 sec 1660 booksellers: - acqui/booksellers.pl: 6.4 sec - acqui/invoices.pl: 5.5 sec 16600 booksellers: - acqui/booksellers.pl: 55.8 sec - acqui/invoices.pl: 47.5 sec Unpatched master: 166 booksellers: - acqui/booksellers.pl: 4.06 sec - acqui/invoices.pl: 3.94 sec 1660 booksellers: - acqui/booksellers.pl: 33.2 sec - acqui/invoices.pl: 31.7 sec Test setup with pre-DBIx bookseller code (3.17.00.014), different server with ca 10-25% faster CPU, but otherwise rather similar software and hardware-wise: 166 booksellers: - acqui/booksellers.pl: 0.68 sec - acqui/invoices.pl: 0.61 sec 1660 booksellers: - acqui/booksellers.pl: 1.71 sec - acqui/invoices.pl: 0.64 sec 16600 booksellers: - acqui/booksellers.pl: 10.8 sec - acqui/invoices.pl: 1.16 sec Other difference between patched and unpatched master is that when running booksellers.pl on the unpatched master, CPU usage is 99+% for booksellers.pl and just 1.2-1.5% for mysqld, while for patched master it is ca 87% for a script and 12% for mysqld. Before filing this bug report I've tried to profile booksellers.pl with nytprof; there are some intriguing things in the results, for example: suspiciously high amount of CPU time (20% or so) is being spent in the various XML::* modules - I think I figured why it does that, separate bug report + patch will follow. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #5 from Jonathan Druart --- (In reply to Jacek Ablewicz from comment #4) > (In reply to Jonathan Druart from comment #2) > > Here my try. > > It does vastly improve Koha DBIx performace, and as far as I can tell after > eyeballing it comprehensively, it rather shouldn't break anything important. > So I change status to signed off. Thanks Jacek! Did you benchmark the scripts booksellers.pl and invoices.pl with this patch? > Would be nice to have some kind of test plan for it, though.. > > OTOH, in theory it can indirectly affect a lot of different places where > Koha::Database->.. calls are being used, so any meaningfull test plan is > probably out of the question anyway ;). Yes, a test plan could be: Verify there is no regression/error with scripts using a dbic connection :) Which is vague... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 --- Comment #4 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #2) > Here my try. It does vastly improve Koha DBIx performace, and as far as I can tell after eyeballing it comprehensively, it rather shouldn't break anything important. So I change status to signed off. Would be nice to have some kind of test plan for it, though.. OTOH, in theory it can indirectly affect a lot of different places where Koha::Database->.. calls are being used, so any meaningfull test plan is probably out of the question anyway ;). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Jacek Ablewicz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Jacek Ablewicz changed: What|Removed |Added Attachment #35636|0 |1 is obsolete|| --- Comment #3 from Jacek Ablewicz --- Created attachment 35657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35657&action=edit Bug 13645: Cache the DBIx connection We don't want to recreate a new connection to the DB every time we want a new schema. This patch creates a $database package level variable on the same way it's done in C4::Context for $dbh. Signed-off-by: Jacek Ablewicz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Jonathan Druart changed: What|Removed |Added CC||ch...@bigballofwax.co.nz, ||jonathan.dru...@biblibre.co ||m, ||k...@bywatersolutions.com, ||tomasco...@gmail.com Summary|Koha::Acquisition::Booksell |DBIx connection needs to be |er->search() performance / |cached |efficiency problems | --- Comment #2 from Jonathan Druart --- Here my try. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
