[Koha-bugs] [Bug 13662] Serial permissions: receive_serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13662] Serial permissions: receive_serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13662] Serial permissions: receive_serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 --- Comment #1 from Jonathan Druart --- Created attachment 35659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35659&action=edit Bug 13662: Fix the serials.receive_serials permissions There are some issues with serial permissions. For instance it's not possible to receive serials if the edit_subscription is not set. Also the toolbar is empty. Test plan: 1/ Set the serials => receive_serials permissions to a patron (and only this one for the serials module). 2/ Verify you cannot create a new subscription, you can search subscriptions but cannot edit them. 3/ On the serial result list, receive a serial (action > Serial receive). You can now change the status and receive it. 4/ On the serial collection, you can edit 1+ serials to reveice it. 5/ Set the serials => edit_subscription permission and confirm there is no regression. QA note: I think we should introduce a C4::Serials::can_receive_serials subroutine, to test the IndependentBranches pref, but I don't want to add to much processing to check permissions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13662] Serial permissions: receive_serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 Paola Rossi changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||paola.ro...@cineca.it --- Comment #2 from Paola Rossi --- I've applied the patch against master 3.19.00.011 head 12948. A) Step 5: Permission edit_subscription ON, receive_serials OFF: on /cgi-bin/koha/serials/subscription-detail.pl toolbar over "Subscription for [serial-title]: Master: "Edit" and "Close" are shown; no "New Subscription" is shown. APPLIED: "Edit", "Close" and "New Subscription" are shown. Selecting "New subscription" gets "Error: you do not have the permission to access this page ..." (RIGHT). Anyway, I think that adding "New subscription" is a regression error of this bug. B) Permission edit_subscription OFF, receive_serials ON : on /cgi-bin/koha/serials/subscription-detail.pl toolbar over "Subscription for [serial-title]:" Master: toolbar is shown but it's empty. APPLIED: "New Subscription" and "Receive" are shown. Selecting "Receive" works fine (RIGHT). Selecting "New subscription" gets "Error: you do not have the permission to access this page ..." (RIGHT). Anyway, I think that adding "New subscription" is an error of this bug (ERROR). C) Permission edit_subscription OFF, receive_serials ON : C1) on /cgi-bin/koha/serials/serials-collection.pl toolbar over "Serial collection information for [serial-title]:" Master: toolbar is shown but it's empty. APPLIED: no toolbar at all is shown (Is it RIGHT that the toolbar is empty? IMO yes, RIGHT fix). C2) on /cgi-bin/koha/serials/serials-collection.pl "Edit" column at the left of the issues table: Master: "disabled" is shown APPLIED: selectable checkboxes (RIGHT, a good fix out of the test plan). For the A) and B) errors I pass this patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13662] Serial permissions: receive_serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13662] Serial permissions: receive_serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 Jonathan Druart changed: What|Removed |Added Attachment #35659|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 36121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36121&action=edit Bug 13662: Fix the serials.receive_serials permissions There are some issues with serial permissions. For instance it's not possible to receive serials if the edit_subscription is not set. Also the toolbar is empty. Test plan: 1/ Set the serials => receive_serials permissions to a patron (and only this one for the serials module). 2/ Verify you cannot create a new subscription, you can search subscriptions but cannot edit them. 3/ On the serial result list, receive a serial (action > Serial receive). You can now change the status and receive it. 4/ On the serial collection, you can edit 1+ serials to reveice it. 5/ Set the serials => edit_subscription permission and confirm there is no regression. QA note: I think we should introduce a C4::Serials::can_receive_serials subroutine, to test the IndependentBranches pref, but I don't want to add to much processing to check permissions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13662] Serial permissions: receive_serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 --- Comment #4 from Jonathan Druart --- (In reply to Paola Rossi from comment #2) Good catch Paola! That should be fixed with the last patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13662] Serial permissions: receive_serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 Paola Rossi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13662] Serial permissions: receive_serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 Paola Rossi changed: What|Removed |Added Attachment #36121|0 |1 is obsolete|| --- Comment #5 from Paola Rossi --- Created attachment 36138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36138&action=edit 36121: Bug 13662: Fix the serials.receive_serials permissions Thanks, Jonathan. I've applied the patch against master 3.19.00.011 head 13645. All the 3 cases about: Permission edit_subscription ON, receive_serials OFF, Permission edit_subscription OFF, receive_serials ON, Permission edit_subscription ON, receive_serials ON, were OK. Everything was OK as required. So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13662] Serial permissions: receive_serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 --- Comment #6 from Brendan Gallagher --- Created attachment 36323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36323&action=edit Bug 13662: Fix the serials.receive_serials permissions There are some issues with serial permissions. For instance it's not possible to receive serials if the edit_subscription is not set. Also the toolbar is empty. Test plan: 1/ Set the serials => receive_serials permissions to a patron (and only this one for the serials module). 2/ Verify you cannot create a new subscription, you can search subscriptions but cannot edit them. 3/ On the serial result list, receive a serial (action > Serial receive). You can now change the status and receive it. 4/ On the serial collection, you can edit 1+ serials to reveice it. 5/ Set the serials => edit_subscription permission and confirm there is no regression. QA note: I think we should introduce a C4::Serials::can_receive_serials subroutine, to test the IndependentBranches pref, but I don't want to add to much processing to check permissions. Signed-off-by: Paola Rossi Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13662] Serial permissions: receive_serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 Brendan Gallagher changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13662] Serial permissions: receive_serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13662] Serial permissions: receive_serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Attachment #36138|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13662] Serial permissions: receive_serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Josef! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13662] Serial permissions: receive_serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 --- Comment #8 from Tomás Cohen Arazi --- I mean Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13662] Serial permissions: receive_serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13662 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
