[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #72 from Marcel de Rooy  ---
IN the period between this push and the the push of bug 26947, the /*! version
dependent lines at the start of kohastructure appear to have been silently
ignored by DBIx::RunSQL.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30620

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Martin Renvoize  changed:

   What|Removed |Added

   Target Milestone|Oldversions |---

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #71 from Marcel de Rooy  ---
I stumbled over RunSQL while trying to add a CREATE FUNCTION in a Koha
installer script.
The script can be run fine with mysql client but not via RunSQL.
Why? In order to create a function or procedure you need to change the
delimiter with DELIMITER // (or some other character). This is not a MySQL
command. RunSQL will crash on it, but the mysql client knows about it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17258


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
[Bug 17258] [OMIBUS] MySQL 5.7
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #70 from Tomás Cohen Arazi  ---
(In reply to Julian Maurice from comment #69)
> I forgot the last followup in 3.22.7, it will be in 3.22.8

Julian, have the PM add it on packaging!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #69 from Julian Maurice  ---
I forgot the last followup in 3.22.7, it will be in 3.22.8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #68 from Kyle M Hall  ---
Excellent! Followup pushed to master! Thanks Bernardo!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Pushed to Master|Pushed to Stable

--- Comment #67 from Julian Maurice  ---
Patches pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Blocks|16554   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554
[Bug 16554] Web installer fails to load i18n sample data on MySQL 5.6+
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Blocks|16572   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16572
[Bug 16572] Warnings on load_sql makes web installer fail
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #51738|0   |1
is obsolete||

--- Comment #66 from Bernardo Gonzalez Kriegel  ---
Created attachment 51746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51746=edit
Bug 13669: followup to add DBIx::RunSQL dependency

Just that

To test:
1) run koha_perl_deps and check it show up

The module appears now on the About page.
Signed-off-by: Marc Véron 

Ammended patch, only change is DBIx::RunSQL version,
now 0.14 :)

Module's author kindly accept to upgrade it, in particular
this makes Bug 16572 innecesary and is not needed to install
without problems.

Tested install on Ubuntu 14.04/Mysql 5.5.49, marc21 + all sample

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Marc Véron  changed:

   What|Removed |Added

  Attachment #51736|0   |1
is obsolete||

--- Comment #65 from Marc Véron  ---
Created attachment 51738
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51738=edit
Bug 13669: followup to add DBIx::RunSQL dependency

Just that

To test:
1) run koha_perl_deps and check it show up

The module appears now on the About page.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #64 from Bernardo Gonzalez Kriegel  ---
Created attachment 51736
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51736=edit
Bug 13669: followup to add DBIx::RunSQL dependency

Just that

To test:
1) run koha_perl_deps and check it show up

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #63 from Tomás Cohen Arazi  ---
Just a followup!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #62 from Bernardo Gonzalez Kriegel  ---
(In reply to Kyle M Hall from comment #61)
> 
> Thanks! If you write it I'm sure we can find some testers!

Will do!

Do you need another bug to add DBIx::RunSQL dependency ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #61 from Kyle M Hall  ---
(In reply to Bernardo Gonzalez Kriegel from comment #60)
> (In reply to Kyle M Hall from comment #59)
> > So, with the release so close, how should we deal with this? Revert? Push
> > forward with Bug 16572 and Bug 16573? Or do we have other options?
> 
> With Bug 16572 + new perl dependency DBIx::RunSQL we can install where we
> used to, not systems with MySQL 5.7. 
> 
> To add support for mysql 5.7 we need Bug 16573 + another one to fix i18n
> installer files. I can write it, but we need someone to test, and that in
> case this kind of fix is considered valid.

Thanks! If you write it I'm sure we can find some testers!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #60 from Bernardo Gonzalez Kriegel  ---
(In reply to Kyle M Hall from comment #59)
> So, with the release so close, how should we deal with this? Revert? Push
> forward with Bug 16572 and Bug 16573? Or do we have other options?

With Bug 16572 + new perl dependency DBIx::RunSQL we can install where we used
to, not systems with MySQL 5.7. 

To add support for mysql 5.7 we need Bug 16573 + another one to fix i18n
installer files. I can write it, but we need someone to test, and that in case
this kind of fix is considered valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #59 from Kyle M Hall  ---
So, with the release so close, how should we deal with this? Revert? Push
forward with Bug 16572 and Bug 16573? Or do we have other options?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #58 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #57)
> Yes it is related - and I think it needs to be packaged, I couldn't find it
> in latest Ubuntu and installed from CPAN for testing.

Just to note, DBIx::RunSQL should be trivial to package. As far as I can tell,
it requires no external dependencies. At least nothing we don't already have
except for Text::Table which appears to be optional.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #57 from Katrin Fischer  ---
Yes it is related - and I think it needs to be packaged, I couldn't find it in
latest Ubuntu and installed from CPAN for testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #56 from Marc Véron  ---
Is the following related to this bug?

Can't locate DBIx/RunSQL.pm in @INC (@INC contains: /usr/share/kohaclone
/etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2
/usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14
/usr/local/lib/site_perl .) at /usr/share/kohaclone/C4/Installer.pm line 23.
BEGIN failed--compilation aborted at /usr/share/kohaclone/C4/Installer.pm line
23.
Compilation failed in require at /usr/share/kohaclone/about.pl line 34.
BEGIN failed--compilation aborted at /usr/share/kohaclone/about.pl line 34.

It seems that a dependency is missing in PerlDependencies.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #55 from Katrin Fischer  ---
Thx all for working on this! I have Ubuntu 16.04 and MySQL 5.7 - so I can test
this tomorrow again at the hackfest if stil needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #54 from Bernardo Gonzalez Kriegel  ---
(In reply to Bernardo Gonzalez Kriegel from comment #52)
> (In reply to Jonathan Druart from comment #50)
> > Yes, on another bug report.
> > Now you have Ubuntu 16.04, could you please submit a patch? :)
> 
> Will do :)

Bug 16572 as POC solution to my last comment
Bug 16573 for Ubuntu 16.04 fix

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Blocks||16572


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16572
[Bug 16572] Warnings on load_sql makes web installer fail
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #53 from Bernardo Gonzalez Kriegel  ---
Mmm, we have a problem :(

RunSQL prints loads of 'warnings', they are catched and treated as
errors because they go to stderr.

RunSQL have this line

261 } elsif( 0 < $sth->{NUM_OF_FIELDS} ) {

but $sth from execute can have that parameter undef for create/delete,
and that seems to be the case, not an error but a warning.

Now we can't install, even on MySQL < 5.7 !!

Can we revert (in another Bug) to something similar to my error treatment?
Displayed errors where not as fancy, but worked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #52 from Bernardo Gonzalez Kriegel  ---
(In reply to Jonathan Druart from comment #50)
> Yes, on another bug report.
> Now you have Ubuntu 16.04, could you please submit a patch? :)

Will do :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #51 from Kyle M Hall  ---
Pushed to master for 16.05! Thanks Tomas, Bernardo and Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #50 from Jonathan Druart  
---
(In reply to Bernardo Gonzalez Kriegel from comment #49)
> Errors are not in the procedeure, I tested extensively but on msyql < 5.6,
> so this is specific to ver 5.6+ treatment of SQL, or 5.7 more specifically
> 
> 1) table: auth_subfield_structure
> 
> line:  72   `defaultvalue` TEXT DEFAULT '',
> error: (BLOB, TEXT, GEOMETRY or JSON column 'defaultvalue' can't have a
> default value): CREATE TABLE `auth_subfield_structure`
> 
> Seems that we can't have default values here.
> 
> Ref: http://dev.mysql.com/doc/refman/5.7/en/blob.html
> ->" BLOB and TEXT columns cannot have DEFAULT values."

I get this one using --show-warnings on MariaDB 10.0.24
Fixed with 
diff --git a/installer/data/mysql/kohastructure.sql
b/installer/data/mysql/kohastructure.sql
index 42bff46..ea220bb 100644
--- a/installer/data/mysql/kohastructure.sql
+++ b/installer/data/mysql/kohastructure.sql
@@ -69,7 +69,7 @@ CREATE TABLE `auth_subfield_structure` (
   `linkid` tinyint(1) NOT NULL default 0,
   `kohafield` varchar(45) NULL default '',
   `frameworkcode` varchar(10) NOT NULL default '',
-  `defaultvalue` TEXT DEFAULT '',
+  `defaultvalue` TEXT,

But I don't get the others

> MySQL 5.7 does not like things like that.
> Perhaps we can change the sql_mode for Koha globally, 
> or fix all the sample data (not difficult) in all languages, 
> and test/sign/QA everything... before release?

Yes, on another bug report.
Now you have Ubuntu 16.04, could you please submit a patch? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #49 from Bernardo Gonzalez Kriegel  ---
Errors are not in the procedeure, I tested extensively but on msyql < 5.6, so
this is specific to ver 5.6+ treatment of SQL, or 5.7 more specifically

1) table: auth_subfield_structure

line:  72   `defaultvalue` TEXT DEFAULT '',
error: (BLOB, TEXT, GEOMETRY or JSON column 'defaultvalue' can't have a default
value): CREATE TABLE `auth_subfield_structure`

Seems that we can't have default values here.

Ref: http://dev.mysql.com/doc/refman/5.7/en/blob.html
->" BLOB and TEXT columns cannot have DEFAULT values."

2) table: virtualshelves
line:  2212   `created_on` TIMESTAMP NOT NULL, -- creation time
error: (Invalid default value for 'created_on'): CREATE TABLE `virtualshelves`

Seems that first TIMESTAMP column in a table not explicitly nullable
automatically gets DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP

Could it be DATETIME instead of TIMESTAMP??

Reference
http://shankargopal.blogspot.com.ar/2013/03/mysql-566-timestamp-columns-and-default.html


3) and 4)
error: (Cannot add foreign key constraint): CREATE TABLE `virtualshelfcontents`
error: (Cannot add foreign key constraint): CREATE TABLE `virtualshelfshares`

This two because virtualshelves table not created

MORE

Fixing somehow previous kohastructure errors, we have more Errors in sample
data

auth_subfield_structure, (Incorrect integer value: '' for column 'linkid' at
row 1)
Here we have an error, '' instead of 0, MySQL < 5.6 tolerates this, 5.7 no

sample_patrons.sql, (Column 'address' cannot be null)

sample_quotes.sql, (Incorrect datetime value: '-00-00 00:00:00' for column
'timestamp' at row 1)

MySQL 5.7 does not like things like that.
Perhaps we can change the sql_mode for Koha globally, 
or fix all the sample data (not difficult) in all languages, 
and test/sign/QA everything... before release?

Ref:
https://www.digitalocean.com/community/tutorials/how-to-prepare-for-your-mysql-5-7-upgrade

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #48 from Bernardo Gonzalez Kriegel  ---
(In reply to Katrin Fischer from comment #47)
> I have installed the dependency from CPAN, made sure that the database was
> empty, applied the patches and ran the web installer in English. But I still
> get errors, any idea what's going wrong there?
> 
...

I can confirm similar problems on Ubuntu 16.05, Myslq 5.7
My test where not done on this kind of system, sorry :(

In case the problem where from DBIX::RunSQL (which gives problems),
I wrote a revision using Tomas' approach (SQL::SplitStatment), and found
the same problems

[Sun May 22 18:49:18 2016] install.pl: DBD::mysql::db do failed: BLOB, TEXT,
GEOMETRY or JSON column 'defaultvalue' can't have a default value at
/home/bgkriegel/kohaclone/C4/Installer.pm line 443. [Sun May 22 18:49:51 2016]
install.pl: DBD::mysql::db do failed: Invalid default value for 'created_on' at
/home/bgkriegel/kohaclone/C4/Installer.pm line 443. [Sun May 22 18:49:52 2016]
install.pl: DBD::mysql::db do failed: Cannot add foreign key constraint at
/home/bgkriegel/kohaclone/C4/Installer.pm line 443. [Sun May 22 18:49:52 2016]
install.pl: DBD::mysql::db do failed: Cannot add foreign key constraint at
/home/bgkriegel/kohaclone/C4/Installer.pm line 443

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #47 from Katrin Fischer  ---
I have installed the dependency from CPAN, made sure that the database was
empty, applied the patches and ran the web installer in English. But I still
get errors, any idea what's going wrong there?

Help?

[Sun May 22 19:38:37 2016] install.pl: Use of uninitialized value in numeric lt
(<) at /usr/local/share/perl/5.22.1/DBIx/RunSQL.pm line 261. [Sun May 22
19:38:37 2016] install.pl: Use of uninitialized value in numeric lt (<) at
/usr/local/share/perl/5.22.1/DBIx/RunSQL.pm line 261. [Sun May 22 19:38:37
2016] install.pl: Use of uninitialized value in numeric lt (<) at
/usr/local/share/perl/5.22.1/DBIx/RunSQL.pm line 261. [Sun May 22 19:38:37
2016] install.pl: Use of uninitialized value in numeric lt (<) at
/usr/local/share/perl/5.22.1/DBIx/RunSQL.pm line 261. [Sun May 22 19:38:37
2016] install.pl: Use of uninitialized value in numeric lt (<) at
/usr/local/share/perl/5.22.1/DBIx/RunSQL.pm line 261. [Sun May 22 19:38:37
2016] install.pl: DBD::mysql::st execute failed: BLOB, TEXT, GEOMETRY or JSON
column 'defaultvalue' can't have a default value at
/usr/local/share/perl/5.22.1/DBIx/RunSQL.pm line 254.

Please contact your system administrator

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #46 from Jonathan Druart  
---
Created attachment 51685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51685=edit
Bug 13669: Catch the errors to have them to the logs

This patch redirect STDERR to a variable to retrieve the errors raised
by the DBMS when loading a sql file, it could be useful to debug errors.

Signed-off-by: Bernardo Gonzalez Kriegel 
It's better of course, trying to load a failed fiel
it outputs mysl errors
DBD::mysql::st execute failed: You have an error in your SQL syntax...
No errors

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #45 from Jonathan Druart  
---
Created attachment 51684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51684=edit
Bug 13669: Re-adds error handling to load_sql

This patch prevents crashing in case an
error is detected when loading a file

To test:
1) Apply patch
2) Mangle kohastructure.sql or any sample
file adding and invalid SQL line
3) Run webinstaller and check that the error
is handled gracefully

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #51600|0   |1
is obsolete||
  Attachment #51601|0   |1
is obsolete||
  Attachment #51608|0   |1
is obsolete||
  Attachment #51671|0   |1
is obsolete||
  Attachment #51680|0   |1
is obsolete||

--- Comment #42 from Jonathan Druart  
---
Created attachment 51681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51681=edit
Bug 13669: Use perl to load SQL statements from sample data

This patch changes C4::Installer::load_sql so it uses File::Slurp [1] to read
the SQL files, and SQL::SplitStatement to extract the statements from the full
SQL
file so they can be passed to $dbh->do.

To test:
- On Mysql 5.5, run the webinstaller
=> SUCCESS: Everything works as expected
- Apply the patch
- Run
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> SUCCESS: Everything works as expected
- On Mysql 5.6+ (5.7 is implied)
- Run
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> FAIL: It cannot load the sql files due to a password-in-command-line error
- Apply the patch
- Make sure everything is clean (it should):
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> SUCCESS: EVerything works as expected
- Sign off :-D

[1] Note: This is a POC patch, in the sense that it does the job, fixes a nasty
problem
but using File::Slurp to load the SQL files in memory comes with a big runtime
penalty.
You will notice the install procedure is now much slower, for instance.

Signed-off-by: Chris Cormack 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #44 from Jonathan Druart  
---
Created attachment 51683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51683=edit
Bug 13669: (alternative) use DBIx::RunSQL

Alternative POC solution, on top of
previous patches, feel free to obsolte.

This patch use DBIx::RunSQL->run_sql_file
to procees each sql file.

To test:
1) Apply all patches
2) Same test plan of patch 1

Timing test running web installer, marc21,
all sample data, time in seconds

a) without patch
structure   data
59.766.5
58.666.0

b) SQL::SplitStatement (patch 1+2)
59.4101
59.7102

c) DBIx::RunSQL (patch 3)
60.766.8
59.466.2

Tomas' version is a bit slower loading sample data,
all give similar results processing kohastructure.

New dependency to package: DBIx::RunSQL

Signed-off-by: Chris Cormack 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #43 from Jonathan Druart  
---
Created attachment 51682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51682=edit
Bug 13669: (followup) Fix kohastructure.sql so FK dependencies are sorted

The current table creation order is left to mysql's strategy, which is not
suitable for parsing the SQL files and passing one statement at a time in
the current order.

This patch just moves table creation statements around so FK constraints are
defined for previously created tables.

Signed-off-by: Chris Cormack 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #41 from Bernardo Gonzalez Kriegel  ---
> 
> Sorry, forgot to apply the last patch locally.

Forgot to sing also :)
I've signed yours, can't sign mine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #51672|0   |1
is obsolete||

--- Comment #40 from Bernardo Gonzalez Kriegel  ---
Created attachment 51680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51680=edit
[SIGNED-OFF] Bug 13669: Catch the errors to have them to the logs

This patch redirect STDERR to a variable to retrieve the errors raised
by the DBMS when loading a sql file, it could be useful to debug errors.

Signed-off-by: Bernardo Gonzalez Kriegel 
It's better of course, trying to load a failed fiel
it outputs mysl errors
DBD::mysql::st execute failed: You have an error in your SQL syntax...
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #39 from Jonathan Druart  
---
Created attachment 51672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51672=edit
Bug 13669: Catch the errors to have them to the logs

This patch redirect STDERR to a variable to retrieve the errors raised
by the DBMS when loading a sql file, it could be useful to debug errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #38 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #37)
> Without the patch the errors are log into the Koha log file and there is not
> crash
> With the patch, there is nothing in the log file and Koha crashes.

Sorry, forgot to apply the last patch locally.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #37 from Jonathan Druart  
---
Yes, I agree: fix without change in the behavior.

That's why I think we should update the patch :)

Without the patch the errors are log into the Koha log file and there is not
crash
With the patch, there is nothing in the log file and Koha crashes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #36 from Bernardo Gonzalez Kriegel  ---
(In reply to Tomás Cohen Arazi from comment #35)
> (In reply to Jonathan Druart from comment #34)
> > I don't know if we should fail or continue actually, hard to say.
> > I would say we should block anything if an error occurs (and so do not
> > execute next files).
> > Otherwise there is a `force` parameter to set to DBIx::RunSQL we could use.
> 
> Any behaviour change in that way would be a nice improvement, but it would
> need to be discussed. Also, that would be an enhancement.
> This is a blocker bugfix so Koha works on newer operating systems, with
> backwards compatibility. Keeping the current behaviour, making it work. I
> think we should push it if the Packaging manager agrees to package
> DBIx::RunSQL (it only depends on DBI!) and add it to the repository.

Was about to say something similar. 
Also 'force' seems to hide the problems, just tried it and can't get number of
problems.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #35 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #34)
> I don't know if we should fail or continue actually, hard to say.
> I would say we should block anything if an error occurs (and so do not
> execute next files).
> Otherwise there is a `force` parameter to set to DBIx::RunSQL we could use.

Any behaviour change in that way would be a nice improvement, but it would need
to be discussed. Also, that would be an enhancement.
This is a blocker bugfix so Koha works on newer operating systems, with
backwards compatibility. Keeping the current behaviour, making it work. I think
we should push it if the Packaging manager agrees to package DBIx::RunSQL (it
only depends on DBI!) and add it to the repository.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #34 from Jonathan Druart  
---
I don't know if we should fail or continue actually, hard to say.
I would say we should block anything if an error occurs (and so do not execute
next files).
Otherwise there is a `force` parameter to set to DBIx::RunSQL we could use.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #33 from Bernardo Gonzalez Kriegel  ---
(In reply to Jonathan Druart from comment #31)
> I think we should gracefully handle errors, as it was before.
> If C4::Installer::load_file encounters an error, Koha will crash.

You are right, added a possible fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #32 from Bernardo Gonzalez Kriegel  ---
Created attachment 51671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51671=edit
Bug 13669: Re-adds error handling to load_sql

This patch prevents crashing in case an
error is detected when loading a file

To test:
1) Apply patch
2) Mangle kohastructure.sql or any sample
file adding and invalid SQL line
3) Run webinstaller and check that the error
is handled gracefully

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #31 from Jonathan Druart  
---
I think we should gracefully handle errors, as it was before.
If C4::Installer::load_file encounters an error, Koha will crash.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Blocks||16554


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554
[Bug 16554] Web installer fails to load i18n sample data on MySQL 5.6+
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #30 from Bernardo Gonzalez Kriegel  ---
Moving i18n files to Bug 16554.
Resetting to 'Signed off' for QA consideration, sorry for the noise

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #51612|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #51611|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #29 from Bernardo Gonzalez Kriegel  ---
Hi Jonathan,

(In reply to Jonathan Druart from comment #27)
> Bernardo, how did you generate new sample files?

Mmmm, sorry but can't understand exactly...
Just edited current files and fix what was needed

(In reply to Jonathan Druart from comment #28)
> What's the expected behavior if an error occurs,

A) de-DE, es-ES, fr-CA and pl-PL, 
same error for all langs

 * first 3 patches applied
 * (cd misc/translator/; ./translate install de-DE) , for example
 * drop/create database, run webinstaller
 * marc21, select all sample data

1) web installer error

Software error:

[SQL ERROR]: -- ISSN: 1041-5653
-- Refer to http://www.niso.org/standards/index.html

-- General Holdings: Type of Unit Designator
INSERT INTO `authorised_values` (category, authorised_value, lib) VALUES
('HINGS_UT','0','Information not available; Not applicable');INSERT INTO
`authorised_values` (category, authorised_value, lib) VALUES
('HINGS_UT','a','Basic bibliographic unit')
For help

2) logs

install.pl: DBD::mysql::st execute failed: You have an error in your SQL
syntax; check the manual that corresponds to your MySQL server version for the
right syntax to use near 'INSERT INTO `authorised_values` (category,
authorised_value, lib) VALUES ('HINGS' at line 5 at
/usr/local/share/perl/5.18.2/DBIx/RunSQL.pm line 254...
and more lines

In this case I suppose that DBIx::RunSQL does not know how to parse 2 sql
statments on the same line.

B) fr-FR
1) web installer

Software error:

[SQL ERROR]: 
INSERT INTO `auth_types` (`authtypecode`, `authtypetext`, `auth_tag_to_report`,
`summary`) VALUES ('','Défaut','','')

2) logs

install.pl: DBD::mysql::st execute failed: Duplicate entry '' for key 'PRIMARY'
at /usr/local/share/perl/5.18.2/DBIx/RunSQL.pm line 254.

In this case as both autorite_default.sql and 
autorites_norme_unimarc.sql are 'Obligatoire',
we have duplicate keys for 'Défaut' auth type 
and some other fields/subfields.

Here the second file was edited to join all inserts in
one statement (like EN marc21 files) instead of adding 
IGNORE to all INSERTs to prevent this error 

The other error is a space after final ';' on sample_labels.sql,
similar to case A)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #28 from Jonathan Druart  
---
What's the expected behavior if an error occurs,

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #27 from Jonathan Druart  
---
Bernardo, how did you generate new sample files?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #51610|0   |1
is obsolete||

--- Comment #26 from Bernardo Gonzalez Kriegel  ---
Created attachment 51612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51612=edit
Bug 13669: (followup) fix I18N files

This patch fix web installer for
de-DE, es-ES, fr-CA, nb-NO and pl-PL

To test:
1) Apply patch
2) Try web installer for any/all listed languages.
a) de-DE, es-ES, fr-CA and pl-PL
There must be no problems for marc21 + all sample files
b) nb-NO
There must be no problems for normarc + all sample files

Fixed test plan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff
 CC||bgkrie...@gmail.com

--- Comment #25 from Bernardo Gonzalez Kriegel  ---
(In reply to Chris Cormack from comment #20)
> It works, but a new dependency eh? We need to update that too.
> 
> I've attached it as a signed off patch, but will let the RM and others
> decide if they want to add the new dependency.

You are right, but SQL::SplitStatement also needs packaging.

Tested web installer in all languages, added fixes for almost all.
ru-RU and uk-UA need more work, but I need to sleep.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #24 from Bernardo Gonzalez Kriegel  ---
Created attachment 51611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51611=edit
Bug 13669: (followup) fix fr-FR files

Rewrite autorites_norme_unimarc.sql to
use only one INSERT IGNORE.

New load method complains about duplicate keys,
and both auth files are mandatory!

Also removed an exotic blank space on sample_labels.sql

Tested with unimarc_complet and all sample files.

To test
1) Apply the patch
2) Try fr-FR web installer, unimarc_complet + all sample files
There must be no errors

Don't know if fr-FR marc21 and unimarc_lecture_pub are used,
need a look from french users.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #23 from Bernardo Gonzalez Kriegel  ---
Created attachment 51610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51610=edit
Bug 13669: (followup) fix I18N files

This patch fix web installer for
de-DE, es-ES, fr-CA, nb-NO and pl-PL

To test:
1) Apply patch
2) Try web installer for any/all listed languages.
There must be no problems for marc21 + all sample files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Keywords||dependency

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #22 from Tomás Cohen Arazi  ---
(In reply to Chris Cormack from comment #20)
> It works, but a new dependency eh? We need to update that too.
> 
> I've attached it as a signed off patch, but will let the RM and others
> decide if they want to add the new dependency.

Yeah, it all depends on the packaging complexity. Let's add the packaging
manager to the talk.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Chris Cormack  changed:

   What|Removed |Added

  Attachment #51607|0   |1
is obsolete||

--- Comment #21 from Chris Cormack  ---
Created attachment 51608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51608=edit
Bug 13669: (alternative) use DBIx::RunSQL

Alternative POC solution, on top of
previous patches, feel free to obsolte.

This patch use DBIx::RunSQL->run_sql_file
to procees each sql file.

To test:
1) Apply all patches
2) Same test plan of patch 1

Timing test running web installer, marc21,
all sample data, time in seconds

a) without patch
structure   data
59.766.5
58.666.0

b) SQL::SplitStatement (patch 1+2)
59.4101
59.7102

c) DBIx::RunSQL (patch 3)
60.766.8
59.466.2

Tomas' version is a bit slower loading sample data,
all give similar results processing kohastructure.

New dependency to package: DBIx::RunSQL

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #20 from Chris Cormack  ---
It works, but a new dependency eh? We need to update that too.

I've attached it as a signed off patch, but will let the RM and others decide
if they want to add the new dependency.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Chris Cormack  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #19 from Chris Cormack  ---
OOhhh, that sounds a lot better, I'll test it out

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #18 from Bernardo Gonzalez Kriegel  ---
Created attachment 51607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51607=edit
Bug 13669: (alternative) use DBIx::RunSQL

Alternative POC solution, on top of
previous patches, feel free to obsolte.

This patch use DBIx::RunSQL->run_sql_file
to procees each sql file.

To test:
1) Apply all patches
2) Same test plan of patch 1

Timing test running web installer, marc21,
all sample data, time in seconds

a) without patch
structure   data
59.766.5
58.666.0

b) SQL::SplitStatement (patch 1+2)
59.4101
59.7102

c) DBIx::RunSQL (patch 3)
60.766.8
59.466.2

Tomas' version is a bit slower loading sample data,
all give similar results processing kohastructure.

New dependency to package: DBIx::RunSQL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #17 from Chris Cormack  ---
This works, but it is slow, I think that is ok though, as you only run the web
installer once :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Chris Cormack  changed:

   What|Removed |Added

  Attachment #51599|0   |1
is obsolete||

--- Comment #16 from Chris Cormack  ---
Created attachment 51601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51601=edit
Bug 13669: (followup) Fix kohastructure.sql so FK dependencies are sorted

The current table creation order is left to mysql's strategy, which is not
suitable for parsing the SQL files and passing one statement at a time in
the current order.

This patch just moves table creation statements around so FK constraints are
defined for previously created tables.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Chris Cormack  changed:

   What|Removed |Added

  Attachment #51598|0   |1
is obsolete||

--- Comment #15 from Chris Cormack  ---
Created attachment 51600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51600=edit
Bug 13669: Use perl to load SQL statements from sample data

This patch changes C4::Installer::load_sql so it uses File::Slurp [1] to read
the SQL files, and SQL::SplitStatement to extract the statements from the full
SQL
file so they can be passed to $dbh->do.

To test:
- On Mysql 5.5, run the webinstaller
=> SUCCESS: Everything works as expected
- Apply the patch
- Run
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> SUCCESS: Everything works as expected
- On Mysql 5.6+ (5.7 is implied)
- Run
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> FAIL: It cannot load the sql files due to a password-in-command-line error
- Apply the patch
- Make sure everything is clean (it should):
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> SUCCESS: EVerything works as expected
- Sign off :-D

[1] Note: This is a POC patch, in the sense that it does the job, fixes a nasty
problem
but using File::Slurp to load the SQL files in memory comes with a big runtime
penalty.
You will notice the install procedure is now much slower, for instance.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #14 from Tomás Cohen Arazi  ---
Created attachment 51599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51599=edit
Bug 13669: (followup) Fix kohastructure.sql so FK dependencies are sorted

The current table creation order is left to mysql's strategy, which is not
suitable for parsing the SQL files and passing one statement at a time in
the current order.

This patch just moves table creation statements around so FK constraints are
defined for previously created tables.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #51597|0   |1
is obsolete||

--- Comment #13 from Tomás Cohen Arazi  ---
Created attachment 51598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51598=edit
Bug 13669: Use perl to load SQL statements from sample data

This patch changes C4::Installer::load_sql so it uses File::Slurp [1] to read
the SQL files, and SQL::SplitStatement to extract the statements from the full
SQL
file so they can be passed to $dbh->do.

To test:
- On Mysql 5.5, run the webinstaller
=> SUCCESS: Everything works as expected
- Apply the patch
- Run
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> SUCCESS: Everything works as expected
- On Mysql 5.6+ (5.7 is implied)
- Run
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> FAIL: It cannot load the sql files due to a password-in-command-line error
- Apply the patch
- Make sure everything is clean (it should):
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> SUCCESS: EVerything works as expected
- Sign off :-D

[1] Note: This is a POC patch, in the sense that it does the job, fixes a nasty
problem
but using File::Slurp to load the SQL files in memory comes with a big runtime
penalty.
You will notice the install procedure is now much slower, for instance.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #51596|0   |1
is obsolete||

--- Comment #12 from Tomás Cohen Arazi  ---
Created attachment 51597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51597=edit
Bug 13669: Use perl to load SQL statements from sample data

This patch changes C4::Installer::load_sql so it uses File::Slurp [1] to read
the SQL files, and SQL::SplitStatement to extract the statements from the full
SQL
file so they can be passed to $dbh->do.

To test:
- On Mysql 5.5, run the webinstaller
=> SUCCESS: Everything works as expected
- Apply the patch
- Run
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> SUCCESS: Everything works as expected
- On Mysql 5.6+ (5.7 is implied)
- Run
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> FAIL: It cannot load the sql files due to a password-in-command-line error
- Apply the patch
- Make sure everything is clean (it should):
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> SUCCESS: EVerything works as expected
- Sign off :-D

[1] Note: This is a POC patch, in the sense that it does the job, fixes a nasty
problem
but using File::Slurp to load the SQL files in memory comes with a big runtime
penalty.
You will notice the install procedure is now much slower, for instance.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #11 from Tomás Cohen Arazi  ---
Created attachment 51596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51596=edit
Bug 13669: Use perl to load SQL statements from sample data

This patch changes C4::Installer::load_sql so it uses File::Slurp [1] to read
the SQL files, and SQL::SplitStatement to extract the statements from the full
SQL
file so they can be passed to $dbh->do.

To test:
- On Mysql 5.5, run the webinstaller
=> SUCCESS: Everything works as expected
- Apply the patch
- Run
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> SUCCESS: Everything works as expected
- On Mysql 5.6+ (5.7 is implied)
- Run
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> FAIL: It cannot load the sql files due to a password-in-command-line error
- Apply the patch
- Make sure everything is clean (it should):
  $ mysql -uroot
  > DROP DATABASE koha_kohadev ; CREATE DATABASE koha_kohadev;
- Run the webinstaller
=> SUCCESS: EVerything works as expected
- Sign off :-D

[1] Note: This is a POC patch, in the sense that it does the job, fixes a nasty
problem
but using File::Slurp to load the SQL files in memory comes with a big runtime
penalty.
You will notice the install procedure is now much slower, for instance.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

--- Comment #10 from Jonathan Druart  
---
It seems that using MySQL v5.7, the web installer fails on step 3 with "using a
password on command line interface can be insecure".
I don't think we can fix that modifying Koha code.
I think we should remove the password from the command line execute in
C4::Installer::load_sql and let the administrators set a config file containing
the password.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Web installer fails to load sample data on MySQL 5.6+

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Tomás Cohen Arazi  changed:

   What|Removed |Added

Summary|Web installer fails on  |Web installer fails to load
   |MySQL 5.6 and .7|sample data on MySQL 5.6+

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/