[Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 Mason James m...@kohaaloha.com changed: What|Removed |Added Keywords|rel_3_16_candidate | --- Comment #11 from Mason James m...@kohaaloha.com --- Pushed to 3.16.x, will be in 3.16.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 Mason James m...@kohaaloha.com changed: What|Removed |Added CC||m...@kohaaloha.com Keywords||rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #9 from Tomás Cohen Arazi tomasco...@gmail.com --- Patches pushed to master. Thanks Katrina and Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #10 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.18.x will be in 3.18.5 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #36126|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 36165 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36165action=edit Bug 13746: On creating a new subscription, notes fields get confused For every subscription we have 4 notes fields in Koha, 2 are in the subscription itself and another 2 are in the subscription history. When creating a new subscription, the notes fields from the subscription get copied to the fields of the subscription history, leading to doubled up display of notes in the OPAC. To test: - Add a new subscription without patch - check manual history - Fill in both notes fields - Verify that the notes fields got also saved into the subscription history (easy from the Summary tab) - Apply patch - Add another subscription, like above - Verify now only the subscription notes fields are saved - Edit subscription and notes - verify all is ok - Edit subscription history (Planning tab) - verify all is ok Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 36166 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36166action=edit Bug 13746: Add tests Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 Brendan Gallagher bren...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 Brendan Gallagher bren...@bywatersolutions.com changed: What|Removed |Added Attachment #36116|0 |1 is obsolete|| --- Comment #6 from Brendan Gallagher bren...@bywatersolutions.com --- Created attachment 36126 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36126action=edit Bug 13746: On creating a new subscription, notes fields get confused For every subscription we have 4 notes fields in Koha, 2 are in the subscription itself and another 2 are in the subscription history. When creating a new subscription, the notes fields from the subscription get copied to the fields of the subscription history, leading to doubled up display of notes in the OPAC. To test: - Add a new subscription without patch - check manual history - Fill in both notes fields - Verify that the notes fields got also saved into the subscription history (easy from the Summary tab) - Apply patch - Add another subscription, like above - Verify now only the subscription notes fields are saved - Edit subscription and notes - verify all is ok - Edit subscription history (Planning tab) - verify all is ok Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 Brendan Gallagher bren...@bywatersolutions.com changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m --- Comment #4 from Brendan Gallagher bren...@bywatersolutions.com --- Katrin - I feel like I've seen this before but described a little bit differently. I am looking for a similar bug (I haven't found it yet). I think I've seen language like - manual history fails. (no comment for new direction on the unit tests). If I do not find a similar bug then I'll be glad to test this. Of course any enlightenment for me is always welcome. Cheers, Brendan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Brendan, this is just for the note fields - the less complicated part of the self-updating history. I have seen some other things while testing in the issue related fields, but haven't looked into it yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- All existing tests pass with the change. Not sure about new unit tests - could someone suggest what would be good to test here? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 --- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 36116 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36116action=edit Bug 13746: On creating a new subscription, notes fields get confused For every subscription we have 4 notes fields in Koha, 2 are in the subscription itself and another 2 are in the subscription history. When creating a new subscription, the notes fields from the subscription get copied to the fields of the subscription history, leading to doubled up display of notes in the OPAC. To test: - Add a new subscription without patch - check manual history - Fill in both notes fields - Verify that the notes fields got also saved into the subscription history (easy from the Summary tab) - Apply patch - Add another subscription, like above - Verify now only the subscription notes fields are saved - Edit subscription and notes - verify all is ok - Edit subscription history (Planning tab) - verify all is ok -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13746] On creating a new subscription, notes fields get confused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13746 --- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Database fields are: Subscription subscription.notes (public) subscription.internalnotes (internal) Subscription history subscriptionhistory.opacnote (public) subscripitonhistory.librariannote (internal) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
