[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #15 from Lucas Gass  ---
backported to 18.05.x for 18.05.12

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Pushed to Master|Pushed to Stable

--- Comment #14 from Martin Renvoize  ---
Pushed to 18.11.x for 18.11.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com

--- Comment #13 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86745|0   |1
is obsolete||

--- Comment #11 from Josef Moravec  ---
Created attachment 86818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86818=edit
Bug 13763: Added check for filter syspref in renew.pl

In Circulation->Renew, the renew feature does not check the system
preference itemBarcodeFilter to see whether the barcode needs to be
converted. This patch fixes this, adding a check for the system pref and
applying it accordingly to convert the barcode if it is needed.

Test plan:
1) In Circulation->Renew, enter a barcode that you know exists in the
catalogue but add extra spaces, breaking up the barcode. Note that this
fails with a warning that says 'No item matches this barcode'

2) In system Preferences, set the itemBarcodeInputFilter pref to Remove
spaces and repeat step1. Note that the result is the same as in step 1

3) Apply the patch

4) Repeat step 1, and note that the filter removes the spaces and the
item is renewed (or gives an error that indicates it recognises the
barcode)

Sponsored-by: Catalyst IT
Signed-off-by: Bin Wen 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763

--- Comment #12 from Josef Moravec  ---
Created attachment 86819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86819=edit
Bug 13763: (follow-up) Strip leading whitespace characters from input barcode

this makes the work with barcodes from input consistant on checking out,
 checking in and renewing

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com
 QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763

Hayley Mapley  changed:

   What|Removed |Added

 Status|Passed QA   |Signed Off

--- Comment #10 from Hayley Mapley  ---
(In reply to Bin from comment #9)
> Created attachment 86745 [details] [review]
> Bug 13763: Added check for filter syspref in renew.pl
> 
> In Circulation->Renew, the renew feature does not check the system
> preference itemBarcodeFilter to see whether the barcode needs to be
> converted. This patch fixes this, adding a check for the system pref and
> applying it accordingly to convert the barcode if it is needed.
> 
> Test plan:
> 1) In Circulation->Renew, enter a barcode that you know exists in the
> catalogue but add extra spaces, breaking up the barcode. Note that this
> fails with a warning that says 'No item matches this barcode'
> 
> 2) In system Preferences, set the itemBarcodeInputFilter pref to Remove
> spaces and repeat step1. Note that the result is the same as in step 1
> 
> 3) Apply the patch
> 
> 4) Repeat step 1, and note that the filter removes the spaces and the
> item is renewed (or gives an error that indicates it recognises the
> barcode)
> 
> Sponsored-by: Catalyst IT
> Signed-off-by: Bin Wen 

Thanks again for testing! I'll change the status to Signed Off so it'll get
picked up by the QA team :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763

Bin  changed:

   What|Removed |Added

  Attachment #86594|0   |1
is obsolete||

--- Comment #9 from Bin  ---
Created attachment 86745
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86745=edit
Bug 13763: Added check for filter syspref in renew.pl

In Circulation->Renew, the renew feature does not check the system
preference itemBarcodeFilter to see whether the barcode needs to be
converted. This patch fixes this, adding a check for the system pref and
applying it accordingly to convert the barcode if it is needed.

Test plan:
1) In Circulation->Renew, enter a barcode that you know exists in the
catalogue but add extra spaces, breaking up the barcode. Note that this
fails with a warning that says 'No item matches this barcode'

2) In system Preferences, set the itemBarcodeInputFilter pref to Remove
spaces and repeat step1. Note that the result is the same as in step 1

3) Apply the patch

4) Repeat step 1, and note that the filter removes the spaces and the
item is renewed (or gives an error that indicates it recognises the
barcode)

Sponsored-by: Catalyst IT
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763

Bin  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

--- Comment #8 from Bin  ---
Sorry, I found that I made a wrong step in my understanding. There is no
problem with the patch and test plan, which worked well！

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763

Hayley Mapley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #7 from Hayley Mapley  ---
(In reply to Bin from comment #6)
> (In reply to Hayley Mapley from comment #5)
> > (In reply to Bin from comment #4)
> > > After applying the patch, it is still invalid
> > 
> > Hi Bin,
> > 
> > Can you please describe what you did, and what was the result?
> 
> I followed the test plan:
> 
> Test plan:
> 1) In Circulation->Renew, enter a barcode that you know exists in the
> catalogue but add extra spaces, breaking up the barcode. Note that this
> fails with a warning that says 'No item matches this barcode'
> 
> 2) In system Preferences, set the itemBarcodeFilter pref to Remove
> spaces and repeat step1. Note that the result is the same as in step 1
> 
> 3) Apply the patch
> 
> but still failed with a warning that said 'No item matches this barcode'

Thanks for testing! 
It still works for me, would you mind verifying that after applying the patch
you restarted memcached and plack (I use restart_all) and that the barcode you
are trying to test actually exists? For example, my test barcode was TEST1
and I entered it as 'TE ST 11 111' with the system preference set to 'Remove
spaces from'. This worked for me, I'm just trying to understand why it hasn't
worked for you.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763

--- Comment #6 from Bin  ---
(In reply to Hayley Mapley from comment #5)
> (In reply to Bin from comment #4)
> > After applying the patch, it is still invalid
> 
> Hi Bin,
> 
> Can you please describe what you did, and what was the result?

I followed the test plan:

Test plan:
1) In Circulation->Renew, enter a barcode that you know exists in the
catalogue but add extra spaces, breaking up the barcode. Note that this
fails with a warning that says 'No item matches this barcode'

2) In system Preferences, set the itemBarcodeFilter pref to Remove
spaces and repeat step1. Note that the result is the same as in step 1

3) Apply the patch

but still failed with a warning that said 'No item matches this barcode'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763

--- Comment #5 from Hayley Mapley  ---
(In reply to Bin from comment #4)
> After applying the patch, it is still invalid

Hi Bin,

Can you please describe what you did, and what was the result?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763

--- Comment #4 from Bin  ---
After applying the patch, it is still invalid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763

Bin  changed:

   What|Removed |Added

 CC||bin@inlibro.com

--- Comment #3 from Bin  ---
After applying the patch, it is still invalid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763

--- Comment #2 from Hayley Mapley  ---
Created attachment 86594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86594=edit
Bug 13763: Added check for filter syspref in renew.pl

In Circulation->Renew, the renew feature does not check the system
preference itemBarcodeFilter to see whether the barcode needs to be
converted. This patch fixes this, adding a check for the system pref and
applying it accordingly to convert the barcode if it is needed.

Test plan:
1) In Circulation->Renew, enter a barcode that you know exists in the
catalogue but add extra spaces, breaking up the barcode. Note that this
fails with a warning that says 'No item matches this barcode'

2) In system Preferences, set the itemBarcodeFilter pref to Remove
spaces and repeat step1. Note that the result is the same as in step 1

3) Apply the patch

4) Repeat step 1, and note that the filter removes the spaces and the
item is renewed (or gives an error that indicates it recognises the
barcode)

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763

Hayley Mapley  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763

Hayley Mapley  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |hayleymap...@catalyst.net.n
   |ity.org |z
 Status|NEW |ASSIGNED
 CC||hayleymap...@catalyst.net.n
   ||z

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763

Owen Leonard  changed:

   What|Removed |Added

Version|3.16|master

--- Comment #1 from Owen Leonard  ---
Still valid in master.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/