[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system - first steps
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Nick Clemens changed: What|Removed |Added Blocks||16550 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16550 [Bug 16550] Can't set opac news expiration date to NULL, it reverts to today -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system - first steps
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Katrin Fischer changed: What|Removed |Added Blocks||15939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15939 [Bug 15939] modification logs view now silently defaults to only current day's actions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system - first steps
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Katrin Fischer changed: What|Removed |Added Summary|Remove deprecated module|Remove deprecated module |C4::Dates from system |C4::Dates from system - ||first steps -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #173 from Katrin Fischer --- I think last comment is fixed with bug 15090. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=15090 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813
--- Comment #172 from Jonathan Druart
---
Comment on attachment 42292
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42292
Bug 13813: Remove deprecated module C4::Dates from system
Review of attachment 42292:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13813&attachment=42292)
-
::: C4/Suggestions.pm
@@ +179,5 @@
> my $to = $field . "_to";
> if ( $suggestion->{$from} || $suggestion->{$to} ) {
> push @query, qq{ AND suggestions.$field BETWEEN ? AND ? };
> push @sql_params,
> + output_pref({ dt => dt_from_string( $suggestion->{$from} ),
> dateformat => 'iso', dateonly => 1 }) || '-00-00';
This is wrong. Please provide a follow-up.
Before this patch the "from" date was -00-00 if not filled, now it's today.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron changed: What|Removed |Added See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7899 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14873 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron changed: What|Removed |Added Blocks|12072 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 [Bug 12072] New dateformat dd.mm. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14870 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #171 from Tomás Cohen Arazi --- Patches pushed to master. Thanks Marc! Clean it aall! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Tomás Cohen Arazi changed: What|Removed |Added Severity|normal |enhancement CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #42286|0 |1 is obsolete|| --- Comment #168 from Marcel de Rooy --- Created attachment 42293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42293&action=edit Bug 13813 - Remove deprecated module C4::Dates from system Changes for QA comment #165 circ/transferstoreceive.pl 'iso' added circ/waitingreserves.pl 'iso' added members/printinvoice.pl 'iso' removed Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #169 from Marcel de Rooy --- Created attachment 42294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42294&action=edit Bug 13813: [QA Follow-up] Fix some tabs for qa tools FAIL C4/Barcodes/annual.pm FAIL forbidden patterns forbidden pattern: tab char (line 86) forbidden pattern: tab char (line 51) FAIL C4/Barcodes/hbyymmincr.pm FAIL forbidden patterns forbidden pattern: tab char (line 108) forbidden pattern: tab char (line 78) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #170 from Marcel de Rooy --- Looks good to me now. Did a full code review twice: found some small issues in both rounds. Tested only some locations in the interface with all three settings of dateformat. Added a follow-up to satisfy qa tools (trivial tabs). This kind of change needs some broader exposure by an early push. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #42274|0 |1 is obsolete|| --- Comment #167 from Marcel de Rooy --- Created attachment 42292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42292&action=edit Bug 13813: Remove deprecated module C4::Dates from system Test plan: See Bugzilla. Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #166 from Marc Véron --- Created attachment 42286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42286&action=edit [Follow-up] Bug 13813 - Remove deprecated module C4::Dates from system Changes for QA comment #165 circ/transferstoreceive.pl 'iso' added circ/waitingreserves.pl 'iso' added members/printinvoice.pl 'iso' removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #165 from Marcel de Rooy ---
Second QA round:
circ/transferstoreceive.pl
-show_date=> format_date(C4::Dates->today('iso')),
+show_date=> output_pref({ dt => dt_from_string, dateonly => 1 }),
No iso? Probably I did not catch this one in the first round :)
circ/waitingreserves.pl
-show_date => format_date(C4::Dates->today('iso')),
+show_date => output_pref({ dt => dt_from_string, dateonly => 1 }),
Same.
members/printinvoice.pl
You did still include this line, as marked in the "first round".
FQA
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813
Marcel de Rooy changed:
What|Removed |Added
Attachment #37810|0 |1
is obsolete||
--- Comment #164 from Marcel de Rooy ---
Comment on attachment 37810
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37810
temporary tests
I ran this test, but it failed.
Illegal date specified (year = 2014, month = 31, day = 01) at dates_compare.t
line 17
The 'month' parameter ("31") to DateTime::new did not pass the 'an integer
between 1 and 12' callback
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37885|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37878|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37875|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #163 from Marcel de Rooy --- Created attachment 42274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42274&action=edit Bug 13813: Remove deprecated module C4::Dates from system Test plan: See Bugzilla. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37880|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37872|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37886|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37882|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37879|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37871|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37874|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Patch complexity|Large patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37876|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37870|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37869|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37860|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37866|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37867|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37865|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37862|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37859|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37861|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #42052|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37858|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37855|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37857|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #40894|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37856|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37854|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37888|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #42175|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #39666|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Attachment #37891|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #162 from Marc Véron --- Created attachment 42175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42175&action=edit [Follow-up] Bug 13813 - Remove C4::Dates from C4/Items.pm Fixed missing character (see comment #150) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron changed: What|Removed |Added Attachment #37889|0 |1 is obsolete|| --- Comment #161 from Marc Véron --- Comment on attachment 37889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37889 Bug 13813 - (follow-up) Remove C4::Dates from C4/Members.pm Removed - will be done in "second round" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron changed: What|Removed |Added Attachment #37877|0 |1 is obsolete|| --- Comment #160 from Marc Véron --- Comment on attachment 37877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37877 Bug 13813 - Remove C4::Dates from C4/Members.pm Removed - Will be done in "second round" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron changed: What|Removed |Added Attachment #37890|0 |1 is obsolete|| --- Comment #158 from Marc Véron --- Comment on attachment 37890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37890 Bug 13813 - (follow-up) Remove C4::Dates from circ/bookcount.pl Removed - will be done in "second round" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron changed: What|Removed |Added Attachment #37863|0 |1 is obsolete|| --- Comment #159 from Marc Véron --- Comment on attachment 37863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37863 Bug 13813 - Remove C4::Dates from C4/VirtualShelves/Page.pm Removed - Will be done in "second round" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron changed: What|Removed |Added Attachment #37864|0 |1 is obsolete|| --- Comment #157 from Marc Véron --- Comment on attachment 37864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37864 Bug 13813 - Remove C4::Dates from circ/bookcount.pl Removed - will be done in "second round" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron changed: What|Removed |Added Attachment #37881|0 |1 is obsolete|| --- Comment #156 from Marc Véron --- Comment on attachment 37881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37881 Bug 13813 - Remove C4::Dates from members/moremember.pl Removed - will be done in "second round" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron changed: What|Removed |Added Attachment #37887|0 |1 is obsolete|| --- Comment #155 from Marc Véron --- Comment on attachment 37887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37887 Bug 13813 - Remove C4::Dates from members/printfeercpt.pl Removed - will be done in "second round" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron changed: What|Removed |Added Attachment #37853|0 |1 is obsolete|| --- Comment #154 from Marc Véron --- Comment on attachment 37853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37853 Bug 13813 - Remove deprecated C4::Dates from opac/opac-showreviews.pl Removed - Will be done in "second round" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #153 from Marcel de Rooy --- (In reply to Marc Véron from comment #152) > Hi Marcel, > > Thanks a lot for QAing. I really appreciate. > > Question: > Can we remove the 'problematic' patches from this huge patch set and then do > a second round (maybe with a new bug number) after the 'unproblematic' > patches have been pushed? > > Marc It seems to that your corrections should not be that hard or time consuming. I would favor to reduce the number of patches here. There is no particular need to add a patch for each module or script. But of course, I have no objection if you move some patches elsewhere. Please set back to SO if you are ready.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #152 from Marc Véron --- Hi Marcel, Thanks a lot for QAing. I really appreciate. Question: Can we remove the 'problematic' patches from this huge patch set and then do a second round (maybe with a new bug number) after the 'unproblematic' patches have been pushed? Marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #151 from Marc Véron --- Created attachment 42052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42052&action=edit Bug 13813 - [Follow-up] Remove C4::Dates from C4/Acquisition.pm Fix badly merged lines in C4/Acquisition.pm See comments #146-149 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813
--- Comment #150 from Marcel de Rooy ---
Apart from the previous question, here are the results of the Dutch jury:
=head2 DelItem
@@ -2128,7 +2128,7 @@ C
sub _set_defaults_for_add {
my $item = shift;
-$item->{dateaccessioned} ||= C4::Dates->new->output('iso');
+$item->{dateaccessioned} || output_pref({ dt => dt_from_string, dateformat
=> 'iso', dateonly => 1 });
$item->{$_} ||= 0 for (qw( notforloan damaged itemlost withdrawn));
}
OOPS: You lost an important character || instead of ||= !!!
C4/Members: $data->{message_date_formatted} = $d->output; [ no longer added ]
GetMessages
Not sure if you also resolved all calls of this sub accordingly.
Could you confirm?
C4/VirtualShelves
-$this_item->{'dateadded'} = format_date(
$this_item->{'dateadded'} );
+$this_item->{'dateadded'} = output_pref({ dt =>
dt_from_string( $this_item->{'dateadded'} ), dateformat => 'iso', dateonly => 1
});
No iso ?
circ.bookcount
-lastdate=> $lastdate ? format_date($lastdate) : 0,
+lastdate=> $lastdate ? output_pref({ dt => dt_from_string(
$lastdate, 'iso' ), dateonly => 1 }) : 0,
No iso?
-format_date($date),
+output_pref({ dt => dt_from_string( $date, 'iso' ), dateonly => 1 }),
Again.
moremember
+$template->param( 'userdebarreddate' => output_pref({ dt =>
dt_from_string( $debar, 'iso' ), dateonly => 1 }) );
Looks different
members/printfeercpt.pl
-my %row = ( 'date' => format_date($accts->[$i]{'date'}),
+my %row = ( 'date' => output_pref({ dt => dt_from_string(
$accts->[$i]{'date'}, 'iso' ), dateonly => 1 }),
No iso?
members/printinvoice.pl
Again
opac-showreviews.pl
+timestamp => strftime("%Y-%m-%dT%H:%M:%S-00:00", gmtime),
Could you confirm this is the same as rfc822
Since I see it more, would this be something for the KohaDates module too ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #149 from Jonathan Druart --- (In reply to Jonathan Druart from comment #148) > It should be > > -use C4::Dates qw(format_date format_date_in_iso); > -use MARC::Record; > > :) Well no, it should be -use C4::Dates qw(format_date format_date_in_iso); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #148 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #146) > Marc: Why do you add MARC::Record in Acquisition.pm? It's a bad merge conflict, in the local branch I have, there is only -use C4::Dates qw(format_date format_date_in_iso); use MARC::Record; Now there is use C4::Dates qw(format_date format_date_in_iso); +use MARC::Record; It should be -use C4::Dates qw(format_date format_date_in_iso); -use MARC::Record; :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #147 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #145) > (In reply to Marc Véron from comment #144) > > Still applies. > > Still blocks Bug 12072: New dateformat dd.mm. > > Will have a look now. But the number of patches here is scary.. > Do not know if I can finish this in one session. It's almost always the same changes. See comments 134-136 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #146 from Marcel de Rooy --- Marc: Why do you add MARC::Record in Acquisition.pm? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #145 from Marcel de Rooy --- (In reply to Marc Véron from comment #144) > Still applies. > Still blocks Bug 12072: New dateformat dd.mm. Will have a look now. But the number of patches here is scary.. Do not know if I can finish this in one session. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #144 from Marc Véron --- Still applies. Still blocks Bug 12072: New dateformat dd.mm. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron changed: What|Removed |Added Attachment #37873|0 |1 is obsolete|| --- Comment #143 from Marc Véron --- Created attachment 40894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40894&action=edit Bug 13813 - Remove C4::Dates from circ/circ/transferstoreceive.pl To test: Go to Home > Circulation > Transfers to your library (Circulation Reports - Transfers to receive) Verify that date in page title appears correcty Amendend following comment #58 /MV Signed-off-by: Jonathan Druart It ssemed that the amendent did not work out. Amended again following comment #58 / MV -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron changed: What|Removed |Added Attachment #37868|0 |1 is obsolete|| --- Comment #142 from Marc Véron --- Comment on attachment 37868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37868 Bug 13813 - Remove superfluous use 'C4::Dates' from opac/opac-ratings.pl Obsoleted because int hte meantime the line use C4::Dates qw(format_date) was removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron changed: What|Removed |Added Patch complexity|Trivial patch |Large patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #141 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #140) > The number of patches this report touches does not justify the trivial patch > status imo btw.. patches -> files OR touches -> includes :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Signed Off |Patch doesn't apply --- Comment #140 from Marcel de Rooy --- The number of patches this report touches does not justify the trivial patch status imo btw.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron changed: What|Removed |Added Depends on|13601 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron changed: What|Removed |Added Attachment #37883|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc Véron changed: What|Removed |Added Attachment #37884|0 |1 is obsolete|| --- Comment #139 from Marc Véron --- Created attachment 39666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39666&action=edit Bug 13813 - Remove C4::Dates from C4/Acquisition.pm This patch removes depraceted C4::Dates from C4/Acquisition.pm To test: Apply patch Go to Home > Acquisitions Verify that receiving orders works as before (Receiving orders only affected by this patch) Amended because of mistake (otputpref should be dateformat), see comment #57/ MV Amended because of "use Koha::DateUtils;" instead of original, See comment #59 /MV Amended following comment #58 Signed-off-by: Jonathan Druart Amended to resolv conflict while applying / MV -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #138 from Marc Véron --- Patches still apply on current master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #137 from Marc Véron --- (In reply to Jonathan Druart from comment #135) > Something else: I did not try but... C4::Dates was (is) very efficient to > format a date from an iso date. > Now we have to call dt_from_string and output_pref. > Maybe we should introduce a new subroutine without calls to DateTime to do > this job. I was thinking about adding new functions to Koha::DateUtils mostly to streamline the transition process to Koha::DateUtils (easier and more human readable calls) but I was afraid that that would slow down the changes. (I'm eager to get Bug 12072 resolved.) I think if calls to dt_from_string and output_pref turn up to be to time costly e.g. in big loops we can resolve this in a follow up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813
--- Comment #136 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #135)
> Something else: I did not try but... C4::Dates was (is) very efficient to
> format a date from an iso date.
> Now we have to call dt_from_string and output_pref.
> Maybe we should introduce a new subroutine without calls to DateTime to do
> this job.
% more t.pl
use C4::Dates qw(format_date);
my $iso_date = '2015-04-10 09:30:03';
for ( 1 .. 1 ) {
format_date($iso_date);
}
% time perl t.pl
perl t.pl 0.78s user 0.01s system 99% cpu 0.795 total
% time perl t.pl
perl t.pl 0.74s user 0.01s system 99% cpu 0.749 total
% time perl t.pl
perl t.pl 0.71s user 0.02s system 99% cpu 0.735 total
% more t.pl
use Koha::DateUtils;
my $iso_date = '2015-04-10 09:30:03';
for ( 1 .. 1 ) {
output_pref({ dt => dt_from_string( $iso_date, 'iso' ), dateonly => 1 });
}
% time perl t.pl
perl t.pl 2.40s user 0.02s system 100% cpu 2.424 total
% time perl t.pl
perl t.pl 2.42s user 0.02s system 99% cpu 2.442 total
% time perl t.pl
perl t.pl 2.43s user 0.01s system 100% cpu 2.439 total
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #135 from Jonathan Druart --- Something else: I did not try but... C4::Dates was (is) very efficient to format a date from an iso date. Now we have to call dt_from_string and output_pref. Maybe we should introduce a new subroutine without calls to DateTime to do this job. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813
--- Comment #134 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #93)
> Comment on attachment 36900 [details] [review]
> Bug 13813 - Remove C4::Dates from tools/koha-news.pl
>
> Review of attachment 36900 [details] [review]:
> -
>
> ::: tools/koha-news.pl
> @@ +40,5 @@
> > my $id = $cgi->param('id');
> > my $title = $cgi->param('title');
> > my $new= $cgi->param('new');
> > +my $expirationdate = output_pref({ dt => dt_from_string(
> > $cgi->param('expirationdate') ), dateformat => 'iso', dateonly => 1 });
> > +my $timestamp = output_pref({ dt => dt_from_string(
> > $cgi->param('timestamp') ), dateformat => 'iso', dateonly => 1 });
>
> Not sure about this but it does not seem to break anything.
For QAer, have a look at this. I don't see the timestamp param set in the
template.
On the list view, before the patch, I got:
koha-news.pl: Usage: POSIX::strftime(fmt, sec, min, hour, mday, mon, year, wday
= -1, yday = -1, isdst = -1) at /home/koha/src/C4/Dates.pm line 187.
koha-news.pl:...caught at /home/koha/src/tools/koha-news.pl line 45.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #130 from Jonathan Druart --- Created attachment 37889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37889&action=edit Bug 13813 - (follow-up) Remove C4::Dates from C4/Members.pm message_date_formatted is only used once in the template. Previous patch does not formatted correctly the date (was in iso). The easier for me was to use the KohaDates TT plugin Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813
Jonathan Druart changed:
What|Removed |Added
Attachment #37842|0 |1
is obsolete||
--- Comment #128 from Jonathan Druart ---
Created attachment 37887
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37887&action=edit
Bug 13813 - Remove C4::Dates from members/printfeercpt.pl
To test:
Apply patch
Go to a patrons Account
In table of fines / transactions, column 'Print', click on 'Print' of a payment
transaction ("Payment, thanks")
Verify that the date displays correctly on the receipt.
Amended for proper input for dt_from_string - (is 'iso')
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What|Removed |Added Attachment #37840|0 |1 is obsolete|| --- Comment #127 from Jonathan Druart --- Created attachment 37886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37886&action=edit Bug 13813 - Remove C4::Dates from members/readingrec.pl This patch removes depraceted C4::Dates from members/readingrec.pl To test: Apply patch Go to a patron's cirulation history Verify that circulation history behaves as before. Amended following comment #58 /MV Amended to fix output_pref (dateonly added) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #131 from Jonathan Druart --- Created attachment 37890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37890&action=edit Bug 13813 - (follow-up) Remove C4::Dates from circ/bookcount.pl Previous patch was wrong for the lastdate format. We want a date formatted following the syspref value, not an iso formatted date. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What|Removed |Added Attachment #37828|0 |1 is obsolete|| --- Comment #126 from Jonathan Druart --- Created attachment 37885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37885&action=edit Bug 13813 - Remove C4::Dates from circ/waitingreserves.pl To test: Go to Home > Circulation > Holds awaiting pickup (Circulation Rports - Holds awaiting pickup) Verify that date in page title appears correcty Amended following comment #58 Changed output_pref to format 'iso' Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What|Removed |Added Attachment #37843|0 |1 is obsolete|| --- Comment #129 from Jonathan Druart --- Created attachment 37888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37888&action=edit Bug 13813 - Remove C4::Dates from members/printinvoice.pl To test: Apply patch Go to a patrons Account In table of fines / transactions, column 'Print', click on 'Print' of a transaction Verify that the date displays correctly on the invoice. Amended for proper format in dt_from_string (is 'iso') Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #132 from Jonathan Druart --- Created attachment 37891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37891&action=edit Bug 13813: Fix compilation errors Bareword "dt_from_string" not allowed while "strict subs" in use Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #133 from Jonathan Druart --- To be honest, I did not check all pages. But looking at the code it should be all right now. I tried some pages and dates look correctly formatted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What|Removed |Added Attachment #37767|0 |1 is obsolete|| --- Comment #123 from Jonathan Druart --- Created attachment 37882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37882&action=edit Bug 13813 - Remove C4::Dates from cataloguing/value_builder/barcode.pl To test: Set syspref autoBarcode to -001, -002 and yymm001 Edit items or add item, click in empty barcode field, verify that barcodes are filled in as appropriate. Amended following comment #58 /mv Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Jonathan Druart changed: What|Removed |Added Attachment #37770|0 |1 is obsolete|| --- Comment #125 from Jonathan Druart --- Created attachment 37884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37884&action=edit Bug 13813 - Remove C4::Dates from C4/Acquisition.pm This patch removes depraceted C4::Dates from C4/Acquisition.pm To test: Apply patch Go to Home > Acquisitions Verify that receiving orders works as before (Receiving orders only affected by this patch) Amended because of mistake (otputpref should be dateformat), see comment #57/ MV Amended because of "use Koha::DateUtils;" instead of original, See comment #59 /MV Amended following comment #58 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
