[Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create new fines with an amount outstanding of 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Status|Pushed to Master|Pushed to Stable --- Comment #10 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create new fines with an amount outstanding of 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tomás Cohen Arazi tomasco...@gmail.com --- Patches pushed to master. Nice one Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create new fines with an amount outstanding of 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841 Heather Braum hbr...@nekls.org changed: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create new fines with an amount outstanding of 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create new fines with an amount outstanding of 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #36964|0 |1 is obsolete|| Attachment #36965|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 37085 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37085action=edit [PASSED QA] Bug 13841 - Unit Test Signed-off-by: Jen DeMuth jdem...@roseville.ca.us Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create new fines with an amount outstanding of 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841 --- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 37086 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37086action=edit [PASSED QA] Bug 13841 - Returns via backdating or SIP2 can create new fines with an amount outstanding of 0 Due to the way AddReturn and UpdateFine work, if you pass in a return date to AddReturn, and that item has a calculated fine of 0, Koha will insert the 0 amount fine into accountlines. This is good behavior when we want to update an existing fine, but bad behavior if there was no fine to begin with! Test Plan: 1) Apply the unit test patch 2) prove t/db_dependent/Circulation.t 3) Note the test fails 4) Apply this patch 5) prove t/db_dependent/Circulation.t 6) Note the test passes Signed-off-by: Jen DeMuth jdem...@roseville.ca.us Signed-off-by: Katrin Fischer katrin.fischer...@web.de Confirmed the problem in the staff interface and that the patch fixes it. Also tested that fines still get calculated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create new fines with an amount outstanding of 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create new fines with an amount outstanding of 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841 --- Comment #6 from Kyle M Hall k...@bywatersolutions.com --- I should note you can also test this by backdating a return to an hour before the current time. This will trigger the behavior and is more easily testable in a sandbox! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create new fines with an amount outstanding of 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841 sandbo...@biblibre.com sandbo...@biblibre.com changed: What|Removed |Added CC||sandbo...@biblibre.com Status|Needs Signoff |Signed Off --- Comment #3 from sandbo...@biblibre.com sandbo...@biblibre.com --- Patch tested with a sandbox, by Jen DeMuth jdem...@roseville.ca.us -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create new fines with an amount outstanding of 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841 --- Comment #5 from sandbo...@biblibre.com sandbo...@biblibre.com --- Created attachment 36965 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36965action=edit Bug 13841 - Returns via backdating or SIP2 can create new fines with an amount outstanding of 0 Due to the way AddReturn and UpdateFine work, if you pass in a return date to AddReturn, and that item has a calculated fine of 0, Koha will insert the 0 amount fine into accountlines. This is good behavior when we want to update an existing fine, but bad behavior if there was no fine to begin with! Test Plan: 1) Apply the unit test patch 2) prove t/db_dependent/Circulation.t 3) Note the test fails 4) Apply this patch 5) prove t/db_dependent/Circulation.t 6) Note the test passes Signed-off-by: Jen DeMuth jdem...@roseville.ca.us -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create new fines with an amount outstanding of 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841 --- Comment #4 from sandbo...@biblibre.com sandbo...@biblibre.com --- Created attachment 36964 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36964action=edit Bug 13841 - Unit Test Signed-off-by: Jen DeMuth jdem...@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create new fines with an amount outstanding of 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841 sandbo...@biblibre.com sandbo...@biblibre.com changed: What|Removed |Added Attachment #36930|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create new fines with an amount outstanding of 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841 sandbo...@biblibre.com sandbo...@biblibre.com changed: What|Removed |Added Attachment #36931|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create new fines with an amount outstanding of 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 36930 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36930action=edit Bug 13841 - Unit Test -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create new fines with an amount outstanding of 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create new fines with an amount outstanding of 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841 --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 36931 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36931action=edit Bug 13841 - Returns via backdating or SIP2 can create new fines with an amount outstanding of 0 Due to the way AddReturn and UpdateFine work, if you pass in a return date to AddReturn, and that item has a calculated fine of 0, Koha will insert the 0 amount fine into accountlines. This is good behavior when we want to update an existing fine, but bad behavior if there was no fine to begin with! Test Plan: 1) Apply the unit test patch 2) prove t/db_dependent/Circulation.t 3) Note the test fails 4) Apply this patch 5) prove t/db_dependent/Circulation.t 6) Note the test passes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create new fines with an amount outstanding of 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
