[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=6810

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #32 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Good job Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

--- Comment #30 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 38409
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38409action=edit
Bug 13889 [QA Followup] - Supress warning, set object column to undef instead
of 0

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

--- Comment #29 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 38408
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38408action=edit
[PASSED QA] Provide parameter $infos in cronlogaction() (Alternative for patch
Bug 13889: Log with parameters)

To test:

- Apply patches interactive and skip following patch:  Bug 13889: Log with
parameters
- Tweak a cron job in order to call cronlogaction twice, one with a param at
the beginning of the cron ob, e.g.
cronlogaction(This is my message) and one without param.
- Run this cron job.
Result: You should have two entries in the log, one with and one without
additional information after the path and name of the calling script.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

--- Comment #28 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 38407
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38407action=edit
[PASSED QA] Bug 13889: Added Test Coverage

Previous commit was lacking test coverage of new function.

TEST PLAN
-
1) Apply all the patches
2) prove -v t/db_dependent/Log.t
   -- should be success.
3) koha qa test tools

Signed-off-by: Marc Véron ve...@veron.ch

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #38229|0   |1
is obsolete||
  Attachment #38236|0   |1
is obsolete||
  Attachment #38239|0   |1
is obsolete||
  Attachment #38283|0   |1
is obsolete||

--- Comment #27 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 38406
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38406action=edit
[PASSED QA] Bug 13889 - Add information about cron jobs to system log

This patch adds information about cron jobs performed and make it viewable
under Home  Tools  Logs (Browse system logs)

To test:

Apply patch
- Got to system preferences and set 'CronjobLog' to:  [Log] information from
  cron jobs.
- Run some cron jobs
- Go to Home  Tools  Logs
- Verify that you have a selection 'Cron jobs' in drop-down 'Module'. Select it
  with Action All and Submit.
- Output should show Date/time and info about Cron jobs

Rebased to work on top of Bug 6911 (conflict in viewlog.tt)  /MV

Rebased after applying patch for Bug 6911 /MV
Conflicts resolved:
misc/cronjobs/overdue_notices.pl
misc/cronjobs/cleanup_database.pl

Signed-off-by: Frederic Demians f.demi...@tamil.fr
  - Merge both patches, and fix updatedatabase.pl
  - Works as described. Provide intersting feedback from cronjob scripts.

--
Modified version taking in account syspref CronJobLog. Handling simplified by
introducing a convenience sub cronlogaction in C4/Log.pm /MV
Amended to take in account comments #11, #12, #13 /MV

http://bugs.koha-community.org/show_bug.cgi?id=13899

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

--- Comment #31 from Jonathan Druart jonathan.dru...@biblibre.com ---
Kyle, Have you seen the discussion before? What's your opinion on it?
See from comment 22

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

--- Comment #21 from Marc Véron ve...@veron.ch ---
Created attachment 38236
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38236action=edit
[Signed-off] Bug 13889: Added Test Coverage

Previous commit was lacking test coverage of new function.

TEST PLAN
-
1) Apply all the patches
2) prove -v t/db_dependent/Log.t
   -- should be success.
3) koha qa test tools

Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

  Attachment #38230|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 CC||fridolyn.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

--- Comment #26 from Marc Véron ve...@veron.ch ---
Created attachment 38283
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38283action=edit
[Follow-up] Provide parameter $infos in cronlogaction() (Alternative for patch
Bug 13889: Log with parameters)

To test:

- Apply patches interactive and skip following patch:  Bug 13889: Log with
parameters
- Tweak a cron job in order to call cronlogaction twice, one with a param at
the beginning of the cron ob, e.g.
cronlogaction(This is my message) and one without param.
- Run this cron job.
Result: You should have two entries in the log, one with and one without
additional information after the path and name of the calling script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

--- Comment #24 from M. Tompsett mtomp...@hotmail.com ---
(In reply to Jonathan Druart from comment #23)
 (In reply to Jonathan Druart from comment #22)
  Created attachment 38239 [details] [review] [review]
  Bug 13889: Log with parameters
 
 Marc, What do you think of this patch?

-- I know I'm not Marc Véron, but I thought I'd chime in my like of that kind
of tweak with the parameters. However, you also moved it before a successful
start. If we have it before a successful start, then where will we record the
difference between the successful start or failure to start? A failure to log
when the cronjoblog is on, is an implied failure to start. And if we
distinguish between those two, why not a successful run as well? There's no
status column. Just some thoughts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

--- Comment #25 from Marc Véron ve...@veron.ch ---
(In reply to Jonathan Druart from comment #23)
 (In reply to Jonathan Druart from comment #22)
  Created attachment 38239 [details] [review] [review]
  Bug 13889: Log with parameters
 
 Marc, What do you think of this patch?

Jonatan, I like the idea. I was thinking about adding some more detailed
information to the action log before and I planned to expand it after this
patch set is pushed. 

First consideration:

With the patch, I have the following problem:

Call of cronlogaction() without param does not display the path:
2015-04-21 15:24:09 0 Cron jobs Run 0

Call of cronlogaction(join ' ', $0, @ARGV) displays the path and the params:
2015-04-21 15:24:09 0 Cron jobs Run 0
misc/cronjobs/overdue_notices.pl -n -csv 

IMO cronlogaction() (without param) should behave as before.

Second consideration: 

I think it would be better tho have a string as param and to prepend it with
caller(0))[1] or whatever it needs to display the script's name. 
(That is what I was planning as a next step.)

With a string param it is up to the logscript's author to decide what to
communicate in the logs (in a human readable form), e.g. not only the params
but their defaults as well if no params are passed.

That brings me to the third consideration: 

The original idea is that the log is written after all of the preconditions. If
the script dies before doing anything real, no log is written. Otherwise we
have an entry in the logs for a cronjob that was called but did not do
anything, and users think that everything is OK.

With the string param mentioned above the author of the log file then can use
logging for more sophisticated things (if necessary), e.g.

- cronlogaction(start)
- do the preconditions and log some information if it dies:
cronlogaction(fail: ..reason...)
- cronlogaction(execute with: ...intersting params / defaults...)
- cronlogaction(success) or cronlogaction(success: ...interesting
results...)

As a minimum, cronlogaction should be called as soon the script does the real
work (that's what my patches to the cronjobs do at the moment), in the sense of
Hi, I was here and did something

So I propose to add the string parameter and, for this first step, leave the
calls in the cron scripts as is.

What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Jonathan Druart from comment #22)
 Created attachment 38239 [details] [review]
 Bug 13889: Log with parameters

Marc, What do you think of this patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

--- Comment #22 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 38239
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38239action=edit
Bug 13889: Log with parameters

This patch proposes to log the cronjob filepath with the parameters.
On this way, we will get even more information.

Note that the @ARGV is modified by GetOptions and have to be put before.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

--- Comment #17 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38228
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38228action=edit
Bug 13889: Added Test Coverage

Previous commit was lacking test coverage of new function.

TEST PLAN
-
1) Apply all the patches
2) prove -v t/db_dependent/Log.t
   -- should be success.
3) koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #38183|0   |1
is obsolete||

--- Comment #16 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38227
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38227action=edit
Bug 13889 - Add information about cron jobs to system log

This patch adds information about cron jobs performed and make it viewable
under Home  Tools  Logs (Browse system logs)

To test:

Apply patch
- Got to system preferences and set 'CronjobLog' to:  [Log] information from
  cron jobs.
- Run some cron jobs
- Go to Home  Tools  Logs
- Verify that you have a selection 'Cron jobs' in drop-down 'Module'. Select it
  with Action All and Submit.
- Output should show Date/time and info about Cron jobs

Rebased to work on top of Bug 6911 (conflict in viewlog.tt)  /MV

Rebased after applying patch for Bug 6911 /MV
Conflicts resolved:
misc/cronjobs/overdue_notices.pl
misc/cronjobs/cleanup_database.pl

Signed-off-by: Frederic Demians f.demi...@tamil.fr
  - Merge both patches, and fix updatedatabase.pl
  - Works as described. Provide intersting feedback from cronjob scripts.

--
Modified version taking in account syspref CronJobLog. Handling simplified by
introducing a convenience sub cronlogaction in C4/Log.pm /MV
Amended to take in account comments #11, #12, #13 /MV

http://bugs.koha-community.org/show_bug.cgi?id=13899

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #38228|0   |1
is obsolete||

--- Comment #19 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38230
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38230action=edit
Bug 13889: Added Test Coverage

Previous commit was lacking test coverage of new function.

TEST PLAN
-
1) Apply all the patches
2) prove -v t/db_dependent/Log.t
   -- should be success.
3) koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #38227|0   |1
is obsolete||

--- Comment #18 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38229
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38229action=edit
Bug 13889 - Add information about cron jobs to system log

This patch adds information about cron jobs performed and make it viewable
under Home  Tools  Logs (Browse system logs)

To test:

Apply patch
- Got to system preferences and set 'CronjobLog' to:  [Log] information from
  cron jobs.
- Run some cron jobs
- Go to Home  Tools  Logs
- Verify that you have a selection 'Cron jobs' in drop-down 'Module'. Select it
  with Action All and Submit.
- Output should show Date/time and info about Cron jobs

Rebased to work on top of Bug 6911 (conflict in viewlog.tt)  /MV

Rebased after applying patch for Bug 6911 /MV
Conflicts resolved:
misc/cronjobs/overdue_notices.pl
misc/cronjobs/cleanup_database.pl

Signed-off-by: Frederic Demians f.demi...@tamil.fr
  - Merge both patches, and fix updatedatabase.pl
  - Works as described. Provide intersting feedback from cronjob scripts.

--
Modified version taking in account syspref CronJobLog. Handling simplified by
introducing a convenience sub cronlogaction in C4/Log.pm /MV
Amended to take in account comments #11, #12, #13 /MV

http://bugs.koha-community.org/show_bug.cgi?id=13899

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

--- Comment #20 from M. Tompsett mtomp...@hotmail.com ---
Leaving as 'Needs Signoff', because my test coverage addition can't be signed
off by me.

Also, I ran the purge suggestions cronjob to test the logging. I did not run
all the scripts, though I did look at all of them. They were all the same
change: use C4::Log, and trigger a cronlogaction() after a successful start.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

  Attachment #38116|0   |1
is obsolete||

--- Comment #14 from Marc Véron ve...@veron.ch ---
Created attachment 38183
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38183action=edit
Bug 13889 - Add information about cron jobs to system log

This patch adds information about cron jobs performed and make it viewable
under Home  Tools  Logs (Browse system logs)

To test:

Apply patch
- Got to system preferences and set 'CronjobLog' to:  [Log] information from
  cron jobs.
- Run some cron jobs
- Go to Home  Tools  Logs
- Verify that you have a selection 'Cron jobs' in drop-down 'Module'. Select it
  with Action All and Submit.
- Output should show Date/time and info about Cron jobs

Rebased to work on top of Bug 6911 (conflict in viewlog.tt)  /MV

Rebased after applying patch for Bug 6911 /MV
Conflicts resolved:
misc/cronjobs/overdue_notices.pl
misc/cronjobs/cleanup_database.pl

Signed-off-by: Frederic Demians f.demi...@tamil.fr
  - Merge both patches, and fix updatedatabase.pl
  - Works as described. Provide intersting feedback from cronjob scripts.

--
Modified version taking in account syspref CronJobLog. Handling simplified by
introducing a convenience sub cronlogaction in C4/Log.pm /MV
Amended to take in account comments #11, #12, #13 /MV

http://bugs.koha-community.org/show_bug.cgi?id=13899

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #15 from Marc Véron ve...@veron.ch ---
Reset to 'Needs Signoff'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

--- Comment #11 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 38116
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38116
Bug 13889 - Add information about cron jobs to system log

Review of attachment 38116:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=13889attachment=38116)
-

::: installer/data/mysql/sysprefs.sql
@@ +474,5 @@
  ('XSLTDetailsDisplay','default','','Enable XSL stylesheet control over 
 details page display on intranet','Free'),
  ('XSLTResultsDisplay','default','','Enable XSL stylesheet control over 
 results page display on intranet','Free'),
  ('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields 
 for Personal Name Authorities to fill biblio.author','free'),
 +('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will 
 replace authors in biblio.author','YesNo'),
 +('CronjobLog','0',NULL,'If ON, log information from cron jobs.','YesNo')

This should be placed alphabetically.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||mtomp...@hotmail.com

--- Comment #13 from M. Tompsett mtomp...@hotmail.com ---
Koha QA tools fails related to my comment #11.
And a tab character on line 37 of C4/Log.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

--- Comment #12 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 38116
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38116
Bug 13889 - Add information about cron jobs to system log

Review of attachment 38116:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=13889attachment=38116)
-

::: installer/data/mysql/updatedatabase.pl
@@ +10039,5 @@
 +if ( CheckVersion($DBversion) ) {
 +$dbh-do(INSERT IGNORE INTO `systempreferences` 
 (variable,value,explanation,options,type) VALUES ('CronjobLog','0',NULL,'If 
 ON, log information from cron jobs.','YesNo'););
 +print Upgrade to $DBversion done (Add CronjobLog syspref)\n;
 +SetVersion ($DBversion);
 +}

This new. Why not do the new atomic update way?
http://wiki.koha-community.org/wiki/Database_updates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

  Attachment #37711|0   |1
is obsolete||

--- Comment #10 from Marc Véron ve...@veron.ch ---
Created attachment 38116
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38116action=edit
Bug 13889 - Add information about cron jobs to system log

This patch adds information about cron jobs performed and make it viewable
under Home  Tools  Logs (Browse system logs)

To test:

Apply patch
- Got to system preferences and set 'CronjobLog' to:  [Log] information from
  cron jobs.
- Run some cron jobs
- Go to Home  Tools  Logs
- Verify that you have a selection 'Cron jobs' in drop-down 'Module'. Select it
  with Action All and Submit.
- Output should show Date/time and info about Cron jobs

Rebased to work on top of Bug 6911 (conflict in viewlog.tt)  /MV

Rebased after applying patch for Bug 6911 /MV
Conflicts resolved:
misc/cronjobs/overdue_notices.pl
misc/cronjobs/cleanup_database.pl

Signed-off-by: Frederic Demians f.demi...@tamil.fr
  - Merge both patches, and fix updatedatabase.pl
  - Works as described. Provide intersting feedback from cronjob scripts.

--
Modified version taking in account syspref CronJobLog. Handling simplified by
introducing a convenience sub cronlogaction in C4/Log.pm /MV

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Signed Off  |Failed QA

--- Comment #9 from Kyle M Hall k...@bywatersolutions.com ---
The syspref CronjobLog is created, but is not used. Instead the cronjob logs
are always written. I'm not sure if this is a bad thing. However, either then
system preference needs to be removed, or utilized.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

  Attachment #37679|0   |1
is obsolete||
  Attachment #37707|0   |1
is obsolete||

--- Comment #8 from Frédéric Demians frede...@tamil.fr ---
Created attachment 37711
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37711action=edit
Bug 13889 - Add information about cron jobs to system log

This patch adds information about cron jobs performed and make it viewable
under Home  Tools  Logs (Browse system logs)

To test:

Apply patch
- Got to system preferences and set 'CronjobLog' to:  [Log] information from
  cron jobs.
- Run some cron jobs
- Go to Home  Tools  Logs
- Verify that you have a selection 'Cron jobs' in drop-down 'Module'. Select it
  with Action All and Submit.
- Output should show Date/time and info about Cron jobs

Rebased to work on top of Bug 6911 (conflict in viewlog.tt)  /MV

Rebased after applying patch for Bug 6911 /MV
Conflicts resolved:
misc/cronjobs/overdue_notices.pl
misc/cronjobs/cleanup_database.pl

Signed-off-by: Frederic Demians f.demi...@tamil.fr
  - Merge both patches, and fix updatedatabase.pl
  - Works as described. Provide intersting feedback from cronjob scripts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

--- Comment #7 from Marc Véron ve...@veron.ch ---
Created attachment 37707
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37707action=edit
[Follow-up]Bug 13889 Add syspref to sysprefs.sql and updatedatabase.pl

This patch adds the syspref CronjobLog to sysprefs.sql and updatedatabase.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-12 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

--- Comment #6 from Frédéric Demians frede...@tamil.fr ---
(In reply to Marc Véron from comment #5)

 The patch depends on Bug 6911 (has changes to viewlog.tt), my patch should
 apply on top of this bug.
 I rebased 2 more conflicts after applying 6911.
 Re-tested applying, works for me on current master.

Works for me also.

Your patch add a new syspref in .pref file. I think you still have to add it in
the DB also:

http://wiki.koha-community.org/wiki/System_Preferences#Adding_a_new_system_preference

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

--- Comment #5 from Marc Véron ve...@veron.ch ---
(In reply to Frédéric Demians from comment #3)
 I wasn't able to apply this patch on master:
 
 fatal: sha1 information is lacking or useless
 (koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt).

Hi Frédéric, thanks for testing.

The patch depends on Bug 6911 (has changes to viewlog.tt), my patch should
apply on top of this bug.
I rebased 2 more conflicts after applying 6911.
Re-tested applying, works for me on current master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #3 from Frédéric Demians frede...@tamil.fr ---
I wasn't able to apply this patch on master:

fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-04-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

  Attachment #37325|0   |1
is obsolete||

--- Comment #4 from Marc Véron ve...@veron.ch ---
Created attachment 37679
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37679action=edit
Bug 13889 - Add information about cron jobs to system log

This patch adds information about cron jobs performed and make it viewable
under Home  Tools  Logs (Browse system logs)

To test:

Apply patch
- Got to system preferences and set 'CronjobLog' to:  [Log] information from
cron jobs.
- Run some cron jobs
- Go to Home  Tools  Logs
- Verify that you have a selection 'Cron jobs' in drop-down 'Module'. Select it
with Action All and Submit.
- Output should show Dae/time and info about Cron jobs

Rebased to work on top of Bug 6911 (conflict in viewlog.tt)  /MV

Rebased after applying patch for Bug 6911 /MV
Conflicts resolved:
misc/cronjobs/overdue_notices.pl
misc/cronjobs/cleanup_database.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-03-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Depends on||6911

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-03-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

  Attachment #37082|0   |1
is obsolete||

--- Comment #2 from Marc Véron ve...@veron.ch ---
Created attachment 37325
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37325action=edit
Bug 13889 - Add information about cron jobs to system log

This patch adds information about cron jobs performed and make it viewable
under Home  Tools  Logs (Browse system logs)

To test:

Apply patch
- Got to system preferences and set 'CronjobLog' to:  [Log] information from
cron jobs.
- Run some cron jobs
- Go to Home  Tools  Logs
- Verify that you have a selection 'Cron jobs' in drop-down 'Module'. Select it
with Action All and Submit.
- Output should show Dae/time and info about Cron jobs

Rebased to work on top of Bug 6911 (conflict in viewlog.tt)  /MV

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-03-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |ve...@veron.ch
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-03-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

--- Comment #1 from Marc Véron ve...@veron.ch ---
Created attachment 37082
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37082action=edit
Bug 13889 - Add information about cron jobs to system log

This patch adds information about cron jobs performed and make it viewable
under Home  Tools  Logs (Browse system logs)

To test:

Apply patch
- Got to system preferences and set 'CronjobLog' to:  [Log] information from
cron jobs.
- Run some cron jobs
- Go to Home  Tools  Logs
- Verify that you have a selection 'Cron jobs' in drop-down 'Module'. Select it
with Action All and Submit.
- Output should show Dae/time and info about Cron jobs

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13889] Add information about cron jobs to system log

2015-03-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/