[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Nicole C. Engard  changed:

   What|Removed |Added

 CC||a...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Marc Véron  changed:

   What|Removed |Added

 Blocks||16686


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686
[Bug 16686] Fix "Item in transit from since" in Holds tab
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #64 from Jonathan Druart  
---
Kyle, since 
  commit 3ff76f3357fe8cdd6bf28384171dfdeb32a82d95
  Bug 13918 - Add waiting expiration date to opac list of holds for user

We now get:
  No method wbrname! at
/home/koha/src/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt line 603.
  No method wbrcd! at
/home/koha/src/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt line 603.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16680


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16680
[Bug 16680] Library name are not displayed for holds in transit
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #65 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #64)
> Kyle, since 
>   commit 3ff76f3357fe8cdd6bf28384171dfdeb32a82d95
>   Bug 13918 - Add waiting expiration date to opac list of holds for user
> 
> We now get:
>   No method wbrname! at
> /home/koha/src/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt line
> 603.
>   No method wbrcd! at
> /home/koha/src/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt line
> 603.

See bug 16680 for a patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #59 from Kyle M Hall  ---
Created attachment 46131
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46131=edit
Bug 13918 [QA Followup] - Unit Tests

Signed-off-by: Jonathan Druart 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #43502|0   |1
is obsolete||
  Attachment #43503|0   |1
is obsolete||
  Attachment #43504|0   |1
is obsolete||
  Attachment #43505|0   |1
is obsolete||
  Attachment #43506|0   |1
is obsolete||
  Attachment #43507|0   |1
is obsolete||

--- Comment #58 from Kyle M Hall  ---
Created attachment 46130
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46130=edit
Bug 13918 - Add waiting expiration date to opac list of holds for user

Waiting holds for patrons in the opac should display the hold expiration
date based on the max pickup delay if it is set.

Test Plan:
1) Ensure ReservesMaxPickUpDelay is set
2) Place a hold on a record
3) Check in the item, use it to fill the hold
4) Log into the opac as that user
5) View the holds list, note the 'until ' addition to the
   waiting hold line.

Signed-off-by: Kyle M Hall 

Signed-off-by: Cathi Wiggins 

Signed-off-by: Megan Wianecki 

Signed-off-by: Jonathan Druart 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #57 from Kyle M Hall  ---
Pushed to master!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #60 from Kyle M Hall  ---
Created attachment 46132
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46132=edit
Bug 13918 [QA Followup] - Remove reserves_count

Signed-off-by: Jonathan Druart 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #63 from Kyle M Hall  ---
Created attachment 46135
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46135=edit
Bug 13918 [QA Followup] - Remove unnecessary reference to $wcount

Signed-off-by: Jonathan Druart 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #62 from Kyle M Hall  ---
Created attachment 46134
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46134=edit
Bug 13918 [QA Followup] - Remove dead template code

Signed-off-by: Jonathan Druart 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #61 from Kyle M Hall  ---
Created attachment 46133
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46133=edit
Bug 13918 [QA Followup] - Improve $biblio->subtitles()

Signed-off-by: Jonathan Druart 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #53 from Jonathan Druart  
---
Created attachment 43504
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43504=edit
Bug 13918 [QA Followup] - Remove reserves_count

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #43429|0   |1
is obsolete||
  Attachment #43430|0   |1
is obsolete||
  Attachment #43431|0   |1
is obsolete||
  Attachment #43432|0   |1
is obsolete||
  Attachment #43433|0   |1
is obsolete||
  Attachment #43438|0   |1
is obsolete||

--- Comment #51 from Jonathan Druart  
---
Created attachment 43502
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43502=edit
Bug 13918 - Add waiting expiration date to opac list of holds for user

Waiting holds for patrons in the opac should display the hold expiration
date based on the max pickup delay if it is set.

Test Plan:
1) Ensure ReservesMaxPickUpDelay is set
2) Place a hold on a record
3) Check in the item, use it to fill the hold
4) Log into the opac as that user
5) View the holds list, note the 'until ' addition to the
   waiting hold line.

Signed-off-by: Kyle M Hall 

Signed-off-by: Cathi Wiggins 

Signed-off-by: Megan Wianecki 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #54 from Jonathan Druart  
---
Created attachment 43505
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43505=edit
Bug 13918 [QA Followup] - Improve $biblio->subtitles()

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #55 from Jonathan Druart  
---
Created attachment 43506
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43506=edit
Bug 13918 [QA Followup] - Remove dead template code

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #56 from Jonathan Druart  
---
Created attachment 43507
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43507=edit
Bug 13918 [QA Followup] - Remove unnecessary reference to $wcount

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #52 from Jonathan Druart  
---
Created attachment 43503
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43503=edit
Bug 13918 [QA Followup] - Unit Tests

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||14310


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310
[Bug 14310] Add ability to suspend and resume individual holds from the patron
holds table
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #49 from Jonathan Druart  
---
Software error:

Global symbol "$wcount" requires explicit package name at
/home/koha/src/opac/opac-user.pl line 323.
Execution of /home/koha/src/opac/opac-user.pl aborted due to compilation
errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #47 from Kyle M Hall  ---
Created attachment 43432
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43432=edit
Bug 13918 [QA Followup] - Improve $biblio->subtitles()

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #48 from Kyle M Hall  ---
Created attachment 43433
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43433=edit
Bug 13918 [QA Followup] - Remove dead template code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #45 from Kyle M Hall  ---
Created attachment 43430
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43430=edit
Bug 13918 [QA Followup] - Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #46 from Kyle M Hall  ---
Created attachment 43431
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43431=edit
Bug 13918 [QA Followup] - Remove reserves_count

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #42779|0   |1
is obsolete||
  Attachment #42780|0   |1
is obsolete||
  Attachment #42781|0   |1
is obsolete||
  Attachment #42782|0   |1
is obsolete||
  Attachment #42783|0   |1
is obsolete||

--- Comment #44 from Kyle M Hall  ---
Created attachment 43429
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43429=edit
Bug 13918 - Add waiting expiration date to opac list of holds for user

Waiting holds for patrons in the opac should display the hold expiration
date based on the max pickup delay if it is set.

Test Plan:
1) Ensure ReservesMaxPickUpDelay is set
2) Place a hold on a record
3) Check in the item, use it to fill the hold
4) Log into the opac as that user
5) View the holds list, note the 'until ' addition to the
   waiting hold line.

Signed-off-by: Kyle M Hall 

Signed-off-by: Cathi Wiggins 

Signed-off-by: Megan Wianecki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #43 from Jonathan Druart  
---
CONFLICT (content): Merge conflict in opac/opac-user.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #50 from Kyle M Hall  ---
Created attachment 43438
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43438=edit
Bug 13918 [QA Followup] - Remove unnecessary reference to $wcount

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

techservs...@gmail.com changed:

   What|Removed |Added

 CC||techservs...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #36 from Jonathan Druart  
---
Kyle,
They now apply but I think you forgot to apply 13517 before rebasing the
patches.
For instance, the first patch redefines the is_in_transit method.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #42 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #36)
> Kyle,
> They now apply but I think you forgot to apply 13517 before rebasing the
> patches.
> For instance, the first patch redefines the is_in_transit method.

I did apply 13517 first, but it looks like a screwed up the merge conflict fix.
Patch updated!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #42745|0   |1
is obsolete||
  Attachment #42746|0   |1
is obsolete||
  Attachment #42747|0   |1
is obsolete||
  Attachment #42748|0   |1
is obsolete||
  Attachment #42749|0   |1
is obsolete||

--- Comment #37 from Kyle M Hall  ---
Created attachment 42779
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42779=edit
Bug 13918 - Add waiting expiration date to opac list of holds for user

Waiting holds for patrons in the opac should display the hold expiration
date based on the max pickup delay if it is set.

Test Plan:
1) Ensure ReservesMaxPickUpDelay is set
2) Place a hold on a record
3) Check in the item, use it to fill the hold
4) Log into the opac as that user
5) View the holds list, note the 'until ' addition to the
   waiting hold line.

Signed-off-by: Kyle M Hall 

Signed-off-by: Cathi Wiggins 

Signed-off-by: Megan Wianecki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #38 from Kyle M Hall  ---
Created attachment 42780
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42780=edit
Bug 13918 [QA Followup] - Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #41 from Kyle M Hall  ---
Created attachment 42783
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42783=edit
Bug 13918 [QA Followup] - Remove dead template code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #39 from Kyle M Hall  ---
Created attachment 42781
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42781=edit
Bug 13918 [QA Followup] - Remove reserves_count

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #40 from Kyle M Hall  ---
Created attachment 42782
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42782=edit
Bug 13918 [QA Followup] - Improve $biblio->subtitles()

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #30 from Jonathan Druart  
---
Patch failed at 0001 Bug 13918 - Add waiting expiration date to opac list of
holds for user

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #34 from Kyle M Hall  ---
Created attachment 42748
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42748=edit
Bug 13918 [QA Followup] - Improve $biblio->subtitles()

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #33 from Kyle M Hall  ---
Created attachment 42747
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42747=edit
Bug 13918 [QA Followup] - Remove reserves_count

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #35 from Kyle M Hall  ---
Created attachment 42749
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42749=edit
Bug 13918 [QA Followup] - Remove dead template code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #32 from Kyle M Hall  ---
Created attachment 42746
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42746=edit
Bug 13918 [QA Followup] - Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #42652|0   |1
is obsolete||
  Attachment #42653|0   |1
is obsolete||
  Attachment #42654|0   |1
is obsolete||
  Attachment #42655|0   |1
is obsolete||
  Attachment #42656|0   |1
is obsolete||

--- Comment #31 from Kyle M Hall  ---
Created attachment 42745
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42745=edit
Bug 13918 - Add waiting expiration date to opac list of holds for user

Waiting holds for patrons in the opac should display the hold expiration
date based on the max pickup delay if it is set.

Test Plan:
1) Ensure ReservesMaxPickUpDelay is set
2) Place a hold on a record
3) Check in the item, use it to fill the hold
4) Log into the opac as that user
5) View the holds list, note the 'until ' addition to the
   waiting hold line.

Signed-off-by: Kyle M Hall 

Signed-off-by: Cathi Wiggins 

Signed-off-by: Megan Wianecki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #41945|0   |1
is obsolete||
  Attachment #41946|0   |1
is obsolete||
  Attachment #41947|0   |1
is obsolete||
  Attachment #41948|0   |1
is obsolete||

--- Comment #25 from Kyle M Hall  ---
Created attachment 42652
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42652=edit
Bug 13918 - Add waiting expiration date to opac list of holds for user

Waiting holds for patrons in the opac should display the hold expiration
date based on the max pickup delay if it is set.

Test Plan:
1) Ensure ReservesMaxPickUpDelay is set
2) Place a hold on a record
3) Check in the item, use it to fill the hold
4) Log into the opac as that user
5) View the holds list, note the 'until ' addition to the
   waiting hold line.

Signed-off-by: Kyle M Hall 

Signed-off-by: Cathi Wiggins 

Signed-off-by: Megan Wianecki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #27 from Kyle M Hall  ---
Created attachment 42654
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42654=edit
Bug 13918 [QA Followup] - Remove reserves_count

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #26 from Kyle M Hall  ---
Created attachment 42653
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42653=edit
Bug 13918 [QA Followup] - Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #28 from Kyle M Hall  ---
Created attachment 42655
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42655=edit
Bug 13918 [QA Followup] - Improve $biblio->subtitles()

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #29 from Kyle M Hall  ---
Created attachment 42656
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42656=edit
Bug 13918 [QA Followup] - Remove dead template code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

--- Comment #23 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #18)
> Thanks, I understand what you were asking now.
> > > t/db_dependent/BiblioObject.t
> > 
> > I would prefer a better filename, but nothing in mind to suggest.
> 
> I feel the same way, but have nothing better to suggest either.
> 
> > > +my $field_mappings = 
> > > Koha::Database->new()->schema()->resultset('Fieldmapping');
> > 
> > Could be better to have a Koha::Fieldmapping[s]
> 
> I can do this if you'd like. It was just a quick way to create a field
> mapping, so I went with dbic directly. Just let me know if you want me to go
> ahead an add a followup to add and use Koha::Fieldmapping[s]

As you like.

> > > -waiting_count  => $wcount,
> > 
> > This variable is still used in the template.
> > 
> > > +WAITING=> $reserves->waiting()
> > 
> > Why not remove this one and access to the waiting holds using
> > RESERVES.waiting in the template?
> 
> I'm working on these ones right now.

So setting the status accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #24 from Kyle M Hall  ---
Excellent! Thanks for looking into that Jonathan. I'll pull that code out and
get everything fixed up!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #22 from Jonathan Druart  
---
"For a while" meant " I didn't find any versions where it works.

If you check out the commit before "Bug 5917 : Swapping templates over"
(d4cd05126da3accef83144d8322fcd455d7eba9b), you will see the same structure in
the TT:

128 Waiting


But no track of a atdestination variable passed to the template.

So if this is correct, I am sure nobody will care if we remove this tab :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #21 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #20)
> (In reply to Jonathan Druart from comment #19)
> > (In reply to Kyle M Hall from comment #18)
> > > Question, I see in the code that there is a "Waiting" tab for only waiting
> > > holds, yet I don't see it in the opac ( while on master ). Is this dead 
> > > code?
> > 
> > It looks like more than a bug :)
> 
> After a deep dive into the code, it seems broken for a while!

Thanks for looking into that! Any idea how long a while has been? Any idea what
the last major version of Koha it worked in was? It seems that maybe it should
be considered dead code since nobody has ever noticed, complained, or filed a
bug related to it! I did look for a related bug submission, but could find
none.

This is also rather superfluous, as the waiting holds are already in the holds
tab. There's really no need for yet another tab that lists only the waiting
holds.

I would like to remove the dead code, what do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #17 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
(In reply to Kyle M Hall from comment #16)
 (In reply to Jonathan Druart from comment #15)
  Kyle, what does the last patch set?
 
 I'm not sure what you mean. Can you explain?

(Maybe a do is missing)

What does the last patch set do?

You have answered my comment 10 by a new patch set, but I don't want to compare
the 2 patch sets (before and after my comment) to know if you have taken into
account my comments.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #19 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
(In reply to Kyle M Hall from comment #18)
 Question, I see in the code that there is a Waiting tab for only waiting
 holds, yet I don't see it in the opac ( while on master ). Is this dead code?

It looks like more than a bug :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #18 from Kyle M Hall kyle.m.h...@gmail.com ---
Thanks, I understand what you were asking now.
  t/db_dependent/BiblioObject.t
 
 I would prefer a better filename, but nothing in mind to suggest.

I feel the same way, but have nothing better to suggest either.

  +my $field_mappings = 
  Koha::Database-new()-schema()-resultset('Fieldmapping');
 
 Could be better to have a Koha::Fieldmapping[s]

I can do this if you'd like. It was just a quick way to create a field mapping,
so I went with dbic directly. Just let me know if you want me to go ahead an
add a followup to add and use Koha::Fieldmapping[s]



 
  -waiting_count  = $wcount,
 
 This variable is still used in the template.
 
  +WAITING= $reserves-waiting()
 
 Why not remove this one and access to the waiting holds using
 RESERVES.waiting in the template?

I'm working on these ones right now.

Question, I see in the code that there is a Waiting tab for only waiting
holds, yet I don't see it in the opac ( while on master ). Is this dead code?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #20 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
(In reply to Jonathan Druart from comment #19)
 (In reply to Kyle M Hall from comment #18)
  Question, I see in the code that there is a Waiting tab for only waiting
  holds, yet I don't see it in the opac ( while on master ). Is this dead 
  code?
 
 It looks like more than a bug :)

After a deep dive into the code, it seems broken for a while!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com

--- Comment #16 from Kyle M Hall kyle.m.h...@gmail.com ---
(In reply to Jonathan Druart from comment #15)
 Kyle, what does the last patch set?

I'm not sure what you mean. Can you explain?

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #15 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
Kyle, what does the last patch set?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #12 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 41946
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41946action=edit
Bug 13918 [QA Followup] - Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #13 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 41947
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41947action=edit
Bug 13918 [QA Followup] - Remove reserves_count

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #14 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 41948
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41948action=edit
Bug 13918 [QA Followup] - Improve $biblio-subtitles()

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #10 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
A bit late to be sure there is no regression, but everything looks good.

Just some minor notes:

 t/db_dependent/BiblioObject.t

I would prefer a better filename, but nothing in mind to suggest.

 +my $field_mappings = 
 Koha::Database-new()-schema()-resultset('Fieldmapping');

Could be better to have a Koha::Fieldmapping[s]

 -waiting_count  = $wcount,

This variable is still used in the template.

 +WAITING= $reserves-waiting()

Why not remove this one and access to the waiting holds using RESERVES.waiting
in the template?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #40035|0   |1
is obsolete||
  Attachment #41862|0   |1
is obsolete||
  Attachment #41863|0   |1
is obsolete||
  Attachment #41865|0   |1
is obsolete||

--- Comment #11 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 41945
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41945action=edit
Bug 13918 - Add waiting expiration date to opac list of holds for user

Waiting holds for patrons in the opac should display the hold expiration
date based on the max pickup delay if it is set.

Test Plan:
1) Ensure ReservesMaxPickUpDelay is set
2) Place a hold on a record
3) Check in the item, use it to fill the hold
4) Log into the opac as that user
5) View the holds list, note the 'until date' addition to the
   waiting hold line.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Cathi Wiggins cwigg...@ci.arcadia.ca.us

Signed-off-by: Megan Wianecki mwiane...@mplmain.mtpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #8 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 41864
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41864action=edit
Bug 13918 [QA Followup]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #41864|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 41865
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41865action=edit
Bug 13918 [QA Followup] - Improve $biblio-subtitles()

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #6 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 41862
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41862action=edit
Bug 13918 [QA Followup] - Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #7 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 41863
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41863action=edit
Bug 13918 [QA Followup] - Remove reserves_count

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Nicole Engard (ByWater) nic...@bywatersolutions.com changed:

   What|Removed |Added

 CC||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m
 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com ---
Comment on attachment 40035
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40035
[SIGNED-OFF] Bug 13918 - Add waiting expiration date to opac list of holds for
user

Review of attachment 40035:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=13918attachment=40035)
-

::: Koha/Biblio.pm
@@ +43,5 @@
 +
 +sub subtitle {
 +my ( $self ) = @_;
 +
 +return GetRecordValue( 'subtitle', GetMarcBiblio( $self-id() ), 
 GetFrameworkCode( $self-id() ) );

Shouldn't we provide a more efficient way to retrieve subtitle here?
Moreover the frameworkcode could be retrieved with self-frameworkcode.

::: Koha/Hold.pm
@@ +96,5 @@
 +Returns true if hold is a cancelable hold
 +
 +=cut
 +
 +sub is_cancelable {

tests are missing for this subroutine.

@@ +122,5 @@
 +Returns true if hold is a in_transit hold
 +
 +=cut
 +
 +sub is_at_destination {

tests are missing for this subroutine.

::: opac/opac-user.pl
@@ +281,4 @@
  
 +$template-param(
 +RESERVES   = $reserves,
 +reserves_count = $reserves-count(),

Is it still needed?
We can access to the number of reserves from the template.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #37272|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 40033
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40033action=edit
Bug 13918 - Add waiting expiration date to opac list of holds for user

Waiting holds for patrons in the opac should display the hold expiration
date based on the max pickup delay if it is set.

Test Plan:
1) Ensure ReservesMaxPickUpDelay is set
2) Place a hold on a record
3) Check in the item, use it to fill the hold
4) Log into the opac as that user
5) View the holds list, note the 'until date' addition to the
   waiting hold line.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #40033|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 40035
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40035action=edit
[SIGNED-OFF] Bug 13918 - Add waiting expiration date to opac list of holds for
user

Waiting holds for patrons in the opac should display the hold expiration
date based on the max pickup delay if it is set.

Test Plan:
1) Ensure ReservesMaxPickUpDelay is set
2) Place a hold on a record
3) Check in the item, use it to fill the hold
4) Log into the opac as that user
5) View the holds list, note the 'until date' addition to the
   waiting hold line.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Cathi Wiggins cwigg...@ci.arcadia.ca.us

Signed-off-by: Megan Wianecki mwiane...@mplmain.mtpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37271
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37271action=edit
Bug 13918 - Add waiting expiration date to opac list of holds for user

Waiting holds for patrons in the opac should display the hold expiration
date based on the max pickup delay if it is set.

Test Plan:
1) Ensure ReservesMaxPickUpDelay is set
2) Place a hold on a record
3) Check in the item, use it to fill the hold
4) Log into the opac as that user
5) View the holds list, note the 'until date' addition to the
   waiting hold line.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Depends on||13517

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #37271|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 37272
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37272action=edit
Bug 13918 - Add waiting expiration date to opac list of holds for user

Waiting holds for patrons in the opac should display the hold expiration
date based on the max pickup delay if it is set.

Test Plan:
1) Ensure ReservesMaxPickUpDelay is set
2) Place a hold on a record
3) Check in the item, use it to fill the hold
4) Log into the opac as that user
5) View the holds list, note the 'until date' addition to the
   waiting hold line.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/