[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-11-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Martin Renvoize  changed:

   What|Removed |Added

  Component|Architecture, internals,|Z39.50 / SRU / OpenSearch
   |and plumbing|Servers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-11-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the|This patch allows libraries |This development allows
  release notes|wishing to run  |libraries wishing to run
   |Elasticsearch but also  |Elasticsearch but also
   |serve as a public   |serve as a public
   |SRU/Z39.50 gateway to do so |SRU/Z39.50 gateway to do so
   |without running Zebra in|without running Zebra in
   |parallel.   |parallel.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-11-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||24022


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24022
[Bug 24022] Z3950Responder tests are failing on D8 and U18
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||23949


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949
[Bug 23949] koha-common.init missing actions for koha-z3950-responder
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #231 from Ere Maijala  ---
Just to clarify: bug 23887 is a separate follow-up, and I obsoleted the patch
attached here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #230 from Martin Renvoize  ---
Agree with Katrin, we've exhausted this bug now, can followups go into their
own bugs as I'm starting to loose track and wouldn't want to miss something.

Cheers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #229 from Katrin Fischer  ---
(In reply to Ere Maijala from comment #228)
> Comment on attachment 94647 [details] [review]
> Bug 13937: (follow-up) sort SRU results by id asc
> 
> See patch in bug 23887. This allows one to use e.g. local-number as the sort
> parameter, but it needs to be made sortable in search engine configuration.

With the patch now being pushed, maybe we should split these out into separate
bugs? Just want to make sure nothing gets lost.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala  changed:

   What|Removed |Added

  Attachment #94647|0   |1
is obsolete||

--- Comment #228 from Ere Maijala  ---
Comment on attachment 94647
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94647
Bug 13937: (follow-up) sort SRU results by id asc

See patch in bug 23887. This allows one to use e.g. local-number as the sort
parameter, but it needs to be made sortable in search engine configuration.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #227 from Ere Maijala  ---
Not really, unless you want them in reverse local-number order. But with bug
23887 you would be able to indicate the preferred order.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #226 from Johanna Räisä  ---
(In reply to Ere Maijala from comment #225)
> Actually, no. I'd say we shouldn't force sorting here. Relevance should be
> used by default. There are other bugs affecting the result with
> Elasticsearch. See bug 23875.

Is that fixing sorting component parts also? If there aren't any sorting then
we are getting them in random order, not in the order they should be.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #225 from Ere Maijala  ---
Actually, no. I'd say we shouldn't force sorting here. Relevance should be used
by default. There are other bugs affecting the result with Elasticsearch. See
bug 23875.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23887

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #224 from Ere Maijala  ---
Thanks, Johanna, that's a good change. I'll file a follow-up issue about adding
support for client-specified sort order.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Johanna Räisä  changed:

   What|Removed |Added

 CC||johanna.ra...@koha-suomi.fi

--- Comment #223 from Johanna Räisä  ---
Created attachment 94647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94647=edit
Bug 13937: (follow-up) sort SRU results by id asc

SRU is giving results in random order. This patch fixes the order to be id asc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #222 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #221 from Ere Maijala  ---
Thanks! And sorry, one more issue was discovered: searching with UTF-8
characters like ä didn't work properly. The last patch fixes that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #219 from Martin Renvoize  ---
Ere, you are a star!  Thanks :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the||This patch allows libraries
  release notes||wishing to run
   ||Elasticsearch but also
   ||serve as a public
   ||SRU/Z39.50 gateway to do so
   ||without running Zebra in
   ||parallel.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|additional_work_needed, |
   |dependency  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #218 from Ere Maijala  ---
Not sure about thoroughness, but I've now added initial documentation on how to
set this up:
https://wiki.koha-community.org/wiki/Setting_up_the_Z39.50_and_SRU_Server. I
also added notes and links to
https://wiki.koha-community.org/wiki/APIs_and_protocols_supported_by_Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #217 from Martin Renvoize  ---
No worries Ere, you've done a fantastic job getting us this far. As you say,
the yaz and zebra docs are cryptic at best, it from me a fair while to find it
and a few pointers to get the right search terms to finally spot it.

I'm very happy it all seems to be working now and am looking forward to seeing
it running in production.  Hoping we can get it thoroughly documented before
release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #216 from Ere Maijala  ---
Thanks Martin! I found the YAZ documentation a bit scattered and didn't spot
that bit of information. We're running YAZ 5, and it seems to do a better job.
Or rather, it seems that YAZ 5 supports paths relative to the config file as
well as current working dir.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #215 from Martin Renvoize  ---
One last followup.

We were still referencing a relative path for the pqf.properties file from
inside the config.xml and this was not resolving correctly.

After a little more digging I spotted that 'cql2rpn' should always be 'relative
to the working directory', but under a daemon start the working directory was
not being set correctly.  One can, however, pass a `-w` to the daemon to
explicitly set working directory and as such make relative paths (from the
config file directory) work as expected.

Ere, this gets the tests passing again in my koha-testing-docker instance and
also in my local environment but it might be worth double-checking at your end
whether things will continue to work in your live environments.. I have a hunch
you're using full paths in your config files there (or perhaps YAZ5 just does a
much better job of detecting working directory in the first place for you).

Pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #214 from Martin Renvoize  ---
Created attachment 94209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94209=edit
Bug 13937: (RM follow-up) Set working directory for daemon mode.

When running as a daemon under Net::Z3950::SimpleServer YAZ requires a
little help to know where it's "working directory" is located so
relative paths in config files may resolve correctly.

This patch passes the working directory as prescribed on
https://software.indexdata.com/yaz/doc/server.invocation.html such that
the resolution of the cql2rpn filepath works as expected in tests.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #213 from Ere Maijala  ---
Thanks, Martin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #212 from Martin Renvoize  ---
Thanks so much for all your work here Ere,

It's looking great to me now, I've just pushed the final followup and am
waiting on Jenkins to go green.. crossed fingers but it all passes locally for
me now in the various versions so touch wood Jenkins will be happy too.

It's great to have this one in!

Martin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #211 from Ere Maijala  ---
Ok, the latest patch includes a copy of pqf.properties so that no copying needs
to be performed. This makes things more simple and avoids possible permission
issues with copying.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala  changed:

   What|Removed |Added

  Attachment #94109|0   |1
is obsolete||

--- Comment #210 from Ere Maijala  ---
Created attachment 94110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94110=edit
Bug 13937: (QA follow-up) Make tests work with YAZ 4 and 5.

Also makes add_item_status tests more robust by clearing the cache after
modifying authorised values.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #209 from Ere Maijala  ---
(In reply to David Cook from comment #207)
> Comment on attachment 94109 [details] [review]
> Bug 13937: (QA follow-up) Make tests work with YAZ 4 and 5.
> 
> Review of attachment 94109 [details] [review]:
> -
> 
> ::: t/db_dependent/Koha/Z3950Responder/GenericSession.t
> @@ +82,5 @@
> >  $child = fork();
> >  if ($child == 0) {
> >  my $config_dir = dirname(__FILE__) . '/';
> > +# Copy pqf.properties from etc/z3950
> > +copy($config_dir . '../../../../etc/z3950/pqf.properties', 
> > $config_dir . 'pqf.properties') || die "Copying pqf.properties failed: $!";
> 
> This seems a little fragile to me. I don't know what we're doing in other
> scripts, but it might be worth using https://perldoc.perl.org/FindBin.html
> here?

I'll revise. Actually, would it better to just include a copy of pqf.properties
in the test dir? It would also make sure that any changes to the default
pqf.properties don't break tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #208 from David Cook  ---
(In reply to Ere Maijala from comment #206)
> The last patch should work with both YAZ versions. The real culprit was that
> the test requests did not include version parameter, and YAZ 5 defaulted to
> a newer SRU version that uses a different namespace. All tests now use
> version=1.1 parameter. Additionally, pqf.properties is copied to the test
> directory so that a relative path isn't needed in config.xml.

Nice one, Ere!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #207 from David Cook  ---
Comment on attachment 94109
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94109
Bug 13937: (QA follow-up) Make tests work with YAZ 4 and 5.

Review of attachment 94109:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=13937=94109)
-

::: t/db_dependent/Koha/Z3950Responder/GenericSession.t
@@ +82,5 @@
>  $child = fork();
>  if ($child == 0) {
>  my $config_dir = dirname(__FILE__) . '/';
> +# Copy pqf.properties from etc/z3950
> +copy($config_dir . '../../../../etc/z3950/pqf.properties', 
> $config_dir . 'pqf.properties') || die "Copying pqf.properties failed: $!";

This seems a little fragile to me. I don't know what we're doing in other
scripts, but it might be worth using https://perldoc.perl.org/FindBin.html
here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #206 from Ere Maijala  ---
The last patch should work with both YAZ versions. The real culprit was that
the test requests did not include version parameter, and YAZ 5 defaulted to a
newer SRU version that uses a different namespace. All tests now use
version=1.1 parameter. Additionally, pqf.properties is copied to the test
directory so that a relative path isn't needed in config.xml.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #205 from Ere Maijala  ---
Created attachment 94109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94109=edit
Bug 13937: (QA follow-up) Make tests work with YAZ 4 and 5.

Also makes add_item_status tests more robust by clearing the cache after
modifying authorised values.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #204 from David Cook  ---
(In reply to Ere Maijala from comment #203)
> I see. I'll take another stab at trying to make the tests work with both
> versions.

I can try to help. I'm pretty busy at the moment, so not too keen to spin up a
koha-testing-docker and try it out, but if you point me at the test, I can have
a look. 

Martin's already pushed the patches to master, so maybe it doesn't matter too
much? Maybe he can clarify things.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #203 from Ere Maijala  ---
(In reply to David Cook from comment #202)

> I think I don't know enough about the particular test in question to really
> continue the conversation. I figured it was a case of providing a
> configuration value to a function in the test, but it sounds like perhaps
> it's a Zebra config file and that it's an integration test, so I see how
> that could be tricky. I withdraw my suggestion heh.

I value the suggestion, though it wouldn't solve the problem that YAZ 4 and 5
do diagnostics (error handling) differently. I'll see if I can modify the tests
to pass on both.

> That's an interesting question. Looking at
> https://packages.debian.org/search?keywords=yaz, I see YAZ 4 is used in
> Jessie and Stretch, but Buster and Bullseye use YAZ 5. 

I see. I'll take another stab at trying to make the tests work with both
versions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #202 from David Cook  ---
(In reply to Ere Maijala from comment #199)
> The path is in a config file, so hard-coding it there there doesn't seem
> quite proper. It doesn't seem possible to specify it programmatically.
> Anyway, it wouldn't help since YAZ 4 and 5 handle some error conditions
> differently, unless I remove the offending tests. That's of course possible
> too, but I would rather not do that unless it's the last option.
> 

I think I don't know enough about the particular test in question to really
continue the conversation. I figured it was a case of providing a configuration
value to a function in the test, but it sounds like perhaps it's a Zebra config
file and that it's an integration test, so I see how that could be tricky. I
withdraw my suggestion heh.

> Now, this strays from the main topic a bit, but as far as I can tell last
> YAZ 4 release was in 2013. That's pretty ancient. Could we decide not to fix
> the tests for such an old version?

That's an interesting question. Looking at
https://packages.debian.org/search?keywords=yaz, I see YAZ 4 is used in Jessie
and Stretch, but Buster and Bullseye use YAZ 5. 

Perhaps we could specify a YAZ 4 run time dependency and YAZ 5 as a build
dependency in the Debian control file? 

But then we probably should be building on the same OSes that we're supporting
at run time, so I think perhaps we do have to support YAZ 4 behaviour until we
don't support Debian Stretch anymore?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #201 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #200 from Tomás Cohen Arazi  ---
Created attachment 94097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94097=edit
Bug 13937: (follow-up) Add missing entry to koha-common.install

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #199 from Ere Maijala  ---
The path is in a config file, so hard-coding it there there doesn't seem quite
proper. It doesn't seem possible to specify it programmatically. Anyway, it
wouldn't help since YAZ 4 and 5 handle some error conditions differently,
unless I remove the offending tests. That's of course possible too, but I would
rather not do that unless it's the last option.

Now, this strays from the main topic a bit, but as far as I can tell last YAZ 4
release was in 2013. That's pretty ancient. Could we decide not to fix the
tests for such an old version?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #198 from David Cook  ---
(In reply to Ere Maijala from comment #193)
> Got the docker stuff running. It seems that there are at least some
> differences between YAZ versions. I've tested with YAZ 5, but the testing
> box has YAZ 4. Looks like v4 can't find the pqf.properties file with a
> relative path in t/db_dependent/Koha/Z3950Responder/config.xml. Upgrading
> YAZ helps a bit, but there are still failing tests I need to check. Would it
> be possible to upgrade the container to use YAZ 5?

Do you have to use a relative path? Could the solution be to use an absolute
path?

(I'm asking without looking at the patches at all. Just an idea.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #197 from Ere Maijala  ---
As far as I can tell YAZ 4 should work in normal use.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #196 from Martin Renvoize  ---
Thanks for taking the time to look Ere.

Hmm, so is it just the tests that require Yaz5, or does this patch
inadvertently mean we need a version bump for Yaz5 in Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #195 from Ere Maijala  ---
Comment on attachment 93913
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93913
Bug 13937: (QA follow-up) Fix tests.

This patch would fix tests with YAZ 5. I tried to copy pqf.properties to the
same directory, but YAZ 4 has other subtle differences making it difficult to
make the tests work properly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #194 from Ere Maijala  ---
Created attachment 93913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93913=edit
Bug 13937: (QA follow-up) Fix tests.

Checking result set size is enough to verify that proper results were returned.
The check for non-existing record could have caused a range error depending of
library versions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #193 from Ere Maijala  ---
Got the docker stuff running. It seems that there are at least some differences
between YAZ versions. I've tested with YAZ 5, but the testing box has YAZ 4.
Looks like v4 can't find the pqf.properties file with a relative path in
t/db_dependent/Koha/Z3950Responder/config.xml. Upgrading YAZ helps a bit, but
there are still failing tests I need to check. Would it be possible to upgrade
the container to use YAZ 5?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #192 from Ere Maijala  ---
I'm having trouble even getting the docker to start, so if someone else knows
what to do, I'm happy for any assistance. That said, the tests should fork
their own server with the configs provided with the tests, so not having the
generic config in place should not cause problems.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #191 from Martin Renvoize  ---
It's something to do with the hard coded z connection port in the tests.. but
there's also an obvious lack of /etc/koha/sites/kohadev/z3950 so the configs
are missing and nothing starts the new daemon..

In short.. it's a few things together that cause the failures.. I don't think
it's anything major to worry about with the actual bug itself.. just a matter
of making Jenkins happy again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #190 from Ere Maijala  ---
I'll try to set up koha-testing-docker to check it out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #189 from Martin Renvoize  ---
Hmm, this still needs a little more work to get tests passing inside
koha-testing-docker.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #188 from David Cook  ---
(In reply to Ere Maijala from comment #184)
> That's because the escaped characters have a special meaning at least in
> Elasticsearch, and unless we escape these characters in ES query builder,
> they need to be accounted for here. Otherwise ES would balk e.g. trying to
> parse [something] as a range.
> 

A that's good to know. I thought it was passing the data straight to Zebra,
so I was confused why we'd be mangling the data. What you say makes more sense.

> I'd be happy to provide some documentation on a wiki page, if that'd be
> useful. In the long run this may be used by quite many since it provides
> Z39.50 and SRU on top of Elasticsearch, which would otherwise require
> running Zebra.

Yes please :). 

I didn't see any references to Elasticsearch in the patches I viewed. I thought
it required Zebra to be used. I must've missed the "Add support for SRU and
Elasticsearch" patch now that I look again... hehe. It would be great to use
this instead of Zebra in that context! I was groaning at the idea of storing
MARCXML in MySQL and indexing it into *both* Elasticsearch and Zebra just to
get Z39.50 functionality...

Nice one, Ere!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #187 from Marcel de Rooy  ---
(In reply to Martin Renvoize from comment #185)
> You mean a few years isn't sufficient?  I've spent hours QAing this on a
> couple of occasions and spend a fair chunk of time discussing it with Nick
> and other ES experts at the Hackfest.. it has my full backing at this point
> and I also have assurances from ES users that we will get quick followups
> should there be issues.

Ok ok

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #186 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||19.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #185 from Martin Renvoize  ---
(In reply to Marcel de Rooy from comment #181)
> A patch set of this size surely needs a sufficient amount of QA time. Hope
> you are not too fast?

You mean a few years isn't sufficient?  I've spent hours QAing this on a couple
of occasions and spend a fair chunk of time discussing it with Nick and other
ES experts at the Hackfest.. it has my full backing at this point and I also
have assurances from ES users that we will get quick followups should there be
issues.

(In reply to David Cook from comment #183)
>At a glance, it does look pretty standalone. However, could a more normative 
>example/documentation be provided?

Agreed, I have requested such documentation and should Ere not get a chance to
get to it quickly I will be asking Bywater for some assistance too.

So.. In short.. lets get this baby pushed :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #184 from Ere Maijala  ---
(In reply to David Cook from comment #182)
> Comment on attachment 91736 [details] [review]
> Bug 13937: Fix RPN conversion
> 
> Review of attachment 91736 [details] [review]:
> -
> 
> Can this be explained a bit more? Why is this necessary?

That's because the escaped characters have a special meaning at least in
Elasticsearch, and unless we escape these characters in ES query builder, they
need to be accounted for here. Otherwise ES would balk e.g. trying to parse
[something] as a range.

I'd be happy to provide some documentation on a wiki page, if that'd be useful.
In the long run this may be used by quite many since it provides Z39.50 and SRU
on top of Elasticsearch, which would otherwise require running Zebra.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #183 from David Cook  ---
(In reply to Ere Maijala from comment #178)
> It's all pretty much standalone and shouldn't affect normal Zebra services
> in any way. Is there something that's particularly scary?

At a glance, it does look pretty standalone. However, could a more normative
example/documentation be provided?

I'm guessing that most people will never use this daemon so will never have to
worry about it either? 

The number of patches makes it a bit challenging to see what's going on at a
glance, but it looks fairly light. I don't understand some of what's going on
here, but if I'm never going to use this feature, I'm probably not going to
worry about looking at it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #182 from David Cook  ---
Comment on attachment 91736
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91736
Bug 13937: Fix RPN conversion

Review of attachment 91736:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=13937=91736)
-

Can this be explained a bit more? Why is this necessary?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #181 from Marcel de Rooy  ---
(In reply to Martin Renvoize from comment #179)
> Right.. I've given this some thought, mulled it over with Nick and others at
> Hackfest and proved to myself that it's doesn't seem to break anything.
> 
> I'm going to PQA and push with the expectation that if we find issues down
> the line I can rely upon our growing team of ES competent people to dive in
> a fix things quickly. 
> 
> Thankyou everyone for your efforts on this one over the long years it's been
> developed.

A patch set of this size surely needs a sufficient amount of QA time. Hope you
are not too fast?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #180 from Ere Maijala  ---
Awesome, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Signed Off  |Passed QA

--- Comment #179 from Martin Renvoize  ---
Right.. I've given this some thought, mulled it over with Nick and others at
Hackfest and proved to myself that it's doesn't seem to break anything.

I'm going to PQA and push with the expectation that if we find issues down the
line I can rely upon our growing team of ES competent people to dive in a fix
things quickly. 

Thankyou everyone for your efforts on this one over the long years it's been
developed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #178 from Ere Maijala  ---
It's all pretty much standalone and shouldn't affect normal Zebra services in
any way. Is there something that's particularly scary?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #177 from Katrin Fischer  ---
I think we are a little bit scared here about it breaking Zebra - it does a bit
too many things in one patch right now, but I hope we'll find a brave soul.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #176 from Ere Maijala  ---
QA, please :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-10-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #175 from Katrin Fischer  ---
Patches still apply, what do we need to be able to continue here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #174 from Ere Maijala  ---
Test plan for SRU:

1. Make sure tests in t/db_dependent/Koha/Z3950Responder/GenericSession.t pass.
2. Use Elasticsearch as the search engine
3. Start the server: perl misc/z3950_responder.pl --debug
4. Check that you get an explain response with browser from
http://localhost:2100/
5. Try some searches to verify that you get results and good search queries in
the output of the daemon . Examples:

http://localhost:2100/biblios?operation=searchRetrieve=10=marcxml=dc.author%3dsmith
http://localhost:2100/biblios?operation=searchRetrieve=10=marcxml=dc.title%3dnew
AND dc.author%3dsmith
http://localhost:2100/biblios?operation=searchRetrieve=10=marcxml=dc.title+cql.eq+"new
world"+AND+dc.creator=smith

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #173 from Ere Maijala  ---
Created attachment 91740
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91740=edit
Bug 13937: Add SRU tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala  changed:

   What|Removed |Added

  Attachment #88916|0   |1
is obsolete||

--- Comment #170 from Ere Maijala  ---
Created attachment 91737
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91737=edit
Bug 13937: Add support for Z39.50 responder to the Debian scripts

Signed-off-by: Stefan Berndtsson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala  changed:

   What|Removed |Added

  Attachment #88918|0   |1
is obsolete||

--- Comment #172 from Ere Maijala  ---
Created attachment 91739
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91739=edit
Bug 13937: Switch from GetItem() to Koha::Items->find()

Signed-off-by: Stefan Berndtsson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala  changed:

   What|Removed |Added

  Attachment #88914|0   |1
is obsolete||

--- Comment #168 from Ere Maijala  ---
Created attachment 91735
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91735=edit
Bug 13937: Add tests for search and retrieval

Sponsored-by: National Library of Finland
Signed-off-by: Stefan Berndtsson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala  changed:

   What|Removed |Added

  Attachment #88915|0   |1
is obsolete||

--- Comment #169 from Ere Maijala  ---
Created attachment 91736
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91736=edit
Bug 13937: Fix RPN conversion

Fixes handling of parenthesis and removes unused quote handling.

Signed-off-by: Stefan Berndtsson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala  changed:

   What|Removed |Added

  Attachment #88917|0   |1
is obsolete||

--- Comment #171 from Ere Maijala  ---
Created attachment 91738
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91738=edit
Bug 13937: Fix the daemon log path.

directory _LOG_DIR_/logs does't exists.

All other log4perl -logs are out to _LOG_DIR_

Thank you for the good work Ere!

Signed-off-by: Stefan Berndtsson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala  changed:

   What|Removed |Added

  Attachment #88913|0   |1
is obsolete||

--- Comment #167 from Ere Maijala  ---
Created attachment 91734
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91734=edit
Bug 13937: Add support for SRU and Elasticsearch

Splits Session to GenericSession and ZebraSession where Generic supports any
search backend via the SearchEngine classes and Zebra maintains the direct
channel to the Zebra server.

Adds config files required for mapping BIB-1 attributes to Koha search fields
and SRU indexes to BIB-1 attributes.

Adds PODs.

Sponsored-by: National Library of Finland
Signed-off-by: Stefan Berndtsson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala  changed:

   What|Removed |Added

  Attachment #88909|0   |1
is obsolete||

--- Comment #163 from Ere Maijala  ---
Created attachment 91730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91730=edit
Bug 13937: (follow-up) Correct error call to use self

Signed-off-by: Stefan Berndtsson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala  changed:

   What|Removed |Added

  Attachment #88907|0   |1
is obsolete||

--- Comment #161 from Ere Maijala  ---
Created attachment 91728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91728=edit
Bug 13937: Add a Z39.50 daemon that can inject item status MARC subfields

This creates a new daemon, misc/z3950_responder.pl, which can respond to
Z39.50 requests. By default, it just proxies searches to Zebra.

If desired, however, it can also add a subfield to the item tags on
outgoing records with a textual description of the item's status
(checked out, lost, etc.). This is useful for certain ILL systems. These
strings can be translated using the 'Z3950_STATUS' authorized value.

Test plan:
  1) Start the Z39.50 server using `perl misc/z3950_responder.pl`.
  2) Connect to the server using `yaz-client 127.0.0.1:/biblios`.
  3) Run a search, such as `find @attr 1=1016 book`.
  4) Fetch the results both one at a time with `show 1` and in a batch
 using `show 1+5`.
  5) Turn on MARCXML using `format xml` and `elements marcxml`, and
 verify that the records are still correctly fetched.
  6) Enable the item status subfield by restarting the server with the
 option `--add-item-status=k`.
  7) Search for and fetch records, and verify that a $k subfield is
 added to the item tags as appropriate. It should show some
 combination of "Checked Out", "Lost", "Not For Loan", "Damaged",
 "Withdrawn", "In Transit", or "On Hold" as appropriate, or
 "Available".
  8) Add an authorized value named "Z3950_STATUS" with any of the keys
 "AVAILABLE", "CHECKED_OUT", "LOST", "NOT_FOR_LOAN", "DAMAGED",
 "WITHDRAWN", "IN_TRANSIT" or "ON_HOLD", and verify that their
 descriptions are used instead of the default values above.

Signed-off-by: George Williams 
Signed-off-by: Stefan Berndtsson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala  changed:

   What|Removed |Added

  Attachment #88910|0   |1
is obsolete||

--- Comment #164 from Ere Maijala  ---
Created attachment 91731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91731=edit
Bug 13937: Add unit tests

Signed-off-by: Stefan Berndtsson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala  changed:

   What|Removed |Added

  Attachment #88908|0   |1
is obsolete||

--- Comment #162 from Ere Maijala  ---
Created attachment 91729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91729=edit
Bug 13937: (follow-up) Remove reference to sub _prefetch_records

Remove reference to sub _prefetch_records

It appears this sub is built into fetch and this call is a duplicate

Signed-off-by: George Williams 
Signed-off-by: Stefan Berndtsson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala  changed:

   What|Removed |Added

  Attachment #88912|0   |1
is obsolete||

--- Comment #166 from Ere Maijala  ---
Created attachment 91733
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91733=edit
Bug 13937: Fix issues found in QA

Signed-off-by: Stefan Berndtsson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Ere Maijala  changed:

   What|Removed |Added

  Attachment #88911|0   |1
is obsolete||

--- Comment #165 from Ere Maijala  ---
Created attachment 91732
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91732=edit
Bug 13937: (follow-up) Pass through yaz switches and don't ignore case

Signed-off-by: Stefan Berndtsson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #160 from Ere Maijala  ---
Alex, please see comments #43 - #45. The listening port was changed due to
conflict with Zebra. I'll provide a test plan for SRU.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-05-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #159 from Alex Arnaud  ---
(In reply to Nick Clemens from comment #158)
> Excited about this, but too late for 19.05

Nick,

Can you reproduce the issue on comment #156 ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-05-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Nick Clemens  changed:

   What|Removed |Added

   Keywords|rel_19_05_candidate |
 CC||n...@bywatersolutions.com

--- Comment #158 from Nick Clemens  ---
Excited about this, but too late for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #157 from Alex Arnaud  ---
Also, a test plan for SRU would be great

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Alex Arnaud  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-05-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Alex Arnaud  changed:

   What|Removed |Added

 CC||alex.arn...@biblibre.com

--- Comment #156 from Alex Arnaud  ---
It seems that something breaks the misc/z3950_responder.pl script after the
first patch

 - apply only first patch (Bug 13937: Add a Z39.50 daemon that can inject item
status MARC subfields),
 - run misc/z3950_responder.pl,
 - sudo netstat -tulpn | grep LISTEN
=> tcp6   0  0 ::: :::*LISTEN  
   8918/perl

 - apply all patches,
 - run misc/z3950_responder.pl,
 - sudo netstat -tulpn | grep LISTEN
No listening on 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-05-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Bouzid Fergani  changed:

   What|Removed |Added

 CC||bouzid.ferg...@inlibro.com
 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-05-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Bouzid Fergani  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-05-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||release-notes-needed,
   ||rel_19_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #155 from Ere Maijala  ---
Actually, it's a bit borked. Bug 19575 missed the change to default mappings
file. That will be fixed in bug 22524. I'll check the mappings to match what
should be correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #154 from Fridolin SOMERS  ---
I see there is pubdate in etc/z3950/attribute_mappings.yaml but since Bug 19575
it is date-of-publication, isn't it ?
Maybe check all changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

--- Comment #153 from Katrin Fischer  ---
Wooh! Thx, Stefan! Next time icecream is on me :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Stefan Berndtsson  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Stefan Berndtsson  changed:

   What|Removed |Added

  Attachment #86364|0   |1
is obsolete||

--- Comment #152 from Stefan Berndtsson  ---
Created attachment 88918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88918=edit
Bug 13937: Switch from GetItem() to Koha::Items->find()

Signed-off-by: Stefan Berndtsson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Stefan Berndtsson  changed:

   What|Removed |Added

  Attachment #86363|0   |1
is obsolete||

--- Comment #151 from Stefan Berndtsson  ---
Created attachment 88917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88917=edit
Bug 13937: Fix the daemon log path.

directory _LOG_DIR_/logs does't exists.

All other log4perl -logs are out to _LOG_DIR_

Thank you for the good work Ere!

Signed-off-by: Stefan Berndtsson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Stefan Berndtsson  changed:

   What|Removed |Added

  Attachment #86362|0   |1
is obsolete||

--- Comment #150 from Stefan Berndtsson  ---
Created attachment 88916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88916=edit
Bug 13937: Add support for Z39.50 responder to the Debian scripts

Signed-off-by: Stefan Berndtsson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Stefan Berndtsson  changed:

   What|Removed |Added

  Attachment #86361|0   |1
is obsolete||

--- Comment #149 from Stefan Berndtsson  ---
Created attachment 88915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88915=edit
Bug 13937: Fix RPN conversion

Fixes handling of parenthesis and removes unused quote handling.

Signed-off-by: Stefan Berndtsson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Stefan Berndtsson  changed:

   What|Removed |Added

  Attachment #86360|0   |1
is obsolete||

--- Comment #148 from Stefan Berndtsson  ---
Created attachment 88914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88914=edit
Bug 13937: Add tests for search and retrieval

Sponsored-by: National Library of Finland
Signed-off-by: Stefan Berndtsson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Stefan Berndtsson  changed:

   What|Removed |Added

  Attachment #86358|0   |1
is obsolete||

--- Comment #146 from Stefan Berndtsson  ---
Created attachment 88912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88912=edit
Bug 13937: Fix issues found in QA

Signed-off-by: Stefan Berndtsson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields

2019-04-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Stefan Berndtsson  changed:

   What|Removed |Added

  Attachment #86359|0   |1
is obsolete||

--- Comment #147 from Stefan Berndtsson  ---
Created attachment 88913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88913=edit
Bug 13937: Add support for SRU and Elasticsearch

Splits Session to GenericSession and ZebraSession where Generic supports any
search backend via the SearchEngine classes and Zebra maintains the direct
channel to the Zebra server.

Adds config files required for mapping BIB-1 attributes to Koha search fields
and SRU indexes to BIB-1 attributes.

Adds PODs.

Sponsored-by: National Library of Finland
Signed-off-by: Stefan Berndtsson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >