subject:"\[Koha\-bugs\] \[Bug 14048\] Change RefundLostItemFeeOnReturn to be branch specific"

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2019-05-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18930

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2018-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||21654

--- Comment #98 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #97)
> There is one occurrence left:
> C4/Installer.pm:push @fnames, C4::Context->config('intranetdir') .
> "/installer/data/mysql/mandatory/refund_lost_item_fee_rules.sql";
> 
> Please fix!

See bug 21654, thanks!


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21654
[Bug 21654] Installer is loading a non-existing file
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-12-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-11-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #97 from Jonathan Druart  
---
There is one occurrence left:
C4/Installer.pm:push @fnames, C4::Context->config('intranetdir') .
"/installer/data/mysql/mandatory/refund_lost_item_fee_rules.sql";

Please fix!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-09-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

J Schmidt  changed:

   What|Removed |Added

 CC||jschm...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-07-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nicole C. Engard  changed:

   What|Removed |Added

 CC||a...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-07-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jesse Weaver  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #96 from Jesse Weaver  ---
Pushed to master for the 16.11 release, thanks for your work!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-07-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52894|0   |1
is obsolete||

--- Comment #95 from Jonathan Druart  
---
Created attachment 53029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53029=edit
Bug 14048: (QA followup) Default to 1 if no default rule

This patch answers Jonathan's request to simplify this patchset a bit.

It removes the need for the .sql file, as _default_rule now defaults to
a fixed value (1, which was set by the removed .sql file).
This allowed to remove the overloaded ->delete method.

The tests have been adjusted to reflect this changes, including tests for
the new 'default'-if-absent situation.

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-07-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52883|0   |1
is obsolete||

--- Comment #94 from Jonathan Druart  
---
Created attachment 53028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53028=edit
Bug 14048: Use mock_preference in tests

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-07-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52876|0   |1
is obsolete||

--- Comment #93 from Jonathan Druart  
---
Created attachment 53027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53027=edit
Bug 14048: (QA folloup) C4::Context->preference should be used

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-07-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52843|0   |1
is obsolete||

--- Comment #91 from Jonathan Druart  
---
Created attachment 53025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53025=edit
Bug 14048: (QA followup) Fix typo on syspref value

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-07-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52844|0   |1
is obsolete||

--- Comment #92 from Jonathan Druart  
---
Created attachment 53026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53026=edit
Bug 14048: (followup) Use the original holding branch

This patch picks the item's holding branch *before* it gets fixed
by using the checkin library instead. This way the RefundLostOnReturnControl
syspref set to ItemHoldingBranch is respected (otherwise, as Nick explained
this behaves just like if CheckinLibrary was set)

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-07-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52841|0   |1
is obsolete||

--- Comment #89 from Jonathan Druart  
---
Created attachment 53023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53023=edit
Bug 14048 [QA Followup] - Delete only the removed system preference

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-07-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52839|0   |1
is obsolete||

--- Comment #87 from Jonathan Druart  
---
Created attachment 53021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53021=edit
Bug 14048: [QA Followup]

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-07-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52842|0   |1
is obsolete||

--- Comment #90 from Jonathan Druart  
---
Created attachment 53024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53024=edit
Bug 14048: (QA followup) Update syspref name for HEA

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-07-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52838|0   |1
is obsolete||

--- Comment #86 from Jonathan Druart  
---
Created attachment 53020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53020=edit
Bug 14048: Hook new rules into C4::Circulation

This patch makes AddIssue and AddReturn use the new implementation

The behaviour should respect the specification.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-07-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52840|0   |1
is obsolete||

--- Comment #88 from Jonathan Druart  
---
Created attachment 53022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53022=edit
Bug 14048: Add syspref and atomic update

This patch introduces the changes to the sysprefs and the atomic update
that creates the new table.

It picks the syspref value for RefundLostItemFeeOnReturn and uses it to
create a default (branchcode='*') rule on the new table.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-07-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52836|0   |1
is obsolete||

--- Comment #84 from Jonathan Druart  
---
Created attachment 53018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53018=edit
Bug 14048: Unit tests

This patch introduces unit tests for the feature.
To test:
- Have all patches from this bug applied
- Run:
  $ prove -v t/db_dependent/RefundLostItemFeeRule.t
=> SUCCESS: All tests pass!

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-07-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52837|0   |1
is obsolete||

--- Comment #85 from Jonathan Druart  
---
Created attachment 53019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53019=edit
Bug 14048: Add a refund rules setting form in smart-rules

This patch introduces the CRUD UI for managing the refund lost item fee
rules on the general 'Circulation and fines rules' page.

Verify that rules can be added and changed.

Rules are correctly associated to the chosen branch (or the
general default rule).

To test:
- Apply the patch
- Open smart-rules.pl
=> SUCCESS: The text and refund rules section correctly refers to default
global rules.
   The policy can be set to Yes and No, and works as expected.
- Pick a specific branch
=> SUCCESS: The rule refers to the specific branch
=> SUCCESS: It detects the default rule is picked
=> SUCCESS: On changing the rules values are correctly retrieved if entering
   again to the page.
=> SUCCESS: The 'Use default' text is suffixed with the correct value set by
the user
   in the 'All libraries' scenario.
=> Sign off :-D

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-07-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-07-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52835|0   |1
is obsolete||

--- Comment #83 from Jonathan Druart  
---
Created attachment 53017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53017=edit
Bug 14048: Add RefundLostItemFeeRule table and classes

This patch introduces new classes for handling refund lost item fee
rules. It introduces a new table for storing this rules.

It is designed so it is possible to define a global rule, and then
branch-specific ones. The specific is prefered if available.

This behaviour is fully tested by unit tests introduced by the following
patches.

This cannot be tested on its own.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #82 from Kyle M Hall  ---
(In reply to Tomás Cohen Arazi from comment #81)
> (In reply to Jonathan Druart from comment #80)
> > Could I get this follow-up before passing it?
> > As Kyle suggest, it may be better to use
> > Koha::Circulation::Rules::LostItemFeeRule instead of
> > Koha::Circulation::Rules::RefundLostItemFeeRule but in that case, should not
> > we rename the table too?
> 
> I'd rather pick Koha::Circulation::Rules::RefundLostItemFee

Sounds good! I'll get that followup written asap!

> 
> > And actually should not we rename it to something less specific, with a
> > column named refund_lost_item_fee?
> 
> Pianohacker is working on a circulation rules refactoring. I'm pretty sure
> some global re-engineering is needed to have a better solution. So I'd avoid
> making this bug responsible for such thing.

Agreed. The circ rules revamp will make merge all these tables together, so I
see little need long term for an additional complication. I think this is fine
for the time being.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #81 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #80)
> Could I get this follow-up before passing it?
> As Kyle suggest, it may be better to use
> Koha::Circulation::Rules::LostItemFeeRule instead of
> Koha::Circulation::Rules::RefundLostItemFeeRule but in that case, should not
> we rename the table too?

I'd rather pick Koha::Circulation::Rules::RefundLostItemFee

> And actually should not we rename it to something less specific, with a
> column named refund_lost_item_fee?

Pianohacker is working on a circulation rules refactoring. I'm pretty sure some
global re-engineering is needed to have a better solution. So I'd avoid making
this bug responsible for such thing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #80 from Jonathan Druart  
---
Could I get this follow-up before passing it?
As Kyle suggest, it may be better to use
Koha::Circulation::Rules::LostItemFeeRule instead of
Koha::Circulation::Rules::RefundLostItemFeeRule but in that case, should not we
rename the table too?
And actually should not we rename it to something less specific, with a column
named refund_lost_item_fee?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Kyle M Hall  changed:

   What|Removed |Added

 Whiteboard||Note to RM/Kyle - Change
   ||new module namespace after
   ||it passes qa

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #79 from Tomás Cohen Arazi  ---
(In reply to Kyle M Hall from comment #77)
> I have a small request, could we move Koha::RefundLostItemFeeRule to a more
> refined namespace? I think it would be better long term. I'm thinking
> Koha::Circulation::Rules::LostItemFeeRule but am open to other suggestions.
> I'd also be happy to write the followup for that myself if you find that
> acceptable.

Kyle, I don't have a strong opinion on this. I think you can write that
followup if this passes QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #78 from Tomás Cohen Arazi  ---
Created attachment 52894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52894=edit
Bug 14048: (QA followup) Default to 1 if no default rule

This patch answers Jonathan's request to simplify this patchset a bit.

It removes the need for the .sql file, as _default_rule now defaults to
a fixed value (1, which was set by the removed .sql file).
This allowed to remove the overloaded ->delete method.

The tests have been adjusted to reflect this changes, including tests for
the new 'default'-if-absent situation.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #77 from Kyle M Hall  ---
I have a small request, could we move Koha::RefundLostItemFeeRule to a more
refined namespace? I think it would be better long term. I'm thinking
Koha::Circulation::Rules::LostItemFeeRule but am open to other suggestions. I'd
also be happy to write the followup for that myself if you find that
acceptable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #76 from Jonathan Druart  
---
(In reply to Tomás Cohen Arazi from comment #73)
> (In reply to Jonathan Druart from comment #72)
> > I have squashed the patches for the review, so I won't use the splinter:
> > 
> > 1/ my $item_holding_branch = $item->{ holdingbranch };
> > => would be good to have a comment here to explain the last patch.
> 
> I thought the commit message would be enough. Do u require a comment on the
> code?

Would be good, but not required. Forget it

> > 2/ Koha::Config::SysPrefs->find should not be used, C4::Context->preference
> > should continue to be used everywhere, to take advantage of the syspref
> > cache.
> 
> Ok, followup coming.

I added one also to fix the tests.

> > 3/ $schema->resultset('RefundLostItemFeeRule')->search()->delete;
> > should use Koha::RefundLostItemFeeRules
> 
> This is done on the tests, instead of the usual DELETE FROM ... The problem
> with Koha::RefundLostItemFeeRules is that it explicitly forbis deleting the
> default rule. I'd leave it as it is.

Correct, and I was wondering if it would not be easier to assume that default
is 1 if no rule exist.
It will permit to remove the sql file in the mysql/mandatory dir (and then no
need to manage it from the installer) and no need to overwrite delete. Why do
you think?

> > 4/ Tests only cover RefundLostOnReturnControl = 'CheckinLibrary'
> 
> This is incorrect:
> 
> subtest 'Koha::RefundLostItemFeeRules::_choose_branch() tests'
> => Tries the three possible values
> 
> subtest 'Koha::RefundLostItemFeeRules::should_refund() tests'
> => Tries the three possible values

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #75 from Jonathan Druart  
---
Created attachment 52883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52883=edit
Bug 14048: Use mock_preference in tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #74 from Tomás Cohen Arazi  ---
Created attachment 52876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52876=edit
Bug 14048: (QA folloup) C4::Context->preference should be used

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #73 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #72)
> I have squashed the patches for the review, so I won't use the splinter:
> 
> 1/ my $item_holding_branch = $item->{ holdingbranch };
> => would be good to have a comment here to explain the last patch.

I thought the commit message would be enough. Do u require a comment on the
code?

> 2/ Koha::Config::SysPrefs->find should not be used, C4::Context->preference
> should continue to be used everywhere, to take advantage of the syspref
> cache.

Ok, followup coming.

> 3/ $schema->resultset('RefundLostItemFeeRule')->search()->delete;
> should use Koha::RefundLostItemFeeRules

This is done on the tests, instead of the usual DELETE FROM ... The problem
with Koha::RefundLostItemFeeRules is that it explicitly forbis deleting the
default rule. I'd leave it as it is.

> 4/ Tests only cover RefundLostOnReturnControl = 'CheckinLibrary'

This is incorrect:

subtest 'Koha::RefundLostItemFeeRules::_choose_branch() tests'
=> Tries the three possible values

subtest 'Koha::RefundLostItemFeeRules::should_refund() tests'
=> Tries the three possible values

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #72 from Jonathan Druart  
---
I have squashed the patches for the review, so I won't use the splinter:

1/ my $item_holding_branch = $item->{ holdingbranch };
=> would be good to have a comment here to explain the last patch.

2/ Koha::Config::SysPrefs->find should not be used, C4::Context->preference
should continue to be used everywhere, to take advantage of the syspref cache.

3/ $schema->resultset('RefundLostItemFeeRule')->search()->delete;
should use Koha::RefundLostItemFeeRules

4/ Tests only cover RefundLostOnReturnControl = 'CheckinLibrary'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koha-c
   |y.org   |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #71 from Tomás Cohen Arazi  ---
Patches rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52756|0   |1
is obsolete||

--- Comment #69 from Tomás Cohen Arazi  ---
Created attachment 52843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52843=edit
Bug 14048: (QA followup) Fix typo on syspref value

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52757|0   |1
is obsolete||

--- Comment #70 from Tomás Cohen Arazi  ---
Created attachment 52844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52844=edit
Bug 14048: (followup) Use the original holding branch

This patch picks the item's holding branch *before* it gets fixed
by using the checkin library instead. This way the RefundLostOnReturnControl
syspref set to ItemHoldingBranch is respected (otherwise, as Nick explained
this behaves just like if CheckinLibrary was set)

Signed-off-by: Tomas Cohen Arazi 
Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52753|0   |1
is obsolete||

--- Comment #66 from Tomás Cohen Arazi  ---
Created attachment 52840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52840=edit
Bug 14048: Add syspref and atomic update

This patch introduces the changes to the sysprefs and the atomic update
that creates the new table.

It picks the syspref value for RefundLostItemFeeOnReturn and uses it to
create a default (branchcode='*') rule on the new table.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52755|0   |1
is obsolete||

--- Comment #68 from Tomás Cohen Arazi  ---
Created attachment 52842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52842=edit
Bug 14048: (QA followup) Update syspref name for HEA

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52754|0   |1
is obsolete||

--- Comment #67 from Tomás Cohen Arazi  ---
Created attachment 52841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52841=edit
Bug 14048 [QA Followup] - Delete only the removed system preference

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52752|0   |1
is obsolete||

--- Comment #65 from Tomás Cohen Arazi  ---
Created attachment 52839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52839=edit
Bug 14048: [QA Followup]

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52750|0   |1
is obsolete||

--- Comment #63 from Tomás Cohen Arazi  ---
Created attachment 52837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52837=edit
Bug 14048: Add a refund rules setting form in smart-rules

This patch introduces the CRUD UI for managing the refund lost item fee
rules on the general 'Circulation and fines rules' page.

Verify that rules can be added and changed.

Rules are correctly associated to the chosen branch (or the
general default rule).

To test:
- Apply the patch
- Open smart-rules.pl
=> SUCCESS: The text and refund rules section correctly refers to default
global rules.
   The policy can be set to Yes and No, and works as expected.
- Pick a specific branch
=> SUCCESS: The rule refers to the specific branch
=> SUCCESS: It detects the default rule is picked
=> SUCCESS: On changing the rules values are correctly retrieved if entering
   again to the page.
=> SUCCESS: The 'Use default' text is suffixed with the correct value set by
the user
   in the 'All libraries' scenario.
=> Sign off :-D

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52751|0   |1
is obsolete||

--- Comment #64 from Tomás Cohen Arazi  ---
Created attachment 52838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52838=edit
Bug 14048: Hook new rules into C4::Circulation

This patch makes AddIssue and AddReturn use the new implementation

The behaviour should respect the specification.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52749|0   |1
is obsolete||

--- Comment #62 from Tomás Cohen Arazi  ---
Created attachment 52836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52836=edit
Bug 14048: Unit tests

This patch introduces unit tests for the feature.
To test:
- Have all patches from this bug applied
- Run:
  $ prove -v t/db_dependent/RefundLostItemFeeRule.t
=> SUCCESS: All tests pass!

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52748|0   |1
is obsolete||

--- Comment #61 from Tomás Cohen Arazi  ---
Created attachment 52835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52835=edit
Bug 14048: Add RefundLostItemFeeRule table and classes

This patch introduces new classes for handling refund lost item fee
rules. It introduces a new table for storing this rules.

It is designed so it is possible to define a global rule, and then
branch-specific ones. The specific is prefered if available.

This behaviour is fully tested by unit tests introduced by the following
patches.

This cannot be tested on its own.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 
Signed-off-by: Jason Robb 
Signed-off-by: Jennifer Schmidt 
Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #60 from Jonathan Druart  
---
Applying: Bug 14048: Hook new rules into C4::Circulation
Using index info to reconstruct a base tree...
M   C4/Circulation.pm
Falling back to patching base and 3-way merge...
Auto-merging C4/Circulation.pm
CONFLICT (content): Merge conflict in C4/Circulation.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #52668|0   |1
is obsolete||

--- Comment #59 from Nicole C. Engard  ---
Created attachment 52757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52757=edit
Bug 14048: (followup) Use the original holding branch

This patch picks the item's holding branch *before* it gets fixed
by using the checkin library instead. This way the RefundLostOnReturnControl
syspref set to ItemHoldingBranch is respected (otherwise, as Nick explained
this behaves just like if CheckinLibrary was set)

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Nick Clemens 

Signed-off-by: Jason Robb 

Signed-off-by: Jennifer Schmidt 

Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #52667|0   |1
is obsolete||

--- Comment #58 from Nicole C. Engard  ---
Created attachment 52756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52756=edit
Bug 14048: (QA followup) Fix typo on syspref value

Signed-off-by: Nick Clemens 

Signed-off-by: Jason Robb 

Signed-off-by: Jennifer Schmidt 

Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #52664|0   |1
is obsolete||

--- Comment #55 from Nicole C. Engard  ---
Created attachment 52753
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52753=edit
Bug 14048: Add syspref and atomic update

This patch introduces the changes to the sysprefs and the atomic update
that creates the new table.

It picks the syspref value for RefundLostItemFeeOnReturn and uses it to
create a default (branchcode='*') rule on the new table.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 

Signed-off-by: Jason Robb 

Signed-off-by: Jennifer Schmidt 

Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #52666|0   |1
is obsolete||

--- Comment #57 from Nicole C. Engard  ---
Created attachment 52755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52755=edit
Bug 14048: (QA followup) Update syspref name for HEA

Signed-off-by: Nick Clemens 

Signed-off-by: Jason Robb 

Signed-off-by: Jennifer Schmidt 

Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #52665|0   |1
is obsolete||

--- Comment #56 from Nicole C. Engard  ---
Created attachment 52754
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52754=edit
Bug 14048 [QA Followup] - Delete only the removed system preference

Signed-off-by: Nick Clemens 

Signed-off-by: Jason Robb 

Signed-off-by: Jennifer Schmidt 

Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #52662|0   |1
is obsolete||

--- Comment #53 from Nicole C. Engard  ---
Created attachment 52751
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52751=edit
Bug 14048: Hook new rules into C4::Circulation

This patch makes AddIssue and AddReturn use the new implementation

The behaviour should respect the specification.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 

Signed-off-by: Jason Robb 

Signed-off-by: Jennifer Schmidt 

Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #52663|0   |1
is obsolete||

--- Comment #54 from Nicole C. Engard  ---
Created attachment 52752
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52752=edit
Bug 14048: [QA Followup]

Signed-off-by: Nick Clemens 

Signed-off-by: Jason Robb 

Signed-off-by: Jennifer Schmidt 

Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #52659|0   |1
is obsolete||

--- Comment #50 from Nicole C. Engard  ---
Created attachment 52748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52748=edit
Bug 14048: Add RefundLostItemFeeRule table and classes

This patch introduces new classes for handling refund lost item fee
rules. It introduces a new table for storing this rules.

It is designed so it is possible to define a global rule, and then
branch-specific ones. The specific is prefered if available.

This behaviour is fully tested by unit tests introduced by the following
patches.

This cannot be tested on its own.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 

Signed-off-by: Jason Robb 

Signed-off-by: Jennifer Schmidt 

Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #52660|0   |1
is obsolete||

--- Comment #51 from Nicole C. Engard  ---
Created attachment 52749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52749=edit
Bug 14048: Unit tests

This patch introduces unit tests for the feature.
To test:
- Have all patches from this bug applied
- Run:
  $ prove -v t/db_dependent/RefundLostItemFeeRule.t
=> SUCCESS: All tests pass!

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 

Signed-off-by: Jason Robb 

Signed-off-by: Jennifer Schmidt 

Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #52661|0   |1
is obsolete||

--- Comment #52 from Nicole C. Engard  ---
Created attachment 52750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52750=edit
Bug 14048: Add a refund rules setting form in smart-rules

This patch introduces the CRUD UI for managing the refund lost item fee
rules on the general 'Circulation and fines rules' page.

Verify that rules can be added and changed.

Rules are correctly associated to the chosen branch (or the
general default rule).

To test:
- Apply the patch
- Open smart-rules.pl
=> SUCCESS: The text and refund rules section correctly refers to default
global rules.
   The policy can be set to Yes and No, and works as expected.
- Pick a specific branch
=> SUCCESS: The rule refers to the specific branch
=> SUCCESS: It detects the default rule is picked
=> SUCCESS: On changing the rules values are correctly retrieved if entering
   again to the page.
=> SUCCESS: The 'Use default' text is suffixed with the correct value set by
the user
   in the 'All libraries' scenario.
=> Sign off :-D

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 

Signed-off-by: Jason Robb 

Signed-off-by: Jennifer Schmidt 

Signed-off-by: Margaret Thrasher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nick Clemens  changed:

   What|Removed |Added

  Attachment #52482|0   |1
is obsolete||

--- Comment #48 from Nick Clemens  ---
Created attachment 52667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52667=edit
Bug 14048: (QA followup) Fix typo on syspref value

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nick Clemens  changed:

   What|Removed |Added

  Attachment #52658|0   |1
is obsolete||

--- Comment #49 from Nick Clemens  ---
Created attachment 52668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52668=edit
Bug 14048: (followup) Use the original holding branch

This patch picks the item's holding branch *before* it gets fixed
by using the checkin library instead. This way the RefundLostOnReturnControl
syspref set to ItemHoldingBranch is respected (otherwise, as Nick explained
this behaves just like if CheckinLibrary was set)

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nick Clemens  changed:

   What|Removed |Added

  Attachment #52451|0   |1
is obsolete||

--- Comment #47 from Nick Clemens  ---
Created attachment 52666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52666=edit
Bug 14048: (QA followup) Update syspref name for HEA

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nick Clemens  changed:

   What|Removed |Added

  Attachment #52450|0   |1
is obsolete||

--- Comment #46 from Nick Clemens  ---
Created attachment 52665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52665=edit
Bug 14048 [QA Followup] - Delete only the removed system preference

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nick Clemens  changed:

   What|Removed |Added

  Attachment #52449|0   |1
is obsolete||

--- Comment #45 from Nick Clemens  ---
Created attachment 52664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52664=edit
Bug 14048: Add syspref and atomic update

This patch introduces the changes to the sysprefs and the atomic update
that creates the new table.

It picks the syspref value for RefundLostItemFeeOnReturn and uses it to
create a default (branchcode='*') rule on the new table.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nick Clemens  changed:

   What|Removed |Added

  Attachment #52448|0   |1
is obsolete||

--- Comment #44 from Nick Clemens  ---
Created attachment 52663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52663=edit
Bug 14048: [QA Followup]

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nick Clemens  changed:

   What|Removed |Added

  Attachment #52447|0   |1
is obsolete||

--- Comment #43 from Nick Clemens  ---
Created attachment 52662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52662=edit
Bug 14048: Hook new rules into C4::Circulation

This patch makes AddIssue and AddReturn use the new implementation

The behaviour should respect the specification.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nick Clemens  changed:

   What|Removed |Added

  Attachment #52445|0   |1
is obsolete||

--- Comment #41 from Nick Clemens  ---
Created attachment 52660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52660=edit
Bug 14048: Unit tests

This patch introduces unit tests for the feature.
To test:
- Have all patches from this bug applied
- Run:
  $ prove -v t/db_dependent/RefundLostItemFeeRule.t
=> SUCCESS: All tests pass!

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nick Clemens  changed:

   What|Removed |Added

  Attachment #52446|0   |1
is obsolete||

--- Comment #42 from Nick Clemens  ---
Created attachment 52661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52661=edit
Bug 14048: Add a refund rules setting form in smart-rules

This patch introduces the CRUD UI for managing the refund lost item fee
rules on the general 'Circulation and fines rules' page.

Verify that rules can be added and changed.

Rules are correctly associated to the chosen branch (or the
general default rule).

To test:
- Apply the patch
- Open smart-rules.pl
=> SUCCESS: The text and refund rules section correctly refers to default
global rules.
   The policy can be set to Yes and No, and works as expected.
- Pick a specific branch
=> SUCCESS: The rule refers to the specific branch
=> SUCCESS: It detects the default rule is picked
=> SUCCESS: On changing the rules values are correctly retrieved if entering
   again to the page.
=> SUCCESS: The 'Use default' text is suffixed with the correct value set by
the user
   in the 'All libraries' scenario.
=> Sign off :-D

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nick Clemens  changed:

   What|Removed |Added

  Attachment #52444|0   |1
is obsolete||

--- Comment #40 from Nick Clemens  ---
Created attachment 52659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52659=edit
Bug 14048: Add RefundLostItemFeeRule table and classes

This patch introduces new classes for handling refund lost item fee
rules. It introduces a new table for storing this rules.

It is designed so it is possible to define a global rule, and then
branch-specific ones. The specific is prefered if available.

This behaviour is fully tested by unit tests introduced by the following
patches.

This cannot be tested on its own.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #39 from Tomás Cohen Arazi  ---
Created attachment 52658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52658=edit
Bug 14048: (followup) Use the original holding branch

This patch picks the item's holding branch *before* it gets fixed
by using the checkin library instead. This way the RefundLostOnReturnControl
syspref set to ItemHoldingBranch is respected (otherwise, as Nick explained
this behaves just like if CheckinLibrary was set)

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #38 from Nick Clemens  ---
Retesting, it looks like the itemlost check is done after the checkin, this
means the item holding branch has been updated to the checkin location, so in
the case of 'item holding branch' rule we aren't using the holding branch
before th eitem was checked in which is what I think is intended (i.e. we
should use where the was last held/checked out, not the current transaction
branch)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #37 from Tomás Cohen Arazi  ---
(In reply to Nick Clemens from comment #35)
> Tested well for syspref RefundLostOnReturnControl with values "homebranch"
> and "check-in library"
> 
> When using "item holding branch" I receive the error below:
> Software error: ItemHoldingbranch requires the  param

Nick, it was due to a typo. It should be fixed by the latest followup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #36 from Tomás Cohen Arazi  ---
Created attachment 52482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52482=edit
Bug 14048: (QA followup) Fix typo on syspref value

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #35 from Nick Clemens  ---
Tested well for syspref RefundLostOnReturnControl with values "homebranch" and
"check-in library"

When using "item holding branch" I receive the error below:
Software error: ItemHoldingbranch requires the  param

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #34 from Tomás Cohen Arazi  ---
Created attachment 52451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52451=edit
Bug 14048: (QA followup) Update syspref name for HEA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #33 from Tomás Cohen Arazi  ---
Created attachment 52450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52450=edit
Bug 14048 [QA Followup] - Delete only the removed system preference

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #32 from Tomás Cohen Arazi  ---
Created attachment 52449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52449=edit
Bug 14048: Add syspref and atomic update

This patch introduces the changes to the sysprefs and the atomic update
that creates the new table.

It picks the syspref value for RefundLostItemFeeOnReturn and uses it to
create a default (branchcode='*') rule on the new table.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #31 from Tomás Cohen Arazi  ---
Created attachment 52448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52448=edit
Bug 14048: [QA Followup]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #30 from Tomás Cohen Arazi  ---
Created attachment 52447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52447=edit
Bug 14048: Hook new rules into C4::Circulation

This patch makes AddIssue and AddReturn use the new implementation

The behaviour should respect the specification.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #29 from Tomás Cohen Arazi  ---
Created attachment 52446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52446=edit
Bug 14048: Add a refund rules setting form in smart-rules

This patch introduces the CRUD UI for managing the refund lost item fee
rules on the general 'Circulation and fines rules' page.

Verify that rules can be added and changed.

Rules are correctly associated to the chosen branch (or the
general default rule).

To test:
- Apply the patch
- Open smart-rules.pl
=> SUCCESS: The text and refund rules section correctly refers to default
global rules.
   The policy can be set to Yes and No, and works as expected.
- Pick a specific branch
=> SUCCESS: The rule refers to the specific branch
=> SUCCESS: It detects the default rule is picked
=> SUCCESS: On changing the rules values are correctly retrieved if entering
   again to the page.
=> SUCCESS: The 'Use default' text is suffixed with the correct value set by
the user
   in the 'All libraries' scenario.
=> Sign off :-D

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #28 from Tomás Cohen Arazi  ---
Created attachment 52445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52445=edit
Bug 14048: Unit tests

This patch introduces unit tests for the feature.
To test:
- Have all patches from this bug applied
- Run:
  $ prove -v t/db_dependent/RefundLostItemFeeRule.t
=> SUCCESS: All tests pass!

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #27 from Tomás Cohen Arazi  ---
Created attachment 52444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52444=edit
Bug 14048: Add RefundLostItemFeeRule table and classes

This patch introduces new classes for handling refund lost item fee
rules. It introduces a new table for storing this rules.

It is designed so it is possible to define a global rule, and then
branch-specific ones. The specific is prefered if available.

This behaviour is fully tested by unit tests introduced by the following
patches.

This cannot be tested on its own.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52291|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52292|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52287|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52293|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52286|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52306|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52290|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52289|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #26 from Tomás Cohen Arazi  ---
(In reply to Kyle M Hall from comment #25)
> Created attachment 52306 [details] [review]
> Bug 14048 [QA Followup] - Delete only the removed system preference

Hehe, I don't know why I didn't notice the second line was removed, see the
commented Perl code!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #25 from Kyle M Hall  ---
Created attachment 52306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52306=edit
Bug 14048 [QA Followup] - Delete only the removed system preference

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52288|0   |1
is obsolete||

--- Comment #24 from Tomás Cohen Arazi  ---
Created attachment 52293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52293=edit
Bug 14048: Add syspref and atomic update

This patch introduces the changes to the sysprefs and the atomic update
that creates the new table.

It picks the syspref value for RefundLostItemFeeOnReturn and uses it to
create a default (branchcode='*') rule on the new table.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #20 from Tomás Cohen Arazi  ---
Created attachment 52289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52289=edit
Bug 14048: Add a refund rules setting form in smart-rules

This patch introduces the CRUD UI for managing the refund lost item fee
rules on the general 'Circulation and fines rules' page.

Verify that rules can be added and changed.

Rules are correctly associated to the chosen branch (or the
general default rule).

To test:
- Apply the patch
- Open smart-rules.pl
=> SUCCESS: The text and refund rules section correctly refers to default
global rules.
   The policy can be set to Yes and No, and works as expected.
- Pick a specific branch
=> SUCCESS: The rule refers to the specific branch
=> SUCCESS: It detects the default rule is picked
=> SUCCESS: On changing the rules values are correctly retrieved if entering
   again to the page.
=> SUCCESS: The 'Use default' text is suffixed with the correct value set by
the user
   in the 'All libraries' scenario.
=> Sign off :-D

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #17 from Tomás Cohen Arazi  ---
Created attachment 52286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52286=edit
Bug 14048: Add RefundLostItemFeeRule table and classes

This patch introduces new classes for handling refund lost item fee
rules. It introduces a new table for storing this rules.

It is designed so it is possible to define a global rule, and then
branch-specific ones. The specific is prefered if available.

This behaviour is fully tested by unit tests introduced by the following
patches.

This cannot be tested on its own.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #18 from Tomás Cohen Arazi  ---
Created attachment 52287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52287=edit
Bug 14048: Unit tests

This patch introduces unit tests for the feature.
To test:
- Have all patches from this bug applied
- Run:
  $ prove -v t/db_dependent/RefundLostItemFeeRule.t
=> SUCCESS: All tests pass!

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #22 from Tomás Cohen Arazi  ---
Created attachment 52291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52291=edit
Bug 14048: [QA Followup]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #23 from Tomás Cohen Arazi  ---
Created attachment 52292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52292=edit
Bug 14048: (QA followup) Fix for TooMany.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #21 from Tomás Cohen Arazi  ---
Created attachment 52290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52290=edit
Bug 14048: Hook new rules into C4::Circulation

This patch makes AddIssue and AddReturn use the new implementation

The behaviour should respect the specification.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #19 from Tomás Cohen Arazi  ---
Created attachment 52288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52288=edit
Bug 14048: Add syspref and atomic update

This patch introduces the changes to the sysprefs and the atomic update
that creates the new table.

It picks the syspref value for RefundLostItemFeeOnReturn and uses it to
create a default (branchcode='*') rule on the new table.

Sponsored-by: DoverNet
Sponsored-by: South-East Kansas Library System
Sponsored-by: SWITCH Library Consortium

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

2016-06-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #52019|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 131 matches

Mail list logo