[Koha-bugs] [Bug 14125] Version variable not properly replaced in csv profiles help page

2015-05-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14125

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Katrina!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14125] Version variable not properly replaced in csv profiles help page

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14125

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14125] Version variable not properly replaced in csv profiles help page

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14125

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #38797|0   |1
is obsolete||
  Attachment #38799|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 38845
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38845action=edit
[PASSED QA] Bug 14125: Fix template problems on csv profiles help page

Page uses TAGS Directive in order to print TT directives
in the manual without having them interpreted, but fails
to switch back/change all following TT code, causing
problems in displaying the file correctly.

See TT documentation:
http://www.template-toolkit.org/docs/manual/Directives.html#section_TAGS

As [- ... -] showed up in translations, I chose to switch back
instead of changing the TT variable and INCLUDE.

To test:
- Go to tools  csv profiles
- Open the help page
- Verify the link to the manual includes the version and works
- Verify the footer shows up correctly with the edit buttons

Works as expected.
Signed-off-by: Marc Veron ve...@veron.ch

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14125] Version variable not properly replaced in csv profiles help page

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14125

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14125] Version variable not properly replaced in csv profiles help page

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14125

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14125] Version variable not properly replaced in csv profiles help page

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14125

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 38797
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38797action=edit
Bug 14125: Fix template problems on csv profiles help page

Page uses TAGS Directive in order to print TT directives
in the manual without having them interpreted, but fails
to switch back/change all following TT code, causing
problems in displaying the file correctly.

See TT documentation:
http://www.template-toolkit.org/docs/manual/Directives.html#section_TAGS

As [- ... -] showed up in translations, I chose to switch back
instead of changing the TT variable and INCLUDE.

To test:
- Go to tools  csv profiles
- Open the help page
- Verify the link to the manual includes the version and works
- Verify the footer shows up correctly with the edit buttons

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14125] Version variable not properly replaced in csv profiles help page

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14125

--- Comment #2 from Marc Véron ve...@veron.ch ---
Created attachment 38799
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38799action=edit
[Signed-off] Bug 14125: Fix template problems on csv profiles help page

Page uses TAGS Directive in order to print TT directives
in the manual without having them interpreted, but fails
to switch back/change all following TT code, causing
problems in displaying the file correctly.

See TT documentation:
http://www.template-toolkit.org/docs/manual/Directives.html#section_TAGS

As [- ... -] showed up in translations, I chose to switch back
instead of changing the TT variable and INCLUDE.

To test:
- Go to tools  csv profiles
- Open the help page
- Verify the link to the manual includes the version and works
- Verify the footer shows up correctly with the edit buttons

Works as expected.
Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14125] Version variable not properly replaced in csv profiles help page

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14125

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/