[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

M. Tompsett  changed:

   What|Removed |Added

   Severity|enhancement |minor
 Status|NEW |ASSIGNED
   Assignee|ch...@bigballofwax.co.nz|mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

--- Comment #1 from M. Tompsett  ---
Created attachment 38835
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38835&action=edit
Bug 14144: Silence warnings in t/db_dependent/Auth_with_ldap.t

TEST PLAN
--
1) prove t/db_dependent/Auth_with_ldap.t
   -- there is a shibboleth related warning
2) apply patch
3) prove t/db_dependent/Auth_with_ldap.t
   -- now there is not.
4) koha qa test tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

M. Tompsett  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2015-05-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

M. Tompsett  changed:

   What|Removed |Added

  Attachment #38835|0   |1
is obsolete||

--- Comment #2 from M. Tompsett  ---
Created attachment 38836
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38836&action=edit
Bug 14144: Silence warnings in t/db_dependent/Auth_with_ldap.t

TEST PLAN
--
1) prove t/db_dependent/Auth_with_ldap.t
   -- there is a shibboleth related warning
2) apply patch
3) prove t/db_dependent/Auth_with_ldap.t
   -- now there is not.
4) koha qa test tools.

NOTE: Further investigation determined this would merely
  delay it, as the function is not called by this test.
  A delay is better than nothing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

--- Comment #3 from M. Tompsett  ---
Created attachment 49882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49882&action=edit
Bug 14144: Silence warnings t/db_dependent/Auth_with_ldap.t

Revisiting this bug, I noticed that C4::Context->config() was mocked
poorly. I expanded the mock function a little and have quieted the
test which seemed to be working in a broken manner before.

TEST PLAN
-
1) prove t/db_dependend/Auth_with_ldap.t
   -- shibboleth noise
2) apply patch
3) prove t/db_dependend/Auth_with_ldap.t
   -- no noise
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

M. Tompsett  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

M. Tompsett  changed:

   What|Removed |Added

  Attachment #49882|0   |1
is obsolete||

--- Comment #4 from M. Tompsett  ---
Created attachment 49883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49883&action=edit
Bug 14144: Silence warnings t/db_dependent/Auth_with_ldap.t

Revisiting this bug, I noticed that C4::Context->config() was mocked
poorly. I expanded the mock function a little and have quieted the
test which seemed to be working in a broken manner before.

TEST PLAN
-
1) prove t/db_dependend/Auth_with_ldap.t
   -- shibboleth noise
2) apply patch
3) prove t/db_dependend/Auth_with_ldap.t
   -- no noise
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

--- Comment #5 from M. Tompsett  ---
Created attachment 49884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49884&action=edit
Bug 14144: Silence warnings t/db_dependent/Auth_with_ldap.t

A little perlcritic cleanup and perltidy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

M. Tompsett  changed:

   What|Removed |Added

  Attachment #49883|0   |1
is obsolete||
  Attachment #49884|0   |1
is obsolete||

--- Comment #6 from M. Tompsett  ---
Created attachment 49885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49885&action=edit
Bug 14144: Silence warnings t/db_dependent/Auth_with_ldap.t

Revisiting this bug, I noticed that C4::Context->config() was mocked
poorly. I expanded the mock function a little and have quieted the
test which seemed to be working in a broken manner before.

TEST PLAN
-
1) prove t/db_dependend/Auth_with_ldap.t
   -- shibboleth noise
2) apply this patch
3) prove t/db_dependend/Auth_with_ldap.t
   -- no noise
4) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

--- Comment #7 from M. Tompsett  ---
Created attachment 49886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49886&action=edit
Bug 14144: Clean ups and refactors

perltidy
old new calls to new call format
attrType -> attr_type (perlcritic friendlier)
double quotes to single quotes
'' combinations to q{} (perlcritic friendlier)
refactored parameters to mock_net_ldap_search into a HASH

This piece is not necessary, but I think it is nicer.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

M. Tompsett  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #8 from M. Tompsett  ---
There are three patches here. I believe that the second one is the best
solution. The third one is clean up and refactors and is not necessary. All
three can be applied at once. The third requires the second one first. The
first can be applied alone.
Testing is merely a prove t/db_dependent/Auth_with_ldap.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #38836|0   |1
is obsolete||

--- Comment #9 from Héctor Eduardo Castro Avalos  ---
Created attachment 50538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50538&action=edit
[SIGNED-OFF]Bug 14144: Silence warnings in t/db_dependent/Auth_with_ldap.t

TEST PLAN
--
1) prove t/db_dependent/Auth_with_ldap.t
   -- there is a shibboleth related warning
2) apply patch
3) prove t/db_dependent/Auth_with_ldap.t
   -- now there is not.
4) koha qa test tools.

NOTE: Further investigation determined this would merely
  delay it, as the function is not called by this test.
  A delay is better than nothing.

Signed-off-by: Hector Castro 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #49886|0   |1
is obsolete||

--- Comment #11 from Héctor Eduardo Castro Avalos  
---
Created attachment 50540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50540&action=edit
[SIGNED-OFF]Bug 14144: Clean ups and refactors

perltidy
old new calls to new call format
attrType -> attr_type (perlcritic friendlier)
double quotes to single quotes
'' combinations to q{} (perlcritic friendlier)
refactored parameters to mock_net_ldap_search into a HASH

This piece is not necessary, but I think it is nicer.

Signed-off-by: Hector Castro 
Works as expected. No koha-qa erros

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #49885|0   |1
is obsolete||

--- Comment #10 from Héctor Eduardo Castro Avalos  
---
Created attachment 50539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50539&action=edit
[SIGNED-OFF]Bug 14144: Silence warnings t/db_dependent/Auth_with_ldap.t

Revisiting this bug, I noticed that C4::Context->config() was mocked
poorly. I expanded the mock function a little and have quieted the
test which seemed to be working in a broken manner before.

TEST PLAN
-
1) prove t/db_dependend/Auth_with_ldap.t
   -- shibboleth noise
2) apply this patch
3) prove t/db_dependend/Auth_with_ldap.t
   -- no noise
4) run koha qa test tools

Signed-off-by: Hector Castro 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||hector.hecax...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |In Discussion

--- Comment #12 from Jonathan Druart  
---
> NOTE: Further investigation determined this would merely
>   delay it, as the function is not called by this test.
>   A delay is better than nothing.

I do not have the time right now to investigate but I disagree with this note.
The carp occurs because some shibboleth stuffs are done in the BEGIN block of
C4::Auth.
I don't think we want to skip the evaluation at compilation time here for this
module.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

--- Comment #13 from M. Tompsett  ---
(In reply to Jonathan Druart from comment #12)
[SNIP disagreement with NOTE]
> The carp occurs because some shibboleth stuffs are done in the BEGIN block
> of C4::Auth.
> I don't think we want to skip the evaluation at compilation time here for
> this module.

Which is why I revisited the bug. Just apply the last two.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

--- Comment #14 from Jonathan Druart  
---
So should the first patch be obsoleted?

If I apply the 2 last patches, then:
% perltidy t/db_dependent/Auth_with_ldap.t 
% perltidy --profile=xt/perltidyrc t/db_dependent/Auth_with_ldap.t 
% diff t/db_dependent/Auth_with_ldap.t{,.tdy} | wc -l
I get 186

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

--- Comment #15 from M. Tompsett  ---
(In reply to Jonathan Druart from comment #14)
> So should the first patch be obsoleted?
> 
> If I apply the 2 last patches, then:
> % perltidy t/db_dependent/Auth_with_ldap.t 
> % perltidy --profile=xt/perltidyrc t/db_dependent/Auth_with_ldap.t 
> % diff t/db_dependent/Auth_with_ldap.t{,.tdy} | wc -l
> I get 186

So, I retested.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12267#c19

Yes, I'll obsolete it.

And lastly, I didn't use that perltidyrc. I used whatever is default in Debian
8, such that the errors in perlcritic -1 where ones I didn't care about and it
didn't complain about being untidy.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

M. Tompsett  changed:

   What|Removed |Added

  Attachment #50538|0   |1
is obsolete||

--- Comment #16 from M. Tompsett  ---
Comment on attachment 50538
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50538
[SIGNED-OFF]Bug 14144: Silence warnings in t/db_dependent/Auth_with_ldap.t

Compile time vs. Run time error checking. Not really a good solution.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

M. Tompsett  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

--- Comment #17 from M. Tompsett  ---
Switching to signed off, since the sign off pre-dated the busting by bug 12267
requiring the schema files to be regenerated.

./misc/devel/update_dbix_class_files.pl -db_name=koha_library -db_user=...
-db_passwd=...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #50539|0   |1
is obsolete||
  Attachment #50540|0   |1
is obsolete||

--- Comment #18 from Kyle M Hall  ---
Created attachment 50920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50920&action=edit
Bug 14144: Silence warnings t/db_dependent/Auth_with_ldap.t

Revisiting this bug, I noticed that C4::Context->config() was mocked
poorly. I expanded the mock function a little and have quieted the
test which seemed to be working in a broken manner before.

TEST PLAN
-
1) prove t/db_dependend/Auth_with_ldap.t
   -- shibboleth noise
2) apply this patch
3) prove t/db_dependend/Auth_with_ldap.t
   -- no noise
4) run koha qa test tools

Signed-off-by: Hector Castro 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

--- Comment #19 from Kyle M Hall  ---
Created attachment 50921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50921&action=edit
Bug 14144: Clean ups and refactors

perltidy
old new calls to new call format
attrType -> attr_type (perlcritic friendlier)
double quotes to single quotes
'' combinations to q{} (perlcritic friendlier)
refactored parameters to mock_net_ldap_search into a HASH

This piece is not necessary, but I think it is nicer.

Signed-off-by: Hector Castro 
Works as expected. No koha-qa erros

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #20 from Kyle M Hall  ---
Pushed to master for the May 2016 release! Dziekuje Mark!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14144] Silence warnings t/db_dependent/Auth_with_ldap.t

2016-05-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14144

Julian Maurice  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||julian.maur...@biblibre.com

--- Comment #21 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/