[Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Status|Pushed to Master|Pushed to Stable --- Comment #6 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #39145|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 39187 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39187action=edit [PASSED QA] Bug 14194: Restore the HH:MM to 23:59 for onsite-checkouts (Introduced by bug 13601) Test plan = 1/ enable 'OnSiteCheckouts' pref under Circulation Preferences 2/ go to the checkouts page and try to issue an item to any user. 3/ when the item barcode entry form shows, select the 'On-site checkout' checkbox 4/ the default date due should show as today with 00:00 as HH:MM 5/ apply the patch 6/ repeat steps 2 - 3. The default date due should show today's date with 23:59 as HH:MM. 7/ run koha-qa.pl -c 1 -v 2 Remarks: Testing result match expected test plan output. The QA tests pass with OK for the commit. Technical note: There is a confusion with iso and sql date formats at some places in the code. A better way should be provided (later) to fix globally the mismatch between these 2 formats. What happened before this patch: the DateTime was cast to a string and the template received -MM-DDTHH:MM:SS which is an iso formatted date. BUT this format is not managed by Koha::DateUtils::output_pref (iso and sql are considered as indentical which is wrong). As I did not estimated the problem (how big it is) I prefer to fix it easily (and dirty) for now. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) indr...@gmail.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39134 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39134action=edit Bug 14194: Restore the HH:MM to 23:59 for onsite-checkouts (Introduced by bug 13601) Test plan: 1/ Enable On-site checkouts 2/ Go on the checkouts page 3/ Click on the On-site checkout checkbox = The default date due should be today with 23:59 as HH:MM (not 00:00). Technical note: There is a confusion with iso and sql date formats at some places in the code. A better way should be provided (later) to fix globally the mismatch between these 2 formats. What happened before this patch: the DateTime was cast to a string and the template received -MM-DDTHH:MM:SS which is an iso formatted date. BUT this format is not managed by Koha::DateUtils::output_pref (iso and sql are considered as indentical which is wrong). As I did not estimated the problem (how big it is) I prefer to fix it easily (and dirty) for now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #39134|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39137 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39137action=edit Bug 14194: Restore the HH:MM to 23:59 for onsite-checkouts (Introduced by bug 13601) Test plan: 1/ Enable On-site checkouts 2/ Go on the checkouts page 3/ Click on the On-site checkout checkbox = The default date due should be today with 23:59 as HH:MM (not 00:00). Technical note: There is a confusion with iso and sql date formats at some places in the code. A better way should be provided (later) to fix globally the mismatch between these 2 formats. What happened before this patch: the DateTime was cast to a string and the template received -MM-DDTHH:MM:SS which is an iso formatted date. BUT this format is not managed by Koha::DateUtils::output_pref (iso and sql are considered as indentical which is wrong). As I did not estimated the problem (how big it is) I prefer to fix it easily (and dirty) for now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||14045 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added Attachment #39137|0 |1 is obsolete|| --- Comment #3 from Indranil Das Gupta indr...@gmail.com --- Created attachment 39145 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39145action=edit Bug 14194: Restore the HH:MM to 23:59 for onsite-checkouts (Introduced by bug 13601) Test plan = 1/ enable 'OnSiteCheckouts' pref under Circulation Preferences 2/ go to the checkouts page and try to issue an item to any user. 3/ when the item barcode entry form shows, select the 'On-site checkout' checkbox 4/ the default date due should show as today with 00:00 as HH:MM 5/ apply the patch 6/ repeat steps 2 - 3. The default date due should show today's date with 23:59 as HH:MM. 7/ run koha-qa.pl -c 1 -v 2 Remarks: Testing result match expected test plan output. The QA tests pass with OK for the commit. Technical note: There is a confusion with iso and sql date formats at some places in the code. A better way should be provided (later) to fix globally the mismatch between these 2 formats. What happened before this patch: the DateTime was cast to a string and the template received -MM-DDTHH:MM:SS which is an iso formatted date. BUT this format is not managed by Koha::DateUtils::output_pref (iso and sql are considered as indentical which is wrong). As I did not estimated the problem (how big it is) I prefer to fix it easily (and dirty) for now. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14194] Date due for on-site checkouts defaults to 00:00 for hh:mm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14194 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added CC||indr...@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
