[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 M. Tompsett changed: What|Removed |Added Summary|Moving the OPAC language|Make the OPAC language |switcher to masthead navbar |switcher available in the ||masthead navbar, footer, or ||both. Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #47 from Indranil Das Gupta --- (In reply to M. Tompsett from comment #46) > Comment on attachment 39725 [details] [review] > (Followup) Fixed issues pointed to in comment #40 > > Review of attachment 39725 [details] [review]: > - > The default value should be 'foot'. New system preferences should not change > current behaviours. Mark, While I acknowledge the part that it shouldn't change current behavior, I do not agree with you on this. Earlier there was only 'foot', it is still retained by 'both', the masthead is an addition, not a replacement. The whole point of having the masthead switcher is nullified IMO if it is not available along with the earlier footer placement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #48 from M. Tompsett --- Created attachment 39727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39727&action=edit Bug 14252: Follow up noprint and default values TEST PLAN - 0) Back up your DB 1) open OPAC -- should only have languages in footer. Annoyingly below the fold. 2) Drop your koha database, and create a blank one. 3) Apply all patches 4) Go to staff client and do an install of koha, with all the dummy data. 5) Once installed, refresh your OPAC page -- language selector position should be in footer still as expected. -- this confirms the sysprefs.sql change. 6) Restore your DB 7) run the updatedatabase.pl script 8) Refresh the OPAC page -- should still only have languages in the footer. -- this confirms that upgrade won't change anything. -- this confirms the atomic update. 9) git diff origin/master -- the opac-bottom.inc difference should only have changes around a SET, IF, and END. This confirms the noprint was fixed. 10) In the staff client, change the OPAC system preference, OpacLangSelectorMode, to all three values. For each value, refresh the OPAC page, and confirm the position of the language selector. -- should work as expected. 11) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 M. Tompsett changed: What|Removed |Added Attachment #39443|0 |1 is obsolete|| --- Comment #49 from M. Tompsett --- Created attachment 39728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39728&action=edit Bug 14252 - Move OPAC lang switcher to masthead navbar The OPAC language switcher takes up a lot of space at the bottom of the browser. It also has issues of being not always visible. This patch adds the switcher to the masthead navbar and removes from the opac-bottom.inc navbar. Test plan = 1/ Apply patch 2/ Set opaclanguagesdisplay syspref to 'show'. 3/ Add a few languages i.e. es-ES, fr-FR and de-DE $ cd misc/translator $ perl translate 4/ Enable installed languages for OPAC use by checking on 'opaclanguages' under I18N/L10N sysprefs 5/ Go to the OPAC, you should have a "Languages" dropdown on the masthead navbar, the opac-bottom.inc navbar should no longer be there. Signed-off-by: Bernardo Gonzalez Kriegel Works, no koha-qa errors. Followup fix language chooser for sublanguages Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 M. Tompsett changed: What|Removed |Added Attachment #39707|0 |1 is obsolete|| --- Comment #51 from M. Tompsett --- Created attachment 39730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39730&action=edit (followup) Adds OpacLangSelectorMode syspref Based on discussion, this followup does the following: 1/ brings back the switcher on opac-bottom.inc 2/ adds a syspref OpacLangSelectorMode to toggle between the three modes: (a) show switcher both on masthead and footer (default) (b) footer only (b) masthead only Test plan = 1/ apply earlier patches attached to this bug in their correct order 2/ apply this followup patch 3/ run updatedatabase.pl to add in the atomic update 4/ goto admin/preferences.pl?tab=opac 5/ look up OpacLangSelectorMode, it should be set with default value "both masthead and footer" 6/ check OPAC to see if both locations show the selectors 7/ change OpacLangSelectorMode to 'only header' and 'only footer' at each iteration, and check if the selection has correctly toggled the selectors. It should Note: make sure you do not have the patch 11057 applied on the branch from before, otherwise merge conflict might happen. http://bugs.koha-community.org/show_bug.cgi?id=14252 Followed test plan. Works as expected. Signed-off-by: Marc Véron Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 M. Tompsett changed: What|Removed |Added Attachment #39706|0 |1 is obsolete|| --- Comment #50 from M. Tompsett --- Created attachment 39729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39729&action=edit Bug 14252: (followup) fix lang chooser for sublanguages This quick fix disables sublanguages dropdown, show all sublanguages on same level. To test: 1) Apply both patches 2) Translate to have sublanguages (en-NZ, de-DE, de-CH) 3) Go to opac, confirm you can select any lang/sublang 4) Check on movil device 4th version. Removed rfc4646 subtag on sublanguages, think it's cleaner. Currently on master all translated languages/regions have valid description ('en' at least) Added language sort using rfc4646 subtag Signed-off-by: Indranil Das Gupta Followup fixes the issue with lang group dropdowns. Works well across standard desktop as well as mobile device with small screens (checked on 4.3" / 4.7" / 5") Works as expected. Signed-off-by: Marc Véron Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 M. Tompsett changed: What|Removed |Added Attachment #39726|0 |1 is obsolete|| --- Comment #53 from M. Tompsett --- Created attachment 39732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39732&action=edit (fix) address the indentation for the lang loop tidy the indentation for that lang selector loop code. http://bugs.koha-community.org/show_bug.cgi?id=14252 Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 M. Tompsett changed: What|Removed |Added Attachment #39725|0 |1 is obsolete|| --- Comment #52 from M. Tompsett --- Created attachment 39731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39731&action=edit (Followup) Fixed issues pointed to in comment #40 Based on Mark's inputs in comment #40 - [1] selected 'mast' (short of 'masthead') and updated : (a) bug_14252-OpacLangSelectorMode_syspref.sql (b) sysprefs.sql (c) opac.pref [2] Reduced the calls to Koha.Preference() from : (a) masthead.inc (b) opac-bottom.inc After applying this patch, update the database once for it to pick up the new option values -'both|mast|foot'. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 M. Tompsett changed: What|Removed |Added Attachment #39727|0 |1 is obsolete|| --- Comment #54 from M. Tompsett --- Created attachment 39733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39733&action=edit Bug 14252: Follow up noprint and default values TEST PLAN - 0) Back up your DB 1) open OPAC -- should only have languages in footer. Annoyingly below the fold. 2) Drop your koha database, and create a blank one. 3) Apply all patches 4) Go to staff client and do an install of koha, with all the dummy data. 5) Once installed, refresh your OPAC page -- language selector position should be in footer still as expected. -- this confirms the sysprefs.sql change. 6) Restore your DB 7) run the updatedatabase.pl script 8) Refresh the OPAC page -- should still only have languages in the footer. -- this confirms that upgrade won't change anything. -- this confirms the atomic update. 9) git diff origin/master -- the opac-bottom.inc difference should only have changes around a SET, IF, and END. This confirms the noprint was fixed. 10) In the staff client, change the OPAC system preference, OpacLangSelectorMode, to all three values. For each value, refresh the OPAC page, and confirm the position of the language selector. -- should work as expected. 11) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Indranil Das Gupta changed: What|Removed |Added Attachment #39733|0 |1 is obsolete|| --- Comment #55 from Indranil Das Gupta --- Created attachment 39734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39734&action=edit Bug 14252: Follow up noprint and default values TEST PLAN - 0) Back up your DB 1) open OPAC -- should only have languages in footer. Annoyingly below the fold. 2) Drop your koha database, and create a blank one. 3) Apply all patches 4) Go to staff client and do an install of koha, with all the dummy data. 5) Once installed, refresh your OPAC page -- language selector position should be in footer still as expected. -- this confirms the sysprefs.sql change. 6) Restore your DB 7) run the updatedatabase.pl script 8) Refresh the OPAC page -- should still only have languages in the footer. -- this confirms that upgrade won't change anything. -- this confirms the atomic update. 9) git diff origin/master -- the opac-bottom.inc difference should only have changes around a SET, IF, and END. This confirms the noprint was fixed. 10) In the staff client, change the OPAC system preference, OpacLangSelectorMode, to all three values. For each value, refresh the OPAC page, and confirm the position of the language selector. -- should work as expected. 11) run koha qa test tools Signed-off-by: Mark Tompsett Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Indranil Das Gupta changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #56 from Katrin Fischer --- Hm, I think maybe a compromise: new installations (sysprefs.sql) could be set to both, while we keep it for existing installations at 'foot'. Looking at this, and hoping not to be to nit-picky - why not use top|both|footer? Mast looks a bit weird and quite template specific. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #57 from Indranil Das Gupta --- Created attachment 39746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39746&action=edit (followup) addresses the QA Manager comments Addresses Katrin's comments in comment# 56 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Indranil Das Gupta changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #58 from Indranil Das Gupta --- (In reply to Katrin Fischer from comment #56) > Hm, I think maybe a compromise: new installations (sysprefs.sql) could be > set to both, while we keep it for existing installations at 'foot'. Mark and I both agree with that! Nice suggestion! > Looking at this, and hoping not to be to nit-picky - why not use > top|both|footer? Mast looks a bit weird and quite template specific. ^^^ Done! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 M. Tompsett changed: What|Removed |Added Attachment #39746|0 |1 is obsolete|| --- Comment #59 from M. Tompsett --- Created attachment 39749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39749&action=edit Bug 14252: (followup) addresses the QA Manager comments Addresses Katrin's comments in comment# 56 TEST PLAN - 1) Back up your DB 2) Ensure you have multiple languages, including some that have sub-languages (e.g. de-DE, de-CH) -- cd misc/translator -- perl translate install {language code} 3) Ensure that you have all the languages enabled -- Staff client -> Home -> Global system preferences --> I18N/L10N Check all the languages in opaclanguages. Ensure that opaclanguagesdisplay is 'Allow' 4) Open OPAC -- should only have languages in footer. Annoyingly below the fold. 5) Drop your koha database, and create a blank one. 6) Apply all patches 7) Reinstall all the known languages, so the templates are appropriately updated. 8) Go to staff client and do an install of koha, with all the dummy data. 9) Ensure you have all the languages enabled (see (3)) 10) Refresh your OPAC page -- language selector position should be in both the footer and at the top as expected. -- this confirms the sysprefs.sql change. 11) Restore your DB 12) run the updatedatabase.pl script 13) Ensure you have all the languages enabled (see (3)) 14) Refresh the OPAC page -- should still only have languages in the footer. -- this confirms that upgrade won't change anything. -- this confirms the atomic update. 15) git diff origin/master -- the opac-bottom.inc difference should only have changes around a SET, IF, and END. This confirms the noprint was fixed. 16) In the staff client, change the OPAC system preference, OpacLangSelectorMode, to all three values. For each value, refresh the OPAC page, and confirm the position of the language selector. -- should work as expected. 17) run koha qa test tools NOTE: Tested as a single batch together. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #61 from Jonathan Druart --- Created attachment 39858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39858&action=edit Bug 14252: (followup) fix lang chooser for sublanguages This quick fix disables sublanguages dropdown, show all sublanguages on same level. To test: 1) Apply both patches 2) Translate to have sublanguages (en-NZ, de-DE, de-CH) 3) Go to opac, confirm you can select any lang/sublang 4) Check on movil device 4th version. Removed rfc4646 subtag on sublanguages, think it's cleaner. Currently on master all translated languages/regions have valid description ('en' at least) Added language sort using rfc4646 subtag Signed-off-by: Indranil Das Gupta Followup fixes the issue with lang group dropdowns. Works well across standard desktop as well as mobile device with small screens (checked on 4.3" / 4.7" / 5") Works as expected. Signed-off-by: Marc Véron Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #63 from Jonathan Druart --- Created attachment 39860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39860&action=edit Bug 14252: (Followup) Fixed issues pointed to in comment #40 Based on Mark's inputs in comment #40 - [1] selected 'mast' (short of 'masthead') and updated : (a) bug_14252-OpacLangSelectorMode_syspref.sql (b) sysprefs.sql (c) opac.pref [2] Reduced the calls to Koha.Preference() from : (a) masthead.inc (b) opac-bottom.inc After applying this patch, update the database once for it to pick up the new option values -'both|mast|foot'. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Jonathan Druart changed: What|Removed |Added Attachment #39728|0 |1 is obsolete|| Attachment #39729|0 |1 is obsolete|| Attachment #39730|0 |1 is obsolete|| Attachment #39731|0 |1 is obsolete|| Attachment #39732|0 |1 is obsolete|| Attachment #39734|0 |1 is obsolete|| Attachment #39749|0 |1 is obsolete|| --- Comment #60 from Jonathan Druart --- Created attachment 39857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39857&action=edit Bug 14252 - Move OPAC lang switcher to masthead navbar The OPAC language switcher takes up a lot of space at the bottom of the browser. It also has issues of being not always visible. This patch adds the switcher to the masthead navbar and removes from the opac-bottom.inc navbar. Test plan = 1/ Apply patch 2/ Set opaclanguagesdisplay syspref to 'show'. 3/ Add a few languages i.e. es-ES, fr-FR and de-DE $ cd misc/translator $ perl translate 4/ Enable installed languages for OPAC use by checking on 'opaclanguages' under I18N/L10N sysprefs 5/ Go to the OPAC, you should have a "Languages" dropdown on the masthead navbar, the opac-bottom.inc navbar should no longer be there. Signed-off-by: Bernardo Gonzalez Kriegel Works, no koha-qa errors. Followup fix language chooser for sublanguages Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #66 from Jonathan Druart --- Created attachment 39863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39863&action=edit Bug 14252: (followup) addresses the QA Manager comments Addresses Katrin's comments in comment# 56 TEST PLAN - 1) Back up your DB 2) Ensure you have multiple languages, including some that have sub-languages (e.g. de-DE, de-CH) -- cd misc/translator -- perl translate install {language code} 3) Ensure that you have all the languages enabled -- Staff client -> Home -> Global system preferences --> I18N/L10N Check all the languages in opaclanguages. Ensure that opaclanguagesdisplay is 'Allow' 4) Open OPAC -- should only have languages in footer. Annoyingly below the fold. 5) Drop your koha database, and create a blank one. 6) Apply all patches 7) Reinstall all the known languages, so the templates are appropriately updated. 8) Go to staff client and do an install of koha, with all the dummy data. 9) Ensure you have all the languages enabled (see (3)) 10) Refresh your OPAC page -- language selector position should be in both the footer and at the top as expected. -- this confirms the sysprefs.sql change. 11) Restore your DB 12) run the updatedatabase.pl script 13) Ensure you have all the languages enabled (see (3)) 14) Refresh the OPAC page -- should still only have languages in the footer. -- this confirms that upgrade won't change anything. -- this confirms the atomic update. 15) git diff origin/master -- the opac-bottom.inc difference should only have changes around a SET, IF, and END. This confirms the noprint was fixed. 16) In the staff client, change the OPAC system preference, OpacLangSelectorMode, to all three values. For each value, refresh the OPAC page, and confirm the position of the language selector. -- should work as expected. 17) run koha qa test tools NOTE: Tested as a single batch together. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #65 from Jonathan Druart --- Created attachment 39862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39862&action=edit Bug 14252: Follow up noprint and default values TEST PLAN - 0) Back up your DB 1) open OPAC -- should only have languages in footer. Annoyingly below the fold. 2) Drop your koha database, and create a blank one. 3) Apply all patches 4) Go to staff client and do an install of koha, with all the dummy data. 5) Once installed, refresh your OPAC page -- language selector position should be in footer still as expected. -- this confirms the sysprefs.sql change. 6) Restore your DB 7) run the updatedatabase.pl script 8) Refresh the OPAC page -- should still only have languages in the footer. -- this confirms that upgrade won't change anything. -- this confirms the atomic update. 9) git diff origin/master -- the opac-bottom.inc difference should only have changes around a SET, IF, and END. This confirms the noprint was fixed. 10) In the staff client, change the OPAC system preference, OpacLangSelectorMode, to all three values. For each value, refresh the OPAC page, and confirm the position of the language selector. -- should work as expected. 11) run koha qa test tools Signed-off-by: Mark Tompsett Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #67 from Jonathan Druart --- Created attachment 39864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39864&action=edit Bug 14252: Add sort by rfc4646_subtag in footer This patch sort by rfc4646_subtag the languages in the footer. Same as in the header. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #62 from Jonathan Druart --- Created attachment 39859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39859&action=edit Bug 14252: (followup) Adds OpacLangSelectorMode syspref Based on discussion, this followup does the following: 1/ brings back the switcher on opac-bottom.inc 2/ adds a syspref OpacLangSelectorMode to toggle between the three modes: (a) show switcher both on masthead and footer (default) (b) footer only (b) masthead only Test plan = 1/ apply earlier patches attached to this bug in their correct order 2/ apply this followup patch 3/ run updatedatabase.pl to add in the atomic update 4/ goto admin/preferences.pl?tab=opac 5/ look up OpacLangSelectorMode, it should be set with default value "both masthead and footer" 6/ check OPAC to see if both locations show the selectors 7/ change OpacLangSelectorMode to 'only header' and 'only footer' at each iteration, and check if the selection has correctly toggled the selectors. It should Note: make sure you do not have the patch 11057 applied on the branch from before, otherwise merge conflict might happen. http://bugs.koha-community.org/show_bug.cgi?id=14252 Followed test plan. Works as expected. Signed-off-by: Marc Véron Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #64 from Jonathan Druart --- Created attachment 39861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39861&action=edit Bug 14252: (fix) address the indentation for the lang loop tidy the indentation for that lang selector loop code. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Bernardo Gonzalez Kriegel changed: What|Removed |Added Blocks||12017 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #68 from Tomás Cohen Arazi --- Enhancement pushed to master. Thanks Indranil! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Héctor Eduardo Castro Avalos changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12017 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/