[Koha-bugs] [Bug 14267] How active is active in additem.tt?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14267 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #6 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14267] How active is active in additem.tt?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14267 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14267] How active is active in additem.tt?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14267 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14267] How active is active in additem.tt?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14267 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #39492|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39508 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39508action=edit Bug 14267: How active is active? git grep on function active in additem.tt: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt:function active(n koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt:active([% koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt:function a koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt: t/Cache.t: unless ( $cache-is_cache_active() defined $cache ); t/Cache.t: unless ( $cache-is_cache_active() ); Conclusion: active in additem seems to be quite inactive. Test plan: Add, edit or delete items and verify that you did not miss active :) NOTE: The active function has a loop which is always run. Inside that loop 'ong' would always be defined as some number concatenated with XX. Both sides of the if/else reference document.getElementById(ong), but there is only one occurence of XX in the file: the concatenation! Similarly, the 'link' logic does not correspond to any of the id= or name= strings in the file. koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt is the only file with id=\link that matches the logic. This is likely a cut-and-paste remnant made useless by datatable upgrades and HTML/CSS class changes. Signed-off-by: Mark Tompsett mtomp...@hotmail.com Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14267] How active is active in additem.tt?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14267 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Yes it's definitely dead code. It was used to select active tab. But actually I suspect a c/p at the creation of the template. Note that this active function is still defined on serials/serial-issues-full.tt but I did not manage to reach this template... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14267] How active is active in additem.tt?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14267 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Summary|How active is active? |How active is active in ||additem.tt? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14267] How active is active in additem.tt?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14267 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14267] How active is active in additem.tt?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14267 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #39476|0 |1 is obsolete|| --- Comment #2 from M. Tompsett mtomp...@hotmail.com --- Created attachment 39492 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39492action=edit Bug 14267: How active is active? git grep on function active in additem.tt: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt:function active(n koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt:active([% koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt:function a koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt: t/Cache.t: unless ( $cache-is_cache_active() defined $cache ); t/Cache.t: unless ( $cache-is_cache_active() ); Conclusion: active in additem seems to be quite inactive. Test plan: Add, edit or delete items and verify that you did not miss active :) NOTE: The active function has a loop which is always run. Inside that loop 'ong' would always be defined as some number concatenated with XX. Both sides of the if/else reference document.getElementById(ong), but there is only one occurence of XX in the file: the concatenation! Similarly, the 'link' logic does not correspond to any of the id= or name= strings in the file. koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt is the only file with id=\link that matches the logic. This is likely a cut-and-paste remnant made useless by datatable upgrades and HTML/CSS class changes. Signed-off-by: Mark Tompsett mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
