[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #20 from Martin Renvoize --- Created attachment 106720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106720&action=edit Bug 25723: Remove tests for removed method We removed the exception_holidays (and single_holidays) methods as part of this patchset. As such, we should no longer test them ;) Signed-off-by: Emma Perks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #18 from Martin Renvoize --- Created attachment 106718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106718&action=edit Bug 25723: Use the same code for single and exception holidays This patch refactors is_exception_holiday and is_single_holiday to utilise a single _holidays method which combines the logic of the previous single_holidays and exception_holidays methods. As Koha::Calendar is instantiated at a branch level, we also move split the cache into branches too. Signed-off-by: Emma Perks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #21 from Martin Renvoize --- Created attachment 106721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106721&action=edit Bug 25723: (QA follow-up) Silent POD warning I didn't introduce the method that is warned about, but adding POD for it seemed reasonable and will silence the QA Script warning. Signed-off-by: Emma Perks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #17 from Martin Renvoize --- Created attachment 106717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106717&action=edit Bug 25723: Use a hasref for lookup Rather than using an array of dates and iterating them, use a hashref and do a direct lookup Signed-off-by: Emma Perks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #19 from Martin Renvoize --- Created attachment 106719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106719&action=edit Bug 25723: Update cache flushing calls This patch updates the previous single_holidays and exeption_holidays cache flushing calls to match the new cache key structure of the updated routines. Signed-off-by: Emma Perks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #16 from Martin Renvoize --- Created attachment 106716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106716&action=edit Bug 25723: Drop DateTime::Set from cpanfile Signed-off-by: Emma Perks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #15 from Martin Renvoize --- Created attachment 106715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106715&action=edit Bug 25723: (follow-up) Fix Unit Test The unit test previously relied on the internals of exception_holidays. Signed-off-by: Emma Perks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #14 from Martin Renvoize --- Created attachment 106714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106714&action=edit Bug 25723: Drop DateTime::Set dependancy This patch removes our use of DateTime::Set and replaces it with a quick hashref implimentation Signed-off-by: Emma Perks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 Martin Renvoize changed: What|Removed |Added Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #13 from Martin Renvoize --- *** This bug has been marked as a duplicate of bug 25723 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 Bug 14315 depends on bug 18519, which changed state. Bug 18519 Summary: Add ability to skip irrelevant dates in Koha::Calendar https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18519 What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #12 from Martin Renvoize --- I've linked two bugs to this report; The first converts the 'exception holiday' handling to match that of 'special holiday' and removes DateTime::Set as a dependency (This gives a marked performance boost when exception holidays are numerous). The second updates the 'special holiday' handing to utilise a hashref lookup instead of an array iteration (This gives a marked performance boost when a series of special holidays are defined, especially if many of them are in the past, as we now do a single comparison as opposed to having to iterate from oldest defined holiday until we find the date in question, or no date at all). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 Martin Renvoize changed: What|Removed |Added Depends on|25723 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 [Bug 25723] Drop DateTime::Set as a dependancy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 Martin Renvoize changed: What|Removed |Added Depends on||18519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18519 [Bug 18519] Add ability to skip irrelevant dates in Koha::Calendar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 Martin Renvoize changed: What|Removed |Added Depends on||25723 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 [Bug 25723] Drop DateTime::Set as a dependancy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #11 from Martin Renvoize --- I think this is still somewhat of an issue.. in my experience we've now worked through the IO bound performance issue with the caching bugs, but we still have some CPU bound issues relating to the slow instantiation speed of DateTime. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #10 from Magnus Enger --- (In reply to Jonathan Druart from comment #9) > (In reply to Mason James from comment #8) > > Update: A new bug has been created, that contains a patch for this > > problem... > > > > http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 > > So can we close this one? 14522 is CLOSED FIXED now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #9 from Jonathan Druart --- (In reply to Mason James from comment #8) > Update: A new bug has been created, that contains a patch for this problem... > > http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 So can we close this one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 --- Comment #8 from Mason James --- Update: A new bug has been created, that contains a patch for this problem... http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 Mason James changed: What|Removed |Added Depends on||14522 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 [Bug 14522] Use Koha::Cache for accessing single_holidays() -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 Irma Birchall changed: What|Removed |Added CC||i...@calyx.net.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 Mason James changed: What|Removed |Added Attachment #39765|nytprof pic2|nytprof pic1 description|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 Mason James changed: What|Removed |Added Attachment #39764|0 |1 is obsolete|| --- Comment #7 from Mason James --- Comment on attachment 39764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39764 nytprof pic1 incorrect file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 Mason James changed: What|Removed |Added Attachment #39765|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 Mason James changed: What|Removed |Added Attachment #39765|0 |1 is obsolete|| --- Comment #6 from Mason James --- Created attachment 39790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39790&action=edit nytprof pic2 oops, attached wrong pic2 file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 Mason James changed: What|Removed |Added Summary|Slow checkouts, caused by |Slow checkouts, caused by |many single_holidays|many 'special_holidays' |definitions |definitions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
