[Koha-bugs] [Bug 14327] Fix js error TypeError: events is null in additem.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14327 Mason James m...@kohaaloha.com changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #7 from Mason James m...@kohaaloha.com --- Patch not applicable for 3.16.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14327] Fix js error TypeError: events is null in additem.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14327 Liz Rea wizzy...@gmail.com changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #6 from Liz Rea wizzy...@gmail.com --- Patch pushed to 3.18.x will be in 3.18.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14327] Fix js error TypeError: events is null in additem.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14327 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14327] Fix js error TypeError: events is null in additem.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14327 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14327] Fix js error TypeError: events is null in additem.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14327 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14327] Fix js error TypeError: events is null in additem.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14327 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #39834|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 39943 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39943action=edit [PASSED QA] Bug 14327: Fix js error TypeError: events is null in additem.js If you have no item plugins, the events variable in BindPluginEvents of additem.js will be null. So testing events.length will generate the described error. This patch adds a check to prevent that from happening again. Test plan: [1] Do not yet apply this patch ! [2] Temporarily remove framework plugins from your items (in ACQ or default framework). Probably you have to clear dateaccessioned.pl and barcode.pl. [3] Open js console in your browser. [4] Go to Acquisition. Open a basket and add an order from a new empty record. [5] You should see js error: TypeError: events is null (additem.js:176) [6] Apply this patch and reload the page (make sure that you refresh so that the new javascript code is read). [7] The TypeError should be gone. [8] Restore the framework plugins from step 2. Refresh the page again and verify that they still work as expected. Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14327] Fix js error TypeError: events is null in additem.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14327 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10480 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14327] Fix js error TypeError: events is null in additem.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14327 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14327] Fix js error TypeError: events is null in additem.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14327 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Assignee|gmcha...@gmail.com |m.de.r...@rijksmuseum.nl Patch complexity|--- |Trivial patch Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14327] Fix js error TypeError: events is null in additem.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14327 --- Comment #1 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 39832 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39832action=edit Bug 14327: Fix js error TypeError: events is null in additem.js If you have no item plugins, the events variable in BindPluginEvents of additem.js will be null. So testing events.length will generate the described error. This patch adds a check to prevent that from happening again. Test plan: [1] Do not yet apply this patch ! [2] Temporarily remove framework plugins from your items (in ACQ or default framework). Probably you have to clear dateaccessioned.pl and barcode.pl. [3] Open js console in your browser. [4] Go to Acquisition. Open a basket and add an order from a new empty record. [5] You should see js error: TypeError: events is null (additem.js:176) [6] Apply this patch and reload the page (make sure that you refresh so that the new javascript code is read). [7] The TypeError should be gone. [8] Restore the framework plugins from step 2. Refresh the page again and verify that they still work as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14327] Fix js error TypeError: events is null in additem.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14327 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14327] Fix js error TypeError: events is null in additem.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14327 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14327] Fix js error TypeError: events is null in additem.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14327 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #39832|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39834 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39834action=edit Bug 14327: Fix js error TypeError: events is null in additem.js If you have no item plugins, the events variable in BindPluginEvents of additem.js will be null. So testing events.length will generate the described error. This patch adds a check to prevent that from happening again. Test plan: [1] Do not yet apply this patch ! [2] Temporarily remove framework plugins from your items (in ACQ or default framework). Probably you have to clear dateaccessioned.pl and barcode.pl. [3] Open js console in your browser. [4] Go to Acquisition. Open a basket and add an order from a new empty record. [5] You should see js error: TypeError: events is null (additem.js:176) [6] Apply this patch and reload the page (make sure that you refresh so that the new javascript code is read). [7] The TypeError should be gone. [8] Restore the framework plugins from step 2. Refresh the page again and verify that they still work as expected. Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
