[Koha-bugs] [Bug 14435] The table saved_reports is never populated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Katrin Fischer changed: What|Removed |Added Attachment #51987|0 |1 is obsolete|| --- Comment #31 from Katrin Fischer --- Created attachment 55814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55814&action=edit [PASSED QA] Bug 14435: Add the ability to store result's report At one time it was possible to store the results of a report into the saved_reports table. This allowed the librarians to compare different results, from the Koha interface. This patch is a proof of concept and is not very polished (understood: it cannot be pushed like that). Test plan: Execute the runreport.pl cronjob script with the new --store-results option. This will serialize into json the results and put it into the saved_reports table. On the "Saved report" list, the "Saved results" column is now populated with a date (note that you can have several date for a given report). If you click on this link, the data will be displayed in a simple table. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #32 from Katrin Fischer --- I've filed bug 17350 for dealing with the deletion of data. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Katrin Fischer changed: What|Removed |Added Blocks||17350 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17350 [Bug 17350] Add option to delete data stored in saved_reports -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #30 from Jonathan Druart --- Hi Katrin, This patch restore a broken behavior, instead of removing it completely. If the feature is used and some guys want to improve it, let's them do it :) I do not plan to improve it by myself, especially because IMO it's out of the scope of this bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #29 from Katrin Fischer --- I got no problem with this not being perfect for the time being, but could we add one little thing? I am missing an option to delete the saved results - either from the GUI or maybe when the runreport.pl is run an option to clean the last x saved results... I am a little worried that this table will fill up quickly with no way to get rid of stored results. Please read "failed qa" as asking for feedback! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #28 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #27) > If this cannot be pushed in this form, could you adjust the status > accordingly? Since it does (should) not introduce regression but reintroduced a broken feature, it may be good to push it and see if someone is interested in it. What do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #27 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #26) > (In reply to Marcel de Rooy from comment #25) > > Commit message still says: > > > > This patch is a proof of concept and is not very polished (understood: > > it cannot be pushed like that). > > I do not plan to work more on this one, unless several people are interested. > But I think it's a good start for someone who wants to continue... If this cannot be pushed in this form, could you adjust the status accordingly? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #26 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #25) > Commit message still says: > > This patch is a proof of concept and is not very polished (understood: > it cannot be pushed like that). I do not plan to work more on this one, unless several people are interested. But I think it's a good start for someone who wants to continue... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #25 from Marcel de Rooy --- Commit message still says: This patch is a proof of concept and is not very polished (understood: it cannot be pushed like that). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Chris Cormack changed: What|Removed |Added Attachment #44795|0 |1 is obsolete|| --- Comment #24 from Chris Cormack --- Created attachment 51987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51987&action=edit Bug 14435: Add the ability to store result's report At one time it was possible to store the results of a report into the saved_reports table. This allowed the librarians to compare different results, from the Koha interface. This patch is a proof of concept and is not very polished (understood: it cannot be pushed like that). Test plan: Execute the runreport.pl cronjob script with the new --store-results option. This will serialize into json the results and put it into the saved_reports table. On the "Saved report" list, the "Saved results" column is now populated with a date (note that you can have several date for a given report). If you click on this link, the data will be displayed in a simple table. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #23 from Katrin Fischer --- Can't count how often I mistype bug numbers... :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Josef Moravec changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #22 from Josef Moravec --- Sorry, it was unintented, bad bug number :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #21 from Katrin Fischer --- Hi Josef, did you intend to mark this patch 'signed off'? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #20 from Jonathan Druart --- (In reply to Frédéric Demians from comment #18) > Thnaks for the rebase. It works as described. > > A new column in the 'Saved report' may be one too many. We can imagine > scenario where librarian will run a report once a day. The 'Saved result' > will > be overcrowded. A simple tick in a column may be enough with detailed > information reported to another page, or the 'run' page. Yes agreed, I have just tried to rescue this feature as quickly as possible. > There is a bug is the result page after you run any report. After the table > containing the result, there is a section called 'Saved report results' > displaying a table populated with "HASH()". The same variable name was used, I have changed one for 'saved_results'. I should be fixed now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart changed: What|Removed |Added Attachment #44767|0 |1 is obsolete|| --- Comment #19 from Jonathan Druart --- Created attachment 44795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44795&action=edit Bug 14435: Add the ability to store result's report At one time it was possible to store the results of a report into the saved_reports table. This allowed the librarians to compare different results, from the Koha interface. This patch is a proof of concept and is not very polished (understood: it cannot be pushed like that). Test plan: Execute the runreport.pl cronjob script with the new --store-results option. This will serialize into json the results and put it into the saved_reports table. On the "Saved report" list, the "Saved results" column is now populated with a date (note that you can have several date for a given report). If you click on this link, the data will be displayed in a simple table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #18 from Frédéric Demians --- Thnaks for the rebase. It works as described. A new column in the 'Saved report' may be one too many. We can imagine scenario where librarian will run a report once a day. The 'Saved result' will be overcrowded. A simple tick in a column may be enough with detailed information reported to another page, or the 'run' page. There is a bug is the result page after you run any report. After the table containing the result, there is a section called 'Saved report results' displaying a table populated with "HASH()". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart changed: What|Removed |Added Attachment #42196|0 |1 is obsolete|| --- Comment #17 from Jonathan Druart --- Created attachment 44767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44767&action=edit Bug 14435: Add the ability to store result's report At one time it was possible to store the results of a report into the saved_reports table. This allowed the librarians to compare different results, from the Koha interface. This patch is a proof of concept and is not very polished (understood: it cannot be pushed like that). Test plan: Execute the runreport.pl cronjob script with the new --store-results option. This will serialize into json the results and put it into the saved_reports table. On the "Saved report" list, the "Saved results" column is now populated with a date (note that you can have several date for a given report). If you click on this link, the data will be displayed in a simple table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Frédéric Demians changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||frede...@tamil.fr --- Comment #16 from Frédéric Demians --- It looks good. Minor merge conflict on master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Heather Braum changed: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10627 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|In Discussion Severity|normal |enhancement --- Comment #15 from Jonathan Druart --- I propose to reintroduce the broken feature. Have a look and test this last patch and tell me what you think about it, to know if it's useful to continue in this direction. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart changed: What|Removed |Added Attachment #40796|0 |1 is obsolete|| Attachment #40797|0 |1 is obsolete|| Attachment #40929|0 |1 is obsolete|| Attachment #40930|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart --- Created attachment 42196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42196&action=edit Bug 14435: Add the ability to store result's report At one time it was possible to store the results of a report into the saved_reports table. This allowed the librarians to compare different results, from the Koha interface. This patch is a proof of concept and is not very polished (understood: it cannot be pushed like that). Test plan: Execute the runreport.pl cronjob script with the new --store-results option. This will serialize into json the results and put it into the saved_reports table. On the "Saved report" list, the "Saved results" column is now populated with a date (note that you can have several date for a given report). If you click on this link, the data will be displayed in a simple table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart changed: What|Removed |Added Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #13 from Katrin Fischer --- What I am missing here a bit is an idea about what this code was actually used for in the past. According to my research it seems like you used to be able to store the results of a report in that table - which got broken at some point. We have a newer bug report asking for such a feature: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10627 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #11 from Jonathan Druart --- Created attachment 40930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40930&action=edit Bug 14435: Remove the SavedReport DBIx::Class schema file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #12 from Jonathan Druart --- (In reply to Kyle M Hall from comment #9) Good catch, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #10 from Jonathan Druart --- Created attachment 40929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40929&action=edit Bug 14435: Make the tests pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA CC||k...@bywatersolutions.com --- Comment #9 from Kyle M Hall --- Unit test fails: prove t/db_dependent/Reports_Guided.t t/db_dependent/Reports_Guided.t .. 1/18 DBD::mysql::db selectall_arrayref failed: Unknown column 'report' in 'where clause' at C4/Reports/Guided.pm line 664. DBD::mysql::db selectall_arrayref failed: Unknown column 'report' in 'where clause' at C4/Reports/Guided.pm line 664. # Looks like you planned 18 tests but ran 7. # Looks like your test exited with 255 just after 7. t/db_dependent/Reports_Guided.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 11/18 subtests Test Summary Report --- t/db_dependent/Reports_Guided.t (Wstat: 65280 Tests: 7 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 18 tests but ran 7. Files=1, Tests=7, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.26 cusr 0.00 csys = 0.28 CPU) Result: FAIL Also, can you delete Koha/Schema/Result/SavedReport.pm? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Indranil Das Gupta changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Indranil Das Gupta changed: What|Removed |Added Attachment #40753|0 |1 is obsolete|| --- Comment #8 from Indranil Das Gupta --- Created attachment 40797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40797&action=edit Bug 14435: Drop table saved_reports The table saved_reports is never populated and is not used since 14be4400d84b28369d095b3b0bfa79c3396f44d4 (2009). The 2 subroutines store_results and format_results are never reachable and will also be removed. Note that an empty column "Saved results" were always displayed on the saved report list. Test plan: 0/ Confirm that there is nothing in the saved_reports table and that you have never seen something in it before. 1/ After applying the patch, confirm that you have still acess to the saved report list (reports/guided_reports.pl?phase=Use saved) Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Indranil Das Gupta changed: What|Removed |Added Attachment #40489|0 |1 is obsolete|| --- Comment #7 from Indranil Das Gupta --- Created attachment 40796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40796&action=edit Bug 14435: Drop table saved_reports - DB Changes Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #6 from Jonathan Druart --- (In reply to M. Tompsett from comment #3) > Comment on attachment 40488 [details] [review] > Bug 14435: Drop table saved_reports > > Review of attachment 40488 [details] [review]: > - > > My quick eyeball only noticed this. Not tested yet. > > ::: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt > @@ +345,1 @@ > > > > Unmatched , I believe. Good catch! Fixed in the last patch. (In reply to M. Tompsett from comment #4) > Comment on attachment 40489 [details] [review] > Bug 14435: Drop table saved_reports - DB Changes > > Review of attachment 40489 [details] [review]: > - > > The drop table saved reports atomic update is empty. What do you mean? The file is empty? --- /dev/null +++ b/installer/data/mysql/atomicupdate/bug_14435_drop_table_saved_reports.sql @@ -0,0 +1 @@ +DROP TABLE IF EXISTS saved_reports; It only contains 1 line but it's not empty :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart changed: What|Removed |Added Attachment #40488|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 40753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40753&action=edit Bug 14435: Drop table saved_reports The table saved_reports is never populated and is not used since 14be4400d84b28369d095b3b0bfa79c3396f44d4 (2009). The 2 subroutines store_results and format_results are never reachable and will also be removed. Note that an empty column "Saved results" were always displayed on the saved report list. Test plan: 0/ Confirm that there is nothing in the saved_reports table and that you have never seen something in it before. 1/ After applying the patch, confirm that you have still acess to the saved report list (reports/guided_reports.pl?phase=Use saved) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #4 from M. Tompsett --- Comment on attachment 40489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40489 Bug 14435: Drop table saved_reports - DB Changes Review of attachment 40489: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14435&attachment=40489) - The drop table saved reports atomic update is empty. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #3 from M. Tompsett --- Comment on attachment 40488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40488 Bug 14435: Drop table saved_reports Review of attachment 40488: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14435&attachment=40488) - My quick eyeball only noticed this. Not tested yet. ::: koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt @@ +345,1 @@ > Unmatched , I believe. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Component|Architecture, internals,|Database |and plumbing| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13618 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #2 from Jonathan Druart --- Created attachment 40489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40489&action=edit Bug 14435: Drop table saved_reports - DB Changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #1 from Jonathan Druart --- Created attachment 40488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40488&action=edit Bug 14435: Drop table saved_reports The table saved_reports is never populated and is not used since 14be4400d84b28369d095b3b0bfa79c3396f44d4 (2009). The 2 subroutines store_results and format_results are never reachable and will also be removed. Note that an empty column "Saved results" were always displayed on the saved report list. Test plan: 0/ Confirm that there is nothing in the saved_reports table and that you have never seen something in it before. 1/ After applying the patch, confirm that you have still acess to the saved report list (reports/guided_reports.pl?phase=Use saved) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14435] The table saved_reports is never populated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
