[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to Master|RESOLVED Resolution|--- |FIXED --- Comment #16 from Fridolin SOMERS --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #15 from Jonathan Druart --- Congratulation Yarik and thanks for your first patch! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #14 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 Tomás Cohen Arazi changed: What|Removed |Added Attachment #64712|0 |1 is obsolete|| --- Comment #12 from Tomás Cohen Arazi --- Created attachment 65920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65920&action=edit Bug 14533: remove CREATE USER when koha-create --use-db Signed-off-by: Lee Jamison Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 Tomás Cohen Arazi changed: What|Removed |Added Attachment #64713|0 |1 is obsolete|| --- Comment #13 from Tomás Cohen Arazi --- Created attachment 65921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65921&action=edit Bug 14533: Make --use-db display a message if no DB defined Signed-off-by: Lee Jamison Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 M. Tompsett changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 M. Tompsett changed: What|Removed |Added Blocks||18877 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18877 [Bug 18877] Outdated explanation of use when two patches applied -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 M. Tompsett changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=9409 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 Tomás Cohen Arazi changed: What|Removed |Added Assignee|gmcha...@gmail.com |mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 Lee Jamison changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 Lee Jamison changed: What|Removed |Added Attachment #64555|0 |1 is obsolete|| --- Comment #11 from Lee Jamison --- Created attachment 64713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64713&action=edit Bug 14533: Deal with comment #2 Signed-off-by: Lee Jamison -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 Lee Jamison changed: What|Removed |Added Attachment #64552|0 |1 is obsolete|| --- Comment #10 from Lee Jamison --- Created attachment 64712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64712&action=edit Bug 14533: remove CREATE USER when koha-create --use-db Signed-off-by: Lee Jamison -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 M. Tompsett changed: What|Removed |Added Attachment #64554|0 |1 is obsolete|| --- Comment #9 from M. Tompsett --- Created attachment 64555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64555&action=edit Bug 14533: Deal with comment #2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 --- Comment #8 from M. Tompsett --- Created attachment 64554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64554&action=edit Bug 14533: Deal with comment #2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 M. Tompsett changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 M. Tompsett changed: What|Removed |Added Attachment #41424|0 |1 is obsolete|| --- Comment #7 from M. Tompsett --- Comment on attachment 41424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41424 Patch - remove CREATE USER when koha-create --use-db This was not a 'git bz attach'd patch. Provided one to make testing easier. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 --- Comment #6 from M. Tompsett --- Created attachment 64552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64552&action=edit Bug 14533: remove CREATE USER when koha-create --use-db -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #5 from M. Tompsett --- Is this ready for sign off? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 --- Comment #4 from Yarik Dot --- (In reply to Tomás Cohen Arazi from comment #2) > > I think the behaviour should be: > > - If the user passes DB parameters (user, pass, hostname, dbname), use them > to configure the instance. This needs more parameters to be added to > koha-create. hostname should default to 'localhost' if ommited. There is currently /etc/mysql/koha-common.cnf used right? Why to change this behavior? If there is nothing defined in here, default client configuration from /etc/mysql/my.cnf is used. Anyway, I am ok with changing this behaviour if the change is consistent. That means, there won't be 10 places where the database connection can be defined. > - If some of the new parameters is missing, fallback to what is configured > in /etc/koha/passwd. Why? That is why passwdfile is used, isn't it? > - If some of the relevant parameters is missing, fail loudly. Agree. --- To explain more how we use it: first# koha-create --request-db mysql# mysql; CREATE DB ...; GRANT ...; first# koha-create --populate-db second# koha-create --use-db --passwdfile ./file (In reply to Tomás Cohen Arazi from comment #3) > This is not enough, as the DB is still being created. Look at my previous > comment I have just double checked the koha-create script and database is only created when --create is used. It is on line 560 and nowhere else. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 --- Comment #3 from Tomás Cohen Arazi --- Comment on attachment 41424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41424 Patch - remove CREATE USER when koha-create --use-db -if [ "$op" = use ] -then -mysql --defaults-extra-file=/etc/mysql/koha-common.cnf --force
[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 --- Comment #2 from Tomás Cohen Arazi --- (In reply to Yarik Dot from comment #1) > Created attachment 41424 [details] [review] > Patch - remove CREATE USER when koha-create --use-db > > Please, check the attachment. I think the behaviour should be: - If the user passes DB parameters (user, pass, hostname, dbname), use them to configure the instance. This needs more parameters to be added to koha-create. hostname should default to 'localhost' if ommited. - If some of the new parameters is missing, fallback to what is configured in /etc/koha/passwd. - If some of the relevant parameters is missing, fail loudly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14533] koha-create --use-db option shouldn't create any db or db user
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14533 Yarik Dot changed: What|Removed |Added CC||yarik...@gmail.com --- Comment #1 from Yarik Dot --- Created attachment 41424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41424&action=edit Patch - remove CREATE USER when koha-create --use-db Please, check the attachment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
