[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #36 from Nick Clemens --- *** Bug 13044 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Jonathan Druart changed: What|Removed |Added Blocks||24380 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Jonathan Druart changed: What|Removed |Added Blocks||24075 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #35 from Martin Renvoize --- (In reply to Katrin Fischer from comment #32) > Where is the test plan here? > > I am trying to determine if this will also help fixing: > > Bug 12144 - Book drop mode mode erasing fine when CalculateFinesOnReturn is > enabled > Bug 8338 - fines not cleared with dropbox mode Bug 12144 has been effectively replaced with bug 22539 which is currently seeking QA. I encountered the though process that I believe has led to bug 8338 whilst coding bug 22539 and I asked the same questions there.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13044 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize changed: What|Removed |Added Blocks||13044 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13044 [Bug 13044] Deprecate old book drop mode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize changed: What|Removed |Added Blocks||22539 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 [Bug 22539] Fines charged on back-dated checkin when item has been renewed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize changed: What|Removed |Added Blocks||22533 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 [Bug 22533] Cannot create manual invoices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED --- Comment #34 from Martin Renvoize --- Bug with enhancement not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #33 from Kyle M Hall --- Yes, I do believe both of those can be closed in some form ( duplicates? ). This bug fixes the issues related to those two bugs. (In reply to Katrin Fischer from comment #32) > Where is the test plan here? > > I am trying to determine if this will also help fixing: > > Bug 12144 - Book drop mode mode erasing fine when CalculateFinesOnReturn is > enabled > Bug 8338 - fines not cleared with dropbox mode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #32 from Katrin Fischer --- Where is the test plan here? I am trying to determine if this will also help fixing: Bug 12144 - Book drop mode mode erasing fine when CalculateFinesOnReturn is enabled Bug 8338 - fines not cleared with dropbox mode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #30 from Kyle M Hall --- Created attachment 86676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86676&action=edit Bug 14591: (QA follow-up) Fix call to AddReturn for SIP -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #31 from Nick Clemens --- (In reply to Kyle M Hall from comment #30) > Created attachment 86676 [details] [review] > Bug 14591: (QA follow-up) Fix call to AddReturn for SIP Followup pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #29 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | --- Comment #23 from Josef Moravec --- (In reply to Martin Renvoize from comment #21) > I really like this solution! It tidies up the code significantly and > corrects the logic considerably! > > Signing off as it all works in testing as described... > > Some QA comments for the next in line however. > > * Can we/Should we remove the 'lastincrement' field here as I believe this > was the only use case for it? > * The logic here puts 'dropboxmode/dropboxdate' in precidence to any > specified return date.. I think we perhaps need a bit more in this regard, > but perhaps that can be done within bug 13044 as there's a fair bit of > contextual conversation over there around this issue. I agree to continue on these two points on other reports, as this patchset is ok and fixes the bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #28 from Josef Moravec --- Created attachment 86643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86643&action=edit Bug 14591: (QA follow-up) Fix AddReturn call in Circulation/issue.t Test plan: prove t/db_dependent/Circulation/issue.t Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Josef Moravec changed: What|Removed |Added Attachment #86618|0 |1 is obsolete|| Attachment #86619|0 |1 is obsolete|| Attachment #86620|0 |1 is obsolete|| Attachment #86621|0 |1 is obsolete|| --- Comment #24 from Josef Moravec --- Created attachment 86639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86639&action=edit Bug 14591: book drop / drop box mode incorrectly decrements accrued overdue fines Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #26 from Josef Moravec --- Created attachment 86641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86641&action=edit Bug 14591: Update unit tests Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #27 from Josef Moravec --- Created attachment 86642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86642&action=edit Bug 14591: (QA follow-up) Optimize DateTime passing We were passing around possibly undefined $return_date variables from AddReturn and then instantiating a new DateTime object as a default for each routine. This followup sets the default higher up the stack within AddReturn which provider clearer logic and a small performance improvment. Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #25 from Josef Moravec --- Created attachment 86640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86640&action=edit Bug 14591: Update other calls to AddReturn Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #22 from Martin Renvoize --- See bug 22516 for the removal of lastincrement.. I decided to leave that as a followup bug to keep this bug simple. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize changed: What|Removed |Added Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize changed: What|Removed |Added Blocks||22516 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 [Bug 22516] accountlines.lastincrement should be removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #21 from Martin Renvoize --- I really like this solution! It tidies up the code significantly and corrects the logic considerably! Signing off as it all works in testing as described... Some QA comments for the next in line however. * Can we/Should we remove the 'lastincrement' field here as I believe this was the only use case for it? * The logic here puts 'dropboxmode/dropboxdate' in precidence to any specified return date.. I think we perhaps need a bit more in this regard, but perhaps that can be done within bug 13044 as there's a fair bit of contextual conversation over there around this issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize changed: What|Removed |Added Attachment #86614|0 |1 is obsolete|| --- Comment #17 from Martin Renvoize --- Created attachment 86618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86618&action=edit Bug 14591: book drop / drop box mode incorrectly decrements accrued overdue fines Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize changed: What|Removed |Added Attachment #86616|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 86620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86620&action=edit Bug 14591: Update unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize changed: What|Removed |Added Attachment #86615|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 86619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86619&action=edit Bug 14591: Update other calls to AddReturn Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #20 from Martin Renvoize --- Created attachment 86621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86621&action=edit Bug 14591: (QA follow-up) Optimize DateTime passing We were passing around possibly undefined $return_date variables from AddReturn and then instantiating a new DateTime object as a default for each routine. This followup sets the default higher up the stack within AddReturn which provider clearer logic and a small performance improvment. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Kyle M Hall changed: What|Removed |Added Attachment #86611|0 |1 is obsolete|| Attachment #86612|0 |1 is obsolete|| Attachment #86613|0 |1 is obsolete|| --- Comment #14 from Kyle M Hall --- Created attachment 86614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86614&action=edit Bug 14591: book drop / drop box mode incorrectly decrements accrued overdue fines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #16 from Kyle M Hall --- Created attachment 86616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86616&action=edit Bug 14591: Update unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #15 from Kyle M Hall --- Created attachment 86615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86615&action=edit Bug 14591: Update other calls to AddReturn -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #13 from Kyle M Hall --- Created attachment 86613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86613&action=edit Bug 14591: Update unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #11 from Kyle M Hall --- Created attachment 86611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86611&action=edit Bug 14591: book drop / drop box mode incorrectly decrements accrued overdue fines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Kyle M Hall changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #12 from Kyle M Hall --- Created attachment 86612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86612&action=edit Bug 14591: Update other calls to AddReturn -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22510 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #10 from Katrin Fischer --- See: Bug 13044 - Deprecate old book drop mode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=13044 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Bug 14591 depends on bug 22049, which changed state. Bug 22049 Summary: MarkIssueReturned should rely on returndate only https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #8 from Katrin Fischer --- Hi Margo, this will still work. What was removed was the checkbox on the circulation page that only allowed to set for last day library open in favor of the newer more flexible specifyreturndate feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #9 from Benjamin Daeuber --- (In reply to Katrin Fischer from comment #8) > Hi Margo, this will still work. What was removed was the checkbox on the > circulation page that only allowed to set for last day library open in favor > of the newer more flexible specifyreturndate feature. Yes, I just read through 13044. I'm generally ok with the solution proposed, though I do have another comment I'll put in that ticket. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Benjamin Daeuber changed: What|Removed |Added CC||bdaeu...@cityoffargo.com --- Comment #7 from Benjamin Daeuber --- (In reply to Kyle M Hall from comment #3) > I think the solution is to remove all the dropbox code, and make dropbox > mode just be a backdated return which backdates to the last day the library > was previously open. I disagree with this. We actually don't use bookdrop mode since it confines us to 24 hours. We manually set the backdate because there are times that we might be days behind checking in items and times we are caught up. We try to match the date to when the item was returned. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Tomás Cohen Arazi changed: What|Removed |Added Depends on||22049 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22049 [Bug 22049] MarkIssueReturned should rely on returndate only -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize changed: What|Removed |Added Blocks||14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #6 from Martin Renvoize --- +1 from me too :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #5 from Tomás Cohen Arazi --- (In reply to Kyle M Hall from comment #3) > I think the solution is to remove all the dropbox code, and make dropbox > mode just be a backdated return which backdates to the last day the library > was previously open. I agree with this :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21969 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591
--- Comment #4 from Tomás Cohen Arazi ---
(In reply to Kyle M Hall from comment #3)
> I think the solution is to remove all the dropbox code, and make dropbox
> mode just be a backdated return which backdates to the last day the library
> was previously open.
I think we now have the account offsets, and can rewrite _FixOverduesOnReturn
as I did with _FixAccountForLostAndReturned, to take them into account. We need
to:
- Make sure each 'increment' actually creates an offset (this of course should
be possible with $line->adjust from bug 21727)
- Replace the current code so it doesn't touch 'amount'. It should calculate
the amount to substract, and create a special type of credit. If there was a
writeoff, skip that writeoff amount, if there was a (maybe partial) payment,
refund it with a CR account line. So:
my $amount = calaculate_amount_to_backtrack_skipping_writeoffs({ $fine_line });
$account->add_credit({ amount => $amount, type => 'credit_return' })->apply({
debit => $fine_line });
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #3 from Kyle M Hall --- I think the solution is to remove all the dropbox code, and make dropbox mode just be a backdated return which backdates to the last day the library was previously open. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | CC||tomasco...@gmail.com --- Comment #2 from Tomás Cohen Arazi --- This is still valid. 'lastincrement' is not enough to determine how much to roll back. This also has the side effect of making debits (the accruing fine) be converted into a credit if it was partially payed or there was a writeoff (this could be the case for a patron having outstanding credit and it being applied automatically as proposed in bug 21915). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- I am not sure if this is still valid, certainly should be retested after over 2 years and changes made to fine calculations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Galen Charlton changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13044 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Galen Charlton changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12144 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
