[Koha-bugs] [Bug 14602] Fix failing t/Creators.t test, when using koha-shell

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #12 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Mason!

Note: I didn't reproduce the problem, but I agree with the change and it
doesn't break tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14602] Fix failing t/Creators.t test, when using koha-shell

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14602] Fix failing t/Creators.t test, when using koha-shell

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #41303|0   |1
is obsolete||

--- Comment #10 from Marcel de Rooy  ---
Created attachment 42315
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42315=edit
Bug 14602 - Fix failing t/Creators.t test

to test..

1/ run t/Creators.t test from git repo, get a FAIL

2/ apply patch

3/ repeat step 1, get a PASS

mason@xen1:~/g/k/3.16.x$ sudo  koha-shell -c 'export
PERL5LIB=/home/mason/g/k/3.16.x ; cd /home/mason/g/k/3.16.x ;  prove -v 
t/Creators.t' k316x1
t/Creators.t ..
1..16
ok 1 - use C4::Creators;
ok 2 - use C4::Creators::PDF;
ok 3 - testing new() works
ok 4 - testing pdf file created
ok 5 - testing Add() works
ok 6 - testing Bookmark() works
ok 7 - testing Compress() works
ok 8 - testing Font() works
ok 9 - testing FontSize() is set to 12 by default
ok 10 - testing FontSize() can be set to a different value
ok 11 - testing Page() works
ok 12 - testing StrWidth() returns correct point width
ok 13 - testing Text() writes from a given x-value
ok 14 - testing Text() writes to the correct x-value
ok 15 - testing End() works
ok 16 - test file /tmp/4YjPQDExeS created OK
ok
All tests successful.
Files=1, Tests=16,  1 wallclock secs ( 0.03 usr  0.01 sys +  0.48 cusr  0.05
csys =  0.57 CPU)
Result: PASS

Signed-off-by: Liz Rea 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14602] Fix failing t/Creators.t test, when using koha-shell

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14602] Fix failing t/Creators.t test, when using koha-shell

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602

--- Comment #11 from Marcel de Rooy  ---
(In reply to Mason James from comment #9)
> (In reply to Liz Rea from comment #8)
> > I think this is different, I get this issue in my vagrant and/or gitify
> > installs as well. Something to do with the fact that it can't write a temp
> > file, but I didn't have time to try and fix it.
> 
> yep, thats all correct ^ :)

It wrote in the current directory..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14602] Fix failing t/Creators.t test, when using koha-shell

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602

--- Comment #9 from Mason James  ---
(In reply to Liz Rea from comment #8)
> I think this is different, I get this issue in my vagrant and/or gitify
> installs as well. Something to do with the fact that it can't write a temp
> file, but I didn't have time to try and fix it.

yep, thats all correct ^ :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14602] Fix failing t/Creators.t test, when using koha-shell

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com ---
(In reply to Mason James from comment #6)
 (In reply to Jonathan Druart from comment #4)
  It passes for me (using a dev install from git).
 
 if you use koha-shell to run tests (and you should be!), it will fail
 
 so, bug still exists for some situations

I'm not against the patch, but Liz, didn't w find a koha-shell bug the other
day? Maybe it is related

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14602] Fix failing t/Creators.t test, when using koha-shell

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602

--- Comment #8 from Liz Rea l...@catalyst.net.nz ---
Naw, that bug is that on a gitified install koha-shell uses the system
/usr/share/koha PERL5LIB instead of the one from the git install, and that can
cause general test weirdness.

I think this is different, I get this issue in my vagrant and/or gitify
installs as well. Something to do with the fact that it can't write a temp
file, but I didn't have time to try and fix it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14602] Fix failing t/Creators.t test, when using koha-shell

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

Summary|Fix failing t/Creators.t|Fix failing t/Creators.t
   |test|test, when using koha-shell

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/