[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15578

--- Comment #21 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #20)
> This patch set has introduced a big issue on Koha::Authority (now
> Koha::Metadata::Authority).
> The authid method does not return the authid anymore...
> The tests in t/db_dependent/Koha_Authority.t are bad: they skipped if the
> authid does not exist.

Will be fixed by bug 15578.


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578
[Bug 15578] Authority tests skip and hide a bug
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

--- Comment #20 from Jonathan Druart  
---
This patch set has introduced a big issue on Koha::Authority (now
Koha::Metadata::Authority).
The authid method does not return the authid anymore...
The tests in t/db_dependent/Koha_Authority.t are bad: they skipped if the
authid does not exist.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

--- Comment #18 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #17)
> It seems that this patch breaks some tests:
> 
> prove t/db_dependent/Koha_Authority.t
> t/db_dependent/Koha_Authority.t .. 5/? 
> #   Failed test 'Object authid is correct'
> #   at t/db_dependent/Koha_Authority.t line 60.
> #  got: undef
> # expected: '1'
> # Looks like you failed 1 test of 11.
> t/db_dependent/Koha_Authority.t .. Dubious, test returned 1 (wstat 256,
> 0x100)
> Failed 1/11 subtests 
> (less 3 skipped subtests: 7 okay)
> 
> Test Summary Report
> ---
> t/db_dependent/Koha_Authority.t (Wstat: 256 Tests: 11 Failed: 1)
>   Failed test:  6
>   Non-zero exit status: 1
> Files=1, Tests=11,  2 wallclock secs ( 0.04 usr  0.00 sys +  1.24 cusr  0.06
> csys =  1.34 CPU)
> Result: FAIL

I've tested them in Jessie and Trusty and cannot reproduce the failing tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

--- Comment #17 from Jonathan Druart  
---
It seems that this patch breaks some tests:

prove t/db_dependent/Koha_Authority.t
t/db_dependent/Koha_Authority.t .. 5/? 
#   Failed test 'Object authid is correct'
#   at t/db_dependent/Koha_Authority.t line 60.
#  got: undef
# expected: '1'
# Looks like you failed 1 test of 11.
t/db_dependent/Koha_Authority.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/11 subtests 
(less 3 skipped subtests: 7 okay)

Test Summary Report
---
t/db_dependent/Koha_Authority.t (Wstat: 256 Tests: 11 Failed: 1)
  Failed test:  6
  Non-zero exit status: 1
Files=1, Tests=11,  2 wallclock secs ( 0.04 usr  0.00 sys +  1.24 cusr  0.06
csys =  1.34 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

--- Comment #19 from Jonathan Druart  
---
Just retested with a clean DB and it passes correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #16 from Tomás Cohen Arazi  ---
Patches pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #11 from Jonathan Druart  
---
Ok, so just one thing prevents to pass QA I think.
The default value for schema should be C4::Context->preference('marcflavour').
And all calls where the pref is passed can be removed.
Don't you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #41386|0   |1
is obsolete||

--- Comment #12 from Marcel de Rooy  ---
Created attachment 42312
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42312=edit
Bug 14639: (regression tests) Extend Koha::MetadataRecord to handle
serialization format and record id

In order to use Koha::MetadataRecord as a container for moving records
around it is important to let it carry the serialization format
of the record object it was built with, so it is easier and cheaper to
make decisions about records.

This patch introduces regression tests for the changes to be made.
The 'format' param is introduced, and also sets default values:
  schema => 'marc21'
  format => 'MARC'

A new (optional) 'id' param is added so the record carries its own id outside
of it.

The default behaviour is preserved, and no changes are needed in places
Koha::MetadataRecord is used.
->new also returns undef if no record is passed, and raises a carped warning.

To test:
- Apply this test patch
- Run the new tests
  $ prove t/Koha_MetadataRecord.t
=> FAIL: Tests shoud fail as the changes are not implemented on
Koha::MetadataRecord

Edit: made serialization format be upper-case to match what is used on
Koha::Filter's

Signed-off-by: Mark Tompsett 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Patch complexity|--- |Small patch
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #41387|0   |1
is obsolete||

--- Comment #13 from Marcel de Rooy  ---
Created attachment 42313
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42313=edit
Bug 14639: Extend Koha::MetadataRecord to handle serialization format and
record id

The description of this changes is on the regression tests commit
message.

To test:
- Apply the test patch
- Run
  $ prove t/Koha_MetadataRecord.t
=> FAIL: Tests fail because changes are not implemented
- Apply this patch
- Run
  $ prove t/Koha_MetadataRecord.t
=> SUCCESS: tests pass
- Run
  $ prove t/Koha_Util_MARC.t
=> SUCCESS: it still passes
- Sign off :-D

NOTE: Tested as above. Read code. Seems to cover all cases.

Signed-off-by: Mark Tompsett 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

--- Comment #15 from Tomás Cohen Arazi  ---
Created attachment 42316
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42316=edit
Bug 14639: (QA followup) make schema mandatory

This patch makes the 'schema' param mandatory. It is passed in every
call on the current codebase, so it makes no harm now, but makes
the code less error-prone.

Tests for this situation are added to t/Koha_MetadataRecord.t (schema
param is omitted and new() returns undef and a carped warning).

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

--- Comment #14 from Jonathan Druart  
---
Marcel, I have let a comment 11, please don't ignore it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

--- Comment #10 from Tomás Cohen Arazi tomasco...@gmail.com ---
(In reply to Jonathan Druart from comment #9)
 Comment on attachment 41387 [details] [review]
 Bug 14639: Extend Koha::MetadataRecord to handle serialization format and
 record id
 
 Review of attachment 41387 [details] [review]:
 -
 
 ::: Koha/MetadataRecord.pm
 @@ +84,5 @@
  +
  +my $record = $params-{ record };
  +my $schema = $params-{ schema } // 'marc21';
  +my $format = $params-{ format } // 'MARC';
  +my $id = $params-{ id };
 
 Don't you think these 4 params should be mandatory?
 I would raise an exception if one of them is not given to the constructor.

I agree. But my plan was to do that on a later stage, so the transition into
using this is more smooth. So for now I just fallback to the current behaviour.
Once this is in, I will provide the relevant regression tests for an API
change.

Also, we need to get the exception handling code pushed before that too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

--- Comment #9 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
Comment on attachment 41387
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41387
Bug 14639: Extend Koha::MetadataRecord to handle serialization format and
record id

Review of attachment 41387:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=14639attachment=41387)
-

::: Koha/MetadataRecord.pm
@@ +84,5 @@
 +
 +my $record = $params-{ record };
 +my $schema = $params-{ schema } // 'marc21';
 +my $format = $params-{ format } // 'MARC';
 +my $id = $params-{ id };

Don't you think these 4 params should be mandatory?
I would raise an exception if one of them is not given to the constructor.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #41360|0   |1
is obsolete||

--- Comment #7 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 41386
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41386action=edit
Bug 14639: (regression tests) Extend Koha::MetadataRecord to handle
serialization format and record id

In order to use Koha::MetadataRecord as a container for moving records
around it is important to let it carry the serialization format
of the record object it was built with, so it is easier and cheaper to
make decisions about records.

This patch introduces regression tests for the changes to be made.
The 'format' param is introduced, and also sets default values:
  schema = 'marc21'
  format = 'MARC'

A new (optional) 'id' param is added so the record carries its own id outside
of it.

The default behaviour is preserved, and no changes are needed in places
Koha::MetadataRecord is used.
-new also returns undef if no record is passed, and raises a carped warning.

To test:
- Apply this test patch
- Run the new tests
  $ prove t/Koha_MetadataRecord.t
= FAIL: Tests shoud fail as the changes are not implemented on
Koha::MetadataRecord

Edit: made serialization format be upper-case to match what is used on
Koha::Filter's

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #41361|0   |1
is obsolete||

--- Comment #8 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 41387
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41387action=edit
Bug 14639: Extend Koha::MetadataRecord to handle serialization format and
record id

The description of this changes is on the regression tests commit
message.

To test:
- Apply the test patch
- Run
  $ prove t/Koha_MetadataRecord.t
= FAIL: Tests fail because changes are not implemented
- Apply this patch
- Run
  $ prove t/Koha_MetadataRecord.t
= SUCCESS: tests pass
- Run
  $ prove t/Koha_Util_MARC.t
= SUCCESS: it still passes
- Sign off :-D

NOTE: Tested as above. Read code. Seems to cover all cases.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #41358|0   |1
is obsolete||

--- Comment #6 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 41361
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41361action=edit
Bug 14639: Extend Koha::MetadataRecord to handle serialization format and
record id

The description of this changes is on the regression tests commit
message.

To test:
- Run
  $ prove t/Koha_MetadataRecord.t
= FAIL: Tests fail because changes are not implemented
- Apply this patch
- Run
  $ prove t/Koha_MetadataRecord.t
= SUCCESS: tests pass
- Run
  $ prove t/Koha_Util_MARC.t
= SUCCESS: it still passes
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #41357|0   |1
is obsolete||

--- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 41360
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41360action=edit
Bug 14639: (regression tests) Extend Koha::MetadataRecord to handle
serialization format and record id

In order to use Koha::MetadataRecord as a container for moving records
around it is important to let it carry the serialization format
of the record object it was built with, so it is easier and cheaper to
make decisions about records.

This patch introduces regression tests for the changes to be made.
The 'format' param is introduced, and also sets default values:
  schema = 'marc21'
  format = 'MARC'

A new (optional) 'id' param is added so the record carries its own id outside
of it.

The default behaviour is preserved, and no changes are needed in places
Koha::MetadataRecord is used.
-new also returns undef if no record is passed, and raises a carped warning.

To test:
- Apply the patch
- Run the new tests
  $ prove t/Koha_MetadataRecord.t
= FAIL: Tests shoud fail as the changes are not implemented on
Koha::MetadataRecord

Edit: made serialization format be upper-case to match what is used on
Koha::Filter's

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Blocks||14645


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14645
[Bug 14645] Koha::RecordProcessor should deal with Koha::MetadataRecord objects
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #41315|0   |1
is obsolete||

--- Comment #3 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 41357
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41357action=edit
Bug 14639: (regression tests) Extend Koha::MetadataRecord to handle
serialization format and record id

In order to use Koha::MetadataRecord as a container for moving records
around it is important to let it carry the serialization format
of the record object it was built with, so it is easier and cheaper to
make decisions about records.

This patch introduces regression tests for the changes to be made.
The 'format' param is introduced, and also sets default values:
  schema = 'marc21'
  format = 'marc'

A new (optional) 'id' param is added so the record carries its own id outside
of it.

The default behaviour is preserved, and no changes are needed in places
Koha::MetadataRecord is used.
-new also returns undef if no record is passed, and raises a carped warning.

To test:
- Apply the patch
- Run the new tests
  $ prove t/Koha_MetadataRecord.t
= FAIL: Tests shoud fail as the changes are not implemented on
Koha::MetadataRecord

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #41316|0   |1
is obsolete||

--- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 41358
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41358action=edit
Bug 14639: Extend Koha::MetadataRecord to handle serialization format and
record id

The description of this changes is on the regression tests commit
message.

To test:
- Run
  $ prove t/Koha_MetadataRecord.t
= FAIL: Tests fail because changes are not implemented
- Apply this patch
- Run
  $ prove t/Koha_MetadataRecord.t
= SUCCESS: tests pass
- Run
  $ prove t/Koha_Util_MARC.t
= SUCCESS: it still passes
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||jcam...@cpbibliography.com
   Assignee|gmcha...@gmail.com  |tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

--- Comment #2 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 41316
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41316action=edit
Bug 14639: Extend Koha::MetadataRecord to handle serialization format

The description of this changes is on the regression tests commit
message.

To test:
- Run
  $ prove t/Koha_MetadataRecord.t
= FAIL: Tests fail because changes are not implemented
- Apply this patch
- Run
  $ prove t/Koha_MetadataRecord.t
= SUCCESS: tests pass
- Run
  $ prove t/Koha_Util_MARC.t
= SUCCESS: it still passes
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

--- Comment #1 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 41315
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41315action=edit
Bug 14639: (regression tests) Extend Koha::MetadataRecord to handle
serialization format

In order to use Koha::MetadataRecord as a container for moving records
around it is important to let it carry the serialization format
of the record object it was built with, so it is easier and cheaper to
make decisions about records.

This patch introduces regression tests for the changes to be made.
The 'format' param is introduced, and also sets default values:
  schema = 'marc21'
  format = 'usmarc'
so the default behaviour is preserved, and no changes are needed in places
Koha::MetadataRecord is used.
-new also returns undef if no record is passed, and raises a carped warning.

To test:
- Apply the patch
- Run the new tests
  $ prove t/Koha_MetadataRecord.t
= FAIL: Tests shoud fail as the changes are not implemented on
Koha::MetadataRecord

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/