[Koha-bugs] [Bug 14648] Batch Remove Reserve Items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Tom Misilo changed: What|Removed |Added CC||misi...@fit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch Remove Reserve Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Joe Sikowitz changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |j...@flo.org |ity.org | --- Comment #2 from Joe Sikowitz --- Created attachment 105190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105190&action=edit Bug 14648: Batch Remove Reserve Items Patch adds a button to course-details page based on the delete_reserves permission. Test plan in patch description. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Katrin Fischer changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Summary|Batch Remove Reserve Items |Batch remove reserve items --- Comment #3 from Katrin Fischer --- Hi Joe, once you attach a patch for testing, don't forget to set the status to 'Needs signoff' so testers can see it in the queue :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer --- Hi Joe, having a look at the patch: 1) QA test tools We have a script the QA team uses to find common mistakes and coding guideline variations in patches. It's a good habit for devs to run the script on their patches too. In this case it alerts of tabs: FAIL course_reserves/course-details.pl OK critic FAIL forbidden patterns forbidden pattern: tab char (line 55) forbidden pattern: tab char (line 56) forbidden pattern: tab char (line 57) forbidden pattern: tab char (line 58) OK git manipulation OK pod OK spelling OK valid FAIL koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt OK filters FAIL forbidden patterns forbidden pattern: tab char (line 39) forbidden pattern: tab char (line 40) forbidden pattern: tab char (line 41) forbidden pattern: tab char (line 290) forbidden pattern: tab char (line 291) forbidden pattern: tab char (line 292) OK git manipulation In Koha we have agreed to use 4 spaces and no tabs. Please check your editor settings, that should make things easier. 2) I'd like to suggest to change the label on the button. The 'batch' features usually work by giving it a list, what you do is delete all - so I think we should we should name it that and leave the 'Batch remove...' to be added later. "Remove all reserves" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #5 from Joe Sikowitz --- Hi Katrin. Thanks for the feedback on the patch. I'll update it without tabs and make the change in the language of the button. I'll then readd the patch and post it for testing. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #6 from Katrin Fischer --- Sounds perfect, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #7 from Joe Sikowitz --- Moved patch to Bug 25606 as "Remove all reserves" button. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Joe Sikowitz changed: What|Removed |Added Attachment #105190|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #8 from Hannah Olsen --- Wait, so is this set up to only remove *everything* from the reserve? Not to let you choose which ones to remove? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #9 from Joe Sikowitz --- Hi Hannah, you can choose to remove items one-by-one. I moved my original patch to Bug 25606 to add an option to remove all items on a course record at once. As Katrin describes, this bug will be used to create a batch remove reserves function which will involve entering barcodes and then removing those items from all course reserves to which they are attached. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #10 from Joe Sikowitz --- Created attachment 105607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105607&action=edit Bug-14648-Batch-remove-reserve-items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #11 from Joe Sikowitz --- Test Plan 1. Log in as a user with permissions to add and delete course reserves 2. Add the same items to multiple course reserves 3. Go to the main course reserves page (i.e. /cgi-bin/koha/course_reserves/course-reserves.pl) 4. Click the "- Batch remove items" button 5. Enter the barcodes that you added to multiple reserves in step 1 6. Click submit 7. Click Ok if you are ready to delete all of these items 8. Check each course reserve that you added the items to in step 1 to make sure the items you entered were deleted but nothing else 9. Log out 10. Log in as a user without permission to delete course reserves 11. Go to the main course reserves page (i.e. /cgi-bin/koha/course_reserves/course-reserves.pl) 12. You should not longer see the "- Batch remove items" button -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Joe Sikowitz changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #12 from Katrin Fischer --- Created attachment 105609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105609&action=edit Bug 14648: Batch remove reserve items Adds "Batch remove items" button to course-reserves.tt. Creates batch_rm_items.pl and batch_rm_items.tt. Allows user to enter a list of barcode numbers so that they will be removed from all course reserves to which they are attached. A dialog box will provide a warning before the final deletion is made. Test Plan 1. Log in as a user with permissions to add and delete course reserves 2. Add the same items to multiple course reserves 3. Go to the main course reserves page (i.e. /cgi-bin/koha/course_reserves/course-reserves.pl) 4. Click the "- Batch remove items" button 5. Enter the barcodes that you added to multiple reserves in step 1 6. Click submit 7. Click Ok if you are ready to delete all of these items 8. Check each course reserve that you added the items to in step 1 to make sure the items you entered were deleted but nothing else 9. Log out 10. Log in as a user without permission to delete course reserves 11. Go to the main course reserves page (i.e. /cgi-bin/koha/course_reserves/course-reserves.pl) 12. You should not longer see the "- Batch remove items" button Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #13 from Katrin Fischer --- Created attachment 105610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105610&action=edit Bug 14648: (follow-up) Remove formatting from note for better translatability Removes to avoid that the sentence is split into separate parts in translation files. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Katrin Fischer changed: What|Removed |Added Attachment #105607|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #14 from Katrin Fischer --- Hi Joe, thx for the patch! I noticed the attached patch file had a bit of a strange description - are you using git bz for attaching your patches? It makes interaction with Bugzilla very easy. I've done a follow-up, that I'd like to explain a bit: All course reserve items will be deleted from all courses to which they are attached. Will result in 3 separate strings to translate. - All course reserve items will be deleted from - all - courses to which they are attached I've seen there is a pre-existing occurence on the batch add feature, but we should fix that another time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #15 from Joe Sikowitz --- Hi Katrin, thanks for the info. No, I haven't used git bz before, but I'll look at it and start to use it. I'm a bit new to the git/Bugzilla world so I'm still learning the ins and outs of getting my patches to the community. Thanks for all of your help! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #16 from Katrin Fischer --- QA team ... I signed off, can one of you take over here please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #17 from Nick Clemens --- (In reply to Katrin Fischer from comment #16) > QA team ... I signed off, can one of you take over here please? These patches keep things simple and work as expected. Blocker: 1 - If I enter barcodes that are not in any courses I report successful deletion from all courses - I don't think that's right Couple questions: 1 - Why not a bulk option to remove from a single course? 2 - Could the results report which courses the items were deleted from, at the very least maybe the number of courses it was removed from? 3 - I would rather see this use Objects, but CourseReserves could use a refactor as a whole -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #18 from Joe Sikowitz --- Hi Nick, These patches keep things simple and work as expected. Blocker: 1 - If I enter barcodes that are not in any courses I report successful deletion from all courses - I don't think that's right I'm going to fix this one and readd the patch. Couple questions: 1 - Why not a bulk option to remove from a single course? I've already submitted this patch and it has been signed off as bug 25606. 2 - Could the results report which courses the items were deleted from, at the very least maybe the number of courses it was removed from? This sounds reasonable. I'll look into adding it. 3 - I would rather see this use Objects, but CourseReserves could use a refactor as a whole I'm not sure what Objects you are referring to. Any information you can provide would be great. Thanks, Joe -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648
--- Comment #19 from Nick Clemens ---
(In reply to Joe Sikowitz from comment #18)
> Hi Nick,
>
> These patches keep things simple and work as expected.
>
> Blocker:
> 1 - If I enter barcodes that are not in any courses I report successful
> deletion from all courses - I don't think that's right
>
> I'm going to fix this one and readd the patch.
>
> Couple questions:
> 1 - Why not a bulk option to remove from a single course?
>
> I've already submitted this patch and it has been signed off as bug 25606.
>
> 2 - Could the results report which courses the items were deleted from, at
> the very least maybe the number of courses it was removed from?
>
> This sounds reasonable. I'll look into adding it.
>
> 3 - I would rather see this use Objects, but CourseReserves could use a
> refactor as a whole
>
> I'm not sure what Objects you are referring to. Any information you can
> provide would be great.
>
> Thanks,
> Joe
For #3 I meant using:
Koha::Course::Reserve->find({itemnumber=> $item->id});
instead of:
GetItemCourseReservesInfo(itemnumber => $item->id);
Probably we should have a 'course_reserves' function in Item.pm or something,
but I think that is beyond scope here
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Joe Sikowitz changed: What|Removed |Added Attachment #105609|0 |1 is obsolete|| --- Comment #20 from Joe Sikowitz --- Created attachment 107043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107043&action=edit Bug 14648: Batch remove reserve items Adds "Batch remove items" button to course-reserves.tt. Creates batch_rm_items.pl and batch_rm_items.tt. Allows user to enter a list of barcode numbers so that they will be removed from all course reserves to which they are attached. A dialog box will provide a warning before the final deletion is made. This patch also now moves barcodes that are invalid or not attached to a course reserve to the invalid barcodes output. It also provides a count of the courses that the deleted items were attached to. Test Plan 1. Log in as a user with permissions to add and delete course reserves 2. Add the same items to multiple course reserves 3. Go to the main course reserves page (i.e. /cgi-bin/koha/course_reserves/course-reserves.pl) 4. Click the "- Batch remove items" button 5. Enter the barcodes that you added to multiple reserves in step 1 6. Click submit 7. Click Ok if you are ready to delete all of these items 8. Check each course reserve that you added the items to in step 1 to make sure the items you entered were deleted but nothing else 9. Repeat 2-5 10. Add an invalid barcode and a valid barcode that is not attached to a course reserve 11. Repeat 6-7 12. You should see that the items attached to course reserves were removed while the invalid and unattached barcodes were rejected 13. Log out 14. Log in as a user without permission to delete course reserves 15. Go to the main course reserves page (i.e. /cgi-bin/koha/course_reserves/course-reserves.pl) 16. You should not longer see the "- Batch remove items" button -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Joe Sikowitz changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Joe Sikowitz changed: What|Removed |Added Attachment #105610|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #21 from Joe Sikowitz --- I set this back to the "Needs Signoff" status even though the first iteration already went to QA and failed. I'm not sure if this is the correct process, but it's been pending for a while. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 David Nind changed: What|Removed |Added Attachment #107043|0 |1 is obsolete|| --- Comment #22 from David Nind --- Created attachment 110228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110228&action=edit Bug 14648: Batch remove reserve items Adds "Batch remove items" button to course-reserves.tt. Creates batch_rm_items.pl and batch_rm_items.tt. Allows user to enter a list of barcode numbers so that they will be removed from all course reserves to which they are attached. A dialog box will provide a warning before the final deletion is made. This patch also now moves barcodes that are invalid or not attached to a course reserve to the invalid barcodes output. It also provides a count of the courses that the deleted items were attached to. Test Plan 1. Log in as a user with permissions to add and delete course reserves 2. Add the same items to multiple course reserves 3. Go to the main course reserves page (i.e. /cgi-bin/koha/course_reserves/course-reserves.pl) 4. Click the "- Batch remove items" button 5. Enter the barcodes that you added to multiple reserves in step 1 6. Click submit 7. Click Ok if you are ready to delete all of these items 8. Check each course reserve that you added the items to in step 1 to make sure the items you entered were deleted but nothing else 9. Repeat 2-5 10. Add an invalid barcode and a valid barcode that is not attached to a course reserve 11. Repeat 6-7 12. You should see that the items attached to course reserves were removed while the invalid and unattached barcodes were rejected 13. Log out 14. Log in as a user without permission to delete course reserves 15. Go to the main course reserves page (i.e. /cgi-bin/koha/course_reserves/course-reserves.pl) 16. You should not longer see the "- Batch remove items" button Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #23 from Katrin Fischer --- Hi Joe, once things have been fixed, you can usually go back to Signed off if the changes were not too major (in this case, do a follow-up patch instead of replacing the original one, so QA can easier see the new changes). Set back to "Needs Signoff" for more drastic changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Katrin Fischer changed: What|Removed |Added Attachment #110228|0 |1 is obsolete|| --- Comment #24 from Katrin Fischer --- Created attachment 110293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110293&action=edit Bug 14648: Batch remove reserve items Adds "Batch remove items" button to course-reserves.tt. Creates batch_rm_items.pl and batch_rm_items.tt. Allows user to enter a list of barcode numbers so that they will be removed from all course reserves to which they are attached. A dialog box will provide a warning before the final deletion is made. This patch also now moves barcodes that are invalid or not attached to a course reserve to the invalid barcodes output. It also provides a count of the courses that the deleted items were attached to. Test Plan 1. Log in as a user with permissions to add and delete course reserves 2. Add the same items to multiple course reserves 3. Go to the main course reserves page (i.e. /cgi-bin/koha/course_reserves/course-reserves.pl) 4. Click the "- Batch remove items" button 5. Enter the barcodes that you added to multiple reserves in step 1 6. Click submit 7. Click Ok if you are ready to delete all of these items 8. Check each course reserve that you added the items to in step 1 to make sure the items you entered were deleted but nothing else 9. Repeat 2-5 10. Add an invalid barcode and a valid barcode that is not attached to a course reserve 11. Repeat 6-7 12. You should see that the items attached to course reserves were removed while the invalid and unattached barcodes were rejected 13. Log out 14. Log in as a user without permission to delete course reserves 15. Go to the main course reserves page (i.e. /cgi-bin/koha/course_reserves/course-reserves.pl) 16. You should not longer see the "- Batch remove items" button Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #26 from Katrin Fischer --- Created attachment 110295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110295&action=edit Bug 14648: (QA follow-up) Terminology items-reserves delete-remove - As we have batch add reserves, we should also have batch remove reserves - Delete items sounds a bit scary, removed items I think is a little better here Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #25 from Katrin Fischer --- Created attachment 110294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110294&action=edit Bug 14648: (QA follow-up) Add missing filters Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #27 from Jonathan Druart --- Would it make sense to dissociate invalid (non-existent) barcodes from items that are not attached to a course (on the result screen)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #28 from Jonathan Druart --- Created attachment 110988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110988&action=edit Bug 14648: Take advantage of I18N to deal with plural -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #29 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #30 from Lucas Gass --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch Remove Reserve Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Hannah Olsen changed: What|Removed |Added CC||hol...@duncanville.com --- Comment #1 from Hannah Olsen --- We use Course Reserves for our displays and would find this feature very useful as well. One can do a workaround through deactivating the course, but there are times when that is not feasible. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch remove reserve items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Katrin Fischer changed: What|Removed |Added Text to go in the||This allows to batch remove release notes||items from any course ||reserve they have been ||added to using a barcode ||list. Access the new ||feature using the "Batch ||remove reserves" button on ||the course reserves module ||start page. Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] Batch Remove Reserve Items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Joe Sikowitz changed: What|Removed |Added CC||j...@flo.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
