[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||27145


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145
[Bug 27145] Patron deletion via intranet doesn't handle exceptions well
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to oldstable |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net

--- Comment #51 from Victor Grousset/tuxayo  ---
Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Version(s)|20.11.00|20.11.00, 20.05.07
released in||
 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable

--- Comment #50 from Andrew Fuerste-Henry  ---
Pushed to 20.05.x for 20.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Kyle M Hall  changed:

   What|Removed |Added

 Blocks|27145   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145
[Bug 27145] Patron deletion via intranet doesn't handle exceptions well
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Joonas Kylmälä  changed:

   What|Removed |Added

 Blocks||27145


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145
[Bug 27145] Patron deletion via intranet doesn't handle exceptions well
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Joonas Kylmälä  changed:

   What|Removed |Added

 Blocks||27144


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144
[Bug 27144] Cannot delete any patrons
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #49 from Lucas Gass  ---
not pushing this to 20.05.x until I can also push the patch for bug 26984

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||26984


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26984
[Bug 26984] Tests are failing if AnonymousPatron is configured
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #48 from Jonathan Druart  
---
This patchset causes bug 26984 (tests are failing if anonymous patron is
configured).
We must fix that before the 20.11 release!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #47 from Jonathan Druart  
---
Pushed to master for 20.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)||20.11.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #46 from Tomás Cohen Arazi  ---
Created attachment 113121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113121=edit
Bug 14708: (QA follow-up) Add tests

This patch adds tests for the change. It also simplifies the delete()
method structure a bit. It fixes the error 500 the tests were raising.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/patrons.t
=> FAIL: Tests fail!
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests pass! The new behaviour (code 403) is tested!
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #45 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #43)
> There is a test failing however:
> 
> #   Failed test 'Patron not found'
> #   at t/db_dependent/api/v1/patrons.t line 423.
> #  got: '500'
> # expected: '404'
> 
> 
> And a test missing to cover the change from the last patch.

BTW: I love tests :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #44 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #42)
> Having this code into master won't help anything: it will have to be rebuilt
> as it cannot be used as a good base.
> 
> I am willing to push this patchset as it, given the low bug number (but not
> sure it's a good argument...)

The argument is, this is a bugfix. And refactoring things the way they are
discussing is a good path forward. But it won't happen in stable for a while.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #43 from Jonathan Druart  
---
There is a test failing however:

#   Failed test 'Patron not found'
#   at t/db_dependent/api/v1/patrons.t line 423.
#  got: '500'
# expected: '404'


And a test missing to cover the change from the last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #42 from Jonathan Druart  
---
Having this code into master won't help anything: it will have to be rebuilt as
it cannot be used as a good base.

I am willing to push this patchset as it, given the low bug number (but not
sure it's a good argument...)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #41 from David Cook  ---
(In reply to Kyle M Hall from comment #40)
> I was actually discussing that as the 'next step' after this development. We
> could easily add a 'read-only' flag to a given account and move the
> AnonymousPatron logic into a a new Patron method like is_deletable. This
> would be especially useful for accounts used for SIP, APIs, and so forth. I
> would consider this to be a building block for bug 26170.

That sounds good to me!

I worry a bit that we're talking about refactoring a change before it's even
pushed into Koha, but I suppose that I wouldn't really want to hold up this
change either...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #40 from Kyle M Hall  ---
(In reply to David Cook from comment #39)
> (In reply to David Cook from comment #38)
> > I like the idea that the Anonymous Patron cannot be deleted, but I think
> > that this implementation is too narrowly cast. 
> > 
> > I think that we should consider doing Bug 26170 (Create "system" patrons
> > that cannot be (easily) deleted via the web UI) instead of this one, since
> > there are many scenarios where we don't want to be able to delete patron
> > accounts that are important (e.g. SIP patron, REST API patron, etc.)
> 
> Admittedly, I don't have any patches on Bug 26170, and it's not high on my
> priority list at the moment, so I don't see myself working on it any time
> soon.
> 
> Kyle has done all this great work, and really if it could be adapted to be
> more generalizable for all kinds of "system" patrons, that would be amazing.
> It would be a very useful development.

I was actually discussing that as the 'next step' after this development. We
could easily add a 'read-only' flag to a given account and move the
AnonymousPatron logic into a a new Patron method like is_deletable. This would
be especially useful for accounts used for SIP, APIs, and so forth. I would
consider this to be a building block for bug 26170.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #39 from David Cook  ---
(In reply to David Cook from comment #38)
> I like the idea that the Anonymous Patron cannot be deleted, but I think
> that this implementation is too narrowly cast. 
> 
> I think that we should consider doing Bug 26170 (Create "system" patrons
> that cannot be (easily) deleted via the web UI) instead of this one, since
> there are many scenarios where we don't want to be able to delete patron
> accounts that are important (e.g. SIP patron, REST API patron, etc.)

Admittedly, I don't have any patches on Bug 26170, and it's not high on my
priority list at the moment, so I don't see myself working on it any time soon.

Kyle has done all this great work, and really if it could be adapted to be more
generalizable for all kinds of "system" patrons, that would be amazing. It
would be a very useful development.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #38 from David Cook  ---
I like the idea that the Anonymous Patron cannot be deleted, but I think that
this implementation is too narrowly cast. 

I think that we should consider doing Bug 26170 (Create "system" patrons that
cannot be (easily) deleted via the web UI) instead of this one, since there are
many scenarios where we don't want to be able to delete patron accounts that
are important (e.g. SIP patron, REST API patron, etc.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #37 from Kyle M Hall  ---
Created attachment 112922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112922=edit
Bug 14708: (QA follow-up) Use try/catch blocks when calling delete() on a
patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Tomás Cohen Arazi  changed:

   What|Removed |Added

Version|unspecified |master
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #112830|0   |1
is obsolete||

--- Comment #36 from Kyle M Hall  ---
Created attachment 112831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112831=edit
Bug 14708: (QA follow-up) Throw exception when deleting anonymous borrower

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Kyle M Hall  changed:

   What|Removed |Added

 Status|In Discussion   |Passed QA

--- Comment #35 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #32)
>  sub delete {
>  my ($self) = @_;
> 
> +my $anonymous_patron = C4::Context->preference("AnonymousPatron");
> +return $self if $anonymous_patron && $self->id eq $anonymous_patron;
> 
> 
> Shouldn't we raise an exception instead?

Here you go!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #34 from Kyle M Hall  ---
Created attachment 112830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112830=edit
Bug 14708: (QA follow-up) Throw exception when deleting anonymous borrower

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion

--- Comment #33 from Jonathan Druart  
---
Waiting for an answer here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #31 from Jonathan Druart  
---
hum, cannot recreate either now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #32 from Jonathan Druart  
---
 sub delete {
 my ($self) = @_;

+my $anonymous_patron = C4::Context->preference("AnonymousPatron");
+return $self if $anonymous_patron && $self->id eq $anonymous_patron;


Shouldn't we raise an exception instead?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Failed QA   |Passed QA

--- Comment #30 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #28)
> I used the "Batch patron deletion and anonymization" tool and the anonymous
> patron has moved to deletedborrowers. Is that expected? I don't think so.

I don't recreate, can you provide your steps?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=26170

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #29 from Katrin Fischer  ---
Hm, I think we always set the anonymous patron as staff user, that prevents
that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #28 from Jonathan Druart  
---
I used the "Batch patron deletion and anonymization" tool and the anonymous
patron has moved to deletedborrowers. Is that expected? I don't think so.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #105029|0   |1
is obsolete||

--- Comment #26 from Katrin Fischer  ---
Created attachment 105189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105189=edit
Bug 14708: Don't allow merging of other patron records into Anonymous Patron

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #27 from Katrin Fischer  ---
Has strings!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #105028|0   |1
is obsolete||

--- Comment #25 from Katrin Fischer  ---
Created attachment 105188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105188=edit
Bug 14708: Don't allow merging of Anonymous Patron into other patron records

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #105027|0   |1
is obsolete||

--- Comment #24 from Katrin Fischer  ---
Created attachment 105187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105187=edit
Bug 14708: Skip AnonymousPatron in GetBorrowersToExpunge

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #105024|0   |1
is obsolete||

--- Comment #21 from Katrin Fischer  ---
Created attachment 105184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105184=edit
Bug 14708: The patron set as the anonymous patron should not be deletable.

Right now it's possible to delete the anonymous patron at any time. When this
happens the system will break just as if anonymouspatron was unset but patrons
still have an "always anonymize" privacy setting.

This issue occurs more frequently than one would expect.

We should make it so that the patron set in AnonymousPatron is not deletable.

Test Plan:
1) Apply this patch
2) Set a patron to by AnonymousPatron
3) Attempt to delete that patron from the members toolbar
4) Note the error message!

Signed-off-by: Devinim 

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #105026|0   |1
is obsolete||

--- Comment #23 from Katrin Fischer  ---
Created attachment 105186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105186=edit
Bug 14708: Prevent deletion of Anonymous Patron at Koha::Patron::delete

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #105025|0   |1
is obsolete||

--- Comment #22 from Katrin Fischer  ---
Created attachment 105185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105185=edit
Bug 14708: Enforce restriction in delete_patrons.pl

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Katrin Fischer  changed:

   What|Removed |Added

Summary|The patron set as the   |The patron set as the
   |anonymous patron should not |anonymous patron should not
   |be deletable.   |be deletable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #103028|0   |1
is obsolete||

--- Comment #19 from Andrew Fuerste-Henry  ---
Created attachment 105028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105028=edit
Bug 14708: Don't allow merging of Anonymous Patron into other patron records

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #103922|0   |1
is obsolete||

--- Comment #20 from Andrew Fuerste-Henry  ---
Created attachment 105029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105029=edit
Bug 14708: Don't allow merging of other patron records into Anonymous Patron

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Andrew Fuerste-Henry  changed:

   What|Removed |Added

  Attachment #85789|0   |1
is obsolete||

--- Comment #16 from Andrew Fuerste-Henry  ---
Created attachment 105025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105025=edit
Bug 14708: Enforce restriction in delete_patrons.pl

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #103027|0   |1
is obsolete||

--- Comment #18 from Andrew Fuerste-Henry  ---
Created attachment 105027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105027=edit
Bug 14708: Skip AnonymousPatron in GetBorrowersToExpunge

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Attachment #103026|0   |1
is obsolete||

--- Comment #17 from Andrew Fuerste-Henry  ---
Created attachment 105026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105026=edit
Bug 14708: Prevent deletion of Anonymous Patron at Koha::Patron::delete

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Andrew Fuerste-Henry  changed:

   What|Removed |Added

  Attachment #85770|0   |1
is obsolete||

--- Comment #15 from Andrew Fuerste-Henry  ---
Created attachment 105024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105024=edit
Bug 14708: The patron set as the anonymous patron should not be deletable.

Right now it's possible to delete the anonymous patron at any time. When this
happens the system will break just as if anonymouspatron was unset but patrons
still have an "always anonymize" privacy setting.

This issue occurs more frequently than one would expect.

We should make it so that the patron set in AnonymousPatron is not deletable.

Test Plan:
1) Apply this patch
2) Set a patron to by AnonymousPatron
3) Attempt to delete that patron from the members toolbar
4) Note the error message!

Signed-off-by: Devinim 

Signed-off-by: Andrew Fuerste-Henry 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

didier  changed:

   What|Removed |Added

 CC||didier.gautheron@biblibre.c
   ||om

--- Comment #14 from didier  ---
Hi,

nitpicking here but IMO:
- tests in their own commit make it easier for double checking they fail on
unpatched code, as they must.

- some patches could be squashed, thinking of git bisect.

- Tests are done with 'AnonymousPatron' set to $anonymous_patron, so far so
good, but what if AnonymousPatron is set to a different patron or unset? It's
not obvious if it's covered by older tests. 

Regards
Didier

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||24483


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24483
[Bug 24483] When batch deleting patrons, report who was not deleted and why
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #13 from Kyle M Hall  ---
(In reply to Andrew Fuerste-Henry from comment #11)
> This technically works, but:
> - When merging patrons, I am able to merge another patron into my anonymous
> patron. Is this what we want? Could be, just wanted to make sure it'd been
> considered.

Fixed with the latest patch!

> - When I try to merge my anonymous patron into someone else, it fails as
> desired but the error given is "No valid patrons to merge were found." Would
> be nice to have something more specific about why the action cannot be
> completed.

That would definitely be a nice enhancement, but it out of the scope of this
bug. Can you file a followup bug report for that?

> - When attempting to include the anonymous patron in a batch delete, Koha
> does not delete them and does not tell you why. This is really a larger
> issue, as that's standard batch patron delete behavior. I'm really just
> taking this opportunity to stump for bug 24483, which suggests adding some
> feedback about who wasn't batch deleted and why.

Also agreed, but is of course outside the scope of this bug report. I will make
14708 depend on this bug so the feedback can include anonymous borrower issues
when merging.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #12 from Kyle M Hall  ---
Created attachment 103922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103922=edit
Bug 14708: Don't allow merging of other patron records into Anonymous Patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #11 from Andrew Fuerste-Henry  ---
This technically works, but:
- When merging patrons, I am able to merge another patron into my anonymous
patron. Is this what we want? Could be, just wanted to make sure it'd been
considered.
- When I try to merge my anonymous patron into someone else, it fails as
desired but the error given is "No valid patrons to merge were found." Would be
nice to have something more specific about why the action cannot be completed.
- When attempting to include the anonymous patron in a batch delete, Koha does
not delete them and does not tell you why. This is really a larger issue, as
that's standard batch patron delete behavior. I'm really just taking this
opportunity to stump for bug 24483, which suggests adding some feedback about
who wasn't batch deleted and why.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 CC||and...@bywatersolutions.com

--- Comment #10 from Andrew Fuerste-Henry  ---
Fleshing out Kyle's test plan based on later additions:
Test Plan:
1) Apply this patch
2) Set a patron to by AnonymousPatron
3) Attempt to delete that patron from the members toolbar
4) Note the error message!
5) Attempt to delete the patron from patch patron deletion
6) Note the error message!
7) Attempt to merge the patron into another record
8) Note the error message!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #9 from Kyle M Hall  ---
Created attachment 103028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103028=edit
Bug 14708: Don't allow merging of Anonymous Patron into other patron records

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #8 from Kyle M Hall  ---
Created attachment 103027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103027=edit
Bug 14708: Skip AnonymousPatron in GetBorrowersToExpunge

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #7 from Kyle M Hall  ---
Created attachment 103026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103026=edit
Bug 14708: Prevent deletion of Anonymous Patron at Koha::Patron::delete

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||josef.mora...@gmail.com

--- Comment #6 from Josef Moravec  ---
(In reply to Jonathan Druart from comment #5)
> Hi Kyle,
> At first glance I'd say tools/cleanborrowers.pl is missing.
> Maybe we should have this constraint in Koha::Patron->delete/move_to_deleted
> to make sure we are covering all cases?

Definitey...

Another place could merging patrons so hard to not forget anything...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
Hi Kyle,
At first glance I'd say tools/cleanborrowers.pl is missing.
Maybe we should have this constraint in Koha::Patron->delete/move_to_deleted to
make sure we are covering all cases?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #4 from Kyle M Hall  ---
Created attachment 85789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85789=edit
Bug 14708: Enforce restriction in delete_patrons.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #85770|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
  Attachment #85783|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #85770|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 85783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85783=edit
Bug 14708: The patron set as the anonymous patron should not be deletable.

Right now it's possible to delete the anonymous patron at any time. When this
happens the system will break just as if anonymouspatron was unset but patrons
still have an "always anonymize" privacy setting.

This issue occurs more frequently than one would expect.

We should make it so that the patron set in AnonymousPatron is not deletable.

Test Plan:
1) Apply this patch
2) Set a patron to by AnonymousPatron
3) Attempt to delete that patron from the members toolbar
4) Note the error message!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Devinim  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Devinim  changed:

   What|Removed |Added

  Attachment #85766|0   |1
is obsolete||

--- Comment #2 from Devinim  ---
Created attachment 85770
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85770=edit
Bug 14708: The patron set as the anonymous patron should not be deletable.

Right now it's possible to delete the anonymous patron at any time. When this
happens the system will break just as if anonymouspatron was unset but patrons
still have an "always anonymize" privacy setting.

This issue occurs more frequently than one would expect.

We should make it so that the patron set in AnonymousPatron is not deletable.

Test Plan:
1) Apply this patch
2) Set a patron to by AnonymousPatron
3) Attempt to delete that patron from the members toolbar
4) Note the error message!

Signed-off-by: Devinim 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

--- Comment #1 from Kyle M Hall  ---
Created attachment 85766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85766=edit
Bug 14708: The patron set as the anonymous patron should not be deletable.

Right now it's possible to delete the anonymous patron at any time. When this
happens the system will break just as if anonymouspatron was unset but patrons
still have an "always anonymize" privacy setting.

This issue occurs more frequently than one would expect.

We should make it so that the patron set in AnonymousPatron is not deletable.

Test Plan:
1) Apply this patch
2) Set a patron to by AnonymousPatron
3) Attempt to delete that patron from the members toolbar
4) Note the error message!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |kyle.m.h...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/