[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Jonathan Druart changed: What|Removed |Added Keywords|release-notes-needed| CC||jonathan.druart+koha@gmail. ||com --- Comment #67 from Jonathan Druart --- No release notes provided in the expected delay. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Florian changed: What|Removed |Added CC||sophie.meyni...@biblibre.co ||m --- Comment #66 from Florian --- *** Bug 15417 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #65 from Martin Renvoize --- No worries at all, we all do it sometimes :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #64 from Emmi Takkinen --- Gosh, I didn't realise I had made that change in follow up and hadn't tested it properly. My bad, sorry. Thanks Martin for fixing this :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #63 from Martin Renvoize --- To clarify, the followups here that converted from string note to translatable code broke the feature entirely ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #62 from Martin Renvoize --- See bug 28813 where I fixed the issues. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #61 from Emmi Takkinen --- (In reply to Martin Renvoize from comment #60) > Ouch.. there's stuff missing here. > > We don't update kohastructure at all and we don't do a DB update to add the > error_code field to the database either. Finally, we don't add error_code > to the _set_message_status routine. I don't understand what you mean with error_code? We add delivery_note column where fail message is added and it's also added to _set_message_status routine. Also kohastructure is updated on first patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Martin Renvoize changed: What|Removed |Added Blocks||28813 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28813 [Bug 28813] Delivery notes feature was pushed prior to it's completion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #60 from Martin Renvoize --- Ouch.. there's stuff missing here. We don't update kohastructure at all and we don't do a DB update to add the error_code field to the database either. Finally, we don't add error_code to the _set_message_status routine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Katrin Fischer changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #59 from Fridolin Somers --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #58 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #57 from Jonathan Druart --- Created attachment 120667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120667&action=edit Bug 14723: Make DBrev idempotent -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #56 from Kyle M Hall --- Created attachment 120492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120492&action=edit Bug 14723: Use DATETIME instead DATE Letters.t tests failed since time_queued didn't include timecode. Use DATETIME when inserting into message_queue. To test prove t/db_dependent/Letters.t Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #55 from Kyle M Hall --- Created attachment 120491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120491&action=edit Bug 14723: (QA follow-up) Fix typo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #54 from Kyle M Hall --- Created attachment 120490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120490&action=edit Bug 14723: Add error codes and replace strings with them in template This patch adds error codes for delivery notes and replaces English strings with them in template. To test confirm everything works as intended. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #53 from Kyle M Hall --- Created attachment 120489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120489&action=edit Bug 14723: Make delivery notes translatable Delivery notes weren't translatable. This patch adds them in notices.tt. If note is Mail::Sendmail error generic 'Error occured while sending email' is shown. Also fixes MySQLisms and adds AFTER to atomicupdate file. To test prove t/db_dependent/Letters.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Kyle M Hall changed: What|Removed |Added Attachment #120487|0 |1 is obsolete|| --- Comment #52 from Kyle M Hall --- Created attachment 120488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120488&action=edit Bug 14723: Additional delivery notes to messages This patch adds additional delivery notes to messages in message queue as there can be multiple reasons for a delivery to fail. Currently in message_queue we are given only two delivery statuses for messages, "sent" and "failed". When the status becomes failed, we have no idea why it fails. This feature can be useful with SMS gateway providers. Many SMS gateways inform the application the reason of SMS delivery failure. With this feature, this information can now be stored. As well as for emails, instead of simply logging failures, we can now store the reason of failure directly into the message row of message_queue. Test plan: 1. Enable EnhancedMessagingPreferences syspref 2. Find a borrower with notices at members/notices.pl 3. Observe that there is no column for Delivery notes 4. Apply patch and run the given database update 5. Repeat step 1. 6. Observe that there is now a column for Delivery notes Sponsored-by: Hypernova Oy Signed-off-by: Liz Rea Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Kyle M Hall changed: What|Removed |Added Attachment #120309|0 |1 is obsolete|| Attachment #120310|0 |1 is obsolete|| Attachment #120312|0 |1 is obsolete|| Attachment #120314|0 |1 is obsolete|| Attachment #120376|0 |1 is obsolete|| --- Comment #51 from Kyle M Hall --- Created attachment 120487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120487&action=edit Bug 14723: Additional delivery notes to messages This patch adds additional delivery notes to messages in message queue as there can be multiple reasons for a delivery to fail. Currently in message_queue we are given only two delivery statuses for messages, "sent" and "failed". When the status becomes failed, we have no idea why it fails. This feature can be useful with SMS gateway providers. Many SMS gateways inform the application the reason of SMS delivery failure. With this feature, this information can now be stored. As well as for emails, instead of simply logging failures, we can now store the reason of failure directly into the message row of message_queue. Test plan: 1. Enable EnhancedMessagingPreferences syspref 2. Find a borrower with notices at members/notices.pl 3. Observe that there is no column for Delivery notes 4. Apply patch and run the given database update 5. Repeat step 1. 6. Observe that there is now a column for Delivery notes Sponsored-by: Hypernova Oy Signed-off-by: Liz Rea Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Emmi Takkinen changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #50 from Emmi Takkinen --- Created attachment 120376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120376&action=edit Bug 14723: Use DATETIME instead DATE Letters.t tests failed since time_queued didn't include timecode. Use DATETIME when inserting into message_queue. To test prove t/db_dependent/Letters.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #49 from Kyle M Hall --- Created attachment 120314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120314&action=edit Bug 14723: (QA follow-up) Fix typo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #48 from Kyle M Hall --- prove t/db_dependent/Letters.t t/db_dependent/Letters.t .. 6/86 # Failed test 'Time status changed equals time queued when created in message_queue table' # at t/db_dependent/Letters.t line 148. # got: '2021-04-29 13:50:54' # expected: '2021-04-29 00:00:00' t/db_dependent/Letters.t .. 70/86 # Looks like you failed 1 test of 86. t/db_dependent/Letters.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/86 subtests Test Summary Report --- t/db_dependent/Letters.t (Wstat: 256 Tests: 86 Failed: 1) Failed test: 21 Non-zero exit status: 1 Files=1, Tests=86, 4 wallclock secs ( 0.03 usr 0.01 sys + 2.48 cusr 0.39 csys = 2.91 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Emmi Takkinen changed: What|Removed |Added Attachment #120252|0 |1 is obsolete|| --- Comment #47 from Emmi Takkinen --- Created attachment 120312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120312&action=edit Bug 14723: Add error codes and replace strings with them in template This patch adds error codes for delivery notes and replaces English strings with them in template. To test confirm everything works as intended. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Emmi Takkinen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Emmi Takkinen changed: What|Removed |Added Attachment #118225|0 |1 is obsolete|| --- Comment #46 from Emmi Takkinen --- Created attachment 120310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120310&action=edit Bug 14723: Make delivery notes translatable Delivery notes weren't translatable. This patch adds them in notices.tt. If note is Mail::Sendmail error generic 'Error occured while sending email' is shown. Also fixes MySQLisms and adds AFTER to atomicupdate file. To test prove t/db_dependent/Letters.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Emmi Takkinen changed: What|Removed |Added Attachment #116642|0 |1 is obsolete|| --- Comment #45 from Emmi Takkinen --- Created attachment 120309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120309&action=edit Bug 14723: Additional delivery notes to messages This patch adds additional delivery notes to messages in message queue as there can be multiple reasons for a delivery to fail. Currently in message_queue we are given only two delivery statuses for messages, "sent" and "failed". When the status becomes failed, we have no idea why it fails. This feature can be useful with SMS gateway providers. Many SMS gateways inform the application the reason of SMS delivery failure. With this feature, this information can now be stored. As well as for emails, instead of simply logging failures, we can now store the reason of failure directly into the message row of message_queue. Test plan: 1. Enable EnhancedMessagingPreferences syspref 2. Find a borrower with notices at members/notices.pl 3. Observe that there is no column for Delivery notes 4. Apply patch and run the given database update 5. Repeat step 1. 6. Observe that there is now a column for Delivery notes Sponsored-by: Hypernova Oy Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Stina Hallin changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #44 from Stina Hallin --- The patch didn't apply: CONFLICT (content): Merge conflict in t/db_dependent/Letters.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Letters.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 14723: Additional delivery notes to messages The copy of the patch that failed is found in: .git/rebase-apply/patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Emmi Takkinen changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #43 from Emmi Takkinen --- Created attachment 120252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120252&action=edit Bug 14723: Add error codes and replace strings with them in template This patch adds error codes for delivery notes and replaces English strings with them in template. To test confirm that everything works according to the first test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #42 from Kyle M Hall --- Can you change the English strings with translatable codes? For example, "Missing SMS number" could be "MISSING_SMS". Martin just did work like this for the accounts tables. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Stina Hallin changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||stina.hal...@ub.lu.se -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lund University Sandbox changed: What|Removed |Added Attachment #116643|0 |1 is obsolete|| --- Comment #41 from Lund University Sandbox --- Created attachment 118225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118225&action=edit Bug 14723: Make delivery notes translatable Delivery notes weren't translatable. This patch adds them in notices.tt. If note is Mail::Sendmail error generic 'Error occured while sending email' is shown. Also fixes MySQLisms and adds AFTER to atomicupdate file. To test prove t/db_dependent/Letters.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Stina Hallin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Emmi Takkinen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Emmi Takkinen changed: What|Removed |Added Attachment #105777|0 |1 is obsolete|| --- Comment #40 from Emmi Takkinen --- Created attachment 116643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116643&action=edit Bug 14723: Make delivery notes translatable Delivery notes weren't translatable. This patch adds them in notices.tt. If note is Mail::Sendmail error generic 'Error occured while sending email' is shown. Also fixes MySQLisms and adds AFTER to atomicupdate file. To test prove t/db_dependent/Letters.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Emmi Takkinen changed: What|Removed |Added Attachment #105776|0 |1 is obsolete|| --- Comment #39 from Emmi Takkinen --- Created attachment 116642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116642&action=edit Bug 14723: Additional delivery notes to messages This patch adds additional delivery notes to messages in message queue as there can be multiple reasons for a delivery to fail. Currently in message_queue we are given only two delivery statuses for messages, "sent" and "failed". When the status becomes failed, we have no idea why it fails. This feature can be useful with SMS gateway providers. Many SMS gateways inform the application the reason of SMS delivery failure. With this feature, this information can now be stored. As well as for emails, instead of simply logging failures, we can now store the reason of failure directly into the message row of message_queue. Test plan: 1. Enable EnhancedMessagingPreferences syspref 2. Find a borrower with notices at members/notices.pl 3. Observe that there is no column for Delivery notes 4. Apply patch and run the given database update 5. Repeat step 1. 6. Observe that there is now a column for Delivery notes Sponsored-by: Hypernova Oy Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Mazen Khallaf changed: What|Removed |Added CC||mazen.i.khal...@gmail.com --- Comment #38 from Mazen Khallaf --- Failed to apply the patch in step 4 $ git bz apply 14723 Bug 14723 - Additional delivery notes to messages 105776 - Bug 14723: Additional delivery notes to messages 105777 - Bug 14723: Make delivery notes translatable Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14723: Additional delivery notes to messages Using index info to reconstruct a base tree... M C4/Letters.pm M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt M t/db_dependent/Letters.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Letters.t CONFLICT (content): Merge conflict in t/db_dependent/Letters.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging C4/Letters.pm CONFLICT (content): Merge conflict in C4/Letters.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 14723: Additional delivery notes to messages The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14723-Additional-delivery-notes-to-messages-h__pEr.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Victoria Faafia changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #37 from Victoria Faafia --- Applying: Bug 14723: Additional delivery notes to messages Using index info to reconstruct a base tree... M C4/Letters.pm M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt M t/db_dependent/Letters.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Letters.t CONFLICT (content): Merge conflict in t/db_dependent/Letters.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging C4/Letters.pm CONFLICT (content): Merge conflict in C4/Letters.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 14723: Additional delivery notes to messages The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14723-Additional-delivery-notes-to-messages-_b90Al.patch Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Victoria Faafia changed: What|Removed |Added CC||vfaafi...@gmail.com --- Comment #36 from Victoria Faafia --- can you please add a test plan? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Emmi Takkinen changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |emmi.takki...@outlook.com |ity.org | Status|Failed QA |Needs Signoff --- Comment #35 from Emmi Takkinen --- Created attachment 105777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105777&action=edit Bug 14723: Make delivery notes translatable Delivery notes weren't translatable. This patch adds them in notices.tt. If note is Mail::Sendmail error generic 'Error occured while sending email' is shown. Also fixes MySQLisms and adds AFTER to atomicupdate file. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Emmi Takkinen changed: What|Removed |Added Attachment #87531|0 |1 is obsolete|| CC||emmi.takki...@outlook.com --- Comment #34 from Emmi Takkinen --- Created attachment 105776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105776&action=edit Bug 14723: Additional delivery notes to messages This patch adds additional delivery notes to messages in message queue as there can be multiple reasons for a delivery to fail. Currently in message_queue we are given only two delivery statuses for messages, "sent" and "failed". When the status becomes failed, we have no idea why it fails. This feature can be useful with SMS gateway providers. Many SMS gateways inform the application the reason of SMS delivery failure. With this feature, this information can now be stored. As well as for emails, instead of simply logging failures, we can now store the reason of failure directly into the message row of message_queue. Test plan: 1. Enable EnhancedMessagingPreferences syspref 2. Find a borrower with notices at members/notices.pl 3. Observe that there is no column for Delivery notes 4. Apply patch and run the given database update 5. Repeat step 1. 6. Observe that there is now a column for Delivery notes Sponsored-by: Hypernova Oy Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Assignee|lari.task...@hypernova.fi |koha-b...@lists.koha-commun ||ity.org --- Comment #33 from Lari Taskula --- I'm no longer able to work on this, so I'm setting assignee to default. Feel free to continue this work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #32 from Katrin Fischer --- Comment on attachment 87531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87531 Bug 14723: Additional delivery notes to messages Review of attachment 87531: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14723&attachment=87531) - I took another look at the code and Joseph is right. Made some additional notes too. ::: C4/Letters.pm @@ +912,2 @@ > VALUES > +( ?, ?, ?, ?,?, ?, > ?, NOW(), ?, ?,?,? ) I think NOW() might be a MySQLism from my research. @@ +1281,5 @@ > # warn "FAIL: No 'to_address' and no email for " . > ($member->{surname} ||'') . ", borrowernumber ($message->{borrowernumber})"; > # warning too verbose for this more common case? > _set_message_status( { message_id => $message->{'message_id'}, > + status => 'failed', > + delivery_note => 'Unable to find an email > address for this borrower' } ); See above, these need to be dealt with in the template. ::: installer/data/mysql/atomicupdate/Bug-14723_-_Additional_delivery_notes_to_messages.perl @@ +1,3 @@ > +$DBversion = 'XXX'; # will be replaced by the RM > +if( CheckVersion( $DBversion ) ) { > +$dbh->do("ALTER TABLE message_queue ADD delivery_note TEXT"); Please use BEFORE or AFTER column to specify where the new column will be added exactly. This will help to keep things the same between new and old installations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #31 from Josef Moravec --- Comment on attachment 87531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87531 Bug 14723: Additional delivery notes to messages Review of attachment 87531: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14723&attachment=87531) - ::: C4/Letters.pm @@ +1272,5 @@ > unless ($patron) { > warn "FAIL: No 'to_address' and INVALID borrowernumber > ($message->{borrowernumber})"; > _set_message_status( { message_id => $message->{'message_id'}, > + status => 'failed', > + delivery_note => 'Invalid borrowernumber > '.$message->{borrowernumber} } ); These notes are untranslatable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||wizzy...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Liz Rea changed: What|Removed |Added Attachment #87525|0 |1 is obsolete|| --- Comment #30 from Liz Rea --- Created attachment 87531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87531&action=edit Bug 14723: Additional delivery notes to messages This patch adds additional delivery notes to messages in message queue as there can be multiple reasons for a delivery to fail. Currently in message_queue we are given only two delivery statuses for messages, "sent" and "failed". When the status becomes failed, we have no idea why it fails. This feature can be useful with SMS gateway providers. Many SMS gateways inform the application the reason of SMS delivery failure. With this feature, this information can now be stored. As well as for emails, instead of simply logging failures, we can now store the reason of failure directly into the message row of message_queue. Test plan: 1. Enable EnhancedMessagingPreferences syspref 2. Find a borrower with notices at members/notices.pl 3. Observe that there is no column for Delivery notes 4. Apply patch and run the given database update 5. Repeat step 1. 6. Observe that there is now a column for Delivery notes Sponsored-by: Hypernova Oy Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Attachment #78313|0 |1 is obsolete|| --- Comment #29 from Lari Taskula --- Created attachment 87525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87525&action=edit Bug 14723: Additional delivery notes to messages This patch adds additional delivery notes to messages in message queue as there can be multiple reasons for a delivery to fail. Currently in message_queue we are given only two delivery statuses for messages, "sent" and "failed". When the status becomes failed, we have no idea why it fails. This feature can be useful with SMS gateway providers. Many SMS gateways inform the application the reason of SMS delivery failure. With this feature, this information can now be stored. As well as for emails, instead of simply logging failures, we can now store the reason of failure directly into the message row of message_queue. Test plan: 1. Enable EnhancedMessagingPreferences syspref 2. Find a borrower with notices at members/notices.pl 3. Observe that there is no column for Delivery notes 4. Apply patch and run the given database update 5. Repeat step 1. 6. Observe that there is now a column for Delivery notes Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 José-Mario Monteiro-Santos changed: What|Removed |Added CC||jose-mario.monteiro-santos@ ||inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #28 from José-Mario Monteiro-Santos --- Failed to apply patch Bug 14723 - Additional delivery notes to messages 78313 - Bug 14723: Additional delivery notes to messages Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14723: Additional delivery notes to messages Using index info to reconstruct a base tree... M C4/Letters.pm M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt M t/db_dependent/Letters.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Letters.t CONFLICT (content): Merge conflict in t/db_dependent/Letters.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Letters.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 14723: Additional delivery notes to messages The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14723-Additional-delivery-notes-to-messages-vyvgwK.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Nick Clemens changed: What|Removed |Added Attachment #62138|0 |1 is obsolete|| --- Comment #27 from Nick Clemens --- Created attachment 78313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78313&action=edit Bug 14723: Additional delivery notes to messages This patch adds additional delivery notes to messages in message queue as there can be multiple reasons for a delivery to fail. Currently in message_queue we are given only two delivery statuses for messages, "sent" and "failed". When the status becomes failed, we have no idea why it fails. This feature can be useful with SMS gateway providers. Many SMS gateways inform the application the reason of SMS delivery failure. With this feature, this information can now be stored. As well as for emails, instead of simply logging failures, we can now store the reason of failure directly into the message row of message_queue. Test plan: 1. Enable EnhancedMessagingPreferences syspref 2. Find a borrower with notices at members/notices.pl 3. Observe that there is no column for Delivery notes 4. Apply patch and run the given database update 5. Repeat step 1. 6. Observe that there is now a column for Delivery notes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Alex Buckley changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||alexbuck...@catalyst.net.nz --- Comment #26 from Alex Buckley --- Hi Lari When applying your patch I got the following merge error on Letters.t file, (note: as I am using an up to date master branch patch 18413 is already applied (I double checked to make sure)): Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14723: Additional delivery notes to messages Using index info to reconstruct a base tree... M C4/Letters.pm M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt M t/db_dependent/Letters.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Letters.t CONFLICT (content): Merge conflict in t/db_dependent/Letters.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Letters.pm Failed to merge in the changes. Patch failed at 0001 Bug 14723: Additional delivery notes to messages The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14723-Additional-delivery-notes-to-messages-Zqwu8p.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Attachment #62080|0 |1 is obsolete|| --- Comment #25 from Lari Taskula --- Created attachment 62138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62138&action=edit Bug 14723: Additional delivery notes to messages This patch adds additional delivery notes to messages in message queue as there can be multiple reasons for a delivery to fail. Currently in message_queue we are given only two delivery statuses for messages, "sent" and "failed". When the status becomes failed, we have no idea why it fails. This feature can be useful with SMS gateway providers. Many SMS gateways inform the application the reason of SMS delivery failure. With this feature, this information can now be stored. As well as for emails, instead of simply logging failures, we can now store the reason of failure directly into the message row of message_queue. Test plan: 1. Enable EnhancedMessagingPreferences syspref 2. Find a borrower with notices at members/notices.pl 3. Observe that there is no column for Delivery notes 4. Apply patch and run the given database update 5. Repeat step 1. 6. Observe that there is now a column for Delivery notes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #24 from Lari Taskula --- Depends on Bug 18413 (otherwise Letters.t fails) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Depends on||18413 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18413 [Bug 18413] Fix Letters.t (follow-up of 17866) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #23 from Lari Taskula --- (In reply to Frédéric Demians from comment #21) > Get this: > > fatal: sha1 information is lacking or useless (C4/Letters.pm). > error: could not build fake ancestor I removed some dependencies and rebased this on master. Should now apply. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Depends on|7174, 14698 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 [Bug 7174] Authentication rewriting https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698 [Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Attachment #42669|0 |1 is obsolete|| Attachment #44413|0 |1 is obsolete|| --- Comment #22 from Lari Taskula --- Created attachment 62080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62080&action=edit Bug 14723: Additional delivery notes to messages This patch adds additional delivery notes to messages in message queue as there can be multiple reasons for a delivery to fail. Currently in message_queue we are given only two delivery statuses for messages, "sent" and "failed". When the status becomes failed, we have no idea why it fails. This feature can be useful with SMS gateway providers. Many SMS gateways inform the application the reason of SMS delivery failure. With this feature, this information can now be stored. As well as for emails, instead of simply logging failures, we can now store the reason of failure directly into the message row of message_queue. Test plan: 1. Enable EnhancedMessagingPreferences syspref 2. Find a borrower with notices at members/notices.pl 3. Observe that there is no column for Delivery notes 4. Apply patch and run the given database update 5. Repeat step 1. 6. Observe that there is now a column for Delivery notes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Frédéric Demians changed: What|Removed |Added CC||frede...@tamil.fr Status|Needs Signoff |Patch doesn't apply --- Comment #21 from Frédéric Demians --- Get this: fatal: sha1 information is lacking or useless (C4/Letters.pm). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #44367|0 |1 is obsolete|| --- Comment #20 from Olli-Antti Kivilahti --- Created attachment 44413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44413&action=edit Bug 14723 - Additional delivery notes to messages - fixed missing kohastructure -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #19 from Olli-Antti Kivilahti --- Created attachment 44367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44367&action=edit Bug 14723 - Additional delivery notes to messages - fixed missing kohastructure -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Mike changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Attachment #42668|0 |1 is obsolete|| --- Comment #18 from Lari Taskula --- Created attachment 42669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42669&action=edit Bug 14723 - Additional delivery notes to messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Attachment #42574|0 |1 is obsolete|| --- Comment #17 from Lari Taskula --- Created attachment 42668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42668&action=edit Bug 14723 - Additional delivery notes to messages Adds delivery_note to SELECT in GetMessage() (bug 12426). Includes PageObject Selenium test for delivery failures in C4::Letters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Depends on||12426 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 [Bug 12426] Allow resending of emails from the notices tab in the patron account -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Blocks||14843 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14843 [Bug 14843] Notifications and messages via REST API -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12426 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Attachment #42553|0 |1 is obsolete|| --- Comment #16 from Lari Taskula --- Created attachment 42574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42574&action=edit Bug 14723 - Additional delivery notes to messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Attachment #42505|0 |1 is obsolete|| --- Comment #15 from Lari Taskula --- Created attachment 42553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42553&action=edit Bug 14723 - Additional delivery notes to messages Fixes MessageQueueFactory parameters to match database format. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Depends on||7174 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 [Bug 7174] Authentication rewriting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Attachment #42466|0 |1 is obsolete|| --- Comment #14 from Lari Taskula --- Created attachment 42505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42505&action=edit Bug 14723 - Additional delivery notes to messages Database updates are now using the AtomicUpdater (Bug 14698) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Depends on|7174|14698 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 [Bug 7174] Authentication rewriting http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698 [Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Blocks||14791 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791 [Bug 14791] Automatically attempt to resend failed notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Attachment #42455|0 |1 is obsolete|| --- Comment #13 from Lari Taskula --- Created attachment 42466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42466&action=edit Bug 14723 - Additional delivery notes to messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14767 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14791 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Attachment #42453|0 |1 is obsolete|| --- Comment #12 from Lari Taskula --- Created attachment 42455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42455&action=edit Bug 14723 - Additional delivery notes to messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Attachment #42384|0 |1 is obsolete|| --- Comment #11 from Lari Taskula --- Created attachment 42453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42453&action=edit Bug 14723 - Additional delivery notes to messages Added unit tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Attachment #42228|0 |1 is obsolete|| --- Comment #10 from Lari Taskula --- Created attachment 42384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42384&action=edit Bug 14723 - Additional delivery notes to messages Fixed PageObject test by enabling EnhancedMessagingPreferences system preference via SystemPreferenceFactory. Without this preference, the Notices tab will not be shown in left navigation menu. Test plan: 1. Enable EnhancedMessagingPreferences syspref 2. Find a borrower with notices at members/notices.pl 3. Observe that there is no column for Delivery notes 4. Apply patch and run the given database update 5. Repeat step 1. 6. Observe that there is now a column for Delivery notes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Zeno Tajoli changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Attachment #42227|0 |1 is obsolete|| --- Comment #9 from Lari Taskula --- Created attachment 42228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42228&action=edit Bug 14723 - Additional delivery notes to messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Attachment #42170|0 |1 is obsolete|| --- Comment #8 from Lari Taskula --- Created attachment 42227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42227&action=edit Bug 14723 - Additional delivery notes to messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #7 from Lari Taskula --- (In reply to Lari Taskula from comment #3) > Created attachment 42074 [details] [review] > Bug 14723: (follow-up) Example of handling custom SMS::Send Driver reports > Patch moved to bug 14767. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #6 from Lari Taskula --- Selenium tests are using PageObjects and Authentication rewrite (therefore dependencey on Bug 7174). The patch only covers delivery notes at failure cases in C4::Letters. If you wish to see how delivery notes can be taken further with custom SMS::Send driver and SMS Gateway reports, please see Bug 14767. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Blocks||14767 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14767 [Bug 14767] Message delivery notes from SMS Gateway provider reports -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Depends on|13799, 14536|7174 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7174 [Bug 7174] Authentication rewriting http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 [Bug 13799] Add base for building RESTful API http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 [Bug 14536] PageObject-pattern base implementation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Attachment #42159|0 |1 is obsolete|| --- Comment #5 from Lari Taskula --- Created attachment 42170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42170&action=edit Bug 14723 - Additional delivery notes to messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Attachment #42074|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Attachment #42053|0 |1 is obsolete|| --- Comment #4 from Lari Taskula --- Created attachment 42159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42159&action=edit Bug 14723 - Additional delivery notes to messages Test plan: 1. Find a borrower with notices at members/notices.pl 2. Observe that there is no column for Delivery notes 3. Apply patch and run the given database update 4. Repeat step 1. 5. Observe that there is now a column for Delivery notes Includes PageObject Selenium test for delivery failures in C4::Letters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Depends on||14536 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 [Bug 14536] PageObject-pattern base implementation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #3 from Lari Taskula --- Created attachment 42074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42074&action=edit Bug 14723: (follow-up) Example of handling custom SMS::Send Driver reports This patch presents an example of how SMS::Send driver can be configured to receive reports from your SMS Gateway provider if they support such feature. With Bug 14723 adding a delivery note column to message_queue, you are now able to update the error status provided by your SMS gateway provider to the message. It uses REST API, so make sure to include dependencies. Koha conf gets a new block "smsProviders", where you are able to define your SMS Gateway login data and the report URL that our provider will use. Koha httpd conf gets an example for blocking all traffic to the REST API address for modifying the message status, apart from our provider IPs. Here is a description of the protocol and common actions with the example driver. 1. message_queue gets processed as usual. 2. Letters.pm calls our example driver with phone number, content and message_id (new!). 3. Our example driver sends a POST request to the SMS Gateway provider as follows: - user: username, loaded from koha conf smsProviders->labyrintti - password: password, loaded from koha conf smsProviders->labyrintti - dests: destination phone number - text: content of the message - report: the URL that SMS Gateway provider will update the status of this delivery, loaded from koha conf (with REST API, it should be http://yourhost.com/v1/messages) smsProviders->labyrintti 4. We get (hopefully) an OK message from our SMS provider. It will already let us know if there was an error with the phone number. If so, we return it to Letters.pm via HASH: { status => 1/0, delivery_note => the message of error/success } 5. When the delivery is complete, our SMS Gateway will contact us via the report URL we provided. 6. Via Swagger definitions, we will use Koha::REST::V1::Messages delivery_report to handle the report. If the given status is "ERROR" (this is our example provider's protocol), we will update the message status (and add delivery note) in message_queue for the given message_id. 7. All done, we have now handled the report given by our SMS Gateway provider :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #2 from Lari Taskula --- To test template modifications: 1. Find a borrower with notices at members/notices.pl 2. Observe that there is no column for Delivery notes 3. Apply patch and run the given database update 4. Repeat step 1. 5. Observe that there is now a column for Delivery notes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |la...@student.uef.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/