[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33228 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Martin Renvoize changed: What|Removed |Added Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 David Nind changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #62 from David Nind --- Patch no longer applies 8-( Applying: Bug 14803: Reload checkouts table on renewal Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/js/checkouts.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/checkouts.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/checkouts.js error: Failed to merge in the changes. Patch failed at 0001 Bug 14803: Reload checkouts table on renewal The copy of the patch that failed is found in: .git/rebase-apply/patch Testing notes: - Was going to use the steps in the description of the issue to a) replicate the issue b) apply the patch c) see if that fixes the issue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Ava changed: What|Removed |Added Attachment #98892|0 |1 is obsolete|| --- Comment #61 from Ava --- Created attachment 115621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115621=edit bug 14803: KOHA.Checkouts js object * Use javascript to: - update fines/checkouts info - show/hide checkouts form and messages * Created svc/fines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Ava changed: What|Removed |Added Attachment #98891|0 |1 is obsolete|| --- Comment #60 from Ava --- Created attachment 115620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115620=edit Bug 14803: Reload checkouts table on renewal svc/checkouts: get real rental charges for patron, rather than itemtype indication -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Ava changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovic changed: What|Removed |Added Attachment #73542|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovic changed: What|Removed |Added Attachment #65696|0 |1 is obsolete|| Attachment #65697|0 |1 is obsolete|| --- Comment #58 from Srdjan Jankovic --- Created attachment 98891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98891=edit Bug 14803: Reload checkouts table on renewal svc/checkouts: get real rental charges for patron, rather than itemtype indication -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovic changed: What|Removed |Added Attachment #73541|0 |1 is obsolete|| --- Comment #59 from Srdjan Jankovic --- Created attachment 98892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98892=edit bug 14803: KOHA.Checkouts js object * Use javascript to: - update fines/checkouts info - show/hide checkouts form and messages * Created svc/fines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Katrin Fischerchanged: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #57 from Katrin Fischer --- Hi Srdjan, QA tests pass, but there is definitely a problem with the checkouts - it claimes I have none now, when I have indeed 4 items checked out. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #56 from Srdjan Jankovic--- Rebased, and fines look fine, however I think checkouts list is somewhat broken on the circ issuing screen. And I believe that's not to do with this patch, but cannot be 100% sure. Can you please have a look. Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Attachment #66261|0 |1 is obsolete|| --- Comment #55 from Srdjan Jankovic --- Created attachment 73542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73542=edit Bug 14803 follow-up: outstanding-fees-amount is a class, not id Multiple outstanding-fees-amount displays on the page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Attachment #65868|0 |1 is obsolete|| --- Comment #54 from Srdjan Jankovic --- Created attachment 73541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73541=edit bug 14803: KOHA.Checkouts js object * Use javascript to: - update fines/checkouts info - show/hide checkouts form and messages * Created svc/patron/fines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Katrin Fischerchanged: What|Removed |Added Status|Failed QA |Patch doesn't apply --- Comment #53 from Katrin Fischer --- Patch doesn't apply any longer - wanted to give this another try. Could you rebase? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Patrick Robitaillechanged: What|Removed |Added CC||patrick.robitai...@ccsr.qc. ||ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #52 from Srdjan Jankovic--- Katrin is correct. And we can make an even stronger statement: It does not show correct charges per item in general - does not take renewals in account. In that spirit, I've added a small follow-up to update Fines & Charges tab as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #51 from Srdjan Jankovic--- Created attachment 66261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66261=edit Bug 14803 follow-up: outstanding-fees-amount is a class, not id Multiple outstanding-fees-amount displays on the page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #50 from Katrin Fischer--- It updates in the checkout table - the rental fine column. I think that didn't happen for me without the patch. It also allows multiple renewals of the same item without reloading the page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #49 from Christopher Brannon--- (In reply to Katrin Fischer from comment #46) > Hi Christopher, is the amount outstanding on top updated immediately with > the checkout? Yes. No patch applied. The attention message is updated to reflect the new charge after renewal. I see no need for the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #48 from Katrin Fischer--- > I am sorry, but this just doesn't work well or reliably. I am seeing lots of > oddness in testing. Scratch that - I had forgotten to reload properly first. Apart from the 2 noted things it works well and not too much oddness! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Katrin Fischerchanged: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #47 from Katrin Fischer --- @Christopher - did you check only check-out and check-in or renewals as well? This bug is about fixing the renewals, checkouts update already. @Srdjan I am sorry, but this just doesn't work well or reliably. I am seeing lots of oddness in testing. 1) Checkouts: With the patch the specified due date (today, 23:59) is set to a date that can't be cleared. Switching back to master and restarting everything + reloading it's ok. It appears to be connected to the patches and is repeatable. Tested in 2 different browsers (Firefox, Chrome) and with different patrons. 2) Renewals: I think it's quite irritating that the items resort immediately after successful renewal with the last items going to the bottom and there is no success message. It really confused me as I was testing with multiple items of the same record. The rental amount display works fine and updates for every renewal. I feel a success message or highlighting the renewed lines in color (like for checkout) could help a lot with this. This kind of behaviour is something that ideally should be tested by a few librarians. 3) Checkins: Works well! Failing for 1) - sorry! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #46 from Katrin Fischer--- Hi Christopher, is the amount outstanding on top updated immediately with the checkout? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #45 from Christopher Brannon--- Testing at Koha US on master. The process seems to work fine without the patch. Is this still needed??? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #44 from Katrin Fischer--- Firefox 54.0 (64-bit) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #43 from Srdjan Jankovic--- (In reply to Katrin Fischer from comment #41) > I found the following JavaScript error in the logs, not sure if it's related: > ReferenceError: checkouts_only is not defined Sorry Katrin, that was a leftover. Out of curiosity, which browser do you use please? I had the error, but it did not seem to stop the execution. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Attachment #65783|0 |1 is obsolete|| --- Comment #42 from Srdjan Jankovic --- Created attachment 65868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65868=edit bug 14803: KOHA.Checkouts js object * Use javascript to: - update fines/checkouts info - show/hide checkouts form and messages * Created svc/patron/fines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Katrin Fischerchanged: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #41 from Katrin Fischer --- I am sorry Srdjan, but something else weird popped up now. Applied the new patches, restarted plack, reloaded to get new Javascript... The amount outstanding is not showing at all. I found the following JavaScript error in the logs, not sure if it's related: ReferenceError: checkouts_only is not defined -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #40 from Srdjan Jankovic--- (In reply to Katrin Fischer from comment #38) > > 6) Check in the item from the table > BUT: Instead of seeing the success message the checkout vanishes instantly. > Without the patch, the checked-in items remain visible, highlighted in > yellow showing the success message. With the patch they vanish immediately. > I think we need to keep the former behavior. You are right, better if it stays there. I just could not live with "Renew" still showing. So I came up with something else. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Attachment #65698|0 |1 is obsolete|| --- Comment #39 from Srdjan Jankovic --- Created attachment 65783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65783=edit bug 14803: KOHA.Checkouts js object * Use javascript to: - update fines/checkouts info - show/hide checkouts form and messages * Created svc/patron/fines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #38 from Katrin Fischer--- Sorry, last test report was partially nonsense: 1) Check out an item 2) Verfiy it shows as checked out 3) Verify the amount has been updated (OK!) 4) Renew item from the table 5) Verify the amount has been updated (OK!) 6) Check in the item from the table BUT: Instead of seeing the success message the checkout vanishes instantly. Without the patch, the checked-in items remain visible, highlighted in yellow showing the success message. With the patch they vanish immediately. I think we need to keep the former behavior. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Katrin Fischerchanged: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #37 from Katrin Fischer --- 1) Check out an item 2) Verfiy it shows as checked out 3) Renew item from the table 4) Verify the amount has been updated (OK!) 5) Check in the item from the table 6) Verify the amount has been updated (OK!) BUT: Instead of seeing the success message the checkout vanishes instantly. Without the patch, the checked-in items remain visible, highlighted in yellow showing the success message. With the patch they vanish immediately. I think we need to keep the former behaviour. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Attachment #63230|0 |1 is obsolete|| --- Comment #36 from Srdjan Jankovic --- Created attachment 65698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65698=edit bug 14803: KOHA.Checkouts js object * Use javascript to: - update fines/checkouts info - show/hide checkouts form and messages * Created svc/patron/fines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Attachment #60630|0 |1 is obsolete|| --- Comment #35 from Srdjan Jankovic --- Created attachment 65697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65697=edit Bugfix: added missing use Koha::Account -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Attachment #60629|0 |1 is obsolete|| --- Comment #34 from Srdjan Jankovic --- Created attachment 65696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65696=edit Bug 14803: Reload checkouts table on renewal svc/checkouts: get real rental charges for patron, rather than itemtype indication -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Katrin Fischerchanged: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||katrin.fisc...@bsz-bw.de --- Comment #33 from Katrin Fischer --- Sorry, can't test, the third patch doesn't apply: Applying: Bugfix: added missing use Koha::Account Applying: bug 14803: KOHA.Checkouts js object fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/js/checkouts.js). error: could not build fake ancestor Patch failed at 0001 bug 14803: KOHA.Checkouts js object The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/bug-14803-KOHACheckouts-js-object-hfCTB4.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Paul Poulainchanged: What|Removed |Added CC||paul.poul...@biblibre.com Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Fiona Borthwickchanged: What|Removed |Added CC||fiona.borthwick@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #32 from Josef Moravec--- (In reply to Srdjan Jankovic from comment #31) > (In reply to Josef Moravec from comment #29) > > Hi Josef, thanks for testing this. > > > I have to more concerns about it: > > 1) The barcode field doesn't have focus after page is loaded - probably easy > > to fix, but important > > 2) Looks like it waits than issues are loaded and then show the barcode > > input field, maybe I am wrong and it just looks like, but in any case it is > > much slower then current master... > > Ok, now it should be behaving like master. I tried to add some accuracy, but > drawbacks are obviously too big... It is Ok now, thanks > > 3) Message "loading, you can continue scanning" is badly placed (in the left > > top corner) > > For me it is placed center of the table. At any rate I believe my patch did > not change the table, it just makes a issuesTable.api().ajax.reload() call. > Could you please a) check it in another browser b) compare to master. Thanks > a lot. Hm, strange... On master it's ok for me, on this patchset still bad... but I can't find out where's the problem... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #31 from Srdjan Jankovic--- (In reply to Josef Moravec from comment #29) Hi Josef, thanks for testing this. > I have to more concerns about it: > 1) The barcode field doesn't have focus after page is loaded - probably easy > to fix, but important > 2) Looks like it waits than issues are loaded and then show the barcode > input field, maybe I am wrong and it just looks like, but in any case it is > much slower then current master... Ok, now it should be behaving like master. I tried to add some accuracy, but drawbacks are obviously too big... > 3) Message "loading, you can continue scanning" is badly placed (in the left > top corner) For me it is placed center of the table. At any rate I believe my patch did not change the table, it just makes a issuesTable.api().ajax.reload() call. Could you please a) check it in another browser b) compare to master. Thanks a lot. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Attachment #63153|0 |1 is obsolete|| --- Comment #30 from Srdjan Jankovic --- Created attachment 63230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63230=edit bug 14803: KOHA.Checkouts js object * Use javascript to: - update fines/checkouts info - show/hide checkouts form and messages * Created svc/patron/fines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Josef Moravecchanged: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #29 from Josef Moravec --- I have to more concerns about it: 1) The barcode field doesn't have focus after page is loaded - probably easy to fix, but important 2) Looks like it waits than issues are loaded and then show the barcode input field, maybe I am wrong and it just looks like, but in any case it is much slower then current master... 3) Message "loading, you can continue scanning" is badly placed (in the left top corner) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #28 from Srdjan Jankovic--- > But now, when I have no fines owed, I can't see the checkout form and even > any current checkouts... Oops. Corrected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Attachment #62432|0 |1 is obsolete|| --- Comment #27 from Srdjan Jankovic --- Created attachment 63153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63153=edit bug 14803: KOHA.Checkouts js object * Use javascript to: - update fines/checkouts info - show/hide checkouts form and messages * Created svc/patron/fines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Josef Moravecchanged: What|Removed |Added CC||josef.mora...@gmail.com --- Comment #26 from Josef Moravec --- Created attachment 63047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63047=edit Checking Out (In reply to Srdjan Jankovic from comment #25) > (In reply to Owen Leonard from comment #23) > > Created attachment 62294 [details] > > Screenshot showing a problem with the checkout box > > > > something weird happens when the patron's fines are past the > > noissuescharge limit. The checkout form is hidden from all users, whether > > they have permission to override or not. > > That may be an existing condition. I've made some changes to take in account > AllowFineOverride pref. But now, when I have no fines owed, I can't see the checkout form and even any current checkouts... See attached screenshot -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #25 from Srdjan Jankovic--- (In reply to Owen Leonard from comment #23) > Created attachment 62294 [details] > Screenshot showing a problem with the checkout box > > something weird happens when the patron's fines are past the > noissuescharge limit. The checkout form is hidden from all users, whether > they have permission to override or not. That may be an existing condition. I've made some changes to take in account AllowFineOverride pref. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Attachment #60631|0 |1 is obsolete|| --- Comment #24 from Srdjan Jankovic --- Created attachment 62432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62432=edit bug 14803: KOHA.Checkouts js object * Use javascript to: - update fines/checkouts info - show/hide checkouts form and messages * Created svc/patron/fines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Owen Leonardchanged: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #23 from Owen Leonard--- Created attachment 62294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62294=edit Screenshot showing a problem with the checkout box (In reply to Srdjan Jankovic from comment #20) > Things have moved on meanwhile, and it seems to me that the page is being > force reloaded now, so I'm not sure how useful this patch is. I don't find that this page is being reloaded when renewing from the checkboxes. This looks like it's working correctly to update the fee numbers, but something weird happens when the patron's fines are past the noissuescharge limit. The checkout form is hidden from all users, whether they have permission to override or not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #22 from Srdjan Jankovic--- Ideally someone should try to replicate the original report in the top note. I could not. But in discussion is fine with me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Marc Véronchanged: What|Removed |Added CC||ve...@veron.ch --- Comment #21 from Marc Véron --- (In reply to Srdjan Jankovic from comment #20) > Things have moved on meanwhile, and it seems to me that the page is being > force reloaded now, so I'm not sure how useful this patch is. Maybe just a > start of a full ajax solution. Srdjan, do I get it right: No sign-off needed at the moment? Can status be switched e.g. to "In Discussion"? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #20 from Srdjan Jankovic--- Things have moved on meanwhile, and it seems to me that the page is being force reloaded now, so I'm not sure how useful this patch is. Maybe just a start of a full ajax solution. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Attachment #53482|0 |1 is obsolete|| --- Comment #19 from Srdjan Jankovic --- Created attachment 60631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60631=edit bug 14803: KOHA.Checkouts js object * Use javascript to: - update fines/checkouts info - show/hide checkouts form and messages * Created svc/patron/fines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Attachment #52208|0 |1 is obsolete|| Attachment #52209|0 |1 is obsolete|| Attachment #52473|0 |1 is obsolete|| --- Comment #17 from Srdjan Jankovic --- Created attachment 60629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60629=edit Bug 14803: Reload checkouts table on renewal svc/checkouts: get real rental charges for patron, rather than itemtype indication -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #18 from Srdjan Jankovic--- Created attachment 60630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60630=edit Bugfix: added missing use Koha::Account -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Christopher Brannonchanged: What|Removed |Added CC||cbran...@cdalibrary.org Status|Needs Signoff |Failed QA --- Comment #16 from Christopher Brannon --- >From what I can tell, when the patches are applied, it breaks the form #mainform, and is not displayed. Cannot follow test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Attachment #53406|0 |1 is obsolete|| --- Comment #15 from Srdjan Jankovic --- Created attachment 53482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53482=edit bug 14803: KOHA.Checkouts js object * Use javascript to: - update fines/checkouts info - show/hide checkouts form and messages * Created svc/patron/fines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Owen Leonardchanged: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #14 from Srdjan Jankovic --- Owen, I'm not sure why you are getting the delay. In my case once page has loaded form comes up instantaneously. Admittedly, my database is not a large one. Nevertheless, the only overhead introduced here is a http request/response, so if the connection is decent (and it should be for the librarian interface) everything should be fine. The change moved one database query from the main handler to a service. As a matter of fact it replaced two calls to the same function with only one, which should only be faster. So when comparing, a fair comparison would be full time from the circulation.pl request inception to the point where the checkout form is shown. Can you please give it another go with timing pre and post patch from the point patron card number is entered to the appearance of the item checkout form. In my env I can detect no difference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Attachment #52474|0 |1 is obsolete|| --- Comment #13 from Srdjan Jankovic --- Created attachment 53406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53406=edit bug 14803: KOHA.Checkouts js object * Use javascript to: - update fines/checkouts info - show/hide checkouts form and messages * Created svc/patron/fines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Owen Leonardchanged: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #12 from Owen Leonard --- This breaks the list of current checkouts. On the circulation page it says "0 checkouts" even though I have many. On the patron detail page it shows the correct count in the checkouts tab but lists no checkouts. I strongly object to the delay this patch introduces to the appearance of the checkout form. In my test system there is a 5-second delay between the time the rest of the page renders and the time the checkout form appears. The more AJAX we introduce on the checkout page the slower it gets. I don't think that's what we intend, but that's the real consequence. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #11 from Srdjan Jankovic--- Yes. And run t/db_dependent/Circulation/issue.t, first two patches is the test fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #10 from Owen Leonard--- (In reply to Srdjan Jankovic from comment #6) > To test - Librarian interface - Circulation: > > Have an item with rental charges. Checkout. Renew. Checkouts table should > reload with rental charges added. Is this the whole test plan for all patches? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #9 from Srdjan Jankovic--- This is a bit bigger than expected. Requires testing issue blocking with fines over limit. Also "Patron details" top " Checkouts are BLOCKED" message needs checking because it uses same component. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #8 from Srdjan Jankovic--- Created attachment 52474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52474=edit bug 14803: KOHA.Checkouts js object * Use javascript to: - update fines/checkouts info - show/hide checkouts form and messages * Created svc/patron/fines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Attachment #52210|0 |1 is obsolete|| --- Comment #7 from Srdjan Jankovic --- Created attachment 52473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52473=edit Bug 14803: Reload checkouts table on renewal svc/checkouts: get real rental charges for patron, rather than itemtype indication -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #6 from Srdjan Jankovic--- To test - Librarian interface - Circulation: Have an item with rental charges. Checkout. Renew. Checkouts table should reload with rental charges added. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #5 from Srdjan Jankovic--- Created attachment 52210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52210=edit Bug 14803: Reload checkouts table on renewal svc/checkouts: get real rental charges for patron, rather than itemtype indication -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #3 from Srdjan Jankovic--- Created attachment 52208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52208=edit Fix test data in issue.t and defaults for stats 'Null' iand '' are not really NULL values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #4 from Srdjan Jankovic--- Created attachment 52209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52209=edit Test rental charges properly * AddIssuingCharge() test was always returning pass - removed and replaced with: * Test rental charges properly for both checkout and renewal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovicchanged: What|Removed |Added CC||srd...@catalyst.net.nz Assignee|koha-b...@lists.koha-commun |srd...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Jonathan Druartchanged: What|Removed |Added Version|3.20|master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Liz Reachanged: What|Removed |Added CC||l...@catalyst.net.nz --- Comment #2 from Liz Rea --- Similar to Bug 14798 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Marjorie Barry-Vilachanged: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Depends on||11703 --- Comment #1 from Jonathan Druart --- Kyle, Have you any idea how we could fix that? Looks tricky. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 [Bug 11703] Convert checkouts table to ajax datatable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Heather Braumchanged: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/