[Koha-bugs] [Bug 14806] Action Log for Modifying message_transport_types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #11 from David Nind  ---
Patch no longer applies because of an issue with bug 18595:

Applying: Bug 18595: Unit tests preparing for GetMessagingPreferences move
Using index info to reconstruct a base tree...
M   t/db_dependent/Circulation.t
M   t/db_dependent/Reserves.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Reserves.t
Auto-merging t/db_dependent/Circulation.t
Applying: Bug 18595: Move C4::Members::Messaging::GetMessagingPreferences
.git/rebase-apply/patch:146: trailing whitespace.
This method defines how a user (or a default for a patron category) wants to
get a certain 
.git/rebase-apply/patch:272: trailing whitespace.

warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M   C4/Circulation.pm
M   C4/Reserves.pm
M   circ/returns.pl
M   misc/cronjobs/advance_notices.pl
.git/rebase-apply/patch:146: trailing whitespace.
This method defines how a user (or a default for a patron category) wants to
get a certain 
.git/rebase-apply/patch:272: trailing whitespace.

warning: 2 lines add whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging misc/cronjobs/advance_notices.pl
CONFLICT (content): Merge conflict in misc/cronjobs/advance_notices.pl
Auto-merging circ/returns.pl
Auto-merging C4/Reserves.pm
Auto-merging C4/Circulation.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 18595: Move
C4::Members::Messaging::GetMessagingPreferences
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-18595-Move-C4MembersMessagingGetMessagingPrefe-TcECxc.patch

Cannot apply cleanly patches from bug 18595. Everything will be left dirty.
git bz apply --continue will not continue the process if patches from other bug
reports need to be applied.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14806] Action Log for Modifying message_transport_types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||22794


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794
[Bug 22794] Omnibus: Improve and extend logging in Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14806] Action Log for Modifying message_transport_types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Assignee|koha-b...@lists.koha-commun |lari.task...@hypernova.fi
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14806] Action Log for Modifying message_transport_types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

Lari Taskula  changed:

   What|Removed |Added

  Attachment #94750|0   |1
is obsolete||

--- Comment #10 from Lari Taskula  ---
Created attachment 94752
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94752=edit
Bug 14806 - (follow-up) Action Log for Modifying message_transport_types

Introducing improvements:
- Centralizing code into new Koha::Patron::Message::Preference(s) objects
- Addings tests

To test:
1. prove t/db_dependent/Koha/Patron/Message/Preferences.t
2. Follow test plan of previous patch

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14806] Action Log for Modifying message_transport_types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

Lari Taskula  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14806] Action Log for Modifying message_transport_types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

Lari Taskula  changed:

   What|Removed |Added

  Attachment #75400|0   |1
is obsolete||

--- Comment #9 from Lari Taskula  ---
Created attachment 94750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94750=edit
Bug 14806 - (follow-up) Action Log for Modifying message_transport_types

Introducing improvements:
- Centralizing code into new Koha::Patron::Message::Preference(s) objects
- Addings tests

To test:
1. prove t/db_dependent/Koha/Patron/Message/Preferences.t
2. Follow test plan of previous patch

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14806] Action Log for Modifying message_transport_types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

Lari Taskula  changed:

   What|Removed |Added

  Attachment #42486|0   |1
is obsolete||

--- Comment #8 from Lari Taskula  ---
Created attachment 94749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94749=edit
Bug 14806 - Action Log for Modifying message_transport_types

This is a crude fix.
koha.action_logs-entries are generated when Borrower has been modified using
C4::Form::MessagingPreferences

log entries look like this:

| MEMBERS | MOD MTT | All message_transports removed
| MEMBERS | MOD MTT | [{'_name' => 'Advance_Notice','da' => '4','dig' =>
1,'mtt' => ['email']},{'_name' => 'Item_Check_in','mtt' => ['email']},{'_name'
=> 'Item_Checkout','mtt' => ['email']}]

TEST PLAN:

0. Activate system preference "BorrowersLog".
1. In intra, edit a Borrowers messaging preferences.
2. In OPAC remove your messaging preferences.
3. SELECT * FROM action_logs ORDER BY timestamp DESC LIMIT 5;
3.1. You should see your new action logs entries.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14806] Action Log for Modifying message_transport_types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

Lari Taskula  changed:

   What|Removed |Added

  Attachment #75399|0   |1
is obsolete||

--- Comment #7 from Lari Taskula  ---
Created attachment 75400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75400=edit
Bug 14806 - (follow-up) Action Log for Modifying message_transport_types

Introducing improvements:
- Centralizing code into new Koha::Patron::Message::Preference(s) objects
- Addings tests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14806] Action Log for Modifying message_transport_types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

Lari Taskula  changed:

   What|Removed |Added

 CC||lari.task...@jns.fi
 Depends on||18595


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595
[Bug 18595] Move C4::Members::Messaging to Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14806] Action Log for Modifying message_transport_types

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

--- Comment #6 from Lari Taskula  ---
Created attachment 75399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75399=edit
Bug 14806 - (follow-up) Action Log for Modifying message_transport_types

Introducing improvements:
- Centralizing code into new Koha::Patron::Message::Preference(s) objects
- Addings tests

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14806] Action Log for Modifying message_transport_types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #42483|0   |1
is obsolete||

--- Comment #3 from Olli-Antti Kivilahti  ---
Created attachment 42484
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42484=edit
Bug 14806 - Action Log for Modifying message_transport_types

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14806] Action Log for Modifying message_transport_types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #42485|0   |1
is obsolete||

--- Comment #5 from Olli-Antti Kivilahti  ---
Created attachment 42486
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42486=edit
Bug 14806 - Action Log for Modifying message_transport_types

TEST PLAN:

0. Activate system preference "BorrowersLog".
1. In intra, edit a Borrowers messaging preferences.
2. In OPAC remove your messaging preferences.
3. SELECT * FROM action_logs ORDER BY timestamp DESC LIMIT 5;
3.1. You should see your new action logs entries.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14806] Action Log for Modifying message_transport_types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #42484|0   |1
is obsolete||

--- Comment #4 from Olli-Antti Kivilahti  ---
Created attachment 42485
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42485=edit
Bug 14806 - Action Log for Modifying message_transport_types

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14806] Action Log for Modifying message_transport_types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

Olli-Antti Kivilahti  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14806] Action Log for Modifying message_transport_types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

--- Comment #1 from Olli-Antti Kivilahti  ---
Created attachment 42482
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42482=edit
Bug 14806 - Action Log for Modifying message_transport_types

This is a crude fix.
koha.action_logs-entries are generated when Borrower has been modified using
C4::Form::MessagingPreferences

log entries look like this:

| MEMBERS | MOD MTT | All message_transports removed
| MEMBERS | MOD MTT | [{'_name' => 'Advance_Notice','da' => '4','dig' =>
1,'mtt' => ['email']},{'_name' => 'Item_Check_in','mtt' => ['email']},{'_name'
=> 'Item_Checkout','mtt' => ['email']}]

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14806] Action Log for Modifying message_transport_types

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #42482|0   |1
is obsolete||

--- Comment #2 from Olli-Antti Kivilahti  ---
Created attachment 42483
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42483=edit
Bug 14806 - Action Log for Modifying message_transport_types

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/