[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Josef Moravec  changed:

   What|Removed |Added

  Attachment #56645|0   |1
is obsolete||

--- Comment #27 from Josef Moravec  ---
Created attachment 57116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57116=edit
Bug 14957: Rule based permission for MARC fields

This patch adds a rule based permission system for MARC field modifications.

Test plan:
1. Apply this patch
2. Apply related database patch
2. Apply related scripts update patch
3. Run updatedatabase.pl
5. Log in to staff client
4. Enable new syspref MARCPermissions
5. You should see a new link "MARC field permissions" in the "Catalog"
   section under "Koha administrtion".
6. Go to the "MARC field permissions" page
7. Next to the page heading ("Manage MARC field permissions") there is a
   button with a question mark, click this for more information about the
   rule system.
8. Add desired rules to the rule table, press the +-button to add.
9. Clicking the pen-icon (edit) should allow you to edit corresponding
rule.
10. Clicking the x-icon should remove corresponding rule after
confirmation.
11. Selecting one or more rules followed by clicking the trash-icon
should remove all selected rules after confirmation.
12. To test your rules, import or in other way modify a record.
13. Check that the record was modified as defined by your rules.

Sponsored-by: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Josef Moravec  changed:

   What|Removed |Added

  Attachment #56647|0   |1
is obsolete||

--- Comment #29 from Josef Moravec  ---
Created attachment 57118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57118=edit
Bug 14957: Key fixes to patch

- Fixing merge conflicts
- adding String::Similariry to list of dependencies
- font-awesome icons and adding consistency to formatting
- removing original use of onclick
- moving help text out of main page and into a new help file

When testing, follow above test plan but:
1) Remember to install String::Similarity before testing (apt-get
install libstring-similarity-perl)
2) Instead of doing step 7, click Help in top-right corner instead.
Confirm this works and shows as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Josef Moravec  changed:

   What|Removed |Added

  Attachment #56648|0   |1
is obsolete||

--- Comment #30 from Josef Moravec  ---
Created attachment 57119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57119=edit
Bug 14957: Followup - Pod, import_lexile.pl, template and test fixes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Josef Moravec  changed:

   What|Removed |Added

  Attachment #56643|0   |1
is obsolete||

--- Comment #25 from Josef Moravec  ---
Created attachment 57114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57114=edit
Bug 14957: Database changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Josef Moravec  changed:

   What|Removed |Added

  Attachment #56644|0   |1
is obsolete||

--- Comment #26 from Josef Moravec  ---
Created attachment 57115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57115=edit
Bug 14957: Add filters to relevant scripts

Add MARCPermissions filters in scripts which modifies MARC records to enable
the
permission system for these scripts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Andreas Hedström Mace  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #24 from Andreas Hedström Mace  ---
Doesn't apply for me. Needs yet another rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #23 from Josef Moravec  ---
Rebased on master

Fixed few issues in the follow-up

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Josef Moravec  changed:

   What|Removed |Added

  Attachment #51724|0   |1
is obsolete||

--- Comment #20 from Josef Moravec  ---
Created attachment 56646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56646=edit
Bug 14957: Correct parameters for TransformMarcToKoha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Josef Moravec  changed:

   What|Removed |Added

  Attachment #56638|0   |1
is obsolete||

--- Comment #21 from Josef Moravec  ---
Created attachment 56647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56647=edit
Bug 14957: Key fixes to patch

- Fixing merge conflicts
- adding String::Similariry to list of dependencies
- font-awesome icons and adding consistency to formatting
- removing original use of onclick
- moving help text out of main page and into a new help file

When testing, follow above test plan but:
1) Remember to install String::Similarity before testing (apt-get
install libstring-similarity-perl)
2) Instead of doing step 7, click Help in top-right corner instead.
Confirm this works and shows as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #22 from Josef Moravec  ---
Created attachment 56648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56648=edit
Bug 14957: Followup - Pod, import_lexile.pl, template and test fixes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Josef Moravec  changed:

   What|Removed |Added

  Attachment #44058|0   |1
is obsolete||

--- Comment #18 from Josef Moravec  ---
Created attachment 56644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56644=edit
Bug 14957: Add filters to relevant scripts

Add MARCPermissions filters in scripts which modifies MARC records to enable
the
permission system for these scripts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Josef Moravec  changed:

   What|Removed |Added

  Attachment #51723|0   |1
is obsolete||

--- Comment #19 from Josef Moravec  ---
Created attachment 56645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56645=edit
Bug 14957: Rule based permission for MARC fields

This patch adds a rule based permission system for MARC field modifications.

Test plan:
1. Apply this patch
2. Apply related database patch
2. Apply related scripts update patch
3. Run updatedatabase.pl
5. Log in to staff client
4. Enable new syspref MARCPermissions
5. You should see a new link "MARC field permissions" in the "Catalog"
   section under "Koha administrtion".
6. Go to the "MARC field permissions" page
7. Next to the page heading ("Manage MARC field permissions") there is a
   button with a question mark, click this for more information about the
   rule system.
8. Add desired rules to the rule table, press the +-button to add.
9. Clicking the pen-icon (edit) should allow you to edit corresponding
rule.
10. Clicking the x-icon should remove corresponding rule after
confirmation.
11. Selecting one or more rules followed by clicking the trash-icon
should remove all selected rules after confirmation.
12. To test your rules, import or in other way modify a record.
13. Check that the record was modified as defined by your rules.

Sponsored-by: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Josef Moravec  changed:

   What|Removed |Added

  Attachment #44057|0   |1
is obsolete||

--- Comment #17 from Josef Moravec  ---
Created attachment 56643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56643=edit
Bug 14957: Database changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #56637|0   |1
is obsolete||

--- Comment #16 from Aleisha Amohia  ---
Created attachment 56638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56638=edit
Bug 14957: Key fixes to patch

- Fixing merge conflicts
- adding String::Similariry to list of dependencies
- font-awesome icons and adding consistency to formatting
- removing original use of onclick
- moving help text out of main page and into a new help file

When testing, follow above test plan but:
1) Remember to install String::Similarity before testing (apt-get
install libstring-similarity-perl)
2) Instead of doing step 7, click Help in top-right corner instead.
Confirm this works and shows as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #15 from Aleisha Amohia  ---
Created attachment 56637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56637=edit
Bug 14957: Key fixes to patch

- Fixing merge conflicts
- adding String::Similariry to list of dependencies
- font-awesome icons and adding consistency to formatting
- removing original use of onclick
- moving help text out of main page and into a new help file

When testing, follow above test plan but:
1) Remember to install String::Similarity before testing (apt-get
install libstring-similarity-perl)
2) Instead of doing step 7, click Help in top-right corner instead.
Confirm this works and shows as expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

delaye  changed:

   What|Removed |Added

 CC||stephane.del...@biblibre.co
   ||m

--- Comment #14 from delaye  ---
i can't test the patch with a sandbox biblibre
i have this message
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 14957:
Something went wrong !Applying: Bug 14957: Database changes
Applying: Bug 14957: Add filters to relevant scripts
.git/rebase-apply/patch:14: trailing whitespace.
} 
.git/rebase-apply/patch:16: trailing whitespace.
ModBiblioframework( ,  ); 
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M   cataloguing/addbiblio.pl
M   koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
M   misc/migration_tools/bulkmarcimport.pl
M   tools/batch_record_modification.pl
.git/rebase-apply/patch:14: trailing whitespace.
} 
.git/rebase-apply/patch:16: trailing whitespace.
ModBiblioframework( ,  ); 
warning: 2 lines add whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging tools/batch_record_modification.pl
CONFLICT (content): Merge conflict in tools/batch_record_modification.pl
Auto-merging misc/migration_tools/bulkmarcimport.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
Auto-merging cataloguing/addbiblio.pl
error: Failed to merge in the changes.
Patch failed at 0001 Bug 14957: Add filters to relevant scripts
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 14957 - Write protecting MARC fields based on source of import

44057 - Bug 14957: Database changes
44058 - Bug 14957: Add filters to relevant scripts
51723 - Bug 14957: Rule based permission for MARC fields
51724 - Bug 14957: Correct parameters for TransformMarcToKoha

Apply? [(y)es, (n)o, (i)nteractive] Patch left in
/tmp/Bug-14957-Add-filters-to-relevant-scripts-7vvvqA.patch .

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Andreas Hedström Mace  changed:

   What|Removed |Added

 CC||andreas.hedstrom.mace@sub.s
   ||u.se

--- Comment #13 from Andreas Hedström Mace  ---
Failed to apply for me (merge conflicts). Needs a rebase again?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #12 from Magnus Enger  ---
When you are on the "MARC field permissions" page, "MARC field permissions" is
not shown in the left hand menu.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #11 from Magnus Enger  ---
Never mind me, I was applying the patches on the 3.22.x branch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #10 from Magnus Enger  ---
I am trying to test this, but after applying the patches (and fixing some
conflicts), I get this error when I try to do a search, both in the OPAC and
the intranet: 

Can't locate object method "fields" via package "DBI::db" at
/home/kohaadmin/kohaclone/C4/Biblio.pm line 2673.

Line 2673 looks like this: 

  MARCFIELD: foreach my $field ( $record->fields() ) {

I'll try to figure out the problem, but if anyone got any hunches I'm all ears!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #9 from David Cook  ---
Oh I had forgotten about this one... might have to look at this sometime...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #8 from Eivin Giske Skaaren  ---
I have rebased and merged this and it seems to work. I dont have any MARC
experience so please test that this works in some real use case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #7 from Eivin Giske Skaaren  ---
Created attachment 51724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51724=edit
Bug 14957: Correct parameters for TransformMarcToKoha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #44057|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #44058|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Eivin Giske Skaaren  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff
   Assignee|mar...@bugs.koha-community. |ei...@sysmystic.com
   |org.xinxidi.net |
 CC||ei...@sysmystic.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #44056|0   |1
is obsolete||
  Attachment #44057|0   |1
is obsolete||
  Attachment #44058|0   |1
is obsolete||

--- Comment #6 from Eivin Giske Skaaren  ---
Created attachment 51723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51723=edit
Bug 14957: Rule based permission for MARC fields

This patch adds a rule based permission system for MARC field modifications.

Test plan:
1. Apply this patch
2. Apply related database patch
2. Apply related scripts update patch
3. Run updatedatabase.pl
5. Log in to staff client
4. Enable new syspref MARCPermissions
5. You should see a new link "MARC field permissions" in the "Catalog"
   section under "Koha administrtion".
6. Go to the "MARC field permissions" page
7. Next to the page heading ("Manage MARC field permissions") there is a
   button with a question mark, click this for more information about the
   rule system.
8. Add desired rules to the rule table, press the +-button to add.
9. Clicking the pen-icon (edit) should allow you to edit corresponding
rule.
10. Clicking the x-icon should remove corresponding rule after
confirmation.
11. Selecting one or more rules followed by clicking the trash-icon
should remove all selected rules after confirmation.
12. To test your rules, import or in other way modify a record.
13. Check that the record was modified as defined by your rules.

Sponsored-by: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #5 from Magnus Enger  ---
Just confirming the patches do not apply. Here is the error:

$ git bz apply 14957
Bug 14957 - Write protecting MARC fields based on source of import

44056 - Bug 14957: Rule based permission for MARC fields
44057 - Bug 14957: Database changes
44058 - Bug 14957: Add filters to relevant scripts

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 14957: Rule based permission for MARC fields
Using index info to reconstruct a base tree...
M   C4/Biblio.pm
M   koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
M  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
Falling back to patching base and 3-way merge...
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
Auto-merging C4/Biblio.pm
CONFLICT (content): Merge conflict in C4/Biblio.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 14957: Rule based permission for MARC fields
The copy of the patch that failed is found in:
   /home/magnus/scripts/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-14957-Rule-based-permission-for-MARC-fields-IZUxzW.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Mirko Tietgen  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net
 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #4 from Martin Stenberg 
 ---
Created attachment 44058
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44058=edit
Bug 14957: Add filters to relevant scripts

Add MARCPermissions filters in scripts which modifies MARC records to enable
the
permission system for these scripts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #3 from Martin Stenberg 
 ---
Created attachment 44057
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44057=edit
Bug 14957: Database changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #2 from Martin Stenberg 
 ---
Created attachment 44056
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44056=edit
Bug 14957: Rule based permission for MARC fields

This patch adds a rule based permission system for MARC field modifications.

Test plan:
1. Apply this patch
2. Apply related database patch
2. Apply related scripts update patch
3. Run updatedatabase.pl
5. Log in to staff client
4. Enable new syspref MARCPermissions
5. You should see a new link "MARC field permissions" in the "Catalog"
   section under "Koha administrtion".
6. Go to the "MARC field permissions" page
7. Next to the page heading ("Manage MARC field permissions") there is a
   button with a question mark, click this for more information about the
   rule system.
8. Add desired rules to the rule table, press the +-button to add.
9. Clicking the pen-icon (edit) should allow you to edit corresponding
rule.
10. Clicking the x-icon should remove corresponding rule after
confirmation.
11. Selecting one or more rules followed by clicking the trash-icon
should remove all selected rules after confirmation.
12. To test your rules, import or in other way modify a record.
13. Check that the record was modified as defined by your rules.

Sponsored-by: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Stenberg  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Marc Véron  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11780

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
+100!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Stenberg  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |mar...@bugs.koha-community.
   ||org.xinxidi.net
 Status|NEW |ASSIGNED
 CC||mar...@bugs.koha-community.
   ||org.xinxidi.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/