[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2017-02-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

rkui...@roundrocktexas.gov changed:

   What|Removed |Added

 CC||rkui...@roundrocktexas.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-12-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Nicole C. Engard  changed:

   What|Removed |Added

 CC||a...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-07-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16920

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #43 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Nick, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-07-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52997|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52722|0   |1
is obsolete||

--- Comment #37 from Jonathan Druart  
---
Created attachment 53040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53040&action=edit
Bug 15128 - Followup

Only check limit for signed in borrower
Show all suggestions after a new one is added

Signed-off-by: Barbara Walters 

Signed-off-by: Kyle M Hall 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #42 from Jonathan Druart  
---
Created attachment 53045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53045&action=edit
Bug 15128: Do not display "New suggestion" if limit has just been reached

If limit is X and patrons has X-1 pending suggestions, when a new one is
added, the "New suggestion" should not been added.
to avoid another call to SearchSuggestions, we assume than the
suggestion has been correctly added.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53034|0   |1
is obsolete||

--- Comment #40 from Jonathan Druart  
---
Created attachment 53043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53043&action=edit
Bug 15128 - (QA Followup) Don't get patrons suggestions if limit not set

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #41 from Jonathan Druart  
---
Created attachment 53044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53044&action=edit
Bug 15128: Revert Display all purchase suggestions whether or not suggestion
was added

This does not work correctly and should be handle on another bug report.
The behavior existed prior to this patchset.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53033|0   |1
is obsolete||

--- Comment #39 from Jonathan Druart  
---
Created attachment 53042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53042&action=edit
Bug 15128 - (QA Followup) Fix use of 'my' variable causing loss of data

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52719|0   |1
is obsolete||

--- Comment #34 from Jonathan Druart  
---
Created attachment 53037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53037&action=edit
Bug 15128 - Add ability to limit patrons open purchase suggestions

To test:
1 - Define a number of MaxOpenSuggestions
2 - Add some suggestions for a patron
3 - Note they cannot add any more suggestions if limit is reached
4 - Delete a suggestion and note you can add another
5 - Add them to limit again
6 - Accept a suggestion in the staff client and note user can add more
7 - Repeat above with rejecting or deleting
8 - Sign off.

Sponsored by:
North Central Regional Library (http://ncrl.org/)

Signed-off-by: Barbara Walters 

Signed-off-by: Kyle M Hall 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #38 from Jonathan Druart  
---
Created attachment 53041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53041&action=edit
Bug 15128 (QA Followup) Display all purchase suggestions whether or not
suggestion was added Correct enforcement of 0 limit

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52721|0   |1
is obsolete||

--- Comment #36 from Jonathan Druart  
---
Created attachment 53039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53039&action=edit
Bug 15128 [QA Followup 2] - Only count pending suggestions for the limit

Signed-off-by: Barbara Walters 

Signed-off-by: Kyle M Hall 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52720|0   |1
is obsolete||

--- Comment #35 from Jonathan Druart  
---
Created attachment 53038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53038&action=edit
Bug 15128 [QA Followup] - Make suggestion display after being added

Also fixes the issue that the add suggestion link would sometimes
show even if the patron could not make an additional suggestion.

Signed-off-by: Barbara Walters 

Signed-off-by: Kyle M Hall 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #33 from Nick Clemens  ---
Created attachment 53034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53034&action=edit
Bug 15128 - (QA Followup) Don't get patrons suggestions if limit not set

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #32 from Nick Clemens  ---
Created attachment 53033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53033&action=edit
Bug 15128 - (QA Followup) Fix use of 'my' variable causing loss of data

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-07-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #31 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #28)
> This cannot be signed off, the patchset does not work at all, there is no
> limitation!

Still valid...
Nick, could you confirm that these patches have been tested correctly?
They do not work for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #30 from Nick Clemens  ---
Created attachment 52997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52997&action=edit
Bug 15128 (QA Followup) Display all purchase suggestions whether or not
suggestion was added Correct enforcement of 0 limit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #29 from Jonathan Druart  
---
Code review:
1/ MaxOpenSuggestions = 0 will not work as expected
2/ If a patron tries to force the add, he will get "There are no pending
purchase suggestions." even if there are.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #28 from Jonathan Druart  
---
This cannot be signed off, the patchset does not work at all, there is no
limitation!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #27 from Kyle M Hall  ---
Created attachment 52722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52722&action=edit
Bug 15128 - Followup

Only check limit for signed in borrower
Show all suggestions after a new one is added

Signed-off-by: Barbara Walters 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #26 from Kyle M Hall  ---
Created attachment 52721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52721&action=edit
Bug 15128 [QA Followup 2] - Only count pending suggestions for the limit

Signed-off-by: Barbara Walters 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #25 from Kyle M Hall  ---
Created attachment 52720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52720&action=edit
Bug 15128 [QA Followup] - Make suggestion display after being added

Also fixes the issue that the add suggestion link would sometimes
show even if the patron could not make an additional suggestion.

Signed-off-by: Barbara Walters 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52715|0   |1
is obsolete||
  Attachment #52716|0   |1
is obsolete||
  Attachment #52717|0   |1
is obsolete||
  Attachment #52718|0   |1
is obsolete||

--- Comment #24 from Kyle M Hall  ---
Created attachment 52719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52719&action=edit
Bug 15128 - Add ability to limit patrons open purchase suggestions

To test:
1 - Define a number of MaxOpenSuggestions
2 - Add some suggestions for a patron
3 - Note they cannot add any more suggestions if limit is reached
4 - Delete a suggestion and note you can add another
5 - Add them to limit again
6 - Accept a suggestion in the staff client and note user can add more
7 - Repeat above with rejecting or deleting
8 - Sign off.

Sponsored by:
North Central Regional Library (http://ncrl.org/)

Signed-off-by: Barbara Walters 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #52624|0   |1
is obsolete||

--- Comment #21 from Nicole C. Engard  ---
Created attachment 52716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52716&action=edit
Bug 15128 [QA Followup] - Make suggestion display after being added

Also fixes the issue that the add suggestion link would sometimes
show even if the patron could not make an additional suggestion.

Signed-off-by: Barbara Walters 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #52626|0   |1
is obsolete||

--- Comment #23 from Nicole C. Engard  ---
Created attachment 52718
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52718&action=edit
Bug 15128 - Followup

Only check limit for signed in borrower
Show all suggestions after a new one is added

Signed-off-by: Barbara Walters 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #52623|0   |1
is obsolete||

--- Comment #20 from Nicole C. Engard  ---
Created attachment 52715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52715&action=edit
Bug 15128 - Add ability to limit patrons open purchase suggestions

To test:
1 - Define a number of MaxOpenSuggestions
2 - Add some suggestions for a patron
3 - Note they cannot add any more suggestions if limit is reached
4 - Delete a suggestion and note you can add another
5 - Add them to limit again
6 - Accept a suggestion in the staff client and note user can add more
7 - Repeat above with rejecting or deleting
8 - Sign off.

Sponsored by:
North Central Regional Library (http://ncrl.org/)

Signed-off-by: Barbara Walters 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #52625|0   |1
is obsolete||

--- Comment #22 from Nicole C. Engard  ---
Created attachment 52717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52717&action=edit
Bug 15128 [QA Followup 2] - Only count pending suggestions for the limit

Signed-off-by: Barbara Walters 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #19 from Marc Véron  ---
No i can add as many suggestions as I want.

It is related to:
opac/opac-suggestions.pl line 117

my $patrons_pending_suggestions_count = scalar @{ SearchSuggestion( {
suggestedby => $borrowernumber, STATUS => 'ASKED' } ) } ;

'my' should be removed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #18 from Nick Clemens  ---
Created attachment 52626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52626&action=edit
Bug 15128 - Followup

Only check limit for signed in borrower
Show all suggestions after a new one is added

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #17 from Kyle M Hall  ---
Created attachment 52625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52625&action=edit
Bug 15128 [QA Followup 2] - Only count pending suggestions for the limit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #16 from Kyle M Hall  ---
Created attachment 52624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52624&action=edit
Bug 15128 [QA Followup] - Make suggestion display after being added

Also fixes the issue that the add suggestion link would sometimes
show even if the patron could not make an additional suggestion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52610|0   |1
is obsolete||
  Attachment #52611|0   |1
is obsolete||

--- Comment #15 from Kyle M Hall  ---
Created attachment 52623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52623&action=edit
Bug 15128 - Add ability to limit patrons open purchase suggestions

To test:
1 - Define a number of MaxOpenSuggestions
2 - Add some suggestions for a patron
3 - Note they cannot add any more suggestions if limit is reached
4 - Delete a suggestion and note you can add another
5 - Add them to limit again
6 - Accept a suggestion in the staff client and note user can add more
7 - Repeat above with rejecting or deleting
8 - Sign off.

Sponsored by:
North Central Regional Library (http://ncrl.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #14 from Kyle M Hall  ---
(In reply to Kyle M Hall from comment #13)
> Created attachment 52611 [details] [review]
> Bug 15128 [QA Followup] - Make suggestion display after being added
> 
> Also fixes the issue that the add suggestion link would sometimes
> show even if the patron could not make an additional suggestion.

This followup also tidys a chunk of very poorly formatted code. No changes in
that part were made aside for tidying.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #13 from Kyle M Hall  ---
Created attachment 52611
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52611&action=edit
Bug 15128 [QA Followup] - Make suggestion display after being added

Also fixes the issue that the add suggestion link would sometimes
show even if the patron could not make an additional suggestion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52596|0   |1
is obsolete||

--- Comment #12 from Kyle M Hall  ---
Created attachment 52610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52610&action=edit
Bug 15128 - Add ability to limit patrons open purchase suggestions

To test:
1 - Define a number of MaxOpenSuggestions
2 - Add some suggestions for a patron
3 - Note they cannot add any more suggestions if limit is reached
4 - Delete a suggestion and note you can add another
5 - Add them to limit again
6 - Accept a suggestion in the staff client and note user can add more
7 - Repeat above with rejecting or deleting
8 - Sign off.

Sponsored by:
North Central Regional Library (http://ncrl.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #11 from Nick Clemens  ---
(In reply to Marc Véron from comment #6)
> Sorry, while testing I found a way to circumvent the restriction

Limits now checked before adding

(In reply to Owen Leonard from comment #9)
> shouldn't there be an atomicupdate file?

Atomic update file included now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Nick Clemens  changed:

   What|Removed |Added

  Attachment #52502|0   |1
is obsolete||

--- Comment #10 from Nick Clemens  ---
Created attachment 52596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52596&action=edit
Bug 15128 - Add ability to limit patrons open purchase suggestions

To test:
1 - Define a number of MaxOpenSuggestions
2 - Add some suggestions for a patron
3 - Note they cannot add any more suggestions if limit is reached
4 - Delete a suggestion and note you can add another
5 - Add them to limit again
6 - Accept a suggestion in the staff client and note user can add more
7 - Repeat above with rejecting or deleting
8 - Sign off.

Sponsored by:
North Central Regional Library (http://ncrl.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #9 from Owen Leonard  ---
If this requires a change to the database, shouldn't there be an atomicupdate
file?

https://wiki.koha-community.org/wiki/Database_updates#New_workflow_since_bug_13068_has_been_pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Koha Team Lyon 3  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #8 from Koha Team Lyon 3  ---
sorry wrong bug...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-20 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Koha Team Lyon 3  changed:

   What|Removed |Added

 CC||k...@univ-lyon3.fr
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #7 from Koha Team Lyon 3  ---
I have tried to install it on a sandbox :
Some problems occurred applying patches from bug 14752:
Something went wrong !Applying: Bug 14752 - Add multiple copies to a
basket at once
Applying: Bug 14752 - (QA followup) Remove annoying modal, use dialog box
instead Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging C4/Barcodes/hbyymmincr.pm
CONFLICT (content): Merge conflict in C4/Barcodes/hbyymmincr.pm Failed to merge
in the changes.
Patch failed at 0001 Bug 14752 - (QA followup) Remove annoying modal, use
dialog box instead

When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 14752 - Add multiple copies to a basket at once

51481 - Bug 14752 - Add multiple copies to a basket at once
52083 - Bug 14752 - (QA followup) Remove annoying modal, use dialog box instead

Sonia

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16767

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #6 from Marc Véron  ---
(In reply to Nick Clemens from comment #5)
> (In reply to Marc Véron from comment #2)
> > From OPAC, I add a suggestion 'AAA'. I get the following:
> > 
> > Your suggestion has been submitted.
> > There are no pending purchase suggestions. (Hmm, should be one?)
> 
> > Clicking the link results in a new screen with the message:
> > "You cannot place any more suggestions" etc.
> > 
> > Question: Couldn't the link be replaced by the message (like in the overview
> > page)? That would be a nicer user experience.
> 
> The two above points are related and are related to existing functionality -
> I filed a new bug for those bug 16767 and will work on that there
I tested together with 16767, works OK

> > Then a minor typo on the overview page: The second sentence has no ending
> > punctuation:
OK

> Fixed
> > Ah, and it would be nice to have the maximum number in the user message.
> 
> Fixed
There seems to be one more needed, line 258. 

Sorry, while testing I found a way to circumvent the restriction:
- Add sussgestions until you reach the limit
- Hit the browser back button
- You are back on the entry form, fill it and submit
- Purchase suggestion is submitted
- Repeat as many times you want

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #5 from Nick Clemens  ---
(In reply to Marc Véron from comment #2)
> From OPAC, I add a suggestion 'AAA'. I get the following:
> 
> Your suggestion has been submitted.
> There are no pending purchase suggestions. (Hmm, should be one?)

> Clicking the link results in a new screen with the message:
> "You cannot place any more suggestions" etc.
> 
> Question: Couldn't the link be replaced by the message (like in the overview
> page)? That would be a nicer user experience.

The two above points are related and are related to existing functionality - I
filed a new bug for those bug 16767 and will work on that there

> Then a minor typo on the overview page: The second sentence has no ending
> punctuation:

Fixed
> Ah, and it would be nice to have the maximum number in the user message.

Fixed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Nick Clemens  changed:

   What|Removed |Added

  Attachment #52452|0   |1
is obsolete||

--- Comment #4 from Nick Clemens  ---
Created attachment 52502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52502&action=edit
Bug 15128 - Add ability to limit patrons open purchase suggestions

To test:
1 - Define a number of MaxOpenSuggestions
2 - Add some suggestions for a patron
3 - Note they cannot add any more suggestions if limit is reached
4 - Delete a suggestion and note you can add another
5 - Add them to limit again
6 - Accept a suggestion in the staff client and note user can add more
7 - Repeat above with rejecting or deleting
8 - Sign off.

Sponsored by:
North Central Regional Library (http://ncrl.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Nicole C. Engard  changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com

--- Comment #3 from Nicole C. Engard  ---
*** Bug 14979 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #2 from Marc Véron  ---
Works fine, I like this feature.

Maybe the following could be improved:

Let's say MaxOpenSuggestions is set to 2.

From OPAC, I add a suggestion 'AAA'. I get the following:

Your suggestion has been submitted.
There are no pending purchase suggestions. (Hmm, should be one?)
New purchase suggestion (Link)


I add a 2nd suggestion 'BBB'

Your suggestion has been submitted.
There are no pending purchase suggestions. (Hmm, should be two?)
New purchase suggestion (Link)

Clicking the link results in a new screen with the message:
"You cannot place any more suggestions" etc.

Question: Couldn't the link be replaced by the message (like in the overview
page)? That would be a nicer user experience.

Then a minor typo on the overview page: The second sentence has no ending
punctuation:

You have reached your limit of suggestions you can place at this time.
Once the library has processed those suggestions you will be able to place more
---

Ah, and it would be nice to have the maximum number in the user message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Nick Clemens  changed:

   What|Removed |Added

   Assignee|k...@bywatersolutions.com   |n...@bywatersolutions.com
 CC||neng...@gmail.com,
   ||n...@bywatersolutions.com,
   ||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-06-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #1 from Nick Clemens  ---
Created attachment 52452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52452&action=edit
Bug 15128 - Add ability to limit patrons open purchase suggestions

To test:
1 - Define a number of MaxOpenSuggestions
2 - Add some suggestions for a patron
3 - Note they cannot add any more suggestions if limit is reached
4 - Delete a suggestion and note you can add another
5 - Add them to limit again
6 - Accept a suggestion in the staff client and note user can add more
7 - Repeat above with rejecting or deleting
8 - Sign off.

Sponsored by:
North Central Regional Library (http://ncrl.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2016-05-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

2015-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/