[Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #4 from Jonathan Druart --- It works for me, please try again, you must be logged with a non-superlibrarian users and have editcatalogue => edit_items_restricted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Lee Jamison changed: What|Removed |Added Attachment #54511|0 |1 is obsolete|| --- Comment #5 from Lee Jamison --- Created attachment 66856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66856&action=edit Bug 15173: Restore SubfieldsToAllowForRestrictedEditing Bug 7673 introduced SubfieldsToAllowForRestrictedEditing but bug 12176 broke it assuming that only selects were impacted by this feature. Test plan: Go back on bug 7673 and confirm that SubfieldsToAllowForRestrictedEditing is working as expected with this patch applied. Signed-off-by: Lee Jamison For clarification, the item fields that are entered in SubfieldsToAllowForRestrictedEditing should EXCLUDE the desired fields you want to disable. Test plan (updated to test the scenario in the bug Description): 1. Create a patron with only the following permissions: - catalogue (Required for staff login) - editcatalogue -> edit_catalogue - editcatalogue -> edit_items - editcatalogue -> edit_items_restricted 2. Navigate to Administration -> Global system preferences -> Cataloging -> Record Structure -> SubfieldsToAllowForRestrictedEditing 3. In the input field for SubfieldsToAllowForRestrictedEditing enter in all the 952 fields EXCEPT the ones desired to be disabled. In this case, we want to disallow editing of 952$2, 952$a, 952$b, 952$e, 952$h, and 952$o so we enter the following into the SubfieldsToAllowForRestrictedEditing (without quotes) "952$0 952$1 952$3 952$4 952$5 952$7 952$8 952$c 952$d 952$f 952$g 952$i 952$j 952$p 952$t 952$u 952$v 952$w 952$x 952$y 952$z" 4. Click Save all Cataloging preferences 5. Login to the staff client as the created restricted editing patron 6. Edit an item 7. Note that all fields except for the ones excluded from the syspref are editable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Lee Jamison changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com QA Contact|testo...@bugs.koha-communit |julian.maur...@biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Julian Maurice changed: What|Removed |Added Attachment #66856|0 |1 is obsolete|| --- Comment #6 from Julian Maurice --- Created attachment 67434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67434&action=edit Bug 15173: Restore SubfieldsToAllowForRestrictedEditing Bug 7673 introduced SubfieldsToAllowForRestrictedEditing but bug 12176 broke it assuming that only selects were impacted by this feature. Test plan: Go back on bug 7673 and confirm that SubfieldsToAllowForRestrictedEditing is working as expected with this patch applied. Signed-off-by: Lee Jamison For clarification, the item fields that are entered in SubfieldsToAllowForRestrictedEditing should EXCLUDE the desired fields you want to disable. Test plan (updated to test the scenario in the bug Description): 1. Create a patron with only the following permissions: - catalogue (Required for staff login) - editcatalogue -> edit_catalogue - editcatalogue -> edit_items - editcatalogue -> edit_items_restricted 2. Navigate to Administration -> Global system preferences -> Cataloging -> Record Structure -> SubfieldsToAllowForRestrictedEditing 3. In the input field for SubfieldsToAllowForRestrictedEditing enter in all the 952 fields EXCEPT the ones desired to be disabled. In this case, we want to disallow editing of 952$2, 952$a, 952$b, 952$e, 952$h, and 952$o so we enter the following into the SubfieldsToAllowForRestrictedEditing (without quotes) "952$0 952$1 952$3 952$4 952$5 952$7 952$8 952$c 952$d 952$f 952$g 952$i 952$j 952$p 952$t 952$u 952$v 952$w 952$x 952$y 952$z" 4. Click Save all Cataloging preferences 5. Login to the staff client as the created restricted editing patron 6. Edit an item 7. Note that all fields except for the ones excluded from the syspref are editable Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Julian Maurice changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #7 from Julian Maurice --- Note that restricted borrowers are still able to edit every subfields if they know how to use a browser to manipulate the DOM (removing the 'readonly' attribute is enough). But that may be fixed in another bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to Master|Pushed to Stable --- Comment #9 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.06. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #10 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.14. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Jonathan Druart changed: What|Removed |Added Depends on||7673 CC||jonathan.dru...@bugs.koha-c ||ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 [Bug 7673] New patron permissions to manage items (edit, batchmod, delete all) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Depends on||12176 Status|NEW |ASSIGNED Severity|enhancement |major --- Comment #1 from Jonathan Druart --- This bug has been introduced by bug 12176. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 [Bug 12176] Remove HTML from additem.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 --- Comment #2 from Jonathan Druart --- Created attachment 54511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54511&action=edit Bug 15173: Restore SubfieldsToAllowForRestrictedEditing Bug 7673 introduced SubfieldsToAllowForRestrictedEditing but bug 12176 broke it assuming that only selects were impacted by this feature. Test plan: Go back on bug 7673 and confirm that SubfieldsToAllowForRestrictedEditing is working as expected with this patch applied. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Claire Gravely changed: What|Removed |Added CC||claire_grav...@hotmail.com Status|Needs Signoff |Failed QA --- Comment #3 from Claire Gravely --- testing this I found that before applying patch I was able to edit all free text fields as reported. After applying the patch I could not edit anything, even with the exceptions defined in SubfieldsToAllowForRestrictedEditing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/