[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Pushed to Master|Pushed to Stable

--- Comment #14 from Julian Maurice  ---
Not needed in 3.22.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #13 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.01.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #12 from Kyle M Hall  ---
Pushed to master for Koha 16.11, thanks Liz!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #51936|0   |1
is obsolete||

--- Comment #11 from Jonathan Druart  
---
Created attachment 52118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52118=edit
Bug 15213 - Fix tools sidebar to highlight Patron lists when in that module

To test:

Add some patron lists, navigate through the lists interface and make
sure that while you are in the module, that Patron lists is highlighted
on the sidebar.

Signed-off-by: Owen Leonard 
Signed-off-by: Jonathan Druart 
Amended patch: fix alignement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

--- Comment #10 from Liz Rea  ---
Ha I forgot all about this patch. Thanks Owen!

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

Owen Leonard  changed:

   What|Removed |Added

  Attachment #45033|0   |1
is obsolete||

--- Comment #9 from Owen Leonard  ---
Created attachment 51936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51936=edit
[SIGNED-OFF] Bug 15213 - Fix tools sidebar to highlight Patron lists when in
that module

To test:

Add some patron lists, navigate through the lists interface and make
sure that while you are in the module, that Patron lists is highlighted
on the sidebar.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|BLOCKED |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|15223   |
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15223


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15223
[Bug 15223] Buttons on patron list main page funny after font awesome
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213
Bug 15213 depends on bug 15212, which changed state.

Bug 15212 Summary: Patron lists tool page needs Tools area sidebar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15212

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

Liz Rea  changed:

   What|Removed |Added

  Attachment #45031|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

Liz Rea  changed:

   What|Removed |Added

  Attachment #45031|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

Liz Rea  changed:

   What|Removed |Added

  Attachment #45033|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

Owen Leonard  changed:

   What|Removed |Added

  Attachment #45272|0   |1
is obsolete||

--- Comment #8 from Owen Leonard  ---
Comment on attachment 45272
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45272
[SIGNED-OFF] Bug 15213 - fix buttons on patron lists

Sorry, wrong bug report!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

Owen Leonard  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED
   Patch complexity|Trivial patch   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

Owen Leonard  changed:

   What|Removed |Added

  Attachment #45033|0   |1
is obsolete||

--- Comment #7 from Owen Leonard  ---
Created attachment 45272
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45272=edit
[SIGNED-OFF] Bug 15213 - fix buttons on patron lists

To test:
go to tools -> patron lists
notice that the buttons are not misaligned anymore

You may need to force refresh the page to see the original issue, and to see it
fixed.

http://bugs.koha-community.org/show_bug.cgi?id=15223
Signed-off-by: Owen Leonard 

I can reproduce the problem in Chromium and the patch fixes it. No
adverse effects in Firefox.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|BLOCKED |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |BLOCKED
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com

--- Comment #6 from Héctor Eduardo Castro Avalos  ---
Hi Liz

(In reply to Liz Rea from comment #1)
> Depends on 15211 and 15212 because both of them bring this issue forward.

15212 doesn't have patch attached.

(In reply to Liz Rea from comment #5)
> Created attachment 45033 [details] [review]
> Bug 15213 - Fix tools sidebar to highlight Patron lists when in that module
> To test:
> 
> Add some patron lists, navigate through the lists interface and make sure
> that while you are in the module, that Patron lists is highlighted on the
> sidebar.
> 
> Depends on 15211 and 15213

Do I need to apply bug 15211 on top?  Test plan isn't clear for me, please
reword/clarify the message :)

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

Liz Rea  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

Liz Rea  changed:

   What|Removed |Added

  Attachment #45031|0   |1
is obsolete||

--- Comment #4 from Liz Rea  ---
Comment on attachment 45031
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45031
Bug 15213 - Fix tools sidebar to highlight Patron lists when in that module

Actually I don't want 15223 included in this patch, in case this one doesn't
get in, so I'll send a new patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

--- Comment #5 from Liz Rea  ---
Created attachment 45033
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45033=edit
Bug 15213 - Fix tools sidebar to highlight Patron lists when in that module

To test:

Add some patron lists, navigate through the lists interface and make sure that
while you are in the module, that Patron lists is highlighted on the sidebar.

Depends on 15211 and 15213

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

Liz Rea  changed:

   What|Removed |Added

 Blocks||15223

--- Comment #3 from Liz Rea  ---
This patch will also fix bug 15223.


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15223
[Bug 15223] Buttons on patron list main page funny after font awesome
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

--- Comment #2 from Liz Rea  ---
Created attachment 45031
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45031=edit
Bug 15213 - Fix tools sidebar to highlight Patron lists when in that module

To test:

Add some patron lists, navigate through the lists interface and make sure that
while you are in the module, that Patron lists is highlighted on the sidebar.

Depends on 15211 and 15213

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15213] Fix tools sidebar to highlight Patron lists when in that module

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15213

Liz Rea  changed:

   What|Removed |Added

 Depends on||15211, 15212

--- Comment #1 from Liz Rea  ---
Depends on 15211 and 15212 because both of them bring this issue forward.


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211
[Bug 15211] Label/patron card creators need to have Tools sidebar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15212
[Bug 15212] Patron lists tool page needs Tools area sidebar
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/